| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cf0cb7f2-acba-d332-8cf5-a196680bcc0c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9576:D7B95:1DFE25:2550E1:6990679C |
| html-safe-nonce | 7435dc997437a85186ad6c77fc66ec21bbc61b970fd6aed804d86872760cd067 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTc2OkQ3Qjk1OjFERkUyNToyNTUwRTE6Njk5MDY3OUMiLCJ2aXNpdG9yX2lkIjoiNDgxMzMyNjg0NDg5MDczNjU0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 77f95af6b59129a4933beb0a6dc89aa8c2d273c789e24a40d4377036d7a7171a |
| hovercard-subject-tag | pull_request:225045761 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23829/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/80efa588f3c302e7db6d8f9e033bf497a7d0e6942772ee523a79795d51f99a6c/nodejs/node/pull/23829 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/80efa588f3c302e7db6d8f9e033bf497a7d0e6942772ee523a79795d51f99a6c/nodejs/node/pull/23829 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lveteau |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23829#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23829 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23829 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23829 |
| Reload | https://github.com/nodejs/node/pull/23829 |
| Reload | https://github.com/nodejs/node/pull/23829 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23829 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
706
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| lveteau | https://github.com/lveteau |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lveteau:master | https://github.com/lveteau/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/23829 |
| Commits2 (2) | https://github.com/nodejs/node/pull/23829/commits |
| Checks | https://github.com/nodejs/node/pull/23829/checks |
| Files changed | https://github.com/nodejs/node/pull/23829/files |
| test: fix strictEqual() argument order | https://github.com/nodejs/node/pull/23829#top |
| lveteau | https://github.com/lveteau |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lveteau:master | https://github.com/lveteau/node/tree/master |
|
| https://github.com/lveteau |
| lveteau | https://github.com/lveteau |
| Oct 23, 2018 | https://github.com/nodejs/node/pull/23829#issue-373009121 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23829 |
|
| https://github.com/lveteau |
| test: fix strictEqual() argument order | https://github.com/nodejs/node/pull/23829/commits/71c7585a42f3909f9587befe119770a7bb051ba2 |
| 71c7585 | https://github.com/nodejs/node/pull/23829/commits/71c7585a42f3909f9587befe119770a7bb051ba2 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Oct 23, 2018 | https://github.com/nodejs/node/pull/23829#event-1920538417 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 23, 2018
| https://github.com/nodejs/node/pull/23829#pullrequestreview-167429532 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23829/files/71c7585a42f3909f9587befe119770a7bb051ba2 |
|
| https://github.com/lveteau |
| test: replaced hardcoded value by variable | https://github.com/nodejs/node/pull/23829/commits/9048c00b0c79d60ba8547c838fd9cbdf5e766eb4 |
| 9048c00 | https://github.com/nodejs/node/pull/23829/commits/9048c00b0c79d60ba8547c838fd9cbdf5e766eb4 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 23, 2018
| https://github.com/nodejs/node/pull/23829#pullrequestreview-167434191 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23829/files/9048c00b0c79d60ba8547c838fd9cbdf5e766eb4 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 23, 2018 | https://github.com/nodejs/node/pull/23829#issuecomment-432350596 |
| https://ci.nodejs.org/job/node-test-pull-request/18081/ | https://ci.nodejs.org/job/node-test-pull-request/18081/ |
| Please reload this page | https://github.com/nodejs/node/pull/23829 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 23, 2018 | https://github.com/nodejs/node/pull/23829#event-1921253786 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Oct 23, 2018
| https://github.com/nodejs/node/pull/23829#pullrequestreview-167615945 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23829/files/9048c00b0c79d60ba8547c838fd9cbdf5e766eb4 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 23, 2018
| https://github.com/nodejs/node/pull/23829#pullrequestreview-167653465 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23829/files/9048c00b0c79d60ba8547c838fd9cbdf5e766eb4 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Oct 24, 2018
| https://github.com/nodejs/node/pull/23829#pullrequestreview-167713421 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23829/files/9048c00b0c79d60ba8547c838fd9cbdf5e766eb4 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 26, 2018 | https://github.com/nodejs/node/pull/23829#issuecomment-433275013 |
| 817e2e8 | https://github.com/nodejs/node/commit/817e2e8a762792b7997425548aaded4d7b08f601 |
| Please reload this page | https://github.com/nodejs/node/pull/23829 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 26, 2018 | https://github.com/nodejs/node/pull/23829#event-1927833544 |
| danbev | https://github.com/danbev |
|
Oct 26, 2018
| https://github.com/nodejs/node/pull/23829#ref-commit-817e2e8 |
|
| https://github.com/lveteau |
|
| https://github.com/danbev |
| test: fix strictEqual() argument order | https://github.com/nodejs/node/commit/817e2e8a762792b7997425548aaded4d7b08f601 |
| 817e2e8 | https://github.com/nodejs/node/commit/817e2e8a762792b7997425548aaded4d7b08f601 |
| #23829 | https://github.com/nodejs/node/pull/23829 |
| targos | https://github.com/targos |
|
Oct 26, 2018
| https://github.com/nodejs/node/pull/23829#ref-commit-3b52343 |
|
| https://github.com/lveteau |
|
| https://github.com/targos |
| test: fix strictEqual() argument order | https://github.com/nodejs/node/commit/3b52343f10eb6af78b4edba1b4cf0c42c447dc37 |
| 3b52343 | https://github.com/nodejs/node/commit/3b52343f10eb6af78b4edba1b4cf0c42c447dc37 |
| #23829 | https://github.com/nodejs/node/pull/23829 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 27, 2018
| https://github.com/nodejs/node/pull/23829#ref-pullrequest-374624819 |
|
Release proposal: v11.1.0
#23922
| https://github.com/nodejs/node/pull/23922 |
| targos | https://github.com/targos |
|
Nov 1, 2018
| https://github.com/nodejs/node/pull/23829#ref-commit-22caa26 |
|
| https://github.com/lveteau |
|
| https://github.com/targos |
| test: fix strictEqual() argument order | https://github.com/nodejs/node/commit/22caa26c695df2fdbef38da919aa0a41e7265403 |
| 22caa26 | https://github.com/nodejs/node/commit/22caa26c695df2fdbef38da919aa0a41e7265403 |
| #23829 | https://github.com/nodejs/node/pull/23829 |
|
2018-11-02 Version 11.1.0 (Current) @targos
beevelop/docker-android-nodejs#245
| https://github.com/beevelop/docker-android-nodejs/issues/245 |
|
2018-11-02 Version 11.1.0 (Current) @targos
beevelop/docker-android-nodejs#246
| https://github.com/beevelop/docker-android-nodejs/issues/246 |
|
2018-11-02 Version 11.1.0 (Current) @targos
beevelop/docker-android-nodejs#247
| https://github.com/beevelop/docker-android-nodejs/issues/247 |
|
2018-11-02 Version 11.1.0 (Current) @targos
beevelop/docker-android-nodejs#248
| https://github.com/beevelop/docker-android-nodejs/issues/248 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 26, 2018
| https://github.com/nodejs/node/pull/23829#ref-commit-1c6820b |
|
| https://github.com/lveteau |
|
| https://github.com/MylesBorins |
| test: fix strictEqual() argument order | https://github.com/nodejs/node/commit/1c6820b9e1d8e5819330f365eb144a1faec2795c |
| 1c6820b | https://github.com/nodejs/node/commit/1c6820b9e1d8e5819330f365eb144a1faec2795c |
| #23829 | https://github.com/nodejs/node/pull/23829 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 26, 2018
| https://github.com/nodejs/node/pull/23829#ref-commit-27dad96 |
|
| https://github.com/lveteau |
|
| https://github.com/MylesBorins |
| test: fix strictEqual() argument order | https://github.com/nodejs/node/commit/27dad9601fea073fee443180254678658434ed23 |
| 27dad96 | https://github.com/nodejs/node/commit/27dad9601fea073fee443180254678658434ed23 |
| #23829 | https://github.com/nodejs/node/pull/23829 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x |
| Nov 26, 2018 | https://github.com/nodejs/node/pull/23829#event-1988097739 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/23829#ref-pullrequest-384882602 |
|
v10.13.1 proposal
#24675
| https://github.com/nodejs/node/pull/24675 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23829#ref-commit-d0368b8 |
|
| https://github.com/lveteau |
|
| https://github.com/rvagg |
| test: fix strictEqual() argument order | https://github.com/nodejs/node/commit/d0368b8245479ce644b5d1ec5d076a504f342b9b |
| d0368b8 | https://github.com/nodejs/node/commit/d0368b8245479ce644b5d1ec5d076a504f342b9b |
| #23829 | https://github.com/nodejs/node/pull/23829 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23829#ref-commit-7e98bc6 |
|
| https://github.com/lveteau |
|
| https://github.com/rvagg |
| test: fix strictEqual() argument order | https://github.com/nodejs/node/commit/7e98bc6e1725340d1d162893bf61539969f93352 |
| 7e98bc6 | https://github.com/nodejs/node/commit/7e98bc6e1725340d1d162893bf61539969f93352 |
| #23829 | https://github.com/nodejs/node/pull/23829 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23829#ref-commit-682361c |
|
| https://github.com/lveteau |
|
| https://github.com/MylesBorins |
| test: fix strictEqual() argument order | https://github.com/nodejs/node/commit/682361cd4afffb9ae10f87010c8ef2684579eb61 |
| 682361c | https://github.com/nodejs/node/commit/682361cd4afffb9ae10f87010c8ef2684579eb61 |
| #23829 | https://github.com/nodejs/node/pull/23829 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23829#ref-pullrequest-385836001 |
|
v10.14.2 proposal
#24727
| https://github.com/nodejs/node/pull/24727 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 4, 2018
| https://github.com/nodejs/node/pull/23829#ref-pullrequest-387422551 |
|
v8.14.1 proposal
#24832
| https://github.com/nodejs/node/pull/24832 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#267
| https://github.com/beevelop/docker-android-nodejs/issues/267 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#268
| https://github.com/beevelop/docker-android-nodejs/issues/268 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#269
| https://github.com/beevelop/docker-android-nodejs/issues/269 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#270
| https://github.com/beevelop/docker-android-nodejs/issues/270 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#271
| https://github.com/beevelop/docker-android-nodejs/issues/271 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23829 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/23829/files/9048c00b0c79d60ba8547c838fd9cbdf5e766eb4 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/23829/files/9048c00b0c79d60ba8547c838fd9cbdf5e766eb4 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/23829/files/9048c00b0c79d60ba8547c838fd9cbdf5e766eb4 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/23829/files/71c7585a42f3909f9587befe119770a7bb051ba2 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/23829/files/9048c00b0c79d60ba8547c838fd9cbdf5e766eb4 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/23829 |
|
| https://github.com/lveteau |
|
| https://github.com/Trott |
|
| https://github.com/danbev |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/targos |
|
| https://github.com/cjihrig |
|
| https://github.com/trivikr |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |