| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4b9b86d3-541b-8788-f00b-4cf70dede9ec |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B238:DE287:1CFE21A:26636EE:696AFE8A |
| html-safe-nonce | feaa718ebd63d59e3445bec0bac4d16f37283a05187295a9873081c510b96e01 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjM4OkRFMjg3OjFDRkUyMUE6MjY2MzZFRTo2OTZBRkU4QSIsInZpc2l0b3JfaWQiOiI1MTI1OTA4NTA4Nzg3Mjc3NDUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6414b249d2b68eacc5f2dfa967ec367dbd715b058eb166e410392c88ef213646 |
| hovercard-subject-tag | pull_request:224949538 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23827/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7587a223af7bf92316cb01a951e91a0495a4dc9486881fd7500ce2bb741d78d2/nodejs/node/pull/23827 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7587a223af7bf92316cb01a951e91a0495a4dc9486881fd7500ce2bb741d78d2/nodejs/node/pull/23827 |
| og:image:alt | Original commit message:
[cpu-profiler] Fix a leak caused by re-logging existing functions.
Don't re-log all existing functions during StartProcessorIfNotStarted().
They will already be in the ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | psmarshall |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23827#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23827 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23827 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23827 |
| Reload | https://github.com/nodejs/node/pull/23827 |
| Reload | https://github.com/nodejs/node/pull/23827 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/23827#issue-comment-box |
| psmarshall | https://github.com/psmarshall |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| psmarshall:backport_525b396195 | https://github.com/psmarshall/node/tree/backport_525b396195 |
|
deps: backport 525b396195 from upstream V8
| https://github.com/nodejs/node/pull/23827#top |
| psmarshall | https://github.com/psmarshall |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| psmarshall:backport_525b396195 | https://github.com/psmarshall/node/tree/backport_525b396195 |
|
Conversation
23
| https://github.com/nodejs/node/pull/23827 |
|
Commits
1
| https://github.com/nodejs/node/pull/23827/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/23827/checks |
|
Files changed
| https://github.com/nodejs/node/pull/23827/files |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Oct 23, 2018 | https://github.com/nodejs/node/pull/23827#issue-372881142 |
| v8:8253 | https://bugs.chromium.org/p/v8/issues/detail?id=8253 |
| https://chromium-review.googlesource.com/1256763 | https://chromium-review.googlesource.com/1256763 |
| #56336 | https://github.com/nodejs/node/pull/56336 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| https://chromium-review.googlesource.com/c/v8/v8/+/1280443 | https://chromium-review.googlesource.com/c/v8/v8/+/1280443 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Oct 23, 2018 | https://github.com/nodejs/node/pull/23827#event-1919761122 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Oct 23, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-432157552 |
| @Flarna | https://github.com/Flarna |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 23, 2018
| https://github.com/nodejs/node/pull/23827#pullrequestreview-167305211 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23827/files |
| https://github.com/targos |
| targos | https://github.com/targos |
| Oct 23, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-432165094 |
| v8/v8@525b396 | https://github.com/v8/v8/commit/525b39619548b4e7fbf48934acb18d3f209321db |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
| Oct 23, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-432168387 |
| #23070 | https://github.com/nodejs/node/issues/23070 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
|
Oct 23, 2018
| https://github.com/nodejs/node/pull/23827#pullrequestreview-167459166 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23827/files |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Oct 23, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-432274600 |
| https://ci.nodejs.org/job/node-test-pull-request/18077/ | https://ci.nodejs.org/job/node-test-pull-request/18077/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1781/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1781/ |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 23, 2018 | https://github.com/nodejs/node/pull/23827#event-1920707274 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 23, 2018
| https://github.com/nodejs/node/pull/23827#pullrequestreview-167482591 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23827/files |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Oct 23, 2018
| https://github.com/nodejs/node/pull/23827#pullrequestreview-167535595 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23827/files |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Oct 23, 2018
| https://github.com/nodejs/node/pull/23827#ref-pullrequest-371578495 |
|
build: spawn make test-ci with -j1
#23733
| https://github.com/nodejs/node/pull/23733 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 23, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-432336187 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| #23733 | https://github.com/nodejs/node/pull/23733 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/8b431ad84ce2be095d904b17ae48c04e483e3211..3f63297fe8e10e54122f211c6ae573112a9f74cc |
| 8b431ad | https://github.com/nodejs/node/commit/8b431ad84ce2be095d904b17ae48c04e483e3211 |
| 3f63297 | https://github.com/nodejs/node/commit/3f63297fe8e10e54122f211c6ae573112a9f74cc |
|
Compare
| https://github.com/nodejs/node/compare/8b431ad84ce2be095d904b17ae48c04e483e3211..3f63297fe8e10e54122f211c6ae573112a9f74cc |
| October 27, 2018 08:14 | https://github.com/nodejs/node/pull/23827#event-1930208606 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/3f63297fe8e10e54122f211c6ae573112a9f74cc..8e7a12f4500c702731313591d64726031ab8c4d2 |
| 3f63297 | https://github.com/nodejs/node/commit/3f63297fe8e10e54122f211c6ae573112a9f74cc |
| 8e7a12f | https://github.com/nodejs/node/commit/8e7a12f4500c702731313591d64726031ab8c4d2 |
|
Compare
| https://github.com/nodejs/node/compare/3f63297fe8e10e54122f211c6ae573112a9f74cc..8e7a12f4500c702731313591d64726031ab8c4d2 |
| October 30, 2018 08:43 | https://github.com/nodejs/node/pull/23827#event-1934378207 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| force-pushed | https://github.com/nodejs/node/compare/b417494f98533d9d59149a50fd0838c2c77c6829..3bf52e2e2da4b9dc53ed83bbdc2ee58aa6408b5b |
| b417494 | https://github.com/nodejs/node/commit/b417494f98533d9d59149a50fd0838c2c77c6829 |
| 3bf52e2 | https://github.com/nodejs/node/commit/3bf52e2e2da4b9dc53ed83bbdc2ee58aa6408b5b |
|
Compare
| https://github.com/nodejs/node/compare/b417494f98533d9d59149a50fd0838c2c77c6829..3bf52e2e2da4b9dc53ed83bbdc2ee58aa6408b5b |
| October 30, 2018 10:41 | https://github.com/nodejs/node/pull/23827#event-1934655874 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-434252489 |
| #23733 | https://github.com/nodejs/node/pull/23733 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-434317197 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1800/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1800/ |
| https://ci.nodejs.org/job/node-test-pull-request/18229/ | https://ci.nodejs.org/job/node-test-pull-request/18229/ |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-435250703 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-435254443 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-435317042 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-435318283 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1806/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1806/ |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-435318411 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-435320078 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-435320253 |
| 46c7d0d | https://github.com/nodejs/node/commit/46c7d0d21ff13db9af731fc77ee56ead0336ab43 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-435321097 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-435321401 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-435507290 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Nov 6, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-436290470 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Nov 6, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-436340676 |
| #24195 | https://github.com/nodejs/node/pull/24195 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Nov 6, 2018 | https://github.com/nodejs/node/pull/23827#event-1949706328 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Nov 7, 2018 | https://github.com/nodejs/node/pull/23827#event-1952290275 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Nov 7, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-436712889 |
| https://ci.nodejs.org/job/node-test-pull-request/18405/ | https://ci.nodejs.org/job/node-test-pull-request/18405/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1823/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1823/ |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| force-pushed | https://github.com/nodejs/node/compare/3bf52e2e2da4b9dc53ed83bbdc2ee58aa6408b5b..ff0970087647a27089e072df379118c777771100 |
| 3bf52e2 | https://github.com/nodejs/node/commit/3bf52e2e2da4b9dc53ed83bbdc2ee58aa6408b5b |
| ff09700 | https://github.com/nodejs/node/commit/ff0970087647a27089e072df379118c777771100 |
|
Compare
| https://github.com/nodejs/node/compare/3bf52e2e2da4b9dc53ed83bbdc2ee58aa6408b5b..ff0970087647a27089e072df379118c777771100 |
| November 9, 2018 09:09 | https://github.com/nodejs/node/pull/23827#event-1956358779 |
|
| https://github.com/psmarshall |
| deps: backport 525b396195 from upstream V8 | https://github.com/nodejs/node/pull/23827/commits/1e6a0b1b99c37914cf60b2e24fac08780b50e38e |
| 1e6a0b1 | https://github.com/nodejs/node/pull/23827/commits/1e6a0b1b99c37914cf60b2e24fac08780b50e38e |
| https://chromium-review.googlesource.com/1256763 | https://chromium-review.googlesource.com/1256763 |
| nodejs#56336 | https://github.com/nodejs/node/pull/56336 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| force-pushed | https://github.com/nodejs/node/compare/ff0970087647a27089e072df379118c777771100..1e6a0b1b99c37914cf60b2e24fac08780b50e38e |
| ff09700 | https://github.com/nodejs/node/commit/ff0970087647a27089e072df379118c777771100 |
| 1e6a0b1 | https://github.com/nodejs/node/commit/1e6a0b1b99c37914cf60b2e24fac08780b50e38e |
|
Compare
| https://github.com/nodejs/node/compare/ff0970087647a27089e072df379118c777771100..1e6a0b1b99c37914cf60b2e24fac08780b50e38e |
| November 9, 2018 09:10 | https://github.com/nodejs/node/pull/23827#event-1956361344 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Nov 9, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-437298027 |
| https://ci.nodejs.org/job/node-test-pull-request/18449/ | https://ci.nodejs.org/job/node-test-pull-request/18449/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1829/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1829/ |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
|
Nov 9, 2018
| https://github.com/nodejs/node/pull/23827#ref-pullrequest-379147124 |
|
deps: cherry-pick b87d408 from upstream V8
#24272
| https://github.com/nodejs/node/pull/24272 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Nov 12, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-437819295 |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 12, 2018 | https://github.com/nodejs/node/pull/23827#issuecomment-437870890 |
| 1e9b4a2 | https://github.com/nodejs/node/commit/1e9b4a2a09ad7a4f31ce85bee5af30b81b6e1980 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 12, 2018 | https://github.com/nodejs/node/pull/23827#event-1960214355 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 12, 2018
| https://github.com/nodejs/node/pull/23827#ref-commit-1e9b4a2 |
|
| https://github.com/psmarshall |
|
| https://github.com/MylesBorins |
| deps: backport 525b396195 from upstream V8 | https://github.com/nodejs/node/commit/1e9b4a2a09ad7a4f31ce85bee5af30b81b6e1980 |
| 1e9b4a2 | https://github.com/nodejs/node/commit/1e9b4a2a09ad7a4f31ce85bee5af30b81b6e1980 |
| v8:8253 | https://bugs.chromium.org/p/v8/issues/detail?id=8253 |
| https://chromium-review.googlesource.com/1256763 | https://chromium-review.googlesource.com/1256763 |
| #56336 | https://github.com/nodejs/node/pull/56336 |
| #23827 | https://github.com/nodejs/node/pull/23827 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/23827#ref-pullrequest-384882602 |
|
v10.13.1 proposal
#24675
| https://github.com/nodejs/node/pull/24675 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23827#ref-commit-9784a5c |
|
| https://github.com/psmarshall |
|
| https://github.com/rvagg |
| deps: backport 525b396195 from upstream V8 | https://github.com/nodejs/node/commit/9784a5cec2cf7017113b446692965c335eebab32 |
| 9784a5c | https://github.com/nodejs/node/commit/9784a5cec2cf7017113b446692965c335eebab32 |
| v8:8253 | https://bugs.chromium.org/p/v8/issues/detail?id=8253 |
| https://chromium-review.googlesource.com/1256763 | https://chromium-review.googlesource.com/1256763 |
| #56336 | https://github.com/nodejs/node/pull/56336 |
| #23827 | https://github.com/nodejs/node/pull/23827 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23827#ref-commit-c8304f6 |
|
| https://github.com/psmarshall |
|
| https://github.com/MylesBorins |
| deps: backport 525b396195 from upstream V8 | https://github.com/nodejs/node/commit/c8304f6567e7eb1c7e776d9f5a0add66fe8d6830 |
| c8304f6 | https://github.com/nodejs/node/commit/c8304f6567e7eb1c7e776d9f5a0add66fe8d6830 |
| v8:8253 | https://bugs.chromium.org/p/v8/issues/detail?id=8253 |
| https://chromium-review.googlesource.com/1256763 | https://chromium-review.googlesource.com/1256763 |
| #56336 | https://github.com/nodejs/node/pull/56336 |
| #23827 | https://github.com/nodejs/node/pull/23827 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23827#ref-pullrequest-385836001 |
|
v10.14.2 proposal
#24727
| https://github.com/nodejs/node/pull/24727 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
Dec 13, 2018
| https://github.com/nodejs/node/pull/23827#ref-issue-363333877 |
|
Memory Leak in V8 CpuProfiler
#23070
| https://github.com/nodejs/node/issues/23070 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23827 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/23827/files/bf10a5097735614e74afa97e1d764efa4c1d3c6a |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/23827/files/bf10a5097735614e74afa97e1d764efa4c1d3c6a |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/23827/files/bf10a5097735614e74afa97e1d764efa4c1d3c6a |
|
| https://github.com/mmarchini |
|
mmarchini
| https://github.com/mmarchini |
|
| https://github.com/nodejs/node/pull/23827/files/bf10a5097735614e74afa97e1d764efa4c1d3c6a |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/23827 |
|
| https://github.com/psmarshall |
|
| https://github.com/targos |
|
| https://github.com/Flarna |
|
| https://github.com/mmarchini |
|
| https://github.com/refack |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
|
| https://github.com/MylesBorins |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |