René's URL Explorer Experiment


Title: module: allow passing a directory to createRequireFromPath by gillesdemey · Pull Request #23818 · nodejs/node · GitHub

Open Graph Title: module: allow passing a directory to createRequireFromPath by gillesdemey · Pull Request #23818 · nodejs/node

X Title: module: allow passing a directory to createRequireFromPath by gillesdemey · Pull Request #23818 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #23710 I still need to update the documentation for this change, I'm not quite sure if we should update the documentation to encourage users to pass a directory or do we prefer a file pa...

X Description: Fixes: #23710 I still need to update the documentation for this change, I'm not quite sure if we should update the documentation to encourage users to pass a directory or do we prefer a fil...

Opengraph URL: https://github.com/nodejs/node/pull/23818

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f96a1b0c-e7f7-9dce-85db-600b79bc7b7d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE1E:C3948:47D5A96:64B4A28:6A4F7CF5
html-safe-nonce2507fbc966fa0dfb781f24c8c337975d6d7987500a8b1ebea671aa54a09694ce
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTFFOkMzOTQ4OjQ3RDVBOTY6NjRCNEEyODo2QTRGN0NGNSIsInZpc2l0b3JfaWQiOiI4NjQ0NDczNjc3NjQ2MTAxNzQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfd55025746c7ff62fd6f41ab1c0729dc740da859ab4d4fde78b0c292a19ed8e9
hovercard-subject-tagpull_request:224775608
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23818/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/58582c49f44188b8936d88c1b46056f45d9a38aec2a5cb00b07612b9575a8ecf/nodejs/node/pull/23818
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/58582c49f44188b8936d88c1b46056f45d9a38aec2a5cb00b07612b9575a8ecf/nodejs/node/pull/23818
og:image:altFixes: #23710 I still need to update the documentation for this change, I'm not quite sure if we should update the documentation to encourage users to pass a directory or do we prefer a file pa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegillesdemey
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23818#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23818
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23818
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23818
Reloadhttps://github.com/nodejs/node/pull/23818
Reloadhttps://github.com/nodejs/node/pull/23818
Please reload this pagehttps://github.com/nodejs/node/pull/23818
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23818
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gillesdemeyhttps://github.com/gillesdemey
nodejs:masterhttps://github.com/nodejs/node/tree/master
gillesdemey:fix/createRequireFromPathhttps://github.com/gillesdemey/node/tree/fix/createRequireFromPath
Conversationhttps://github.com/nodejs/node/pull/23818
Commits6 (6)https://github.com/nodejs/node/pull/23818/commits
Checkshttps://github.com/nodejs/node/pull/23818/checks
Files changedhttps://github.com/nodejs/node/pull/23818/files
module: allow passing a directory to createRequireFromPathhttps://github.com/nodejs/node/pull/23818#top
gillesdemeyhttps://github.com/gillesdemey
nodejs:masterhttps://github.com/nodejs/node/tree/master
gillesdemey:fix/createRequireFromPathhttps://github.com/gillesdemey/node/tree/fix/createRequireFromPath
https://github.com/gillesdemey
gillesdemeyhttps://github.com/gillesdemey
Oct 22, 2018https://github.com/nodejs/node/pull/23818#issue-372648848
#23710https://github.com/nodejs/node/issues/23710
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/jdalton
jdaltonhttps://github.com/jdalton
Oct 22, 2018 https://github.com/nodejs/node/pull/23818#pullrequestreview-167078954
View reviewed changes https://github.com/nodejs/node/pull/23818/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/23818/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/gillesdemey
gillesdemeyhttps://github.com/gillesdemey
Oct 22, 2018 https://github.com/nodejs/node/pull/23818#pullrequestreview-167110134
View reviewed changes https://github.com/nodejs/node/pull/23818/files
test/parallel/test-module-create-require-from-directory.jshttps://github.com/nodejs/node/pull/23818/files#diff-0b34eecaf169fda727b54dfb04261c0d1090dcd38cfecd133ae4079e6a48a3df
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 19, 2018https://github.com/nodejs/node/pull/23818#issuecomment-439742834
https://ci.nodejs.org/job/node-test-pull-request/18730/https://ci.nodejs.org/job/node-test-pull-request/18730/
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 20, 2018 https://github.com/nodejs/node/pull/23818#pullrequestreview-176695961
View reviewed changes https://github.com/nodejs/node/pull/23818/files
guybedfordhttps://github.com/guybedford
https://github.com/nodejs/node/pull/23818#pullrequestreview-176695961
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/gillesdemey
gillesdemeyhttps://github.com/gillesdemey
Nov 20, 2018https://github.com/nodejs/node/pull/23818#issuecomment-440225334
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 23, 2018https://github.com/nodejs/node/pull/23818#issuecomment-441329745
https://ci.nodejs.org/job/node-test-pull-request/18906/https://ci.nodejs.org/job/node-test-pull-request/18906/
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/Trott
Trotthttps://github.com/Trott
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Nov 28, 2018https://github.com/nodejs/node/pull/23818#event-1991360622
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 28, 2018https://github.com/nodejs/node/pull/23818#issuecomment-442306538
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 28, 2018 https://github.com/nodejs/node/pull/23818#pullrequestreview-179149531
View reviewed changes https://github.com/nodejs/node/pull/23818/files
test/parallel/test-module-create-require-from-directory.jshttps://github.com/nodejs/node/pull/23818/files#diff-0b34eecaf169fda727b54dfb04261c0d1090dcd38cfecd133ae4079e6a48a3df
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 28, 2018https://github.com/nodejs/node/pull/23818#issuecomment-442468602
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 28, 2018 https://github.com/nodejs/node/pull/23818#pullrequestreview-179401311
View reviewed changes https://github.com/nodejs/node/pull/23818/files
test/parallel/test-module-create-require-from-directory.jshttps://github.com/nodejs/node/pull/23818/files#diff-0b34eecaf169fda727b54dfb04261c0d1090dcd38cfecd133ae4079e6a48a3df
mcollinahttps://github.com/mcollina
Nov 28, 2018https://github.com/nodejs/node/pull/23818#discussion_r237168353
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23818
guybedfordhttps://github.com/guybedford
Nov 29, 2018https://github.com/nodejs/node/pull/23818#discussion_r237451671
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/23818
gillesdemeyhttps://github.com/gillesdemey
Dec 1, 2018https://github.com/nodejs/node/pull/23818#discussion_r238078977
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23818
guybedfordhttps://github.com/guybedford
Mar 11, 2019https://github.com/nodejs/node/pull/23818#discussion_r264285433
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23818
MylesBorinshttps://github.com/MylesBorins
Apr 25, 2019https://github.com/nodejs/node/pull/23818#discussion_r278414098
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23818
BridgeARhttps://github.com/BridgeAR
Apr 25, 2019https://github.com/nodejs/node/pull/23818#discussion_r278425168
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23818
MylesBorinshttps://github.com/MylesBorins
Apr 30, 2019https://github.com/nodejs/node/pull/23818#discussion_r279858628
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/23818
BridgeARhttps://github.com/BridgeAR
Apr 30, 2019https://github.com/nodejs/node/pull/23818#discussion_r279862748
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23818
MylesBorinshttps://github.com/MylesBorins
May 1, 2019https://github.com/nodejs/node/pull/23818#discussion_r280013658
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/23818
module: createRequireFromPath documentation is incorrect #23710 https://github.com/nodejs/node/issues/23710
doc fix: align code example for module.createRequireFromPath() with actual code behavior. #26606 https://github.com/nodejs/node/pull/26606
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 25, 2019 https://github.com/nodejs/node/pull/23818#ref-issue-436935031
Odd behaviour: createRequireFromPath('.') #27401 https://github.com/nodejs/node/issues/27401
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Apr 25, 2019https://github.com/nodejs/node/pull/23818#event-2299227160
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 25, 2019 https://github.com/nodejs/node/pull/23818#pullrequestreview-230471192
View reviewed changes https://github.com/nodejs/node/pull/23818/files
MylesBorinshttps://github.com/MylesBorins
https://github.com/nodejs/node/pull/23818#pullrequestreview-230471192
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/83f4c9b02ab88b4c7ca8ee390ceb32e512e812cb..4c6c0d68a4901bbfb943051d11d56f60af490f6d
83f4c9bhttps://github.com/nodejs/node/commit/83f4c9b02ab88b4c7ca8ee390ceb32e512e812cb
4c6c0d6https://github.com/nodejs/node/commit/4c6c0d68a4901bbfb943051d11d56f60af490f6d
Compare https://github.com/nodejs/node/compare/83f4c9b02ab88b4c7ca8ee390ceb32e512e812cb..4c6c0d68a4901bbfb943051d11d56f60af490f6d
April 25, 2019 06:44https://github.com/nodejs/node/pull/23818#event-2299247067
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 25, 2019https://github.com/nodejs/node/pull/23818#event-2299247563
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23818
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 25, 2019https://github.com/nodejs/node/pull/23818#issuecomment-486542408
@Trotthttps://github.com/Trott
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 25, 2019https://github.com/nodejs/node/pull/23818#issuecomment-486542556
https://ci.nodejs.org/job/node-test-pull-request/22714/https://ci.nodejs.org/job/node-test-pull-request/22714/
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 25, 2019 https://github.com/nodejs/node/pull/23818#pullrequestreview-230483449
View reviewed changes https://github.com/nodejs/node/pull/23818/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/23818/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/23818
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/23818/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
BridgeARhttps://github.com/BridgeAR
Apr 25, 2019https://github.com/nodejs/node/pull/23818#discussion_r278424168
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23818
MylesBorinshttps://github.com/MylesBorins
Apr 25, 2019https://github.com/nodejs/node/pull/23818#discussion_r278719483
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23818
test/parallel/test-module-create-require-from-directory.jshttps://github.com/nodejs/node/pull/23818/files#diff-0b34eecaf169fda727b54dfb04261c0d1090dcd38cfecd133ae4079e6a48a3df
BridgeARhttps://github.com/BridgeAR
Apr 25, 2019https://github.com/nodejs/node/pull/23818#discussion_r278425168
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/jdalton
jdaltonhttps://github.com/jdalton
Apr 25, 2019 https://github.com/nodejs/node/pull/23818#pullrequestreview-230629925
View reviewed changes https://github.com/nodejs/node/pull/23818/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/23818/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/targos
targoshttps://github.com/targos
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Apr 25, 2019https://github.com/nodejs/node/pull/23818#event-2301017944
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 25, 2019https://github.com/nodejs/node/pull/23818#issuecomment-486826603
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/targos
targoshttps://github.com/targos
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Apr 25, 2019https://github.com/nodejs/node/pull/23818#event-2301476546
https://github.com/targos
targoshttps://github.com/targos
Apr 25, 2019https://github.com/nodejs/node/pull/23818#issuecomment-486837454
Please reload this pagehttps://github.com/nodejs/node/pull/23818
gillesdemeyhttps://github.com/gillesdemey
April 30, 2019 10:14https://github.com/nodejs/node/pull/23818#commits-pushed-a734696
https://github.com/gillesdemey
https://github.com/MylesBorins
module: allow passing a directory to createRequireFromPathhttps://github.com/nodejs/node/pull/23818/commits/a73469663de0c7360b0ba0e01126e899c82376aa
a734696https://github.com/nodejs/node/pull/23818/commits/a73469663de0c7360b0ba0e01126e899c82376aa
nodejs#23710https://github.com/nodejs/node/issues/23710
https://github.com/gillesdemey
https://github.com/MylesBorins
module: fix windows path separatorshttps://github.com/nodejs/node/pull/23818/commits/676cc00ee0337ece577173eb5e2eb61e01396f2d
676cc00https://github.com/nodejs/node/pull/23818/commits/676cc00ee0337ece577173eb5e2eb61e01396f2d
gillesdemeyhttps://github.com/gillesdemey
April 30, 2019 10:14https://github.com/nodejs/node/pull/23818#commits-pushed-c2eff11
https://github.com/gillesdemey
https://github.com/MylesBorins
test: make test-module-create-require-from-directory pass on Windowshttps://github.com/nodejs/node/pull/23818/commits/c2eff1160a5361cf5ebe0ac3176c5d8c1e182a2f
c2eff11https://github.com/nodejs/node/pull/23818/commits/c2eff1160a5361cf5ebe0ac3176c5d8c1e182a2f
https://github.com/gillesdemey
https://github.com/MylesBorins
test: add a negative test to test-module-create-require-from-directoryhttps://github.com/nodejs/node/pull/23818/commits/2b1f48e01f26b67877748aa7481299e868cf7460
2b1f48ehttps://github.com/nodejs/node/pull/23818/commits/2b1f48e01f26b67877748aa7481299e868cf7460
https://github.com/MylesBorins
fixup: doc changehttps://github.com/nodejs/node/pull/23818/commits/59427473434d007911ba3d3152a5a202b2a260a3
5942747https://github.com/nodejs/node/pull/23818/commits/59427473434d007911ba3d3152a5a202b2a260a3
https://github.com/MylesBorins
fixup: notes from reviewhttps://github.com/nodejs/node/pull/23818/commits/9ec4cb8d607945be44ddf7647382b0d40cbf3db4
9ec4cb8https://github.com/nodejs/node/pull/23818/commits/9ec4cb8d607945be44ddf7647382b0d40cbf3db4
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/d79796084125aaa84832658b42379a6ff762d641..9ec4cb8d607945be44ddf7647382b0d40cbf3db4
d797960https://github.com/nodejs/node/commit/d79796084125aaa84832658b42379a6ff762d641
9ec4cb8https://github.com/nodejs/node/commit/9ec4cb8d607945be44ddf7647382b0d40cbf3db4
Compare https://github.com/nodejs/node/compare/d79796084125aaa84832658b42379a6ff762d641..9ec4cb8d607945be44ddf7647382b0d40cbf3db4
April 30, 2019 17:49https://github.com/nodejs/node/pull/23818#event-2310250962
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 30, 2019https://github.com/nodejs/node/pull/23818#issuecomment-488049274
https://ci.nodejs.org/job/node-test-pull-request/22840/https://ci.nodejs.org/job/node-test-pull-request/22840/
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 30, 2019https://github.com/nodejs/node/pull/23818#issuecomment-488049593
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 30, 2019https://github.com/nodejs/node/pull/23818#issuecomment-488108514
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 1, 2019 https://github.com/nodejs/node/pull/23818#pullrequestreview-232543609
View reviewed changes https://github.com/nodejs/node/pull/23818/files/9ec4cb8d607945be44ddf7647382b0d40cbf3db4
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/23818#pullrequestreview-232543609
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 1, 2019 https://github.com/nodejs/node/pull/23818#pullrequestreview-232781023
View reviewed changes https://github.com/nodejs/node/pull/23818/files/9ec4cb8d607945be44ddf7647382b0d40cbf3db4
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/23818#pullrequestreview-232781023
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 1, 2019https://github.com/nodejs/node/pull/23818#issuecomment-488457804
https://ci.nodejs.org/job/node-test-pull-request/22871/https://ci.nodejs.org/job/node-test-pull-request/22871/
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 1, 2019https://github.com/nodejs/node/pull/23818#issuecomment-488459726
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 1, 2019https://github.com/nodejs/node/pull/23818#issuecomment-488460919
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 2, 2019https://github.com/nodejs/node/pull/23818#issuecomment-488520596
e5c8be2https://github.com/nodejs/node/commit/e5c8be2bd0f34ea9b579164ac053fcd30b98d213
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 2, 2019https://github.com/nodejs/node/pull/23818#event-2313311861
MylesBorinshttps://github.com/MylesBorins
May 2, 2019 https://github.com/nodejs/node/pull/23818#ref-commit-e5c8be2
https://github.com/gillesdemey
https://github.com/MylesBorins
module: allow passing a directory to createRequireFromPathhttps://github.com/nodejs/node/commit/e5c8be2bd0f34ea9b579164ac053fcd30b98d213
e5c8be2https://github.com/nodejs/node/commit/e5c8be2bd0f34ea9b579164ac053fcd30b98d213
#23710https://github.com/nodejs/node/issues/23710
#23818https://github.com/nodejs/node/pull/23818
https://github.com/gillesdemey
gillesdemeyhttps://github.com/gillesdemey
May 2, 2019 08:23https://github.com/nodejs/node/pull/23818#event-2313823699
targoshttps://github.com/targos
May 4, 2019 https://github.com/nodejs/node/pull/23818#ref-commit-be9a1ec
https://github.com/gillesdemey
https://github.com/targos
module: allow passing a directory to createRequireFromPathhttps://github.com/nodejs/node/commit/be9a1ec1d189667a8c2d6bd4ddb661c985f9da87
be9a1echttps://github.com/nodejs/node/commit/be9a1ec1d189667a8c2d6bd4ddb661c985f9da87
#23710https://github.com/nodejs/node/issues/23710
#23818https://github.com/nodejs/node/pull/23818
https://github.com/targos
targoshttps://github.com/targos
May 6, 2019 https://github.com/nodejs/node/pull/23818#ref-pullrequest-440681623
v12.2.0 proposal #27578 https://github.com/nodejs/node/pull/27578
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#281 https://github.com/beevelop/docker-nodejs/issues/281
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#309 https://github.com/beevelop/docker-android-nodejs/issues/309
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#282 https://github.com/beevelop/docker-nodejs/issues/282
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#310 https://github.com/beevelop/docker-android-nodejs/issues/310
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#283 https://github.com/beevelop/docker-nodejs/issues/283
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#311 https://github.com/beevelop/docker-android-nodejs/issues/311
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#284 https://github.com/beevelop/docker-nodejs/issues/284
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#312 https://github.com/beevelop/docker-android-nodejs/issues/312
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#285 https://github.com/beevelop/docker-nodejs/issues/285
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#313 https://github.com/beevelop/docker-android-nodejs/issues/313
https://github.com/HarshithaKP
HarshithaKPhttps://github.com/HarshithaKP
Mar 31, 2020 https://github.com/nodejs/node/pull/23818#ref-pullrequest-386387406
module: createRequireFromPath missed docs #24763 https://github.com/nodejs/node/pull/24763
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23818
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/23818/files/83f4c9b02ab88b4c7ca8ee390ceb32e512e812cb
https://github.com/guybedford
guybedford https://github.com/guybedford
https://github.com/nodejs/node/pull/23818/files/d79796084125aaa84832658b42379a6ff762d641
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/23818/files/39733adfa4e09acbb86c3e1929ccb12cee4cd094
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23818/files/9ec4cb8d607945be44ddf7647382b0d40cbf3db4
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/23818/files/9ec4cb8d607945be44ddf7647382b0d40cbf3db4
https://github.com/jdalton
jdalton https://github.com/jdalton
https://github.com/nodejs/node/pull/23818/files/d79796084125aaa84832658b42379a6ff762d641
https://github.com/MylesBorins
MylesBorins https://github.com/MylesBorins
https://github.com/nodejs/node/pull/23818/files/9ec4cb8d607945be44ddf7647382b0d40cbf3db4
https://github.com/MylesBorins
MylesBorins https://github.com/MylesBorins
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
module: createRequireFromPath documentation is incorrect https://github.com/nodejs/node/issues/23710
Please reload this pagehttps://github.com/nodejs/node/pull/23818
https://github.com/gillesdemey
https://github.com/Trott
https://github.com/guybedford
https://github.com/nodejs-github-bot
https://github.com/MylesBorins
https://github.com/targos
https://github.com/BridgeAR
https://github.com/addaleax
https://github.com/jdalton
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.