René's URL Explorer Experiment


Title: src: fix missing deprecation assignment by jasnell · Pull Request #23809 · nodejs/node · GitHub

Open Graph Title: src: fix missing deprecation assignment by jasnell · Pull Request #23809 · nodejs/node

X Title: src: fix missing deprecation assignment by jasnell · Pull Request #23809 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Missed the assignment when landing This needs a fast-track for v11.0.0 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is cha...

X Description: Missed the assignment when landing This needs a fast-track for v11.0.0 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is cha...

Opengraph URL: https://github.com/nodejs/node/pull/23809

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:70a380e1-c7f4-673a-84b2-043258a6f9c1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF0E:1C3C8A:51646A:670915:69912F4E
html-safe-nonce33c22678f7b796d4e847a5dd3c7428a4a9da2c0e9317715ffb26159c18df89ca
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjBFOjFDM0M4QTo1MTY0NkE6NjcwOTE1OjY5OTEyRjRFIiwidmlzaXRvcl9pZCI6IjYwMTM3NTQwODA4MTU1NTg0NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacff1041bae494d2a5341fd0f58a7a1f097e83b4070b03072b95624c02198a8d99
hovercard-subject-tagpull_request:224563849
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23809/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/86502678956ee98fdbe285223d62ba5987d311eb65eb4162cdb194530cbf4527/nodejs/node/pull/23809
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/86502678956ee98fdbe285223d62ba5987d311eb65eb4162cdb194530cbf4527/nodejs/node/pull/23809
og:image:altMissed the assignment when landing This needs a fast-track for v11.0.0 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is cha...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23809#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23809
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23809
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23809
Reloadhttps://github.com/nodejs/node/pull/23809
Reloadhttps://github.com/nodejs/node/pull/23809
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23809
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 710 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:fix-missing-deprecation-assignmenthttps://github.com/jasnell/node/tree/fix-missing-deprecation-assignment
Conversationhttps://github.com/nodejs/node/pull/23809
Commits3 (3)https://github.com/nodejs/node/pull/23809/commits
Checkshttps://github.com/nodejs/node/pull/23809/checks
Files changedhttps://github.com/nodejs/node/pull/23809/files
src: fix missing deprecation assignmenthttps://github.com/nodejs/node/pull/23809#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:fix-missing-deprecation-assignmenthttps://github.com/jasnell/node/tree/fix-missing-deprecation-assignment
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 21, 2018https://github.com/nodejs/node/pull/23809#issue-372349175
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23809
https://github.com/jasnell
src: fix missing deprecation assignmenthttps://github.com/nodejs/node/pull/23809/commits/deb329b509368fa52dfc7f232be3db39c940df57
deb329bhttps://github.com/nodejs/node/pull/23809/commits/deb329b509368fa52dfc7f232be3db39c940df57
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 21, 2018https://github.com/nodejs/node/pull/23809#issuecomment-431697556
@jasnellhttps://github.com/jasnell
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1328/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1328/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23809
https://github.com/jasnell
jasnellhttps://github.com/jasnell
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
deprecations https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations
Oct 21, 2018https://github.com/nodejs/node/pull/23809#event-1916802184
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 21, 2018https://github.com/nodejs/node/pull/23809#issuecomment-431697598
Please reload this pagehttps://github.com/nodejs/node/pull/23809
https://github.com/jasnell
jasnellhttps://github.com/jasnell
addaleaxhttps://github.com/addaleax
mcollinahttps://github.com/mcollina
vsemozhetbythttps://github.com/vsemozhetbyt
October 21, 2018 19:50https://github.com/nodejs/node/pull/23809#event-1916806271
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 21, 2018https://github.com/nodejs/node/pull/23809#issuecomment-431699754
Please reload this pagehttps://github.com/nodejs/node/pull/23809
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 21, 2018 https://github.com/nodejs/node/pull/23809#pullrequestreview-166798982
View reviewed changes https://github.com/nodejs/node/pull/23809/files/deb329b509368fa52dfc7f232be3db39c940df57
doc/api/deprecations.mdhttps://github.com/nodejs/node/pull/23809/files/deb329b509368fa52dfc7f232be3db39c940df57#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 21, 2018https://github.com/nodejs/node/pull/23809#discussion_r226876376
Please reload this pagehttps://github.com/nodejs/node/pull/23809
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23809
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 21, 2018https://github.com/nodejs/node/pull/23809#discussion_r226876903
Please reload this pagehttps://github.com/nodejs/node/pull/23809
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
another PRhttps://github.com/nodejs/node/pull/23810
Please reload this pagehttps://github.com/nodejs/node/pull/23809
https://github.com/refack
refackhttps://github.com/refack
Oct 21, 2018 https://github.com/nodejs/node/pull/23809#pullrequestreview-166799151
View reviewed changes https://github.com/nodejs/node/pull/23809/files/deb329b509368fa52dfc7f232be3db39c940df57
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/23809#pullrequestreview-166799151
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23809
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 21, 2018 https://github.com/nodejs/node/pull/23809#pullrequestreview-166800341
View reviewed changes https://github.com/nodejs/node/pull/23809/files/deb329b509368fa52dfc7f232be3db39c940df57
vsemozhetbythttps://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/23809#pullrequestreview-166800341
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23809
https://github.com/jasnell
[Squash] nithttps://github.com/nodejs/node/pull/23809/commits/3bab8d8689097fed8ff4c60ab14b4ce4ca76cd48
3bab8d8https://github.com/nodejs/node/pull/23809/commits/3bab8d8689097fed8ff4c60ab14b4ce4ca76cd48
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 21, 2018https://github.com/nodejs/node/pull/23809#issuecomment-431706315
https://ci.nodejs.org/job/node-test-pull-request/18038/https://ci.nodejs.org/job/node-test-pull-request/18038/
Please reload this pagehttps://github.com/nodejs/node/pull/23809
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 21, 2018https://github.com/nodejs/node/pull/23809#event-1916853989
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 22, 2018 https://github.com/nodejs/node/pull/23809#ref-pullrequest-372353779
doc: add missing YAML labels #23810 https://github.com/nodejs/node/pull/23810
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 22, 2018 https://github.com/nodejs/node/pull/23809#pullrequestreview-166846236
View reviewed changes https://github.com/nodejs/node/pull/23809/files/deb329b509368fa52dfc7f232be3db39c940df57
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/23809#pullrequestreview-166846236
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23809
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 22, 2018 https://github.com/nodejs/node/pull/23809#pullrequestreview-166913443
View reviewed changes https://github.com/nodejs/node/pull/23809/files/3bab8d8689097fed8ff4c60ab14b4ce4ca76cd48
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 22, 2018 https://github.com/nodejs/node/pull/23809#pullrequestreview-167078802
View reviewed changes https://github.com/nodejs/node/pull/23809/files/3bab8d8689097fed8ff4c60ab14b4ce4ca76cd48
doc/api/deprecations.mdhttps://github.com/nodejs/node/pull/23809/files/3bab8d8689097fed8ff4c60ab14b4ce4ca76cd48#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87
Please reload this pagehttps://github.com/nodejs/node/pull/23809
https://github.com/lpinca
https://github.com/jasnell
[Squash] nithttps://github.com/nodejs/node/pull/23809/commits/802ab9e71aa54b7e57027a20722f2cf2d5f7c0f1
802ab9ehttps://github.com/nodejs/node/pull/23809/commits/802ab9e71aa54b7e57027a20722f2cf2d5f7c0f1
jasnellhttps://github.com/jasnell
Oct 22, 2018 https://github.com/nodejs/node/pull/23809#ref-commit-7f61b52
https://github.com/jasnell
src: fix missing deprecation assignmenthttps://github.com/nodejs/node/commit/7f61b528d3da0eae041d1b0316cf87c7684f5bf9
7f61b52https://github.com/nodejs/node/commit/7f61b528d3da0eae041d1b0316cf87c7684f5bf9
#23809https://github.com/nodejs/node/pull/23809
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 22, 2018https://github.com/nodejs/node/pull/23809#issuecomment-431962055
Please reload this pagehttps://github.com/nodejs/node/pull/23809
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 22, 2018https://github.com/nodejs/node/pull/23809#event-1918433771
jasnellhttps://github.com/jasnell
Oct 22, 2018 https://github.com/nodejs/node/pull/23809#ref-commit-f0e5afc
https://github.com/jasnell
src: fix missing deprecation assignmenthttps://github.com/nodejs/node/commit/f0e5afc96843a88f109b87b0bcfbd2754e48efca
f0e5afchttps://github.com/nodejs/node/commit/f0e5afc96843a88f109b87b0bcfbd2754e48efca
#23809https://github.com/nodejs/node/pull/23809
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Nov 13, 2018https://github.com/nodejs/node/pull/23809#event-1964219857
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23809
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/23809/files/deb329b509368fa52dfc7f232be3db39c940df57
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/23809/files/3bab8d8689097fed8ff4c60ab14b4ce4ca76cd48
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23809/files/3bab8d8689097fed8ff4c60ab14b4ce4ca76cd48
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/23809/files/deb329b509368fa52dfc7f232be3db39c940df57
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/23809/files/deb329b509368fa52dfc7f232be3db39c940df57
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
deprecations https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Please reload this pagehttps://github.com/nodejs/node/pull/23809
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com/vsemozhetbyt
https://github.com/mcollina
https://github.com/refack
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.