René's URL Explorer Experiment


Title: [v10.x] buffer: fix crash for invalid index types by addaleax · Pull Request #23795 · nodejs/node · GitHub

Open Graph Title: [v10.x] buffer: fix crash for invalid index types by addaleax · Pull Request #23795 · nodejs/node

X Title: [v10.x] buffer: fix crash for invalid index types by addaleax · Pull Request #23795 · nodejs/node

Description: 2555cb4 introduced a crash when a non-number value was passed to ParseArrayIndex(). We do not always have JS typechecking for that in place, though. This returns back to the previous behavior of de...

Open Graph Description: 2555cb4 introduced a crash when a non-number value was passed to ParseArrayIndex(). We do not always have JS typechecking for that in place, though. This returns back to the previous behavior of de...

X Description: 2555cb4 introduced a crash when a non-number value was passed to ParseArrayIndex(). We do not always have JS typechecking for that in place, though. This returns back to the previous behavior of de...

Opengraph URL: https://github.com/nodejs/node/pull/23795

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ed188148-f81c-6556-ee29-f3b47fd983fd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA61C:12343F:1EB4BF7:28A14F4:696AFDE1
html-safe-nonceda799663cddb35421e11cfc4a3721badb3ddf3a0be3fd60c85856fa7bc3b707d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjFDOjEyMzQzRjoxRUI0QkY3OjI4QTE0RjQ6Njk2QUZERTEiLCJ2aXNpdG9yX2lkIjoiNTc4MjkzOTgxOTYxMTcxNzA4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2b7bc33285633418d6ee939ef61efeb309f804c9b691f87c658294c2fa269f20
hovercard-subject-tagpull_request:224518143
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23795/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8f9b8abc0e5070a019168c6db5eac063d56093a2692292ff4032aa8855efffe2/nodejs/node/pull/23795
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8f9b8abc0e5070a019168c6db5eac063d56093a2692292ff4032aa8855efffe2/nodejs/node/pull/23795
og:image:alt2555cb4 introduced a crash when a non-number value was passed to ParseArrayIndex(). We do not always have JS typechecking for that in place, though. This returns back to the previous behavior of de...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23795#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23795
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23795
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23795
Reloadhttps://github.com/nodejs/node/pull/23795
Reloadhttps://github.com/nodejs/node/pull/23795
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23795
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 692 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/23795
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/23795#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
addaleax:fix-buffer-intvaluehttps://github.com/addaleax/node/tree/fix-buffer-intvalue
[v10.x] buffer: fix crash for invalid index types https://github.com/nodejs/node/pull/23795#top
addaleaxhttps://github.com/addaleax
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
addaleax:fix-buffer-intvaluehttps://github.com/addaleax/node/tree/fix-buffer-intvalue
Conversation 50 https://github.com/nodejs/node/pull/23795
Commits 1 https://github.com/nodejs/node/pull/23795/commits
Checks 0 https://github.com/nodejs/node/pull/23795/checks
Files changed https://github.com/nodejs/node/pull/23795/files
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 21, 2018https://github.com/nodejs/node/pull/23795#issue-372279322
2555cb4https://github.com/nodejs/node/commit/2555cb4a4049dc4c41d8a2f4ce50909cc0a12a4a
#22129https://github.com/nodejs/node/pull/22129
#23668https://github.com/nodejs/node/issues/23668
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
regression https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aregression
lts-watch-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x
Oct 21, 2018https://github.com/nodejs/node/pull/23795#event-1916497553
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
ryzokukenhttps://github.com/ryzokuken
October 21, 2018 04:50https://github.com/nodejs/node/pull/23795#event-1916497564
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 21, 2018https://github.com/nodejs/node/pull/23795#issuecomment-431638738
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1323/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1323/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Oct 21, 2018https://github.com/nodejs/node/pull/23795#event-1916497580
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 21, 2018https://github.com/nodejs/node/pull/23795#issuecomment-431638769
https://ci.nodejs.org/job/node-test-pull-request/18022/https://ci.nodejs.org/job/node-test-pull-request/18022/
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 21, 2018 https://github.com/nodejs/node/pull/23795#pullrequestreview-166786578
View reviewed changes https://github.com/nodejs/node/pull/23795/files
https://github.com/refack
refackhttps://github.com/refack
Oct 21, 2018 https://github.com/nodejs/node/pull/23795#pullrequestreview-166790432
View reviewed changes https://github.com/nodejs/node/pull/23795/files
refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/nodejs/node/pull/23795#pullrequestreview-166790432
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
tsc-agenda https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-agenda
Oct 21, 2018https://github.com/nodejs/node/pull/23795#event-1916718425
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 21, 2018https://github.com/nodejs/node/pull/23795#issuecomment-431680997
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 21, 2018https://github.com/nodejs/node/pull/23795#issuecomment-431687283
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 21, 2018https://github.com/nodejs/node/pull/23795#issuecomment-431687904
Please reload this pagehttps://github.com/nodejs/node/pull/23795
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 21, 2018https://github.com/nodejs/node/pull/23795#issuecomment-431695347
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 22, 2018 https://github.com/nodejs/node/pull/23795#pullrequestreview-166829283
View reviewed changes https://github.com/nodejs/node/pull/23795/files
joyeecheunghttps://github.com/joyeecheung
https://github.com/nodejs/node/pull/23795#pullrequestreview-166829283
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 22, 2018 https://github.com/nodejs/node/pull/23795#pullrequestreview-166829334
View reviewed changes https://github.com/nodejs/node/pull/23795/files
joyeecheunghttps://github.com/joyeecheung
https://github.com/nodejs/node/pull/23795#pullrequestreview-166829334
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
2555cb4https://github.com/nodejs/node/commit/2555cb4a4049dc4c41d8a2f4ce50909cc0a12a4a
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 22, 2018 https://github.com/nodejs/node/pull/23795#pullrequestreview-166829426
View reviewed changes https://github.com/nodejs/node/pull/23795/files
joyeecheunghttps://github.com/joyeecheung
https://github.com/nodejs/node/pull/23795#pullrequestreview-166829426
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
2555cb4https://github.com/nodejs/node/commit/2555cb4a4049dc4c41d8a2f4ce50909cc0a12a4a
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 22, 2018 https://github.com/nodejs/node/pull/23795#pullrequestreview-166829520
View reviewed changes https://github.com/nodejs/node/pull/23795/files
joyeecheunghttps://github.com/joyeecheung
https://github.com/nodejs/node/pull/23795#pullrequestreview-166829520
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
2555cb4https://github.com/nodejs/node/commit/2555cb4a4049dc4c41d8a2f4ce50909cc0a12a4a
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 22, 2018 https://github.com/nodejs/node/pull/23795#ref-issue-372492779
Node.js Foundation Technical Steering Committee (TSC) Meeting 2018-10-24 nodejs/TSC#615 https://github.com/nodejs/TSC/issues/615
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 22, 2018 https://github.com/nodejs/node/pull/23795#pullrequestreview-166926800
View reviewed changes https://github.com/nodejs/node/pull/23795/files
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 22, 2018 https://github.com/nodejs/node/pull/23795#pullrequestreview-166926813
View reviewed changes https://github.com/nodejs/node/pull/23795/files
joyeecheunghttps://github.com/joyeecheung
https://github.com/nodejs/node/pull/23795#pullrequestreview-166926813
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
2555cb4https://github.com/nodejs/node/commit/2555cb4a4049dc4c41d8a2f4ce50909cc0a12a4a
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 22, 2018https://github.com/nodejs/node/pull/23795#issuecomment-431836488
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Oct 22, 2018 https://github.com/nodejs/node/pull/23795#pullrequestreview-167023927
View reviewed changes https://github.com/nodejs/node/pull/23795/files
ryzokukenhttps://github.com/ryzokuken
https://github.com/nodejs/node/pull/23795#pullrequestreview-167023927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/refack
refackhttps://github.com/refack
Oct 23, 2018https://github.com/nodejs/node/pull/23795#issuecomment-432401787
#23668https://github.com/nodejs/node/issues/23668
wyhaya/updns#7https://github.com/wyhaya/updns/issues/7
https://github.com/wyhaya/updns/blob/4fb62c6fa6863089c8443d737ad1de61031280af/lib/parse.js#L125-L126https://github.com/wyhaya/updns/blob/4fb62c6fa6863089c8443d737ad1de61031280af/lib/parse.js#L125-L126
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/refack
refackhttps://github.com/refack
Oct 23, 2018https://github.com/nodejs/node/pull/23795#issuecomment-432403988
Please reload this pagehttps://github.com/nodejs/node/pull/23795
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/refack
refackhttps://github.com/refack
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Oct 23, 2018https://github.com/nodejs/node/pull/23795#event-1921632829
https://github.com/refack
refackhttps://github.com/refack
Oct 24, 2018https://github.com/nodejs/node/pull/23795#issuecomment-432474499
Please reload this pagehttps://github.com/nodejs/node/pull/23795
buf.copy(target[, targetStart[, sourceStart[, sourceEnd]]])https://nodejs.org/api/buffer.html#buffer_buf_copy_target_targetstart_sourcestart_sourceend
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/refack
refackhttps://github.com/refack
Oct 24, 2018 https://github.com/nodejs/node/pull/23795#ref-pullrequest-373274985
buffer: validate arg types #23840 https://github.com/nodejs/node/pull/23840
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 24, 2018https://github.com/nodejs/node/pull/23795#issuecomment-432495238
Please reload this pagehttps://github.com/nodejs/node/pull/23795
@refackhttps://github.com/refack
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/27aa8f69da0fff3f698d96a996e8c2359cb0fb3a..b31dd6e1168cf8a1c79820d3f42808ddefd067e1
27aa8f6https://github.com/nodejs/node/commit/27aa8f69da0fff3f698d96a996e8c2359cb0fb3a
b31dd6ehttps://github.com/nodejs/node/commit/b31dd6e1168cf8a1c79820d3f42808ddefd067e1
Compare https://github.com/nodejs/node/compare/27aa8f69da0fff3f698d96a996e8c2359cb0fb3a..b31dd6e1168cf8a1c79820d3f42808ddefd067e1
October 24, 2018 05:44https://github.com/nodejs/node/pull/23795#event-1922398234
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lts-watch-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x
Oct 25, 2018https://github.com/nodejs/node/pull/23795#event-1926427645
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/1036d6e79a19c39793713da4c15d6a1b30d71ebd..027082d43f4af2f86b3425704957775edff92a30
1036d6ehttps://github.com/nodejs/node/commit/1036d6e79a19c39793713da4c15d6a1b30d71ebd
027082dhttps://github.com/nodejs/node/commit/027082d43f4af2f86b3425704957775edff92a30
Compare https://github.com/nodejs/node/compare/1036d6e79a19c39793713da4c15d6a1b30d71ebd..027082d43f4af2f86b3425704957775edff92a30
October 25, 2018 14:37https://github.com/nodejs/node/pull/23795#event-1926432079
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 25, 2018https://github.com/nodejs/node/pull/23795#issuecomment-433076896
Please reload this pagehttps://github.com/nodejs/node/pull/23795
#23840https://github.com/nodejs/node/pull/23840
https://ci.nodejs.org/job/node-test-pull-request/18150/https://ci.nodejs.org/job/node-test-pull-request/18150/
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
October 25, 2018 14:38https://github.com/nodejs/node/pull/23795#event-1926434287
https://github.com/refack
refackhttps://github.com/refack
stale reviewhttps://github.com/nodejs/node/pull/23795#pullrequestreview-166790432
October 25, 2018 14:44https://github.com/nodejs/node/pull/23795#event-1926453000
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 25, 2018https://github.com/nodejs/node/pull/23795#issuecomment-433080323
#23875https://github.com/nodejs/node/pull/23875
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 25, 2018https://github.com/nodejs/node/pull/23795#issuecomment-433104012
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 25, 2018 https://github.com/nodejs/node/pull/23795#pullrequestreview-168457828
View reviewed changes https://github.com/nodejs/node/pull/23795/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/23795#pullrequestreview-168457828
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Oct 25, 2018https://github.com/nodejs/node/pull/23795#issuecomment-433106153
@MylesBorinshttps://github.com/MylesBorins
#23875https://github.com/nodejs/node/pull/23875
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 25, 2018https://github.com/nodejs/node/pull/23795#issuecomment-433110108
https://github.com/nodejs/node/blob/f14274714d00bb5b58482bef15e84cdda9237910/COLLABORATOR_GUIDE.md#when-breaking-changes-actually-break-thingshttps://github.com/nodejs/node/blob/f14274714d00bb5b58482bef15e84cdda9237910/COLLABORATOR_GUIDE.md#when-breaking-changes-actually-break-things
2555cb4https://github.com/nodejs/node/commit/2555cb4a4049dc4c41d8a2f4ce50909cc0a12a4a
changeloghttps://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V10.md#2018-09-06-version-10100-current-targos
c637d41b9dhttps://github.com/nodejs/node/commit/c637d41b9d
#23795https://github.com/nodejs/node/pull/23795
#23875https://github.com/nodejs/node/pull/23875
#23795https://github.com/nodejs/node/pull/23795
#23875https://github.com/nodejs/node/pull/23875
#22129https://github.com/nodejs/node/pull/22129
#23795https://github.com/nodejs/node/pull/23795
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 25, 2018https://github.com/nodejs/node/pull/23795#issuecomment-433110665
@MylesBorinshttps://github.com/MylesBorins
@richardlauhttps://github.com/richardlau
#23876https://github.com/nodejs/node/pull/23876
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 25, 2018https://github.com/nodejs/node/pull/23795#issuecomment-433123968
https://ci.nodejs.org/job/node-test-pull-request/18153/https://ci.nodejs.org/job/node-test-pull-request/18153/
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 26, 2018https://github.com/nodejs/node/pull/23795#issuecomment-433301230
https://ci.nodejs.org/job/node-test-pull-request/18166/https://ci.nodejs.org/job/node-test-pull-request/18166/
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 26, 2018https://github.com/nodejs/node/pull/23795#issuecomment-433498317
https://ci.nodejs.org/job/node-test-pull-request/18176/https://ci.nodejs.org/job/node-test-pull-request/18176/
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/8b431ad84ce2be095d904b17ae48c04e483e3211..3f63297fe8e10e54122f211c6ae573112a9f74cc
8b431adhttps://github.com/nodejs/node/commit/8b431ad84ce2be095d904b17ae48c04e483e3211
3f63297https://github.com/nodejs/node/commit/3f63297fe8e10e54122f211c6ae573112a9f74cc
Compare https://github.com/nodejs/node/compare/8b431ad84ce2be095d904b17ae48c04e483e3211..3f63297fe8e10e54122f211c6ae573112a9f74cc
October 27, 2018 08:14https://github.com/nodejs/node/pull/23795#event-1930208603
https://github.com/addaleax
buffer: fix crash for invalid index typeshttps://github.com/nodejs/node/pull/23795/commits/b617de09caaa0c821e88fef07a07e6dff14e8fdb
b617de0https://github.com/nodejs/node/pull/23795/commits/b617de09caaa0c821e88fef07a07e6dff14e8fdb
2555cb4https://github.com/addaleax/node/commit/2555cb4a4049dc4c41d8a2f4ce50909cc0a12a4a
nodejs#22129https://github.com/nodejs/node/pull/22129
nodejs#23668https://github.com/nodejs/node/issues/23668
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/027082d43f4af2f86b3425704957775edff92a30..b617de09caaa0c821e88fef07a07e6dff14e8fdb
027082dhttps://github.com/nodejs/node/commit/027082d43f4af2f86b3425704957775edff92a30
b617de0https://github.com/nodejs/node/commit/b617de09caaa0c821e88fef07a07e6dff14e8fdb
Compare https://github.com/nodejs/node/compare/027082d43f4af2f86b3425704957775edff92a30..b617de09caaa0c821e88fef07a07e6dff14e8fdb
October 27, 2018 08:14https://github.com/nodejs/node/pull/23795#event-1930208743
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 27, 2018https://github.com/nodejs/node/pull/23795#issuecomment-433601273
#23625https://github.com/nodejs/node/pull/23625
https://ci.nodejs.org/job/node-test-pull-request/18181/https://ci.nodejs.org/job/node-test-pull-request/18181/
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 28, 2018https://github.com/nodejs/node/pull/23795#issuecomment-433689046
https://ci.nodejs.org/job/node-test-pull-request/18186/https://ci.nodejs.org/job/node-test-pull-request/18186/
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 29, 2018https://github.com/nodejs/node/pull/23795#issuecomment-433786578
https://ci.nodejs.org/job/node-test-pull-request/18193/https://ci.nodejs.org/job/node-test-pull-request/18193/
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 29, 2018https://github.com/nodejs/node/pull/23795#issuecomment-433975771
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://ci.nodejs.org/job/node-test-pull-request/18208/https://ci.nodejs.org/job/node-test-pull-request/18208/
https://ci.nodejs.org/job/node-test-pull-request/18209/https://ci.nodejs.org/job/node-test-pull-request/18209/
https://ci.nodejs.org/job/node-test-pull-request/18210/https://ci.nodejs.org/job/node-test-pull-request/18210/
https://ci.nodejs.org/job/node-test-pull-request/18211/https://ci.nodejs.org/job/node-test-pull-request/18211/
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/refack
refackhttps://github.com/refack
Oct 29, 2018 https://github.com/nodejs/node/pull/23795#ref-pullrequest-375163319
build: add -Werror=undefined-inline to clang builds #23961 https://github.com/nodejs/node/pull/23961
https://github.com/refack
refackhttps://github.com/refack
Oct 29, 2018https://github.com/nodejs/node/pull/23795#issuecomment-434043720
#22006https://github.com/nodejs/node/issues/22006
https://ci.nodejs.org/job/node-test-pull-request/18213/https://ci.nodejs.org/job/node-test-pull-request/18213/
#23733https://github.com/nodejs/node/pull/23733
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/refack
refackhttps://github.com/refack
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 29, 2018https://github.com/nodejs/node/pull/23795#event-1933242098
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 29, 2018https://github.com/nodejs/node/pull/23795#issuecomment-434051342
2ba6010https://github.com/nodejs/node/commit/2ba60100820afe9b01f0d3dcee46453ce26db7e0
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 29, 2018https://github.com/nodejs/node/pull/23795#event-1933258720
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
October 29, 2018 19:42https://github.com/nodejs/node/pull/23795#event-1933259478
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 20, 2018 https://github.com/nodejs/node/pull/23795#ref-pullrequest-372190618
[v10.x backport] test: move tick.js from test/async-hooks to test/common #23780 https://github.com/nodejs/node/pull/23780
https://github.com/refack
refackhttps://github.com/refack
Nov 25, 2018 https://github.com/nodejs/node/pull/23795#ref-issue-384069924
Regression v10.x node_file.cc:1713: Assertion `(off) <= (buffer_length)' failed. #24640 https://github.com/nodejs/node/issues/24640
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 20, 2018 https://github.com/nodejs/node/pull/23795#ref-pullrequest-393175233
buffer: fix crash for invalid index types #25154 https://github.com/nodejs/node/pull/25154
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23795
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/23795/files/027082d43f4af2f86b3425704957775edff92a30
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23795/files/0ad112c452253622130f91d85135a64308e43055
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/23795/files/27aa8f69da0fff3f698d96a996e8c2359cb0fb3a
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23795/files/27aa8f69da0fff3f698d96a996e8c2359cb0fb3a
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/23795/files/27aa8f69da0fff3f698d96a996e8c2359cb0fb3a
https://github.com/thefourtheye
thefourtheye https://github.com/thefourtheye
https://github.com/nodejs/node/pull/23795/files/b31dd6e1168cf8a1c79820d3f42808ddefd067e1
https://github.com/ryzokuken
ryzokuken https://github.com/ryzokuken
https://github.com/nodejs/node/pull/23795/files/27aa8f69da0fff3f698d96a996e8c2359cb0fb3a
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/23795/files/27aa8f69da0fff3f698d96a996e8c2359cb0fb3a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
regression https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aregression
Please reload this pagehttps://github.com/nodejs/node/pull/23795
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/joyeecheung
https://github.com/refack
https://github.com/Trott
https://github.com/targos
https://github.com/mhdawson
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com/ryzokuken
https://github.com/richardlau
https://github.com/thefourtheye
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.