René's URL Explorer Experiment


Title: src: factor out Node.js-agnostic N-APIs by gabrielschulhof · Pull Request #23786 · nodejs/node · GitHub

Open Graph Title: src: factor out Node.js-agnostic N-APIs by gabrielschulhof · Pull Request #23786 · nodejs/node

X Title: src: factor out Node.js-agnostic N-APIs by gabrielschulhof · Pull Request #23786 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Split the Node.js ECMAScript API (N-EAPI?) into its own header and implementation files. The motivation is that the ECMAScript API stand on its own so it might be embedded separately, implementatio...

X Description: Split the Node.js ECMAScript API (N-EAPI?) into its own header and implementation files. The motivation is that the ECMAScript API stand on its own so it might be embedded separately, implementatio...

Opengraph URL: https://github.com/nodejs/node/pull/23786

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ebd87709-4103-16cf-aedd-d2d0a994f3a1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA336:99A39:20B34F1:2A7098E:699272BC
html-safe-nonce9f1103c21fa9f8189fd221bbf71950d5f449d05abac840e5b55a783d652895db
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzM2Ojk5QTM5OjIwQjM0RjE6MkE3MDk4RTo2OTkyNzJCQyIsInZpc2l0b3JfaWQiOiI3MDExMjg4MTA5NjQ5MzkyMzE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfe28bd8a5212b1ff3e6bc9f45b137320c7da587830f1aa0f2de8b37c657f7d6d
hovercard-subject-tagpull_request:224474306
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23786/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0dfd8a352cbfde7aae248c99c6c6414dcca54a4c54021c5ba567451910c41e60/nodejs/node/pull/23786
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0dfd8a352cbfde7aae248c99c6c6414dcca54a4c54021c5ba567451910c41e60/nodejs/node/pull/23786
og:image:altSplit the Node.js ECMAScript API (N-EAPI?) into its own header and implementation files. The motivation is that the ECMAScript API stand on its own so it might be embedded separately, implementatio...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabrielschulhof
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23786#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23786
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23786
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23786
Reloadhttps://github.com/nodejs/node/pull/23786
Reloadhttps://github.com/nodejs/node/pull/23786
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23786
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 716 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:split-out-n-apihttps://github.com/gabrielschulhof/node/tree/split-out-n-api
Conversationhttps://github.com/nodejs/node/pull/23786
Commits2 (2)https://github.com/nodejs/node/pull/23786/commits
Checkshttps://github.com/nodejs/node/pull/23786/checks
Files changedhttps://github.com/nodejs/node/pull/23786/files
src: factor out Node.js-agnostic N-APIshttps://github.com/nodejs/node/pull/23786#top
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:split-out-n-apihttps://github.com/gabrielschulhof/node/tree/split-out-n-api
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 20, 2018https://github.com/nodejs/node/pull/23786#issue-372211123
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 20, 2018https://github.com/nodejs/node/pull/23786#issuecomment-431581456
@gabrielschulhofhttps://github.com/gabrielschulhof
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1318/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1318/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Oct 20, 2018https://github.com/nodejs/node/pull/23786#event-1916208107
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Oct 20, 2018https://github.com/nodejs/node/pull/23786#event-1916208370
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 20, 2018https://github.com/nodejs/node/pull/23786#issuecomment-431581644
https://ci.nodejs.org/job/node-test-pull-request/18009/https://ci.nodejs.org/job/node-test-pull-request/18009/
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 20, 2018https://github.com/nodejs/node/pull/23786#issuecomment-431589096
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018 https://github.com/nodejs/node/pull/23786#pullrequestreview-166752606
View reviewed changes https://github.com/nodejs/node/pull/23786/files
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/23786#pullrequestreview-166752606
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
src/node_api_impl.hhttps://github.com/nodejs/node/pull/23786/files#diff-6498a24c3033a1ce31f367a4c6bf61a00685e057bf662cccd3cfd25c90550811
refackhttps://github.com/refack
Oct 20, 2018https://github.com/nodejs/node/pull/23786#discussion_r226830416
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 20, 2018https://github.com/nodejs/node/pull/23786#discussion_r226831202
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 20, 2018https://github.com/nodejs/node/pull/23786#issuecomment-431593710
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 20, 2018https://github.com/nodejs/node/pull/23786#issuecomment-431594282
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 20, 2018https://github.com/nodejs/node/pull/23786#issuecomment-431606531
Please reload this pagehttps://github.com/nodejs/node/pull/23786
ECMA TC53 that works on a ECMAScript-based wearable platformhttps://www.ecma-international.org/memento/tc53-m.htm
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 20, 2018https://github.com/nodejs/node/pull/23786#issuecomment-431611097
@joyeecheunghttps://github.com/joyeecheung
JerryScript implementationhttps://github.com/jerryscript-project/jerryscript/tree/master/jerry-core/ecma
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 20, 2018https://github.com/nodejs/node/pull/23786#issuecomment-431611364
@joyeecheunghttps://github.com/joyeecheung
https://nodejs.org/docs/latest/api/n-api.html#n_api_working_with_javascript_valueshttps://nodejs.org/docs/latest/api/n-api.html#n_api_working_with_javascript_values
https://nodejs.org/docs/latest/api/n-api.html#n_api_napi_typedarray_typehttps://nodejs.org/docs/latest/api/n-api.html#n_api_napi_typedarray_type
https://nodejs.org/docs/latest/api/n-api.html#n_api_napi_create_arrayhttps://nodejs.org/docs/latest/api/n-api.html#n_api_napi_create_array
https://nodejs.org/docs/latest/api/n-api.html#n_api_napi_create_arraybufferhttps://nodejs.org/docs/latest/api/n-api.html#n_api_napi_create_arraybuffer
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 20, 2018https://github.com/nodejs/node/pull/23786#issuecomment-431613895
Please reload this pagehttps://github.com/nodejs/node/pull/23786
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 20, 2018https://github.com/nodejs/node/pull/23786#issuecomment-431622984
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 21, 2018https://github.com/nodejs/node/pull/23786#issuecomment-431627563
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/db1194f0a4d7da1cebbdda16dc1c00b19bd1c3fb..c759091d6bc8a4622254bdda378ec19854dc1edf
db1194fhttps://github.com/nodejs/node/commit/db1194f0a4d7da1cebbdda16dc1c00b19bd1c3fb
c759091https://github.com/nodejs/node/commit/c759091d6bc8a4622254bdda378ec19854dc1edf
Compare https://github.com/nodejs/node/compare/db1194f0a4d7da1cebbdda16dc1c00b19bd1c3fb..c759091d6bc8a4622254bdda378ec19854dc1edf
October 21, 2018 00:23https://github.com/nodejs/node/pull/23786#event-1916439922
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 21, 2018https://github.com/nodejs/node/pull/23786#issuecomment-431628295
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 21, 2018https://github.com/nodejs/node/pull/23786#issuecomment-431670186
@bghgaryhttps://github.com/bghgary
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/bghgary
bghgaryhttps://github.com/bghgary
Oct 21, 2018 https://github.com/nodejs/node/pull/23786#ref-issue-372048797
Factor out N-API to expand embeddability use cases nodejs/abi-stable-node#354 https://github.com/nodejs/abi-stable-node/issues/354
https://github.com/bghgary
bghgaryhttps://github.com/bghgary
Oct 21, 2018https://github.com/nodejs/node/pull/23786#issuecomment-431691292
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 22, 2018https://github.com/nodejs/node/pull/23786#issuecomment-432001176
Please reload this pagehttps://github.com/nodejs/node/pull/23786
@bghgaryhttps://github.com/bghgary
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 23, 2018https://github.com/nodejs/node/pull/23786#issuecomment-432090435
@bghgaryhttps://github.com/bghgary
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/0995958d3701b1993d86897fa78f43645f9a849c..78733cebac6f3bd66050f5c39277da1f852a4dd3
0995958https://github.com/nodejs/node/commit/0995958d3701b1993d86897fa78f43645f9a849c
78733cehttps://github.com/nodejs/node/commit/78733cebac6f3bd66050f5c39277da1f852a4dd3
Compare https://github.com/nodejs/node/compare/0995958d3701b1993d86897fa78f43645f9a849c..78733cebac6f3bd66050f5c39277da1f852a4dd3
October 23, 2018 06:08https://github.com/nodejs/node/pull/23786#event-1919372942
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 23, 2018https://github.com/nodejs/node/pull/23786#issuecomment-432106357
@bghgaryhttps://github.com/bghgary
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/bghgary
bghgaryhttps://github.com/bghgary
Oct 23, 2018https://github.com/nodejs/node/pull/23786#issuecomment-432447386
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/bghgary
bghgaryhttps://github.com/bghgary
Oct 25, 2018 https://github.com/nodejs/node/pull/23786#pullrequestreview-168146576
View reviewed changes https://github.com/nodejs/node/pull/23786/files
bghgaryhttps://github.com/bghgary
https://github.com/nodejs/node/pull/23786#pullrequestreview-168146576
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
src/node_api_internals.hhttps://github.com/nodejs/node/pull/23786/files#diff-c372bc32c40bb03a940f5df7367e7e7ac804e05908ff08ce1b5e6fc50fe7057d
bghgaryhttps://github.com/bghgary
Oct 24, 2018https://github.com/nodejs/node/pull/23786#discussion_r227981489
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
src/node_api_internals.hhttps://github.com/nodejs/node/pull/23786/files#diff-c372bc32c40bb03a940f5df7367e7e7ac804e05908ff08ce1b5e6fc50fe7057d
bghgaryhttps://github.com/bghgary
Oct 24, 2018https://github.com/nodejs/node/pull/23786#discussion_r227982338
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
src/node_api_internals.hhttps://github.com/nodejs/node/pull/23786/files#diff-c372bc32c40bb03a940f5df7367e7e7ac804e05908ff08ce1b5e6fc50fe7057d
bghgaryhttps://github.com/bghgary
Oct 24, 2018https://github.com/nodejs/node/pull/23786#discussion_r227983248
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
src/node_api_internals.hhttps://github.com/nodejs/node/pull/23786/files#diff-c372bc32c40bb03a940f5df7367e7e7ac804e05908ff08ce1b5e6fc50fe7057d
bghgaryhttps://github.com/bghgary
Oct 24, 2018https://github.com/nodejs/node/pull/23786#discussion_r227984332
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node_persistent.hhttps://github.com/nodejs/node/blob/master/src/node_persistent.h
Please reload this pagehttps://github.com/nodejs/node/pull/23786
src/node_api_internals.hhttps://github.com/nodejs/node/pull/23786/files#diff-c372bc32c40bb03a940f5df7367e7e7ac804e05908ff08ce1b5e6fc50fe7057d
bghgaryhttps://github.com/bghgary
Oct 24, 2018https://github.com/nodejs/node/pull/23786#discussion_r227984853
Please reload this pagehttps://github.com/nodejs/node/pull/23786
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
src/node_api.cchttps://github.com/nodejs/node/pull/23786/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc
bghgaryhttps://github.com/bghgary
Oct 24, 2018https://github.com/nodejs/node/pull/23786#discussion_r227988797
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
src/node_api_internals.hhttps://github.com/nodejs/node/pull/23786/files#diff-c372bc32c40bb03a940f5df7367e7e7ac804e05908ff08ce1b5e6fc50fe7057d
bghgaryhttps://github.com/bghgary
Oct 24, 2018https://github.com/nodejs/node/pull/23786#discussion_r227990520
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
bghgaryhttps://github.com/bghgary
Oct 25, 2018https://github.com/nodejs/node/pull/23786#discussion_r228313117
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
test/addons-napi/7_factory_wrap/myobject.hhttps://github.com/nodejs/node/pull/23786/files#diff-a135109be61267505ce0e7ac9899b4138e384153a9ee18f51bea000f11705939
bghgaryhttps://github.com/bghgary
Oct 24, 2018https://github.com/nodejs/node/pull/23786#discussion_r227992455
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
src/node_api.hhttps://github.com/nodejs/node/pull/23786/files#diff-1a7a14ecb8ebcfadce2b39d74f174b946745bf6970291ea7be17399b7bbca3d5
bghgaryhttps://github.com/bghgary
Oct 24, 2018https://github.com/nodejs/node/pull/23786#discussion_r227994528
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 7, 2018https://github.com/nodejs/node/pull/23786#discussion_r231460965
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/bghgary
bghgaryhttps://github.com/bghgary
Oct 25, 2018https://github.com/nodejs/node/pull/23786#issuecomment-432869027
Please reload this pagehttps://github.com/nodejs/node/pull/23786
@gabrielschulhofhttps://github.com/gabrielschulhof
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/bghgary
bghgaryhttps://github.com/bghgary
Oct 25, 2018https://github.com/nodejs/node/pull/23786#issuecomment-432869439
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 25, 2018https://github.com/nodejs/node/pull/23786#issuecomment-432902163
@bghgaryhttps://github.com/bghgary
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/bghgary
bghgaryhttps://github.com/bghgary
Oct 25, 2018https://github.com/nodejs/node/pull/23786#issuecomment-433163606
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 15, 2018https://github.com/nodejs/node/pull/23786#issuecomment-439133269
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 15, 2018https://github.com/nodejs/node/pull/23786#issuecomment-439133873
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/yorkie
yorkiehttps://github.com/yorkie
Nov 16, 2018 https://github.com/nodejs/node/pull/23786#pullrequestreview-175672722
View reviewed changes https://github.com/nodejs/node/pull/23786/files/f69d030d9a9c6e6246c3803e663444931b7b843a
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 16, 2018https://github.com/nodejs/node/pull/23786#issuecomment-439457385
@yorkiehttps://github.com/yorkie
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 16, 2018https://github.com/nodejs/node/pull/23786#issuecomment-439496580
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 16, 2018https://github.com/nodejs/node/pull/23786#issuecomment-439541597
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 16, 2018 https://github.com/nodejs/node/pull/23786#pullrequestreview-176011234
View reviewed changes https://github.com/nodejs/node/pull/23786/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/23786#pullrequestreview-176011234
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 17, 2018https://github.com/nodejs/node/pull/23786#issuecomment-439573939
https://ci.nodejs.org/job/node-test-pull-request/18693/https://ci.nodejs.org/job/node-test-pull-request/18693/
Please reload this pagehttps://github.com/nodejs/node/pull/23786
address review commentshttps://github.com/nodejs/node/pull/23786/commits/4b1257485b0dd6549ec3bfce39cf95cf1096a614
4b12574https://github.com/nodejs/node/pull/23786/commits/4b1257485b0dd6549ec3bfce39cf95cf1096a614
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/26461cc64d2b66bfa1b5d2d955a0cae7630a22c9..4b1257485b0dd6549ec3bfce39cf95cf1096a614
26461cchttps://github.com/nodejs/node/commit/26461cc64d2b66bfa1b5d2d955a0cae7630a22c9
4b12574https://github.com/nodejs/node/commit/4b1257485b0dd6549ec3bfce39cf95cf1096a614
Compare https://github.com/nodejs/node/compare/26461cc64d2b66bfa1b5d2d955a0cae7630a22c9..4b1257485b0dd6549ec3bfce39cf95cf1096a614
November 17, 2018 20:49https://github.com/nodejs/node/pull/23786#event-1972946607
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 17, 2018https://github.com/nodejs/node/pull/23786#issuecomment-439646678
https://ci.nodejs.org/job/node-test-pull-request/18703/https://ci.nodejs.org/job/node-test-pull-request/18703/
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 17, 2018https://github.com/nodejs/node/pull/23786#issuecomment-439652882
596bd5fhttps://github.com/nodejs/node/commit/596bd5f1bb64cebc8d9b72c114f78ef9f074863b
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 17, 2018https://github.com/nodejs/node/pull/23786#event-1972985615
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 17, 2018 https://github.com/nodejs/node/pull/23786#ref-commit-596bd5f
src: factor out Node.js-agnostic N-APIshttps://github.com/nodejs/node/commit/596bd5f1bb64cebc8d9b72c114f78ef9f074863b
596bd5fhttps://github.com/nodejs/node/commit/596bd5f1bb64cebc8d9b72c114f78ef9f074863b
#23786https://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
November 17, 2018 22:43https://github.com/nodejs/node/pull/23786#event-1972986369
targoshttps://github.com/targos
Nov 18, 2018 https://github.com/nodejs/node/pull/23786#ref-commit-6083179
https://github.com/targos
src: factor out Node.js-agnostic N-APIshttps://github.com/nodejs/node/commit/6083179836f3ba386460ba842f6482d57b513a95
6083179https://github.com/nodejs/node/commit/6083179836f3ba386460ba842f6482d57b513a95
#23786https://github.com/nodejs/node/pull/23786
https://github.com/bghgary
bghgaryhttps://github.com/bghgary
Nov 19, 2018https://github.com/nodejs/node/pull/23786#issuecomment-440006226
@gabrielschulhofhttps://github.com/gabrielschulhof
this issuehttps://github.com/nodejs/node/pull/23786#discussion_r231292411
this issuehttps://github.com/nodejs/node/pull/23786#discussion_r231292896
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 19, 2018https://github.com/nodejs/node/pull/23786#issuecomment-440037563
@bghgaryhttps://github.com/bghgary
@gabrielschulhofhttps://github.com/gabrielschulhof
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/bghgary
bghgaryhttps://github.com/bghgary
Nov 19, 2018https://github.com/nodejs/node/pull/23786#issuecomment-440039161
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/bghgary
bghgaryhttps://github.com/bghgary
Nov 20, 2018https://github.com/nodejs/node/pull/23786#issuecomment-440094114
#24498https://github.com/nodejs/node/pull/24498
Please reload this pagehttps://github.com/nodejs/node/pull/23786
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23786#ref-commit-af3c7ef
https://github.com/rvagg
src: factor out Node.js-agnostic N-APIshttps://github.com/nodejs/node/commit/af3c7efffc43894a789b2460b60ea95fc70f51db
af3c7efhttps://github.com/nodejs/node/commit/af3c7efffc43894a789b2460b60ea95fc70f51db
#23786https://github.com/nodejs/node/pull/23786
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 5, 2018 https://github.com/nodejs/node/pull/23786#ref-pullrequest-387948820
v11.4.0 proposal #24854 https://github.com/nodejs/node/pull/24854
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261 https://github.com/beevelop/docker-android-nodejs/issues/261
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262 https://github.com/beevelop/docker-android-nodejs/issues/262
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263 https://github.com/beevelop/docker-android-nodejs/issues/263
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264 https://github.com/beevelop/docker-android-nodejs/issues/264
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265 https://github.com/beevelop/docker-android-nodejs/issues/265
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jan 12, 2019https://github.com/nodejs/node/pull/23786#issuecomment-453789075
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/codebytere
codebyterehttps://github.com/codebytere
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Jan 12, 2019https://github.com/nodejs/node/pull/23786#event-2070309829
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/23786#ref-commit-fbba37d
https://github.com/refack
src: factor out Node.js-agnostic N-APIshttps://github.com/refack/node/commit/fbba37db42de9b75d59acbec081cbb6fcde557de
fbba37dhttps://github.com/refack/node/commit/fbba37db42de9b75d59acbec081cbb6fcde557de
nodejs#23786https://github.com/nodejs/node/pull/23786
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23786
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/23786/files/26461cc64d2b66bfa1b5d2d955a0cae7630a22c9
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/23786/files/db1194f0a4d7da1cebbdda16dc1c00b19bd1c3fb
https://github.com/bghgary
bghgary https://github.com/bghgary
https://github.com/nodejs/node/pull/23786/files/f69d030d9a9c6e6246c3803e663444931b7b843a
https://github.com/yorkie
yorkie https://github.com/yorkie
https://github.com/nodejs/node/pull/23786/files/f69d030d9a9c6e6246c3803e663444931b7b843a
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/23786
https://github.com/gabrielschulhof
https://github.com/nodejs-github-bot
https://github.com/joyeecheung
https://github.com/bghgary
https://github.com/mhdawson
https://github.com/Trott
https://github.com/codebytere
https://github.com/refack
https://github.com/yorkie
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.