René's URL Explorer Experiment


Title: test: verify `performance.timerify()` works w/ non-Node Contexts by addaleax · Pull Request #23784 · nodejs/node · GitHub

Open Graph Title: test: verify `performance.timerify()` works w/ non-Node Contexts by addaleax · Pull Request #23784 · nodejs/node

X Title: test: verify `performance.timerify()` works w/ non-Node Contexts by addaleax · Pull Request #23784 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/23784

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:283cbf77-fbca-9a54-8ec2-3fdc7cd7d109
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB496:32F1C:61C086:8032B3:699030DA
html-safe-nonce3acb4f7576d95ead38f2330bab7207c8d7d4c5d8fa9d1423fd95857e3f9c8861
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDk2OjMyRjFDOjYxQzA4Njo4MDMyQjM6Njk5MDMwREEiLCJ2aXNpdG9yX2lkIjoiODg1NzE5MTgyODU3MjYxNDg3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf9aeb6e388d0bb6424b51f5ab86a5bfd41938b0d99ce44f5c630f18688f1efbc
hovercard-subject-tagpull_request:224470769
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23784/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5010bbfcac04995987abdd4a33411f664ed7d3af6c7052a25ca9db4327671274/nodejs/node/pull/23784
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5010bbfcac04995987abdd4a33411f664ed7d3af6c7052a25ca9db4327671274/nodejs/node/pull/23784
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23784#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23784
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23784
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23784
Reloadhttps://github.com/nodejs/node/pull/23784
Reloadhttps://github.com/nodejs/node/pull/23784
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23784
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:perf-timerify-non-non-contexthttps://github.com/addaleax/node/tree/perf-timerify-non-non-context
Conversationhttps://github.com/nodejs/node/pull/23784
Commits1 (1)https://github.com/nodejs/node/pull/23784/commits
Checkshttps://github.com/nodejs/node/pull/23784/checks
Files changedhttps://github.com/nodejs/node/pull/23784/files
test: verify performance.timerify() works w/ non-Node Contextshttps://github.com/nodejs/node/pull/23784#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:perf-timerify-non-non-contexthttps://github.com/addaleax/node/tree/perf-timerify-non-non-context
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 20, 2018https://github.com/nodejs/node/pull/23784#issue-372204388
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23784
https://github.com/addaleax
test: verify performance.timerify() works w/ non-Node Contextshttps://github.com/nodejs/node/pull/23784/commits/a134d74c81877a4f3bce0efe2a3845c8fd4cccc5
a134d74https://github.com/nodejs/node/pull/23784/commits/a134d74c81877a4f3bce0efe2a3845c8fd4cccc5
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 20, 2018https://github.com/nodejs/node/pull/23784#issuecomment-431574163
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1315/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1315/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23784
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Oct 20, 2018https://github.com/nodejs/node/pull/23784#event-1916181575
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018 https://github.com/nodejs/node/pull/23784#pullrequestreview-166751731
View reviewed changes https://github.com/nodejs/node/pull/23784/files/a134d74c81877a4f3bce0efe2a3845c8fd4cccc5
test/addons/non-node-context/test-perf-hooks-timerify.jshttps://github.com/nodejs/node/pull/23784/files/a134d74c81877a4f3bce0efe2a3845c8fd4cccc5#diff-fbe218365e46430f79f1b30b50053992c2c1a480b6dedb1c37bf6b72fe270182
refackhttps://github.com/refack
Oct 20, 2018https://github.com/nodejs/node/pull/23784#discussion_r226829364
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23784
addaleaxhttps://github.com/addaleax
Oct 21, 2018https://github.com/nodejs/node/pull/23784#discussion_r226844871
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23784
refackhttps://github.com/refack
Oct 21, 2018https://github.com/nodejs/node/pull/23784#discussion_r226845321
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://user-images.githubusercontent.com/96947/47262277-78c14780-d4b2-11e8-87cf-0a6a07dade9c.png
Please reload this pagehttps://github.com/nodejs/node/pull/23784
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 22, 2018 https://github.com/nodejs/node/pull/23784#pullrequestreview-167127303
View reviewed changes https://github.com/nodejs/node/pull/23784/files/a134d74c81877a4f3bce0efe2a3845c8fd4cccc5
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 24, 2018https://github.com/nodejs/node/pull/23784#event-1922977545
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 24, 2018https://github.com/nodejs/node/pull/23784#issuecomment-432601053
https://ci.nodejs.org/job/node-test-pull-request/18102/https://ci.nodejs.org/job/node-test-pull-request/18102/
Please reload this pagehttps://github.com/nodejs/node/pull/23784
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 24, 2018 https://github.com/nodejs/node/pull/23784#pullrequestreview-167998640
View reviewed changes https://github.com/nodejs/node/pull/23784/files/a134d74c81877a4f3bce0efe2a3845c8fd4cccc5
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 25, 2018https://github.com/nodejs/node/pull/23784#issuecomment-433144816
a3cad3ehttps://github.com/nodejs/node/commit/a3cad3e2ff95eb7474b4baefafc969211657a896
Please reload this pagehttps://github.com/nodejs/node/pull/23784
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 25, 2018https://github.com/nodejs/node/pull/23784#event-1926928921
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
October 25, 2018 17:50https://github.com/nodejs/node/pull/23784#event-1926929104
addaleaxhttps://github.com/addaleax
Oct 25, 2018 https://github.com/nodejs/node/pull/23784#ref-commit-a3cad3e
https://github.com/addaleax
test: verify performance.timerify() works w/ non-Node Contextshttps://github.com/nodejs/node/commit/a3cad3e2ff95eb7474b4baefafc969211657a896
a3cad3ehttps://github.com/nodejs/node/commit/a3cad3e2ff95eb7474b4baefafc969211657a896
#23784https://github.com/nodejs/node/pull/23784
targoshttps://github.com/targos
Oct 26, 2018 https://github.com/nodejs/node/pull/23784#ref-commit-4182f74
https://github.com/addaleax
https://github.com/targos
test: verify performance.timerify() works w/ non-Node Contextshttps://github.com/nodejs/node/commit/4182f7430771b58886a5297f234c4f04246bf7b9
4182f74https://github.com/nodejs/node/commit/4182f7430771b58886a5297f234c4f04246bf7b9
#23784https://github.com/nodejs/node/pull/23784
https://github.com/targos
targoshttps://github.com/targos
Oct 27, 2018 https://github.com/nodejs/node/pull/23784#ref-pullrequest-374624819
Release proposal: v11.1.0 #23922 https://github.com/nodejs/node/pull/23922
targoshttps://github.com/targos
Nov 1, 2018 https://github.com/nodejs/node/pull/23784#ref-commit-572ea60
https://github.com/addaleax
https://github.com/targos
test: verify performance.timerify() works w/ non-Node Contextshttps://github.com/nodejs/node/commit/572ea60378110b15b31600ec723599709c5e6a57
572ea60https://github.com/nodejs/node/commit/572ea60378110b15b31600ec723599709c5e6a57
#23784https://github.com/nodejs/node/pull/23784
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#245 https://github.com/beevelop/docker-android-nodejs/issues/245
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#246 https://github.com/beevelop/docker-android-nodejs/issues/246
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#247 https://github.com/beevelop/docker-android-nodejs/issues/247
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#248 https://github.com/beevelop/docker-android-nodejs/issues/248
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x
Nov 26, 2018https://github.com/nodejs/node/pull/23784#event-1988090683
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 26, 2018https://github.com/nodejs/node/pull/23784#issuecomment-441827884
Please reload this pagehttps://github.com/nodejs/node/pull/23784
MylesBorinshttps://github.com/MylesBorins
Nov 26, 2018 https://github.com/nodejs/node/pull/23784#ref-commit-f30f11b
https://github.com/addaleax
https://github.com/MylesBorins
test: verify performance.timerify() works w/ non-Node Contextshttps://github.com/nodejs/node/commit/f30f11bd5db889ff66d890427af7e8a2245a4495
f30f11bhttps://github.com/nodejs/node/commit/f30f11bd5db889ff66d890427af7e8a2245a4495
#23784https://github.com/nodejs/node/pull/23784
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23784#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23784#ref-commit-889acf0
https://github.com/addaleax
https://github.com/rvagg
test: verify performance.timerify() works w/ non-Node Contextshttps://github.com/nodejs/node/commit/889acf0b741e78ffc601583e9727b714fdf2ba65
889acf0https://github.com/nodejs/node/commit/889acf0b741e78ffc601583e9727b714fdf2ba65
#23784https://github.com/nodejs/node/pull/23784
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23784#ref-commit-d1c6238
https://github.com/addaleax
https://github.com/MylesBorins
test: verify performance.timerify() works w/ non-Node Contextshttps://github.com/nodejs/node/commit/d1c6238e1d01175446cfbd4c16d3957df2a4720a
d1c6238https://github.com/nodejs/node/commit/d1c6238e1d01175446cfbd4c16d3957df2a4720a
#23784https://github.com/nodejs/node/pull/23784
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23784#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23784
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23784/files/a134d74c81877a4f3bce0efe2a3845c8fd4cccc5
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23784/files/a134d74c81877a4f3bce0efe2a3845c8fd4cccc5
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/23784/files/a134d74c81877a4f3bce0efe2a3845c8fd4cccc5
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/23784
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/MylesBorins
https://github.com/refack
https://github.com/jasnell
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.