René's URL Explorer Experiment


Title: src: use more explicit return type in Sign::SignFinal() by addaleax · Pull Request #23779 · nodejs/node · GitHub

Open Graph Title: src: use more explicit return type in Sign::SignFinal() by addaleax · Pull Request #23779 · nodejs/node

X Title: src: use more explicit return type in Sign::SignFinal() by addaleax · Pull Request #23779 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Using the non-indexed variant of std::get<> broke Travis CI. Also, this allows us to be a bit more concise when returning from SignFinal() due to some error condition. Refs: #23427 Checklist...

X Description: Using the non-indexed variant of std::get&lt;&gt; broke Travis CI. Also, this allows us to be a bit more concise when returning from SignFinal() due to some error condition. Refs: #23427 C...

Opengraph URL: https://github.com/nodejs/node/pull/23779

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e297c099-ba9f-cf00-91a7-bced0b3d95f5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC452:3463DE:3C320DD:551A234:6A4FA2F0
html-safe-nonce2a2c619c4b72e0ca1d971370294b1283b5333007737a5b72167d8005ca02e04b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDUyOjM0NjNERTozQzMyMEREOjU1MUEyMzQ6NkE0RkEyRjAiLCJ2aXNpdG9yX2lkIjoiMzY5NDk3MDY5MDUwNjM0OTkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf60b987faa75e28fc00260f0878df23bd724338798eabbf978233e6b61c5b436
hovercard-subject-tagpull_request:224448590
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23779/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c4daae43bfe42dd6f2e435bb50736684be4d9b220ed382fc6323e0b231eda77b/nodejs/node/pull/23779
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c4daae43bfe42dd6f2e435bb50736684be4d9b220ed382fc6323e0b231eda77b/nodejs/node/pull/23779
og:image:altUsing the non-indexed variant of std::get<> broke Travis CI. Also, this allows us to be a bit more concise when returning from SignFinal() due to some error condition. Refs: #23427 Checklist...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23779#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23779
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23779
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23779
Reloadhttps://github.com/nodejs/node/pull/23779
Reloadhttps://github.com/nodejs/node/pull/23779
Please reload this pagehttps://github.com/nodejs/node/pull/23779
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23779
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 972 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:crypto-no-pairhttps://github.com/addaleax/node/tree/crypto-no-pair
Conversationhttps://github.com/nodejs/node/pull/23779
Commits2 (2)https://github.com/nodejs/node/pull/23779/commits
Checkshttps://github.com/nodejs/node/pull/23779/checks
Files changedhttps://github.com/nodejs/node/pull/23779/files
src: use more explicit return type in Sign::SignFinal()https://github.com/nodejs/node/pull/23779#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:crypto-no-pairhttps://github.com/addaleax/node/tree/crypto-no-pair
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 20, 2018https://github.com/nodejs/node/pull/23779#issue-372167496
#23427https://github.com/nodejs/node/pull/23427
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23779
https://github.com/addaleax
src: use more explicit return type in Sign::SignFinal()https://github.com/nodejs/node/pull/23779/commits/b0046488a30d55050b1fd6c49e466ed627300432
b004648https://github.com/nodejs/node/pull/23779/commits/b0046488a30d55050b1fd6c49e466ed627300432
nodejs#23427https://github.com/nodejs/node/pull/23427
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 20, 2018https://github.com/nodejs/node/pull/23779#issuecomment-431544751
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1310/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1310/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23779
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Oct 20, 2018https://github.com/nodejs/node/pull/23779#event-1916029949
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 20, 2018https://github.com/nodejs/node/pull/23779#issuecomment-431544831
Please reload this pagehttps://github.com/nodejs/node/pull/23779
@refackhttps://github.com/refack
@tniessenhttps://github.com/tniessen
https://ci.nodejs.org/job/node-test-pull-request/18003/https://ci.nodejs.org/job/node-test-pull-request/18003/
#23778https://github.com/nodejs/node/pull/23778
Please reload this pagehttps://github.com/nodejs/node/pull/23779
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Oct 20, 2018https://github.com/nodejs/node/pull/23779#event-1916030752
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018 https://github.com/nodejs/node/pull/23779#pullrequestreview-166737099
View reviewed changes https://github.com/nodejs/node/pull/23779/files/b0046488a30d55050b1fd6c49e466ed627300432
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/23779#pullrequestreview-166737099
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23779
src/node_crypto.hhttps://github.com/nodejs/node/pull/23779/files/b0046488a30d55050b1fd6c49e466ed627300432#diff-470e0cf24a7d187261d3d90860324ab61599d549fbbcd910c011d394d2a3a950
Please reload this pagehttps://github.com/nodejs/node/pull/23779
src/node_crypto.cchttps://github.com/nodejs/node/pull/23779/files/b0046488a30d55050b1fd6c49e466ed627300432#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
Please reload this pagehttps://github.com/nodejs/node/pull/23779
https://github.com/addaleax
fixup! src: use more explicit return type in Sign::SignFinal()https://github.com/nodejs/node/pull/23779/commits/a765e78244487dc929dec57eb1d3a6eedc1a7be5
a765e78https://github.com/nodejs/node/pull/23779/commits/a765e78244487dc929dec57eb1d3a6eedc1a7be5
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 20, 2018https://github.com/nodejs/node/pull/23779#issuecomment-431547383
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23779
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 20, 2018 https://github.com/nodejs/node/pull/23779#pullrequestreview-166742512
View reviewed changes https://github.com/nodejs/node/pull/23779/files/a765e78244487dc929dec57eb1d3a6eedc1a7be5
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 20, 2018 https://github.com/nodejs/node/pull/23779#pullrequestreview-166748882
View reviewed changes https://github.com/nodejs/node/pull/23779/files/a765e78244487dc929dec57eb1d3a6eedc1a7be5
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018 https://github.com/nodejs/node/pull/23779#pullrequestreview-166749801
View reviewed changes https://github.com/nodejs/node/pull/23779/files/a765e78244487dc929dec57eb1d3a6eedc1a7be5
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018https://github.com/nodejs/node/pull/23779#issuecomment-431582941
Please reload this pagehttps://github.com/nodejs/node/pull/23779
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 20, 2018 https://github.com/nodejs/node/pull/23779#pullrequestreview-166750053
View reviewed changes https://github.com/nodejs/node/pull/23779/files/a765e78244487dc929dec57eb1d3a6eedc1a7be5
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018https://github.com/nodejs/node/pull/23779#issuecomment-431620155
Please reload this pagehttps://github.com/nodejs/node/pull/23779
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 21, 2018https://github.com/nodejs/node/pull/23779#issuecomment-431630363
20282b1https://github.com/nodejs/node/commit/20282b1cb0389553421c4c5b14de198c5dfff50b
Please reload this pagehttps://github.com/nodejs/node/pull/23779
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 21, 2018https://github.com/nodejs/node/pull/23779#event-1916451359
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
October 21, 2018 01:15https://github.com/nodejs/node/pull/23779#event-1916451391
addaleaxhttps://github.com/addaleax
Oct 21, 2018 https://github.com/nodejs/node/pull/23779#ref-commit-20282b1
https://github.com/addaleax
src: use more explicit return type in Sign::SignFinal()https://github.com/nodejs/node/commit/20282b1cb0389553421c4c5b14de198c5dfff50b
20282b1https://github.com/nodejs/node/commit/20282b1cb0389553421c4c5b14de198c5dfff50b
#23427https://github.com/nodejs/node/pull/23427
#23779https://github.com/nodejs/node/pull/23779
jasnellhttps://github.com/jasnell
Oct 21, 2018 https://github.com/nodejs/node/pull/23779#ref-commit-b8cb60f
https://github.com/addaleax
https://github.com/jasnell
src: use more explicit return type in Sign::SignFinal()https://github.com/nodejs/node/commit/b8cb60fcb913c56c8938e41024db6b7dead94e02
b8cb60fhttps://github.com/nodejs/node/commit/b8cb60fcb913c56c8938e41024db6b7dead94e02
#23427https://github.com/nodejs/node/pull/23427
#23779https://github.com/nodejs/node/pull/23779
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Nov 26, 2018https://github.com/nodejs/node/pull/23779#event-1987318507
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 26, 2018https://github.com/nodejs/node/pull/23779#issuecomment-441711540
the guidehttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/23779
BethGriggshttps://github.com/BethGriggs
Oct 18, 2019 https://github.com/nodejs/node/pull/23779#ref-commit-1bb5102
https://github.com/addaleax
https://github.com/BethGriggs
src: use more explicit return type in Sign::SignFinal()https://github.com/nodejs/node/commit/1bb51029998c7a53b78828a7a0c2f312768fc71e
1bb5102https://github.com/nodejs/node/commit/1bb51029998c7a53b78828a7a0c2f312768fc71e
#23427https://github.com/nodejs/node/pull/23427
#23779https://github.com/nodejs/node/pull/23779
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Oct 18, 2019https://github.com/nodejs/node/pull/23779#event-2724410905
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 18, 2019 https://github.com/nodejs/node/pull/23779#ref-pullrequest-503572635
v10.17.0 proposal #29875 https://github.com/nodejs/node/pull/29875
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23779
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23779/files/a765e78244487dc929dec57eb1d3a6eedc1a7be5
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/23779/files/a765e78244487dc929dec57eb1d3a6eedc1a7be5
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/23779/files/a765e78244487dc929dec57eb1d3a6eedc1a7be5
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/23779/files/a765e78244487dc929dec57eb1d3a6eedc1a7be5
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Please reload this pagehttps://github.com/nodejs/node/pull/23779
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/refack
https://github.com/MylesBorins
https://github.com/cjihrig
https://github.com/tniessen
https://github.com/joyeecheung
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.