René's URL Explorer Experiment


Title: src: don't use fopen() in require() fast path by bnoordhuis · Pull Request #2377 · nodejs/node · GitHub

Open Graph Title: src: don't use fopen() in require() fast path by bnoordhuis · Pull Request #2377 · nodejs/node

X Title: src: don't use fopen() in require() fast path by bnoordhuis · Pull Request #2377 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fix a regression that was introduced in commit 1bbf8d0 ("lib: speed up require(), phase 2") where file paths with Unicode characters fail to load on Windows. Refs #2236. CI: https://jenki...

X Description: Fix a regression that was introduced in commit 1bbf8d0 ("lib: speed up require(), phase 2") where file paths with Unicode characters fail to load on Windows. Refs #2236. CI: https...

Opengraph URL: https://github.com/nodejs/node/pull/2377

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bc47e757-adae-6dcb-a465-164a41f195b8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF9A:310BDB:1921870:22A5D73:6A4EB9B4
html-safe-nonce351935aa1003ab3f990c61e5248d56956022bbdafdd3b3f8260dd5dbedda7cf7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjlBOjMxMEJEQjoxOTIxODcwOjIyQTVENzM6NkE0RUI5QjQiLCJ2aXNpdG9yX2lkIjoiMzE2NjcyMjQ4OTEyMTE1OTYwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac92dd52aa777dfdce40d26209bc44095e1feb675b4dc10d4934a8d4d440c8e6dd
hovercard-subject-tagpull_request:42461975
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/2377/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4f4dd78431e78a4f5ed1e705ce0b73ea12d443674748448b5c3bb414ffce5c6e/nodejs/node/pull/2377
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4f4dd78431e78a4f5ed1e705ce0b73ea12d443674748448b5c3bb414ffce5c6e/nodejs/node/pull/2377
og:image:altFix a regression that was introduced in commit 1bbf8d0 ("lib: speed up require(), phase 2") where file paths with Unicode characters fail to load on Windows. Refs #2236. CI: https://jenki...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/2377#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2377
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2377
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/2377
Reloadhttps://github.com/nodejs/node/pull/2377
Reloadhttps://github.com/nodejs/node/pull/2377
Please reload this pagehttps://github.com/nodejs/node/pull/2377
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/2377
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix-issue-2236https://github.com/bnoordhuis/io.js/tree/fix-issue-2236
Conversationhttps://github.com/nodejs/node/pull/2377
Commits0 (0)https://github.com/nodejs/node/pull/2377/commits
Checkshttps://github.com/nodejs/node/pull/2377/checks
Files changedhttps://github.com/nodejs/node/pull/2377/files
src: don't use fopen() in require() fast pathhttps://github.com/nodejs/node/pull/2377#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix-issue-2236https://github.com/bnoordhuis/io.js/tree/fix-issue-2236
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 14, 2015https://github.com/nodejs/node/pull/2377#issue-101022950
#2236https://github.com/nodejs/node/issues/2236
https://jenkins-iojs.nodesource.com/job/node-test-pull-request/87/https://jenkins-iojs.nodesource.com/job/node-test-pull-request/87/
https://jenkins-iojs.nodesource.com/job/node-test-commit/158/https://jenkins-iojs.nodesource.com/job/node-test-commit/158/
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/2377
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 14, 2015 https://github.com/nodejs/node/pull/2377#ref-issue-97007070
require fails to load 'package.json' when the module path contains Chinese characters on Windows. #2236 https://github.com/nodejs/node/issues/2236
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Aug 14, 2015https://github.com/nodejs/node/pull/2377#event-382630129
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Aug 14, 2015https://github.com/nodejs/node/pull/2377#issuecomment-131128481
Please reload this pagehttps://github.com/nodejs/node/pull/2377
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 14, 2015https://github.com/nodejs/node/pull/2377#issuecomment-131129812
Please reload this pagehttps://github.com/nodejs/node/pull/2377
thefourtheyehttps://github.com/thefourtheye
Aug 14, 2015 https://github.com/nodejs/node/pull/2377#discussion-diff-37083023
View reviewed changes https://github.com/nodejs/node/pull/2377/files#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6
src/node_file.cchttps://github.com/nodejs/node/pull/2377/files#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6
thefourtheyehttps://github.com/thefourtheye
Aug 14, 2015https://github.com/nodejs/node/pull/2377#discussion_r37083023
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2377
bnoordhuishttps://github.com/bnoordhuis
Aug 14, 2015https://github.com/nodejs/node/pull/2377#discussion_r37084685
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2377
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 14, 2015https://github.com/nodejs/node/pull/2377#issuecomment-131167199
libuv/libuv#479https://github.com/libuv/libuv/pull/479
Please reload this pagehttps://github.com/nodejs/node/pull/2377
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 14, 2015https://github.com/nodejs/node/pull/2377#issuecomment-131168326
https://jenkins-iojs.nodesource.com/job/node-test-pull-request/87/https://jenkins-iojs.nodesource.com/job/node-test-pull-request/87/
https://jenkins-iojs.nodesource.com/job/node-test-commit/158/https://jenkins-iojs.nodesource.com/job/node-test-commit/158/
Please reload this pagehttps://github.com/nodejs/node/pull/2377
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Aug 15, 2015https://github.com/nodejs/node/pull/2377#issuecomment-131321989
https://jenkins-iojs.nodesource.com/job/node-test-pull-request/91/https://jenkins-iojs.nodesource.com/job/node-test-pull-request/91/
Please reload this pagehttps://github.com/nodejs/node/pull/2377
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 15, 2015https://github.com/nodejs/node/pull/2377#issuecomment-131354973
#784https://github.com/nodejs/node/issues/784
https://jenkins-iojs.nodesource.com/job/node-test-pull-request/92/https://jenkins-iojs.nodesource.com/job/node-test-pull-request/92/
Please reload this pagehttps://github.com/nodejs/node/pull/2377
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 15, 2015https://github.com/nodejs/node/pull/2377#issuecomment-131354990
@silverwindhttps://github.com/silverwind
Please reload this pagehttps://github.com/nodejs/node/pull/2377
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Aug 15, 2015https://github.com/nodejs/node/pull/2377#issuecomment-131367836
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/2377
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Aug 15, 2015https://github.com/nodejs/node/pull/2377#issuecomment-131369053
@bpaserohttps://github.com/bpasero
@hokeinhttps://github.com/hokein
Please reload this pagehttps://github.com/nodejs/node/pull/2377
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 15, 2015https://github.com/nodejs/node/pull/2377#issuecomment-131421543
Please reload this pagehttps://github.com/nodejs/node/pull/2377
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 17, 2015https://github.com/nodejs/node/pull/2377#issuecomment-131794596
confirmationhttps://github.com/nodejs/node/issues/2236#issuecomment-131728060
@piscisaureushttps://github.com/piscisaureus
@trevnorrishttps://github.com/trevnorris
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/2377
https://github.com/piscisaureus
piscisaureushttps://github.com/piscisaureus
Aug 17, 2015https://github.com/nodejs/node/pull/2377#issuecomment-131798728
Please reload this pagehttps://github.com/nodejs/node/pull/2377
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 17, 2015https://github.com/nodejs/node/pull/2377#event-384528004
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/8c6d6eb433f24c2fe7969fb69e949b9545b05280..a593cb7682df7e45550d1ebe26be310dc7bef6bd
8c6d6ebhttps://github.com/nodejs/node/commit/8c6d6eb433f24c2fe7969fb69e949b9545b05280
a593cb7https://github.com/nodejs/node/commit/a593cb7682df7e45550d1ebe26be310dc7bef6bd
Compare https://github.com/nodejs/node/compare/8c6d6eb433f24c2fe7969fb69e949b9545b05280..a593cb7682df7e45550d1ebe26be310dc7bef6bd
August 17, 2015 18:20https://github.com/nodejs/node/pull/2377#event-384528005
bnoordhuishttps://github.com/bnoordhuis
Aug 17, 2015 https://github.com/nodejs/node/pull/2377#ref-commit-a593cb7
https://github.com/bnoordhuis
src: don't use fopen() in require() fast pathhttps://github.com/bnoordhuis/io.js/commit/a593cb7682df7e45550d1ebe26be310dc7bef6bd
a593cb7https://github.com/bnoordhuis/io.js/commit/a593cb7682df7e45550d1ebe26be310dc7bef6bd
nodejs#2236https://github.com/nodejs/node/issues/2236
nodejs#2377https://github.com/nodejs/node/pull/2377
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
August 17, 2015 18:20https://github.com/nodejs/node/pull/2377#event-384528029
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
a593cb7https://github.com/nodejs/node/commit/a593cb7682df7e45550d1ebe26be310dc7bef6bd
Aug 17, 2015https://github.com/nodejs/node/pull/2377#event-384528171
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
land-on-v3.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v3.x
Aug 17, 2015https://github.com/nodejs/node/pull/2377#event-384528910
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Aug 18, 2015 https://github.com/nodejs/node/pull/2377#ref-pullrequest-100370242
Release Proposal: v3.1.0 #2347 https://github.com/nodejs/node/pull/2347
Fishrock123https://github.com/Fishrock123
Aug 19, 2015 https://github.com/nodejs/node/pull/2377#ref-commit-d1307b2
https://github.com/bnoordhuis
https://github.com/Fishrock123
src: don't use fopen() in require() fast pathhttps://github.com/Fishrock123/node/commit/d1307b2995c8ce05dbe35a279c75ed6f0e4c903f
d1307b2https://github.com/Fishrock123/node/commit/d1307b2995c8ce05dbe35a279c75ed6f0e4c903f
nodejs#2236https://github.com/nodejs/node/issues/2236
nodejs#2377https://github.com/nodejs/node/pull/2377
jsonnhttps://github.com/jsonn
Sep 9, 2015 https://github.com/nodejs/node/pull/2377#ref-commit-33b3766
Update to 4.0.0https://github.com/jsonn/pkgsrc/commit/33b3766530c9de4a54b95c97cc3f1c4dfc57c845
33b3766https://github.com/jsonn/pkgsrc/commit/33b3766530c9de4a54b95c97cc3f1c4dfc57c845
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 7, 2022 https://github.com/nodejs/node/pull/2377#ref-pullrequest-1196270523
[Snyk] Security upgrade request from 2.74.0 to 2.75.0 solebox/node#28 https://github.com/solebox/node/pull/28
mskhttps://github.com/msk
May 11, 2026 https://github.com/nodejs/node/pull/2377#ref-commit-e40913a
https://github.com/ryoon
Update to 4.0.0https://github.com/msk/pkgsrc/commit/e40913a84d8a2f34a1cfb92bd22db143bc1e0c52
e40913ahttps://github.com/msk/pkgsrc/commit/e40913a84d8a2f34a1cfb92bd22db143bc1e0c52
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2377
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/2377
https://github.com/bnoordhuis
https://github.com/thefourtheye
https://github.com/silverwind
https://github.com/piscisaureus
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.