René's URL Explorer Experiment


Title: test: fix invalid modulesLength during DSA keygen by AdamMajer · Pull Request #23732 · nodejs/node · GitHub

Open Graph Title: test: fix invalid modulesLength during DSA keygen by AdamMajer · Pull Request #23732 · nodejs/node

X Title: test: fix invalid modulesLength during DSA keygen by AdamMajer · Pull Request #23732 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: In #23430, key sizes were reduced to speed up the test. Unfortunately this resulted in invalid DSA key generation parameters. In standard build of OpenSSL, key generation uses dsa_builtin_paramgen ...

X Description: In #23430, key sizes were reduced to speed up the test. Unfortunately this resulted in invalid DSA key generation parameters. In standard build of OpenSSL, key generation uses dsa_builtin_paramgen ...

Opengraph URL: https://github.com/nodejs/node/pull/23732

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:150b9e14-efbe-5405-99f9-6c943bc94f04
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC3E6:1988EF:62738:7E6B8:69902A69
html-safe-nonce60fce9296a0ea4f4902ebf038591713710ef9f770ed6fca802a4087ab35fc6b4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0U2OjE5ODhFRjo2MjczODo3RTZCODo2OTkwMkE2OSIsInZpc2l0b3JfaWQiOiI2NjYxMjgzMjAxNjk5MjkzODAxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8e82c7dd34d7c783821ac40b89be7cc85f9e5b1d7546e4c4270d602c40debbe9
hovercard-subject-tagpull_request:223973860
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23732/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/10625aa9d03b36b240779fc97c37dfe05ba07fe97dfb73bedb99287b40926f7c/nodejs/node/pull/23732
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/10625aa9d03b36b240779fc97c37dfe05ba07fe97dfb73bedb99287b40926f7c/nodejs/node/pull/23732
og:image:altIn #23430, key sizes were reduced to speed up the test. Unfortunately this resulted in invalid DSA key generation parameters. In standard build of OpenSSL, key generation uses dsa_builtin_paramgen ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAdamMajer
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23732#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23732
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23732
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23732
Reloadhttps://github.com/nodejs/node/pull/23732
Reloadhttps://github.com/nodejs/node/pull/23732
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23732
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
AdamMajerhttps://github.com/AdamMajer
nodejs:masterhttps://github.com/nodejs/node/tree/master
AdamMajer:masterhttps://github.com/AdamMajer/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/23732
Commits1 (1)https://github.com/nodejs/node/pull/23732/commits
Checkshttps://github.com/nodejs/node/pull/23732/checks
Files changedhttps://github.com/nodejs/node/pull/23732/files
test: fix invalid modulesLength during DSA keygenhttps://github.com/nodejs/node/pull/23732#top
AdamMajerhttps://github.com/AdamMajer
nodejs:masterhttps://github.com/nodejs/node/tree/master
AdamMajer:masterhttps://github.com/AdamMajer/node/tree/master
https://github.com/AdamMajer
AdamMajerhttps://github.com/AdamMajer
Oct 18, 2018https://github.com/nodejs/node/pull/23732#issue-371552631
#23430https://github.com/nodejs/node/pull/23430
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23732
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Oct 18, 2018https://github.com/nodejs/node/pull/23732#event-1912380800
https://github.com/AdamMajer
test: fix invalid modulesLength for DSA keygenhttps://github.com/nodejs/node/pull/23732/commits/478e360c550df5472364229bbb2bc11ea1be3210
478e360https://github.com/nodejs/node/pull/23732/commits/478e360c550df5472364229bbb2bc11ea1be3210
nodejs#23430https://github.com/nodejs/node/pull/23430
https://github.com/AdamMajer
AdamMajerhttps://github.com/AdamMajer
force-pushedhttps://github.com/nodejs/node/compare/cbede9dbbe680da5123e2d4baf5667385ecaeecb..478e360c550df5472364229bbb2bc11ea1be3210
cbede9dhttps://github.com/nodejs/node/commit/cbede9dbbe680da5123e2d4baf5667385ecaeecb
478e360https://github.com/nodejs/node/commit/478e360c550df5472364229bbb2bc11ea1be3210
Compare https://github.com/nodejs/node/compare/cbede9dbbe680da5123e2d4baf5667385ecaeecb..478e360c550df5472364229bbb2bc11ea1be3210
October 18, 2018 14:17https://github.com/nodejs/node/pull/23732#event-1912384325
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Oct 18, 2018 https://github.com/nodejs/node/pull/23732#pullrequestreview-166128685
View reviewed changes https://github.com/nodejs/node/pull/23732/files/478e360c550df5472364229bbb2bc11ea1be3210
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Oct 18, 2018https://github.com/nodejs/node/pull/23732#issuecomment-431034672
@AdamMajerhttps://github.com/AdamMajer
Please reload this pagehttps://github.com/nodejs/node/pull/23732
https://github.com/AdamMajer
AdamMajerhttps://github.com/AdamMajer
Oct 18, 2018https://github.com/nodejs/node/pull/23732#issuecomment-431036798
Please reload this pagehttps://github.com/nodejs/node/pull/23732
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 18, 2018 https://github.com/nodejs/node/pull/23732#pullrequestreview-166194539
View reviewed changes https://github.com/nodejs/node/pull/23732/files/478e360c550df5472364229bbb2bc11ea1be3210
test/parallel/test-crypto-keygen.jshttps://github.com/nodejs/node/pull/23732/files/478e360c550df5472364229bbb2bc11ea1be3210#diff-a8ca9cf1f986d6c6b75d22592ed05f4726e34b37ae8583bb47d09b69183a1474
Trotthttps://github.com/Trott
Oct 18, 2018https://github.com/nodejs/node/pull/23732#discussion_r226384532
Please reload this pagehttps://github.com/nodejs/node/pull/23732
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23732
sam-githubhttps://github.com/sam-github
Oct 18, 2018https://github.com/nodejs/node/pull/23732#discussion_r226389644
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23732
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 18, 2018https://github.com/nodejs/node/pull/23732#issuecomment-431083025
https://ci.nodejs.org/job/node-test-pull-request/17972/https://ci.nodejs.org/job/node-test-pull-request/17972/
Please reload this pagehttps://github.com/nodejs/node/pull/23732
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 18, 2018https://github.com/nodejs/node/pull/23732#event-1912801254
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 18, 2018https://github.com/nodejs/node/pull/23732#issuecomment-431190819
Please reload this pagehttps://github.com/nodejs/node/pull/23732
https://ci.nodejs.org/job/node-test-pull-request/17979/https://ci.nodejs.org/job/node-test-pull-request/17979/
Please reload this pagehttps://github.com/nodejs/node/pull/23732
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 19, 2018 https://github.com/nodejs/node/pull/23732#pullrequestreview-166559692
View reviewed changes https://github.com/nodejs/node/pull/23732/files/478e360c550df5472364229bbb2bc11ea1be3210
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 19, 2018 https://github.com/nodejs/node/pull/23732#pullrequestreview-166561151
View reviewed changes https://github.com/nodejs/node/pull/23732/files/478e360c550df5472364229bbb2bc11ea1be3210
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Oct 19, 2018 https://github.com/nodejs/node/pull/23732#pullrequestreview-166578401
View reviewed changes https://github.com/nodejs/node/pull/23732/files/478e360c550df5472364229bbb2bc11ea1be3210
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 19, 2018 https://github.com/nodejs/node/pull/23732#pullrequestreview-166717865
View reviewed changes https://github.com/nodejs/node/pull/23732/files/478e360c550df5472364229bbb2bc11ea1be3210
https://github.com/tniessen
tniessenhttps://github.com/tniessen
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Oct 19, 2018https://github.com/nodejs/node/pull/23732#event-1915879458
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 24, 2018https://github.com/nodejs/node/pull/23732#issuecomment-432501610
a88ca52https://github.com/nodejs/node/commit/a88ca5246c5af6bf5d7b614a0f92c3a847efb20b
Please reload this pagehttps://github.com/nodejs/node/pull/23732
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 24, 2018https://github.com/nodejs/node/pull/23732#event-1922275968
danbevhttps://github.com/danbev
Oct 24, 2018 https://github.com/nodejs/node/pull/23732#ref-commit-a88ca52
https://github.com/AdamMajer
https://github.com/danbev
test: fix invalid modulesLength for DSA keygenhttps://github.com/nodejs/node/commit/a88ca5246c5af6bf5d7b614a0f92c3a847efb20b
a88ca52https://github.com/nodejs/node/commit/a88ca5246c5af6bf5d7b614a0f92c3a847efb20b
#23732https://github.com/nodejs/node/pull/23732
#23430https://github.com/nodejs/node/pull/23430
targoshttps://github.com/targos
Oct 24, 2018 https://github.com/nodejs/node/pull/23732#ref-commit-1521d89
https://github.com/AdamMajer
https://github.com/targos
test: fix invalid modulesLength for DSA keygenhttps://github.com/nodejs/node/commit/1521d8991d393d440f59a68979db6cb31ae706db
1521d89https://github.com/nodejs/node/commit/1521d8991d393d440f59a68979db6cb31ae706db
#23732https://github.com/nodejs/node/pull/23732
#23430https://github.com/nodejs/node/pull/23430
https://github.com/targos
targoshttps://github.com/targos
Oct 27, 2018 https://github.com/nodejs/node/pull/23732#ref-pullrequest-374624819
Release proposal: v11.1.0 #23922 https://github.com/nodejs/node/pull/23922
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#245 https://github.com/beevelop/docker-android-nodejs/issues/245
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#246 https://github.com/beevelop/docker-android-nodejs/issues/246
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#247 https://github.com/beevelop/docker-android-nodejs/issues/247
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#248 https://github.com/beevelop/docker-android-nodejs/issues/248
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Nov 26, 2018https://github.com/nodejs/node/pull/23732#event-1987732792
MylesBorinshttps://github.com/MylesBorins
Nov 26, 2018 https://github.com/nodejs/node/pull/23732#ref-commit-79be83d
https://github.com/AdamMajer
https://github.com/MylesBorins
test: fix invalid modulesLength for DSA keygenhttps://github.com/nodejs/node/commit/79be83dde9aec5830226a07bba15dc430d035980
79be83dhttps://github.com/nodejs/node/commit/79be83dde9aec5830226a07bba15dc430d035980
#23732https://github.com/nodejs/node/pull/23732
#23430https://github.com/nodejs/node/pull/23430
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23732#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23732#ref-commit-cb229e0
https://github.com/AdamMajer
https://github.com/rvagg
test: fix invalid modulesLength for DSA keygenhttps://github.com/nodejs/node/commit/cb229e0fd9680fc5379519405c43669f1f6c8f95
cb229e0https://github.com/nodejs/node/commit/cb229e0fd9680fc5379519405c43669f1f6c8f95
#23732https://github.com/nodejs/node/pull/23732
#23430https://github.com/nodejs/node/pull/23430
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23732#ref-commit-1747e47
https://github.com/AdamMajer
https://github.com/MylesBorins
test: fix invalid modulesLength for DSA keygenhttps://github.com/nodejs/node/commit/1747e473bd57b9a67dd6a70245461fe70d96f190
1747e47https://github.com/nodejs/node/commit/1747e473bd57b9a67dd6a70245461fe70d96f190
#23732https://github.com/nodejs/node/pull/23732
#23430https://github.com/nodejs/node/pull/23430
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23732#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23732
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23732/files/478e360c550df5472364229bbb2bc11ea1be3210
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/23732/files/478e360c550df5472364229bbb2bc11ea1be3210
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/23732/files/478e360c550df5472364229bbb2bc11ea1be3210
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/23732/files/478e360c550df5472364229bbb2bc11ea1be3210
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/23732/files/478e360c550df5472364229bbb2bc11ea1be3210
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/23732/files/478e360c550df5472364229bbb2bc11ea1be3210
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/23732
https://github.com/AdamMajer
https://github.com/sam-github
https://github.com/Trott
https://github.com/danbev
https://github.com/jasnell
https://github.com/tniessen
https://github.com/BridgeAR
https://github.com/trivikr
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.