René's URL Explorer Experiment


Title: tools: do not lint commit message if var undefined by Trott · Pull Request #23725 · nodejs/node · GitHub

Open Graph Title: tools: do not lint commit message if var undefined by Trott · Pull Request #23725 · nodejs/node

X Title: tools: do not lint commit message if var undefined by Trott · Pull Request #23725 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit messages in Travis CI. Refs: #23572 (comment) Refs: #22842 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows...

X Description: Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit messages in Travis CI. Refs: #23572 (comment) Refs: #22842 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows...

Opengraph URL: https://github.com/nodejs/node/pull/23725

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ed6b05c7-1b1e-cc19-4d7f-6b74ca00c3ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF8A:D9F0:152A079:1ADC7AA:69917C9C
html-safe-nonce38478c1d2d328279352f0635a503e1a392ebe4b6522505c3d1083e9716d73c6b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjhBOkQ5RjA6MTUyQTA3OToxQURDN0FBOjY5OTE3QzlDIiwidmlzaXRvcl9pZCI6IjU2MTEzNTU0ODUyOTcwMTU5NjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacacd1fc5c3c67d1608efd938c0b78f6c43ef1e0665399259525c19e66c99c470a
hovercard-subject-tagpull_request:223806211
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23725/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b1013c957ae85669fd4b727bc533ed868e62f81f42977ac3d21147439319927b/nodejs/node/pull/23725
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b1013c957ae85669fd4b727bc533ed868e62f81f42977ac3d21147439319927b/nodejs/node/pull/23725
og:image:altCheck that $TRAVIS_COMMIT_RANGE is set before trying to lint commit messages in Travis CI. Refs: #23572 (comment) Refs: #22842 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23725#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23725
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23725
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23725
Reloadhttps://github.com/nodejs/node/pull/23725
Reloadhttps://github.com/nodejs/node/pull/23725
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23725
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:travis-env-checkhttps://github.com/Trott/io.js/tree/travis-env-check
Conversationhttps://github.com/nodejs/node/pull/23725
Commits1 (1)https://github.com/nodejs/node/pull/23725/commits
Checkshttps://github.com/nodejs/node/pull/23725/checks
Files changedhttps://github.com/nodejs/node/pull/23725/files
tools: do not lint commit message if var undefinedhttps://github.com/nodejs/node/pull/23725#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:travis-env-checkhttps://github.com/Trott/io.js/tree/travis-env-check
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 18, 2018https://github.com/nodejs/node/pull/23725#issue-371335615
#23572 (comment)https://github.com/nodejs/node/pull/23572#issuecomment-430850382
#22842 (comment)https://github.com/nodejs/node/pull/22842#issuecomment-430850049
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23725
https://github.com/Trott
tools: do not lint commit message if var undefinedhttps://github.com/nodejs/node/pull/23725/commits/83628a48b5e0be3b992a89333999b5ee174a75c4
83628a4https://github.com/nodejs/node/pull/23725/commits/83628a48b5e0be3b992a89333999b5ee174a75c4
nodejs#23572 (comment)https://github.com/nodejs/node/pull/23572#issuecomment-430850382
nodejs#22842 (comment)https://github.com/nodejs/node/pull/22842#issuecomment-430850049
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 18, 2018https://github.com/nodejs/node/pull/23725#issuecomment-430852813
@Trotthttps://github.com/Trott
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1279/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1279/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23725
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Oct 18, 2018 https://github.com/nodejs/node/pull/23725#pullrequestreview-165905465
View reviewed changes https://github.com/nodejs/node/pull/23725/files/83628a48b5e0be3b992a89333999b5ee174a75c4
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 18, 2018 https://github.com/nodejs/node/pull/23725#pullrequestreview-165921428
View reviewed changes https://github.com/nodejs/node/pull/23725/files/83628a48b5e0be3b992a89333999b5ee174a75c4
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 18, 2018https://github.com/nodejs/node/pull/23725#event-1911252057
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 18, 2018https://github.com/nodejs/node/pull/23725#issuecomment-430875693
Please reload this pagehttps://github.com/nodejs/node/pull/23725
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 18, 2018 https://github.com/nodejs/node/pull/23725#pullrequestreview-165945152
View reviewed changes https://github.com/nodejs/node/pull/23725/files/83628a48b5e0be3b992a89333999b5ee174a75c4
.travis.ymlhttps://github.com/nodejs/node/pull/23725/files/83628a48b5e0be3b992a89333999b5ee174a75c4#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485
lpincahttps://github.com/lpinca
Oct 18, 2018https://github.com/nodejs/node/pull/23725#discussion_r226185488
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23725
Trotthttps://github.com/Trott
Oct 18, 2018https://github.com/nodejs/node/pull/23725#discussion_r226491524
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23725
Trotthttps://github.com/Trott
Oct 18, 2018https://github.com/nodejs/node/pull/23725#discussion_r226492033
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#23741https://github.com/nodejs/node/pull/23741
Please reload this pagehttps://github.com/nodejs/node/pull/23725
Trotthttps://github.com/Trott
Oct 18, 2018https://github.com/nodejs/node/pull/23725#discussion_r226492285
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://codebeautify.org/yaml-validatorhttps://codebeautify.org/yaml-validator
Please reload this pagehttps://github.com/nodejs/node/pull/23725
lpincahttps://github.com/lpinca
Oct 19, 2018https://github.com/nodejs/node/pull/23725#discussion_r226537032
Please reload this pagehttps://github.com/nodejs/node/pull/23725
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/primus/eventemitter3/blob/991b9454dd977cbfb327203a03885c8f721095e3/.travis.ymlhttps://github.com/primus/eventemitter3/blob/991b9454dd977cbfb327203a03885c8f721095e3/.travis.yml
Please reload this pagehttps://github.com/nodejs/node/pull/23725
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Oct 18, 2018 https://github.com/nodejs/node/pull/23725#pullrequestreview-166269129
View reviewed changes https://github.com/nodejs/node/pull/23725/files/83628a48b5e0be3b992a89333999b5ee174a75c4
mmarchinihttps://github.com/mmarchini
https://github.com/nodejs/node/pull/23725#pullrequestreview-166269129
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#23737https://github.com/nodejs/node/issues/23737
Please reload this pagehttps://github.com/nodejs/node/pull/23725
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Oct 18, 2018https://github.com/nodejs/node/pull/23725#issuecomment-431141678
Please reload this pagehttps://github.com/nodejs/node/pull/23725
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 18, 2018 https://github.com/nodejs/node/pull/23725#ref-issue-371685057
Travis linter false-negatives for commit message checks #23737 https://github.com/nodejs/node/issues/23737
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/c7be511d2efd61c30a579eee3b914c176b1db1a9..83628a48b5e0be3b992a89333999b5ee174a75c4
c7be511https://github.com/nodejs/node/commit/c7be511d2efd61c30a579eee3b914c176b1db1a9
83628a4https://github.com/nodejs/node/commit/83628a48b5e0be3b992a89333999b5ee174a75c4
Compare https://github.com/nodejs/node/compare/c7be511d2efd61c30a579eee3b914c176b1db1a9..83628a48b5e0be3b992a89333999b5ee174a75c4
October 18, 2018 23:02https://github.com/nodejs/node/pull/23725#event-1913552647
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 18, 2018 https://github.com/nodejs/node/pull/23725#ref-pullrequest-371745915
WIP: Do not merge #23741 https://github.com/nodejs/node/pull/23741
https://github.com/Trott
Trotthttps://github.com/Trott
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Oct 18, 2018https://github.com/nodejs/node/pull/23725#event-1913555547
https://github.com/refack
refackhttps://github.com/refack
Oct 18, 2018 https://github.com/nodejs/node/pull/23725#ref-pullrequest-371719010
build,meta: don't fail Travis for commit message #23739 https://github.com/nodejs/node/pull/23739
https://github.com/refack
refackhttps://github.com/refack
Oct 18, 2018https://github.com/nodejs/node/pull/23725#issuecomment-431197763
Please reload this pagehttps://github.com/nodejs/node/pull/23725
#23739https://github.com/nodejs/node/pull/23739
Please reload this pagehttps://github.com/nodejs/node/pull/23725
https://github.com/refack
refackhttps://github.com/refack
Oct 18, 2018https://github.com/nodejs/node/pull/23725#event-1913589425
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 18, 2018https://github.com/nodejs/node/pull/23725#issuecomment-431197991
Please reload this pagehttps://github.com/nodejs/node/pull/23725
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 18, 2018https://github.com/nodejs/node/pull/23725#event-1913589724
refackhttps://github.com/refack
Oct 18, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-6afaebc
https://github.com/Trott
https://github.com/refack
tools: do not lint commit message if var undefinedhttps://github.com/nodejs/node/commit/6afaebc4a0458e433d410d70d419fbc72b9b7c4a
6afaebchttps://github.com/nodejs/node/commit/6afaebc4a0458e433d410d70d419fbc72b9b7c4a
#23572 (comment)https://github.com/nodejs/node/pull/23572#issuecomment-430850382
#22842 (comment)https://github.com/nodejs/node/pull/22842#issuecomment-430850049
#23725https://github.com/nodejs/node/pull/23725
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 18, 2018https://github.com/nodejs/node/pull/23725#event-1913590455
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 18, 2018https://github.com/nodejs/node/pull/23725#issuecomment-431200752
https://user-images.githubusercontent.com/439929/47190343-aa40e400-d2f5-11e8-8353-17f2a79e4e3b.png
Please reload this pagehttps://github.com/nodejs/node/pull/23725
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 18, 2018https://github.com/nodejs/node/pull/23725#issuecomment-431200931
@jasnellhttps://github.com/jasnell
@mmarchinihttps://github.com/mmarchini
Please reload this pagehttps://github.com/nodejs/node/pull/23725
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 18, 2018https://github.com/nodejs/node/pull/23725#issuecomment-431201524
Collaborator Guidehttps://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#waiting-for-approvals
@mmarchinihttps://github.com/mmarchini
Please reload this pagehttps://github.com/nodejs/node/pull/23725
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 19, 2018https://github.com/nodejs/node/pull/23725#issuecomment-431202936
Please reload this pagehttps://github.com/nodejs/node/pull/23725
@mmarchinihttps://github.com/mmarchini
Please reload this pagehttps://github.com/nodejs/node/pull/23725
jasnellhttps://github.com/jasnell
Oct 19, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-c759b56
https://github.com/jasnell
meta: clarify fast-track approvalhttps://github.com/jasnell/node/commit/c759b56712434fdfc7cbbf730b878eaa61b5c4f1
c759b56https://github.com/jasnell/node/commit/c759b56712434fdfc7cbbf730b878eaa61b5c4f1
nodejs#23725 (comment)https://github.com/nodejs/node/pull/23725#issuecomment-431202936
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 19, 2018 https://github.com/nodejs/node/pull/23725#ref-pullrequest-371766063
meta: clarify fast-track approval #23744 https://github.com/nodejs/node/pull/23744
jasnellhttps://github.com/jasnell
Oct 19, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-f142747
https://github.com/jasnell
meta: clarify fast-track approvalhttps://github.com/nodejs/node/commit/f14274714d00bb5b58482bef15e84cdda9237910
f142747https://github.com/nodejs/node/commit/f14274714d00bb5b58482bef15e84cdda9237910
#23725 (comment)https://github.com/nodejs/node/pull/23725#issuecomment-431202936
#23744https://github.com/nodejs/node/pull/23744
addaleaxhttps://github.com/addaleax
Oct 20, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-bf93064
https://github.com/Trott
https://github.com/addaleax
tools: do not lint commit message if var undefinedhttps://github.com/nodejs/node/commit/bf9306471b75256d72c980c26875fedf267defa4
bf93064https://github.com/nodejs/node/commit/bf9306471b75256d72c980c26875fedf267defa4
#23572 (comment)https://github.com/nodejs/node/pull/23572#issuecomment-430850382
#22842 (comment)https://github.com/nodejs/node/pull/22842#issuecomment-430850049
#23725https://github.com/nodejs/node/pull/23725
addaleaxhttps://github.com/addaleax
Oct 20, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-3c0b3d5
https://github.com/jasnell
https://github.com/addaleax
meta: clarify fast-track approvalhttps://github.com/nodejs/node/commit/3c0b3d582d08793c0f729b884a78b02a43dfd3ad
3c0b3d5https://github.com/nodejs/node/commit/3c0b3d582d08793c0f729b884a78b02a43dfd3ad
#23725 (comment)https://github.com/nodejs/node/pull/23725#issuecomment-431202936
#23744https://github.com/nodejs/node/pull/23744
jasnellhttps://github.com/jasnell
Oct 21, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-40280e6
https://github.com/Trott
https://github.com/jasnell
tools: do not lint commit message if var undefinedhttps://github.com/nodejs/node/commit/40280e62a30399469b93bf5a5eb78f9a1e1bae62
40280e6https://github.com/nodejs/node/commit/40280e62a30399469b93bf5a5eb78f9a1e1bae62
#23572 (comment)https://github.com/nodejs/node/pull/23572#issuecomment-430850382
#22842 (comment)https://github.com/nodejs/node/pull/22842#issuecomment-430850049
#23725https://github.com/nodejs/node/pull/23725
jasnellhttps://github.com/jasnell
Oct 21, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-bb26d4f
https://github.com/jasnell
meta: clarify fast-track approvalhttps://github.com/nodejs/node/commit/bb26d4f2f88f30ae17e04dca44e7c004f62d0a43
bb26d4fhttps://github.com/nodejs/node/commit/bb26d4f2f88f30ae17e04dca44e7c004f62d0a43
#23725 (comment)https://github.com/nodejs/node/pull/23725#issuecomment-431202936
#23744https://github.com/nodejs/node/pull/23744
MylesBorinshttps://github.com/MylesBorins
Oct 30, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-28599e8
https://github.com/Trott
https://github.com/MylesBorins
tools: do not lint commit message if var undefinedhttps://github.com/nodejs/node/commit/28599e896a4d23da246935561dc7e98fc7c69953
28599e8https://github.com/nodejs/node/commit/28599e896a4d23da246935561dc7e98fc7c69953
#23572 (comment)https://github.com/nodejs/node/pull/23572#issuecomment-430850382
#22842 (comment)https://github.com/nodejs/node/pull/22842#issuecomment-430850049
#23725https://github.com/nodejs/node/pull/23725
MylesBorinshttps://github.com/MylesBorins
Oct 30, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-8ec2c51
https://github.com/jasnell
https://github.com/MylesBorins
meta: clarify fast-track approvalhttps://github.com/nodejs/node/commit/8ec2c51bc9c1212fb30ab256b7923455b1d1e581
8ec2c51https://github.com/nodejs/node/commit/8ec2c51bc9c1212fb30ab256b7923455b1d1e581
#23725 (comment)https://github.com/nodejs/node/pull/23725#issuecomment-431202936
#23744https://github.com/nodejs/node/pull/23744
MylesBorinshttps://github.com/MylesBorins
Nov 26, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-6c8c01d
https://github.com/Trott
https://github.com/MylesBorins
tools: do not lint commit message if var undefinedhttps://github.com/nodejs/node/commit/6c8c01d438f95b1aa0609e4662df1e2ede6c0418
6c8c01dhttps://github.com/nodejs/node/commit/6c8c01d438f95b1aa0609e4662df1e2ede6c0418
#23572 (comment)https://github.com/nodejs/node/pull/23572#issuecomment-430850382
#22842 (comment)https://github.com/nodejs/node/pull/22842#issuecomment-430850049
#23725https://github.com/nodejs/node/pull/23725
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
Nov 26, 2018https://github.com/nodejs/node/pull/23725#event-1988082000
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23725#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-22043cc
https://github.com/Trott
https://github.com/rvagg
tools: do not lint commit message if var undefinedhttps://github.com/nodejs/node/commit/22043ccb840119337bca8d61f578b6ea1143257d
22043cchttps://github.com/nodejs/node/commit/22043ccb840119337bca8d61f578b6ea1143257d
#23572 (comment)https://github.com/nodejs/node/pull/23572#issuecomment-430850382
#22842 (comment)https://github.com/nodejs/node/pull/22842#issuecomment-430850049
#23725https://github.com/nodejs/node/pull/23725
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-30e3899
https://github.com/Trott
https://github.com/rvagg
tools: do not lint commit message if var undefinedhttps://github.com/nodejs/node/commit/30e389951289a9a23e39ccca6a14f0629f098622
30e3899https://github.com/nodejs/node/commit/30e389951289a9a23e39ccca6a14f0629f098622
#23572 (comment)https://github.com/nodejs/node/pull/23572#issuecomment-430850382
#22842 (comment)https://github.com/nodejs/node/pull/22842#issuecomment-430850049
#23725https://github.com/nodejs/node/pull/23725
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-6f5d609
https://github.com/jasnell
https://github.com/rvagg
meta: clarify fast-track approvalhttps://github.com/nodejs/node/commit/6f5d609cbfbee7d63e25089d9efa1fac3badf3b5
6f5d609https://github.com/nodejs/node/commit/6f5d609cbfbee7d63e25089d9efa1fac3badf3b5
#23725 (comment)https://github.com/nodejs/node/pull/23725#issuecomment-431202936
#23744https://github.com/nodejs/node/pull/23744
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-36bd9a9
https://github.com/Trott
https://github.com/MylesBorins
tools: do not lint commit message if var undefinedhttps://github.com/nodejs/node/commit/36bd9a98d7e429e106c4ef269515992800c3651a
36bd9a9https://github.com/nodejs/node/commit/36bd9a98d7e429e106c4ef269515992800c3651a
#23572 (comment)https://github.com/nodejs/node/pull/23572#issuecomment-430850382
#22842 (comment)https://github.com/nodejs/node/pull/22842#issuecomment-430850049
#23725https://github.com/nodejs/node/pull/23725
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23725#ref-commit-9718919
https://github.com/jasnell
https://github.com/MylesBorins
meta: clarify fast-track approvalhttps://github.com/nodejs/node/commit/9718919da9725dd0973e757b12b3ce5a13464179
9718919https://github.com/nodejs/node/commit/9718919da9725dd0973e757b12b3ce5a13464179
#23725 (comment)https://github.com/nodejs/node/pull/23725#issuecomment-431202936
#23744https://github.com/nodejs/node/pull/23744
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23725#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 4, 2018 https://github.com/nodejs/node/pull/23725#ref-pullrequest-387422551
v8.14.1 proposal #24832 https://github.com/nodejs/node/pull/24832
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#267 https://github.com/beevelop/docker-android-nodejs/issues/267
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#268 https://github.com/beevelop/docker-android-nodejs/issues/268
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#269 https://github.com/beevelop/docker-android-nodejs/issues/269
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#270 https://github.com/beevelop/docker-android-nodejs/issues/270
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#271 https://github.com/beevelop/docker-android-nodejs/issues/271
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:50https://github.com/nodejs/node/pull/23725#event-5890969197
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23725
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/23725/files/83628a48b5e0be3b992a89333999b5ee174a75c4
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23725/files/83628a48b5e0be3b992a89333999b5ee174a75c4
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/23725/files/83628a48b5e0be3b992a89333999b5ee174a75c4
https://github.com/mmarchini
mmarchini https://github.com/mmarchini
https://github.com/nodejs/node/pull/23725/files/83628a48b5e0be3b992a89333999b5ee174a75c4
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Please reload this pagehttps://github.com/nodejs/node/pull/23725
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/mmarchini
https://github.com/refack
https://github.com/jasnell
https://github.com/apapirovski
https://github.com/lpinca
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.