| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b8ffdb3d-63d3-fc94-7fbb-163b39d7b539 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A2C2:6964C:1597F88:1BADD2F:699083F6 |
| html-safe-nonce | 26ab5f48abc835e87c6689d903ae8d7d48be2485fc2545544885831ebe65e5c7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkMyOjY5NjRDOjE1OTdGODg6MUJBREQyRjo2OTkwODNGNiIsInZpc2l0b3JfaWQiOiIzNDY3NTExODgyMjA5ODU0NDU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a5337f90c9ed7ca4d9b39eb89f7cc99affa406a02048da7f4049c782b68235fe |
| hovercard-subject-tag | pull_request:223763776 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23721/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/df7486193d505ccd5f218ce055f5849e1475579f1cc5d7ddc5e858288a5e3a76/nodejs/node/pull/23721 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/df7486193d505ccd5f218ce055f5849e1475579f1cc5d7ddc5e858288a5e3a76/nodejs/node/pull/23721 |
| og:image:alt | Without this fix net/tcp-raw-c2s.js aborts in environments where PORT
is defined. TCPWrap::Connect expects the third arg to be a UInt32.
marceline :: ~/src/node ‹v10.x› » PORT=8080 node test/sequen... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ofrobots |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23721#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23721 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23721 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23721 |
| Reload | https://github.com/nodejs/node/pull/23721 |
| Reload | https://github.com/nodejs/node/pull/23721 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23721 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
706
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ofrobots | https://github.com/ofrobots |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| ofrobots:benchmarking-port-string | https://github.com/ofrobots/node/tree/benchmarking-port-string |
| Conversation | https://github.com/nodejs/node/pull/23721 |
| Commits1 (1) | https://github.com/nodejs/node/pull/23721/commits |
| Checks | https://github.com/nodejs/node/pull/23721/checks |
| Files changed | https://github.com/nodejs/node/pull/23721/files |
| benchmark: coerce PORT to number | https://github.com/nodejs/node/pull/23721#top |
| ofrobots | https://github.com/ofrobots |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| ofrobots:benchmarking-port-string | https://github.com/ofrobots/node/tree/benchmarking-port-string |
|
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Oct 17, 2018 | https://github.com/nodejs/node/pull/23721#issue-371280000 |
| Please reload this page | https://github.com/nodejs/node/pull/23721 |
| https://ci.nodejs.org/job/node-test-pull-request/17981/ | https://ci.nodejs.org/job/node-test-pull-request/17981/ |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23721 |
|
| https://github.com/ofrobots |
| benchmark: coerce PORT to number | https://github.com/nodejs/node/pull/23721/commits/dde99f3d9328bab3678ef18e54bfe960525a3c16 |
| dde99f3 | https://github.com/nodejs/node/pull/23721/commits/dde99f3d9328bab3678ef18e54bfe960525a3c16 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 17, 2018 | https://github.com/nodejs/node/pull/23721#issuecomment-430801164 |
| @ofrobots | https://github.com/ofrobots |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1277/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1277/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/23721 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Oct 17, 2018 | https://github.com/nodejs/node/pull/23721#event-1910777677 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23721#pullrequestreview-165858484 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23721/files/dde99f3d9328bab3678ef18e54bfe960525a3c16 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 18, 2018
| https://github.com/nodejs/node/pull/23721#pullrequestreview-165898621 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23721/files/dde99f3d9328bab3678ef18e54bfe960525a3c16 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 18, 2018 | https://github.com/nodejs/node/pull/23721#event-1911080101 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Oct 18, 2018
| https://github.com/nodejs/node/pull/23721#pullrequestreview-165945522 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23721/files/dde99f3d9328bab3678ef18e54bfe960525a3c16 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Oct 19, 2018
| https://github.com/nodejs/node/pull/23721#pullrequestreview-166383436 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23721/files/dde99f3d9328bab3678ef18e54bfe960525a3c16 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 19, 2018
| https://github.com/nodejs/node/pull/23721#pullrequestreview-166560576 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23721/files/dde99f3d9328bab3678ef18e54bfe960525a3c16 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 19, 2018 | https://github.com/nodejs/node/pull/23721#issuecomment-431390714 |
| https://ci.nodejs.org/job/node-test-pull-request/17985/ | https://ci.nodejs.org/job/node-test-pull-request/17985/ |
| Please reload this page | https://github.com/nodejs/node/pull/23721 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Oct 19, 2018
| https://github.com/nodejs/node/pull/23721#pullrequestreview-166578912 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23721/files/dde99f3d9328bab3678ef18e54bfe960525a3c16 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Oct 19, 2018 | https://github.com/nodejs/node/pull/23721#issuecomment-431458555 |
| https://ci.nodejs.org/job/node-test-pull-request/17990/ | https://ci.nodejs.org/job/node-test-pull-request/17990/ |
| Please reload this page | https://github.com/nodejs/node/pull/23721 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Oct 19, 2018 | https://github.com/nodejs/node/pull/23721#issuecomment-431513586 |
| Please reload this page | https://github.com/nodejs/node/pull/23721 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Oct 19, 2018 | https://github.com/nodejs/node/pull/23721#event-1915833866 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| October 19, 2018 22:07 | https://github.com/nodejs/node/pull/23721#event-1915833929 |
| ofrobots | https://github.com/ofrobots |
|
Oct 19, 2018
| https://github.com/nodejs/node/pull/23721#ref-commit-e5accf5 |
|
| https://github.com/ofrobots |
| benchmark: coerce PORT to number | https://github.com/nodejs/node/commit/e5accf546c30a813e268ca299c1dc8eed0adeb80 |
| e5accf5 | https://github.com/nodejs/node/commit/e5accf546c30a813e268ca299c1dc8eed0adeb80 |
| #23721 | https://github.com/nodejs/node/pull/23721 |
| addaleax | https://github.com/addaleax |
|
Oct 20, 2018
| https://github.com/nodejs/node/pull/23721#ref-commit-433507a |
|
| https://github.com/ofrobots |
|
| https://github.com/addaleax |
| benchmark: coerce PORT to number | https://github.com/nodejs/node/commit/433507a2f255aee47e607793867fb37bfe51fc75 |
| 433507a | https://github.com/nodejs/node/commit/433507a2f255aee47e607793867fb37bfe51fc75 |
| #23721 | https://github.com/nodejs/node/pull/23721 |
| jasnell | https://github.com/jasnell |
|
Oct 21, 2018
| https://github.com/nodejs/node/pull/23721#ref-commit-996b3c5 |
|
| https://github.com/ofrobots |
|
| https://github.com/jasnell |
| benchmark: coerce PORT to number | https://github.com/nodejs/node/commit/996b3c5bb1bc6f3a8035293ebc1cba7a854b0bd3 |
| 996b3c5 | https://github.com/nodejs/node/commit/996b3c5bb1bc6f3a8035293ebc1cba7a854b0bd3 |
| #23721 | https://github.com/nodejs/node/pull/23721 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23721#ref-commit-d13bb2c |
|
| https://github.com/ofrobots |
|
| https://github.com/MylesBorins |
| benchmark: coerce PORT to number | https://github.com/nodejs/node/commit/d13bb2c2eb6831d041af200b603573a8ac68fb33 |
| d13bb2c | https://github.com/nodejs/node/commit/d13bb2c2eb6831d041af200b603573a8ac68fb33 |
| #23721 | https://github.com/nodejs/node/pull/23721 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/23721#ref-pullrequest-384882602 |
|
v10.13.1 proposal
#24675
| https://github.com/nodejs/node/pull/24675 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23721#ref-commit-f3c32b9 |
|
| https://github.com/ofrobots |
|
| https://github.com/rvagg |
| benchmark: coerce PORT to number | https://github.com/nodejs/node/commit/f3c32b9c4ed6207119adab5de7b82471f4ebf065 |
| f3c32b9 | https://github.com/nodejs/node/commit/f3c32b9c4ed6207119adab5de7b82471f4ebf065 |
| #23721 | https://github.com/nodejs/node/pull/23721 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23721#ref-commit-60fe7f1 |
|
| https://github.com/ofrobots |
|
| https://github.com/MylesBorins |
| benchmark: coerce PORT to number | https://github.com/nodejs/node/commit/60fe7f1f29408c9b40c77f9c734a5d5ef502e070 |
| 60fe7f1 | https://github.com/nodejs/node/commit/60fe7f1f29408c9b40c77f9c734a5d5ef502e070 |
| #23721 | https://github.com/nodejs/node/pull/23721 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23721#ref-pullrequest-385836001 |
|
v10.14.2 proposal
#24727
| https://github.com/nodejs/node/pull/24727 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23721 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/23721/files/dde99f3d9328bab3678ef18e54bfe960525a3c16 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/23721/files/dde99f3d9328bab3678ef18e54bfe960525a3c16 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/23721/files/dde99f3d9328bab3678ef18e54bfe960525a3c16 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/23721/files/dde99f3d9328bab3678ef18e54bfe960525a3c16 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/23721/files/dde99f3d9328bab3678ef18e54bfe960525a3c16 |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/23721/files/dde99f3d9328bab3678ef18e54bfe960525a3c16 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Please reload this page | https://github.com/nodejs/node/pull/23721 |
|
| https://github.com/ofrobots |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/thefourtheye |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
|
| https://github.com/trivikr |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |