René's URL Explorer Experiment


Title: crypto: remove DiffieHellman.initialised_ by tniessen · Pull Request #23717 · nodejs/node · GitHub

Open Graph Title: crypto: remove DiffieHellman.initialised_ by tniessen · Pull Request #23717 · nodejs/node

X Title: crypto: remove DiffieHellman.initialised_ by tniessen · Pull Request #23717 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: As pointed out by @bnoordhuis, this internal field can be removed since all instances are initialized when exposed to users. Refs: #23648 Checklist make -j4 test (UNIX), or vcbuild test (Window...

X Description: As pointed out by @bnoordhuis, this internal field can be removed since all instances are initialized when exposed to users. Refs: #23648 Checklist make -j4 test (UNIX), or vcbuild test (Window...

Opengraph URL: https://github.com/nodejs/node/pull/23717

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:165e0d68-c081-d355-cd70-f1fc994a1355
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC43C:1AEC3E:2A62DD6:363FAA1:699030AC
html-safe-nonce298f404db03f06ae0a2bbc99f8fa075a8740daf28becb903f5688ccb4599bd8f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDNDOjFBRUMzRToyQTYyREQ2OjM2M0ZBQTE6Njk5MDMwQUMiLCJ2aXNpdG9yX2lkIjoiNDk0Njk5MDE0ODQ0NzM4MzcyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace4d6995ee437a7ee4db845481d6ddc0d12660f0bbf73a5a2e609804abb0ff21d
hovercard-subject-tagpull_request:223687441
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23717/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7403ac5589e8d646b4324897f8c06953e21a9f12c180446b34939fd3241fd676/nodejs/node/pull/23717
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7403ac5589e8d646b4324897f8c06953e21a9f12c180446b34939fd3241fd676/nodejs/node/pull/23717
og:image:altAs pointed out by @bnoordhuis, this internal field can be removed since all instances are initialized when exposed to users. Refs: #23648 Checklist make -j4 test (UNIX), or vcbuild test (Window...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23717#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23717
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23717
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23717
Reloadhttps://github.com/nodejs/node/pull/23717
Reloadhttps://github.com/nodejs/node/pull/23717
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23717
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-remove-diffiehellman-initialisedhttps://github.com/tniessen/node/tree/crypto-remove-diffiehellman-initialised
Conversationhttps://github.com/nodejs/node/pull/23717
Commits1 (1)https://github.com/nodejs/node/pull/23717/commits
Checkshttps://github.com/nodejs/node/pull/23717/checks
Files changedhttps://github.com/nodejs/node/pull/23717/files
crypto: remove DiffieHellman.initialised_https://github.com/nodejs/node/pull/23717#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-remove-diffiehellman-initialisedhttps://github.com/tniessen/node/tree/crypto-remove-diffiehellman-initialised
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 17, 2018https://github.com/nodejs/node/pull/23717#issue-371183233
@bnoordhuishttps://github.com/bnoordhuis
#23648https://github.com/nodejs/node/pull/23648
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23717
https://github.com/tniessen
crypto: remove DiffieHellman.initialised_https://github.com/nodejs/node/pull/23717/commits/d536fa5f62d7525ced6b3db01b7f5ed1c8f6c14b
d536fa5https://github.com/nodejs/node/pull/23717/commits/d536fa5f62d7525ced6b3db01b7f5ed1c8f6c14b
nodejs#23648https://github.com/nodejs/node/pull/23648
https://github.com/tniessen
tniessenhttps://github.com/tniessen
bnoordhuishttps://github.com/bnoordhuis
October 17, 2018 17:20https://github.com/nodejs/node/pull/23717#event-1910191907
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2018https://github.com/nodejs/node/pull/23717#issuecomment-430714454
@tniessenhttps://github.com/tniessen
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1276/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1276/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23717
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Oct 17, 2018https://github.com/nodejs/node/pull/23717#event-1910191988
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23717#pullrequestreview-165750155
View reviewed changes https://github.com/nodejs/node/pull/23717/files/d536fa5f62d7525ced6b3db01b7f5ed1c8f6c14b
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 18, 2018 https://github.com/nodejs/node/pull/23717#pullrequestreview-166162302
View reviewed changes https://github.com/nodejs/node/pull/23717/files/d536fa5f62d7525ced6b3db01b7f5ed1c8f6c14b
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 19, 2018 https://github.com/nodejs/node/pull/23717#pullrequestreview-166369047
View reviewed changes https://github.com/nodejs/node/pull/23717/files/d536fa5f62d7525ced6b3db01b7f5ed1c8f6c14b
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 19, 2018 https://github.com/nodejs/node/pull/23717#pullrequestreview-166562393
View reviewed changes https://github.com/nodejs/node/pull/23717/files/d536fa5f62d7525ced6b3db01b7f5ed1c8f6c14b
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 19, 2018https://github.com/nodejs/node/pull/23717#issuecomment-431391362
https://ci.nodejs.org/job/node-test-pull-request/17987/https://ci.nodejs.org/job/node-test-pull-request/17987/
Please reload this pagehttps://github.com/nodejs/node/pull/23717
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 19, 2018https://github.com/nodejs/node/pull/23717#event-1914983955
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 19, 2018https://github.com/nodejs/node/pull/23717#issuecomment-431519388
c0d86b9https://github.com/nodejs/node/commit/c0d86b9e6144e91fe48f29c0d7f0b61c11b49597
Please reload this pagehttps://github.com/nodejs/node/pull/23717
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 19, 2018https://github.com/nodejs/node/pull/23717#event-1915874031
tniessenhttps://github.com/tniessen
Oct 19, 2018 https://github.com/nodejs/node/pull/23717#ref-commit-c0d86b9
https://github.com/tniessen
crypto: remove DiffieHellman.initialised_https://github.com/nodejs/node/commit/c0d86b9e6144e91fe48f29c0d7f0b61c11b49597
c0d86b9https://github.com/nodejs/node/commit/c0d86b9e6144e91fe48f29c0d7f0b61c11b49597
#23717https://github.com/nodejs/node/pull/23717
#23648https://github.com/nodejs/node/pull/23648
addaleaxhttps://github.com/addaleax
Oct 20, 2018 https://github.com/nodejs/node/pull/23717#ref-commit-a37f7c2
https://github.com/tniessen
https://github.com/addaleax
crypto: remove DiffieHellman.initialised_https://github.com/nodejs/node/commit/a37f7c284cfb72fe79dac7d455b1befdb5f7b4e9
a37f7c2https://github.com/nodejs/node/commit/a37f7c284cfb72fe79dac7d455b1befdb5f7b4e9
#23717https://github.com/nodejs/node/pull/23717
#23648https://github.com/nodejs/node/pull/23648
jasnellhttps://github.com/jasnell
Oct 21, 2018 https://github.com/nodejs/node/pull/23717#ref-commit-f4d1d9c
https://github.com/tniessen
https://github.com/jasnell
crypto: remove DiffieHellman.initialised_https://github.com/nodejs/node/commit/f4d1d9cb3101a7b95ea5c465018b7fa75efab1d4
f4d1d9chttps://github.com/nodejs/node/commit/f4d1d9cb3101a7b95ea5c465018b7fa75efab1d4
#23717https://github.com/nodejs/node/pull/23717
#23648https://github.com/nodejs/node/pull/23648
MylesBorinshttps://github.com/MylesBorins
Oct 30, 2018 https://github.com/nodejs/node/pull/23717#ref-commit-f216699
https://github.com/tniessen
https://github.com/MylesBorins
crypto: remove DiffieHellman.initialised_https://github.com/nodejs/node/commit/f216699ab42c19050f3278e93b657548ffa6d05a
f216699https://github.com/nodejs/node/commit/f216699ab42c19050f3278e93b657548ffa6d05a
#23717https://github.com/nodejs/node/pull/23717
#23648https://github.com/nodejs/node/pull/23648
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23717#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23717#ref-commit-be76a82
https://github.com/tniessen
https://github.com/rvagg
crypto: remove DiffieHellman.initialised_https://github.com/nodejs/node/commit/be76a82a5eea80e66f4d88ce2e34f5b47b21ac2d
be76a82https://github.com/nodejs/node/commit/be76a82a5eea80e66f4d88ce2e34f5b47b21ac2d
#23717https://github.com/nodejs/node/pull/23717
#23648https://github.com/nodejs/node/pull/23648
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23717#ref-commit-806242b
https://github.com/tniessen
https://github.com/MylesBorins
crypto: remove DiffieHellman.initialised_https://github.com/nodejs/node/commit/806242bf403fc1fa9d026b9246ea52f33484efdc
806242bhttps://github.com/nodejs/node/commit/806242bf403fc1fa9d026b9246ea52f33484efdc
#23717https://github.com/nodejs/node/pull/23717
#23648https://github.com/nodejs/node/pull/23648
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23717#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.com/tniessen
tniessenhttps://github.com/tniessen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 14, 2021https://github.com/nodejs/node/pull/23717#event-4205713836
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23717
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/23717/files/d536fa5f62d7525ced6b3db01b7f5ed1c8f6c14b
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23717/files/d536fa5f62d7525ced6b3db01b7f5ed1c8f6c14b
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23717/files/d536fa5f62d7525ced6b3db01b7f5ed1c8f6c14b
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/23717/files/d536fa5f62d7525ced6b3db01b7f5ed1c8f6c14b
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/23717
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/BridgeAR
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.