René's URL Explorer Experiment


Title: doc: clarify fd behaviour with {read,write}File by thefourtheye · Pull Request #23706 · nodejs/node · GitHub

Open Graph Title: doc: clarify fd behaviour with {read,write}File by thefourtheye · Pull Request #23706 · nodejs/node

X Title: doc: clarify fd behaviour with {read,write}File by thefourtheye · Pull Request #23706 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist documentation is changed or added commit message follows commit guidelines Ref: #23433 (comment) cc @nodejs/fs @nodejs/documentation @Trott

X Description: Checklist documentation is changed or added commit message follows commit guidelines Ref: #23433 (comment) cc @nodejs/fs @nodejs/documentation @Trott

Opengraph URL: https://github.com/nodejs/node/pull/23706

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8603e72a-934b-70ec-e4f4-7f5d7b1cd83d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8368:272222:15FBFBD:1C658C8:6990835C
html-safe-noncecf73ecb173c5291de90d4fc351e0ba2c91fe631d404eb16cd129b1cd20748993
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzY4OjI3MjIyMjoxNUZCRkJEOjFDNjU4Qzg6Njk5MDgzNUMiLCJ2aXNpdG9yX2lkIjoiMzk3Njc5ODEwOTA1MzI1NjU0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdd8c27330b86a46c00166e05290a8d409a1fa694e5a02970605dc08d0984de84
hovercard-subject-tagpull_request:223495634
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23706/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/eab5d69f825c8f80b228801374d296553d8bf90cfd33982e8526cd6e05bb050e/nodejs/node/pull/23706
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/eab5d69f825c8f80b228801374d296553d8bf90cfd33982e8526cd6e05bb050e/nodejs/node/pull/23706
og:image:altChecklist documentation is changed or added commit message follows commit guidelines Ref: #23433 (comment) cc @nodejs/fs @nodejs/documentation @Trott
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamethefourtheye
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23706#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23706
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23706
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23706
Reloadhttps://github.com/nodejs/node/pull/23706
Reloadhttps://github.com/nodejs/node/pull/23706
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23706
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
thefourtheyehttps://github.com/thefourtheye
nodejs:masterhttps://github.com/nodejs/node/tree/master
thefourtheye:update-rw-file-docs-with-fdhttps://github.com/thefourtheye/io.js/tree/update-rw-file-docs-with-fd
Conversationhttps://github.com/nodejs/node/pull/23706
Commits7 (7)https://github.com/nodejs/node/pull/23706/commits
Checkshttps://github.com/nodejs/node/pull/23706/checks
Files changedhttps://github.com/nodejs/node/pull/23706/files
doc: clarify fd behaviour with {read,write}Filehttps://github.com/nodejs/node/pull/23706#top
thefourtheyehttps://github.com/thefourtheye
nodejs:masterhttps://github.com/nodejs/node/tree/master
thefourtheye:update-rw-file-docs-with-fdhttps://github.com/thefourtheye/io.js/tree/update-rw-file-docs-with-fd
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 17, 2018https://github.com/nodejs/node/pull/23706#issue-370934834
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
#23433 (comment)https://github.com/nodejs/node/issues/23433#issuecomment-430411926
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/thefourtheye
doc: clarify fd behaviour with {read,write}Filehttps://github.com/nodejs/node/pull/23706/commits/351d9dfae45c04fec8ae7dfeac109cb98764752c
351d9dfhttps://github.com/nodejs/node/pull/23706/commits/351d9dfae45c04fec8ae7dfeac109cb98764752c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2018https://github.com/nodejs/node/pull/23706#issuecomment-430520650
@thefourtheyehttps://github.com/thefourtheye
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1271/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1271/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Oct 17, 2018https://github.com/nodejs/node/pull/23706#event-1908734847
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 17, 2018 https://github.com/nodejs/node/pull/23706#ref-issue-369348203
fs: behaviour of readFile and writeFile with file descriptors #23433 https://github.com/nodejs/node/issues/23433
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 17, 2018 https://github.com/nodejs/node/pull/23706#pullrequestreview-165496885
View reviewed changes https://github.com/nodejs/node/pull/23706/files/351d9dfae45c04fec8ae7dfeac109cb98764752c
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 17, 2018 https://github.com/nodejs/node/pull/23706#pullrequestreview-165503377
View reviewed changes https://github.com/nodejs/node/pull/23706/files/351d9dfae45c04fec8ae7dfeac109cb98764752c
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 17, 2018 https://github.com/nodejs/node/pull/23706#pullrequestreview-165668664
View reviewed changes https://github.com/nodejs/node/pull/23706/files/351d9dfae45c04fec8ae7dfeac109cb98764752c
vsemozhetbythttps://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/23706#pullrequestreview-165668664
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23706
doc/api/fs.mdhttps://github.com/nodejs/node/pull/23706/files/351d9dfae45c04fec8ae7dfeac109cb98764752c#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 17, 2018https://github.com/nodejs/node/pull/23706#discussion_r225959533
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23706
doc/api/fs.mdhttps://github.com/nodejs/node/pull/23706/files/351d9dfae45c04fec8ae7dfeac109cb98764752c#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 17, 2018https://github.com/nodejs/node/pull/23706#discussion_r225961693
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 17, 2018https://github.com/nodejs/node/pull/23706#issuecomment-430661477
#23709https://github.com/nodejs/node/pull/23709
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 17, 2018https://github.com/nodejs/node/pull/23706#issuecomment-430671444
@vsemozhetbythttps://github.com/vsemozhetbyt
#23709https://github.com/nodejs/node/pull/23709
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/thefourtheye
addresshttps://github.com/nodejs/node/pull/23706/commits/5370c1482ad7c8a5431f3e818574d3ae74e391c7
@vsemozhetbythttps://github.com/vsemozhetbyt
's commentshttps://github.com/nodejs/node/pull/23706/commits/5370c1482ad7c8a5431f3e818574d3ae74e391c7
5370c14https://github.com/nodejs/node/pull/23706/commits/5370c1482ad7c8a5431f3e818574d3ae74e391c7
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 19, 2018https://github.com/nodejs/node/pull/23706#event-1914440878
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Oct 19, 2018 https://github.com/nodejs/node/pull/23706#pullrequestreview-166581739
View reviewed changes https://github.com/nodejs/node/pull/23706/files/5370c1482ad7c8a5431f3e818574d3ae74e391c7
thefourtheyehttps://github.com/thefourtheye
October 20, 2018 04:21https://github.com/nodejs/node/pull/23706#commits-pushed-b5a440c
https://github.com/thefourtheye
changes because ofhttps://github.com/nodejs/node/pull/23706/commits/b5a440c19119014b5f4f09ffdf702fcc739d905b
nodejs#23709https://github.com/nodejs/node/pull/23709
b5a440chttps://github.com/nodejs/node/pull/23706/commits/b5a440c19119014b5f4f09ffdf702fcc739d905b
https://github.com/thefourtheye
group the relevant partshttps://github.com/nodejs/node/pull/23706/commits/d44bf9fc8cce351afcd5edc5eca635d9d022b9c1
d44bf9fhttps://github.com/nodejs/node/pull/23706/commits/d44bf9fc8cce351afcd5edc5eca635d9d022b9c1
https://github.com/thefourtheye
update fs promisified functions' behaviourhttps://github.com/nodejs/node/pull/23706/commits/121e1dd077745278f93ec297aa9b58cf690ea57a
121e1ddhttps://github.com/nodejs/node/pull/23706/commits/121e1dd077745278f93ec297aa9b58cf690ea57a
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 19, 2018https://github.com/nodejs/node/pull/23706#issuecomment-431522693
#23709https://github.com/nodejs/node/pull/23709
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 19, 2018 https://github.com/nodejs/node/pull/23706#pullrequestreview-166725086
View reviewed changes https://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a
doc/api/fs.mdhttps://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 19, 2018https://github.com/nodejs/node/pull/23706#discussion_r226805191
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 19, 2018https://github.com/nodejs/node/pull/23706#issuecomment-431529001
Please reload this pagehttps://github.com/nodejs/node/pull/23706
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 20, 2018https://github.com/nodejs/node/pull/23706#issuecomment-431573616
@vsemozhetbythttps://github.com/vsemozhetbyt
#23709https://github.com/nodejs/node/pull/23709
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 20, 2018https://github.com/nodejs/node/pull/23706#issuecomment-431574485
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1316/https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1316/
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 22, 2018 https://github.com/nodejs/node/pull/23706#pullrequestreview-166994104
View reviewed changes https://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/23706#pullrequestreview-166994104
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Oct 24, 2018 https://github.com/nodejs/node/pull/23706#pullrequestreview-167873056
View reviewed changes https://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a
doc/api/fs.mdhttps://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
ChALkeRhttps://github.com/ChALkeR
Oct 24, 2018https://github.com/nodejs/node/pull/23706#discussion_r227760868
Please reload this pagehttps://github.com/nodejs/node/pull/23706
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23706
thefourtheyehttps://github.com/thefourtheye
Oct 24, 2018https://github.com/nodejs/node/pull/23706#discussion_r227783753
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Oct 24, 2018 https://github.com/nodejs/node/pull/23706#pullrequestreview-167873733
View reviewed changes https://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a
doc/api/fs.mdhttps://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
ChALkeRhttps://github.com/ChALkeR
Oct 24, 2018https://github.com/nodejs/node/pull/23706#discussion_r227761368
Please reload this pagehttps://github.com/nodejs/node/pull/23706
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#18592https://github.com/nodejs/node/pull/18592
Please reload this pagehttps://github.com/nodejs/node/pull/23706
Trotthttps://github.com/Trott
Oct 24, 2018https://github.com/nodejs/node/pull/23706#discussion_r227764048
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23706
thefourtheyehttps://github.com/thefourtheye
Oct 24, 2018https://github.com/nodejs/node/pull/23706#discussion_r227784096
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Oct 24, 2018 https://github.com/nodejs/node/pull/23706#pullrequestreview-167874721
View reviewed changes https://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a
doc/api/fs.mdhttps://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
ChALkeRhttps://github.com/ChALkeR
Oct 24, 2018https://github.com/nodejs/node/pull/23706#discussion_r227762164
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23706
thefourtheyehttps://github.com/thefourtheye
Oct 24, 2018https://github.com/nodejs/node/pull/23706#discussion_r227784157
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Oct 24, 2018 https://github.com/nodejs/node/pull/23706#pullrequestreview-167875104
View reviewed changes https://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a
ChALkeRhttps://github.com/ChALkeR
https://github.com/nodejs/node/pull/23706#pullrequestreview-167875104
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 24, 2018 https://github.com/nodejs/node/pull/23706#pullrequestreview-167884152
View reviewed changes https://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/23706#pullrequestreview-167884152
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23706
thefourtheyehttps://github.com/thefourtheye
October 24, 2018 18:36https://github.com/nodejs/node/pull/23706#commits-pushed-9975e9a
https://github.com/thefourtheye
Revert "changes because ofhttps://github.com/nodejs/node/pull/23706/commits/9975e9ae064a39443c8c5be9b5b6e44e22647824
nodejs#23709https://github.com/nodejs/node/pull/23709
"https://github.com/nodejs/node/pull/23706/commits/9975e9ae064a39443c8c5be9b5b6e44e22647824
9975e9ahttps://github.com/nodejs/node/pull/23706/commits/9975e9ae064a39443c8c5be9b5b6e44e22647824
b5a440chttps://github.com/thefourtheye/io.js/commit/b5a440c19119014b5f4f09ffdf702fcc739d905b
https://github.com/thefourtheye
address review commentshttps://github.com/nodejs/node/pull/23706/commits/ef290a78d8fbddf0b870c27f60235a5e88635aac
ef290a7https://github.com/nodejs/node/pull/23706/commits/ef290a78d8fbddf0b870c27f60235a5e88635aac
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 24, 2018https://github.com/nodejs/node/pull/23706#issuecomment-432653422
#23709https://github.com/nodejs/node/pull/23709
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 25, 2018https://github.com/nodejs/node/pull/23706#issuecomment-433086861
31 October 2018, 07:30:00 (UTC time)https://www.timeanddate.com/countdown/generic?p0=1440&iso=20181031T0730&msg=Landing%20https%3a//github.com/nodejs/node/pull/23706
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 25, 2018https://github.com/nodejs/node/pull/23706#issuecomment-433140622
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1368/https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1368/
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 31, 2018https://github.com/nodejs/node/pull/23706#issuecomment-434698740
8bd6df8https://github.com/nodejs/node/commit/8bd6df8927c1363789b195020397c8a672a46a0a
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 31, 2018https://github.com/nodejs/node/pull/23706#event-1937958289
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
October 31, 2018 14:03https://github.com/nodejs/node/pull/23706#event-1937959891
thefourtheyehttps://github.com/thefourtheye
Oct 31, 2018 https://github.com/nodejs/node/pull/23706#ref-commit-8bd6df8
https://github.com/thefourtheye
doc: clarify fd behaviour with {read,write}Filehttps://github.com/nodejs/node/commit/8bd6df8927c1363789b195020397c8a672a46a0a
8bd6df8https://github.com/nodejs/node/commit/8bd6df8927c1363789b195020397c8a672a46a0a
#23706https://github.com/nodejs/node/pull/23706
targoshttps://github.com/targos
Nov 1, 2018 https://github.com/nodejs/node/pull/23706#ref-commit-da494ef
https://github.com/thefourtheye
https://github.com/targos
doc: clarify fd behaviour with {read,write}Filehttps://github.com/nodejs/node/commit/da494ef8891b5c16f5f4c55f8f4f792116ab3ca7
da494efhttps://github.com/nodejs/node/commit/da494ef8891b5c16f5f4c55f8f4f792116ab3ca7
#23706https://github.com/nodejs/node/pull/23706
https://github.com/targos
targoshttps://github.com/targos
Nov 1, 2018 https://github.com/nodejs/node/pull/23706#ref-pullrequest-374624819
Release proposal: v11.1.0 #23922 https://github.com/nodejs/node/pull/23922
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#245 https://github.com/beevelop/docker-android-nodejs/issues/245
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#246 https://github.com/beevelop/docker-android-nodejs/issues/246
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#247 https://github.com/beevelop/docker-android-nodejs/issues/247
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#248 https://github.com/beevelop/docker-android-nodejs/issues/248
MylesBorinshttps://github.com/MylesBorins
Nov 27, 2018 https://github.com/nodejs/node/pull/23706#ref-commit-8180b0b
https://github.com/thefourtheye
https://github.com/MylesBorins
doc: clarify fd behaviour with {read,write}Filehttps://github.com/nodejs/node/commit/8180b0b5b36e2ec0b35128a43f03c6b04c834a13
8180b0bhttps://github.com/nodejs/node/commit/8180b0b5b36e2ec0b35128a43f03c6b04c834a13
#23706https://github.com/nodejs/node/pull/23706
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Nov 27, 2018https://github.com/nodejs/node/pull/23706#event-1988287545
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23706#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23706#ref-commit-390db42
https://github.com/thefourtheye
https://github.com/rvagg
doc: clarify fd behaviour with {read,write}Filehttps://github.com/nodejs/node/commit/390db428537a5017aae2d5bf3b821bb9e622c708
390db42https://github.com/nodejs/node/commit/390db428537a5017aae2d5bf3b821bb9e622c708
#23706https://github.com/nodejs/node/pull/23706
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23706#ref-commit-9581295
https://github.com/thefourtheye
https://github.com/MylesBorins
doc: clarify fd behaviour with {read,write}Filehttps://github.com/nodejs/node/commit/95812953bee0cdf02c82afd5e30946292b6af92b
9581295https://github.com/nodejs/node/commit/95812953bee0cdf02c82afd5e30946292b6af92b
#23706https://github.com/nodejs/node/pull/23706
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23706#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23706
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a
https://github.com/ChALkeR
ChALkeR https://github.com/ChALkeR
https://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23706/files/351d9dfae45c04fec8ae7dfeac109cb98764752c
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/23706/files/351d9dfae45c04fec8ae7dfeac109cb98764752c
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/23706/files/5370c1482ad7c8a5431f3e818574d3ae74e391c7
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/23706/files/121e1dd077745278f93ec297aa9b58cf690ea57a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/23706
https://github.com/thefourtheye
https://github.com/nodejs-github-bot
https://github.com/vsemozhetbyt
https://github.com/Trott
https://github.com/mcollina
https://github.com/ChALkeR
https://github.com/addaleax
https://github.com/lpinca
https://github.com/mhdawson
https://github.com/trivikr
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.