René's URL Explorer Experiment


Title: build: for debug mode set `v8_optimized_debug` by refack · Pull Request #23704 · nodejs/node · GitHub

Open Graph Title: build: for debug mode set `v8_optimized_debug` by refack · Pull Request #23704 · nodejs/node

X Title: build: for debug mode set `v8_optimized_debug` by refack · Pull Request #23704 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This cuts down the debug CI run from ~1:20h to 50m Second commit is a bugfix in the V8 gypfiles. Since common.gypi already defines target_defaults, the previous setup in gypfiles/toolchain.gypi (wi...

X Description: This cuts down the debug CI run from ~1:20h to 50m Second commit is a bugfix in the V8 gypfiles. Since common.gypi already defines target_defaults, the previous setup in gypfiles/toolchain.gypi (wi...

Opengraph URL: https://github.com/nodejs/node/pull/23704

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6529e418-55e4-29e6-5f34-e5cc14462e8c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC90C:12FEF5:86A36:AAD9B:69903BCA
html-safe-nonce1253374eb44463dd7086ec80e100c5e7289986e31a32ad2e3007e65438999ae1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTBDOjEyRkVGNTo4NkEzNjpBQUQ5Qjo2OTkwM0JDQSIsInZpc2l0b3JfaWQiOiI2Njc2OTgxMjc3MTAxNDA3MTc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5de820841a5addb1a60c25cfdf7598931e1bb338f473b710266d0aa137005357
hovercard-subject-tagpull_request:223416500
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23704/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/39c059541e701936cd7450e1975565dc55cba005e073f08302d32b645185994a/nodejs/node/pull/23704
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/39c059541e701936cd7450e1975565dc55cba005e073f08302d32b645185994a/nodejs/node/pull/23704
og:image:altThis cuts down the debug CI run from ~1:20h to 50m Second commit is a bugfix in the V8 gypfiles. Since common.gypi already defines target_defaults, the previous setup in gypfiles/toolchain.gypi (wi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerefack
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23704#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23704
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23704
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23704
Reloadhttps://github.com/nodejs/node/pull/23704
Reloadhttps://github.com/nodejs/node/pull/23704
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23704
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 708 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:default-v8-optimized-debughttps://github.com/refack/node/tree/default-v8-optimized-debug
Conversationhttps://github.com/nodejs/node/pull/23704
Commits2 (2)https://github.com/nodejs/node/pull/23704/commits
Checkshttps://github.com/nodejs/node/pull/23704/checks
Files changedhttps://github.com/nodejs/node/pull/23704/files
build: for debug mode set v8_optimized_debughttps://github.com/nodejs/node/pull/23704#top
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:default-v8-optimized-debughttps://github.com/refack/node/tree/default-v8-optimized-debug
https://github.com/refack
refackhttps://github.com/refack
Oct 16, 2018https://github.com/nodejs/node/pull/23704#issue-370826106
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://www.diffchecker.com/Q340bUuJhttps://www.diffchecker.com/Q340bUuJ
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
refackhttps://github.com/refack
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Oct 16, 2018https://github.com/nodejs/node/pull/23704#event-1908117334
https://github.com/refack
refackhttps://github.com/refack
Oct 16, 2018https://github.com/nodejs/node/pull/23704#event-1908117337
https://github.com/refack
refackhttps://github.com/refack
targoshttps://github.com/targos
October 16, 2018 22:32https://github.com/nodejs/node/pull/23704#event-1908117343
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 16, 2018https://github.com/nodejs/node/pull/23704#issuecomment-430424206
@refackhttps://github.com/refack
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1269/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1269/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
refackhttps://github.com/refack
addaleaxhttps://github.com/addaleax
October 16, 2018 22:32https://github.com/nodejs/node/pull/23704#event-1908117535
https://github.com/refack
refackhttps://github.com/refack
Oct 16, 2018https://github.com/nodejs/node/pull/23704#issuecomment-430424466
https://ci.nodejs.org/job/node-test-pull-request/17924/https://ci.nodejs.org/job/node-test-pull-request/17924/
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 17, 2018https://github.com/nodejs/node/pull/23704#issuecomment-430496566
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018https://github.com/nodejs/node/pull/23704#issuecomment-430521975
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018https://github.com/nodejs/node/pull/23704#issuecomment-430527193
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018https://github.com/nodejs/node/pull/23704#issuecomment-430527421
https://ci.nodejs.org/job/node-test-pull-request/17933/https://ci.nodejs.org/job/node-test-pull-request/17933/
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018https://github.com/nodejs/node/pull/23704#issuecomment-430693127
@addaleaxhttps://github.com/addaleax
https://www.diffchecker.com/Q340bUuJhttps://www.diffchecker.com/Q340bUuJ
node/deps/v8/src/elements.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/src/elements.cc#L2169
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
node/deps/v8/src/heap/heap.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/src/heap/heap.cc#L2860-L2881
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
node/deps/v8/src/heap/heap.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/src/heap/heap.cc#L2972-L2979
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
node/deps/v8/src/objects.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/src/objects.cc#L2603
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
node/deps/v8/src/objects.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/src/objects.cc#L2683
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
node/deps/v8/src/objects.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/src/objects.cc#L9327
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
node/deps/v8/src/objects.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/src/objects.cc#L11703
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
node/deps/v8/src/objects.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/src/objects.cc#L11754
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
node/deps/v8/src/objects.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/src/objects.cc#L15638
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
node/deps/v8/src/source-position-table.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/src/source-position-table.cc#L114
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
node/deps/v8/src/source-position-table.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/src/source-position-table.cc#L150
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
node/deps/v8/src/source-position-table.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/src/source-position-table.cc#L164
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
node/deps/v8/src/source-position-table.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/src/source-position-table.cc#L181
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
node/deps/v8/test/cctest/compiler/test-code-generator.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/test/cctest/compiler/test-code-generator.cc#L677
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
node/deps/v8/test/cctest/compiler/test-code-generator.cchttps://github.com/nodejs/node/blob/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09/deps/v8/test/cctest/compiler/test-code-generator.cc#L686
cf3f8ddhttps://github.com/nodejs/node/commit/cf3f8dd42ea153efce77d69f7be9ca0f99cc7b09
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
refackhttps://github.com/refack
Trotthttps://github.com/Trott
October 17, 2018 16:20https://github.com/nodejs/node/pull/23704#event-1910047782
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 17, 2018https://github.com/nodejs/node/pull/23704#issuecomment-430761871
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018https://github.com/nodejs/node/pull/23704#issuecomment-430783007
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/hashseed
hashseedhttps://github.com/hashseed
Oct 18, 2018https://github.com/nodejs/node/pull/23704#issuecomment-430881658
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
refackhttps://github.com/refack
Oct 18, 2018https://github.com/nodejs/node/pull/23704#issuecomment-431053113
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 19, 2018 https://github.com/nodejs/node/pull/23704#pullrequestreview-166428311
View reviewed changes https://github.com/nodejs/node/pull/23704/files
joyeecheunghttps://github.com/joyeecheung
https://github.com/nodejs/node/pull/23704#pullrequestreview-166428311
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://ci.nodejs.org/job/node-test-commit-custom-suites/https://ci.nodejs.org/job/node-test-commit-custom-suites/
Please reload this pagehttps://github.com/nodejs/node/pull/23704
deps/v8/gypfiles/toolchain.gypihttps://github.com/nodejs/node/pull/23704/files#diff-04b83bbb6e5854f8cc6ac96ab81fbf93c5356327bc44acb1420b279bc41ec9d8
joyeecheunghttps://github.com/joyeecheung
Oct 19, 2018https://github.com/nodejs/node/pull/23704#discussion_r226573124
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23704
refackhttps://github.com/refack
Oct 19, 2018https://github.com/nodejs/node/pull/23704#discussion_r226648106
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/deps/v8/gypfiles/toolchain.gypihttps://github.com/nodejs/node/blob/9800fd7aaa7226fff3f21edd7f77f563b9a69753/deps/v8/gypfiles/toolchain.gypi#L1315-L1325
9800fd7https://github.com/nodejs/node/commit/9800fd7aaa7226fff3f21edd7f77f563b9a69753
https://github.com/nodejs/node/blob/693c7bbe621f4ab8686397e301e1f8027e734dff/deps/v8/gypfiles/toolchain.gypi#L1136-L1137https://github.com/nodejs/node/blob/693c7bbe621f4ab8686397e301e1f8027e734dff/deps/v8/gypfiles/toolchain.gypi#L1136-L1137
https://github.com/nodejs/node/blob/693c7bbe621f4ab8686397e301e1f8027e734dff/deps/v8/gypfiles/toolchain.gypi#L1200https://github.com/nodejs/node/blob/693c7bbe621f4ab8686397e301e1f8027e734dff/deps/v8/gypfiles/toolchain.gypi#L1200
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
refackhttps://github.com/refack
Oct 19, 2018https://github.com/nodejs/node/pull/23704#issuecomment-431363448
ci.nodejs.org/job/node-test-commit-custom-suiteshttps://ci.nodejs.org/job/node-test-commit-custom-suites/
https://ci.nodejs.org/job/node-test-commit-custom-suites/727/default/https://ci.nodejs.org/job/node-test-commit-custom-suites/727/default/
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 20, 2018https://github.com/nodejs/node/pull/23704#issuecomment-431546712
@refackhttps://github.com/refack
74c4bb7https://github.com/nodejs/node/commit/74c4bb7e77d4f2f07693606c08cbe15198aa3fa3
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018https://github.com/nodejs/node/pull/23704#issuecomment-431582216
74c4bb7https://github.com/nodejs/node/commit/74c4bb7e77d4f2f07693606c08cbe15198aa3fa3
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
refackhttps://github.com/refack
Oct 21, 2018 https://github.com/nodejs/node/pull/23704#ref-pullrequest-372313048
deps: fix wrong default for v8 handle zapping #23801 https://github.com/nodejs/node/pull/23801
https://github.com/refack
refackhttps://github.com/refack
force-pushedhttps://github.com/nodejs/node/compare/693c7bbe621f4ab8686397e301e1f8027e734dff..803fce20f9896de2a00914ea03f0873bbcaf2595
693c7bbhttps://github.com/nodejs/node/commit/693c7bbe621f4ab8686397e301e1f8027e734dff
803fce2https://github.com/nodejs/node/commit/803fce20f9896de2a00914ea03f0873bbcaf2595
Compare https://github.com/nodejs/node/compare/693c7bbe621f4ab8686397e301e1f8027e734dff..803fce20f9896de2a00914ea03f0873bbcaf2595
October 31, 2018 02:10https://github.com/nodejs/node/pull/23704#event-1936740681
https://github.com/refack
refackhttps://github.com/refack
Oct 31, 2018https://github.com/nodejs/node/pull/23704#issuecomment-434536340
https://ci.nodejs.org/job/node-test-pull-request/18250/https://ci.nodejs.org/job/node-test-pull-request/18250/
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 31, 2018 https://github.com/nodejs/node/pull/23704#pullrequestreview-170095779
View reviewed changes https://github.com/nodejs/node/pull/23704/files
joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/nodejs/node/pull/23704#pullrequestreview-170095779
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Oct 31, 2018 https://github.com/nodejs/node/pull/23704#pullrequestreview-170151844
View reviewed changes https://github.com/nodejs/node/pull/23704/files
ryzokukenhttps://github.com/ryzokuken
https://github.com/nodejs/node/pull/23704#pullrequestreview-170151844
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
refackhttps://github.com/refack
force-pushedhttps://github.com/nodejs/node/compare/803fce20f9896de2a00914ea03f0873bbcaf2595..b4c6b16c895cda96b23bb97e4a8da1d2556cdc54
803fce2https://github.com/nodejs/node/commit/803fce20f9896de2a00914ea03f0873bbcaf2595
b4c6b16https://github.com/nodejs/node/commit/b4c6b16c895cda96b23bb97e4a8da1d2556cdc54
Compare https://github.com/nodejs/node/compare/803fce20f9896de2a00914ea03f0873bbcaf2595..b4c6b16c895cda96b23bb97e4a8da1d2556cdc54
October 31, 2018 14:31https://github.com/nodejs/node/pull/23704#event-1938045706
https://github.com/refack
refackhttps://github.com/refack
Oct 31, 2018https://github.com/nodejs/node/pull/23704#issuecomment-434709967
https://ci.nodejs.org/job/node-test-pull-request/18261/https://ci.nodejs.org/job/node-test-pull-request/18261/
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
refackhttps://github.com/refack
Trotthttps://github.com/Trott
addaleaxhttps://github.com/addaleax
targoshttps://github.com/targos
October 31, 2018 16:13https://github.com/nodejs/node/pull/23704#event-1938362464
https://github.com/refack
refackhttps://github.com/refack
Oct 31, 2018https://github.com/nodejs/node/pull/23704#event-1938362613
https://github.com/refack
refackhttps://github.com/refack
df7f629https://github.com/nodejs/node/commit/df7f629544bb39e9e07b1f812d1089f0579e4a1f
Oct 31, 2018https://github.com/nodejs/node/pull/23704#event-1938365886
https://github.com/refack
refackhttps://github.com/refack
November 1, 2018 02:28https://github.com/nodejs/node/pull/23704#event-1939484657
targoshttps://github.com/targos
Nov 2, 2018 https://github.com/nodejs/node/pull/23704#ref-commit-e7133f1
https://github.com/refack
https://github.com/targos
build: configure default v8_optimized_debughttps://github.com/nodejs/node/commit/e7133f1e7c2c71b2f5a180472c7d120e2b37bc74
e7133f1https://github.com/nodejs/node/commit/e7133f1e7c2c71b2f5a180472c7d120e2b37bc74
#23704https://github.com/nodejs/node/pull/23704
targoshttps://github.com/targos
Nov 2, 2018 https://github.com/nodejs/node/pull/23704#ref-commit-ef8b5b4
https://github.com/refack
https://github.com/targos
deps,v8: fix gypfile bughttps://github.com/nodejs/node/commit/ef8b5b4094bcec3f67ae49d18b048d5164fcd362
ef8b5b4https://github.com/nodejs/node/commit/ef8b5b4094bcec3f67ae49d18b048d5164fcd362
#23704https://github.com/nodejs/node/pull/23704
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/23704#ref-pullrequest-380492752
Release proposal: v11.2 #24350 https://github.com/nodejs/node/pull/24350
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232 https://github.com/beevelop/docker-nodejs/issues/232
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249 https://github.com/beevelop/docker-android-nodejs/issues/249
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#233 https://github.com/beevelop/docker-nodejs/issues/233
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#234 https://github.com/beevelop/docker-nodejs/issues/234
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#235 https://github.com/beevelop/docker-nodejs/issues/235
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#236 https://github.com/beevelop/docker-nodejs/issues/236
MylesBorinshttps://github.com/MylesBorins
Nov 27, 2018 https://github.com/nodejs/node/pull/23704#ref-commit-51947a5
https://github.com/refack
https://github.com/MylesBorins
build: configure default v8_optimized_debughttps://github.com/nodejs/node/commit/51947a515d3977dab388801888beb43591edac2c
51947a5https://github.com/nodejs/node/commit/51947a515d3977dab388801888beb43591edac2c
#23704https://github.com/nodejs/node/pull/23704
MylesBorinshttps://github.com/MylesBorins
Nov 27, 2018 https://github.com/nodejs/node/pull/23704#ref-commit-67f5d30
https://github.com/refack
https://github.com/MylesBorins
deps,v8: fix gypfile bughttps://github.com/nodejs/node/commit/67f5d3052d2d8e451bf3801cab1ab0da1ee719f6
67f5d30https://github.com/nodejs/node/commit/67f5d3052d2d8e451bf3801cab1ab0da1ee719f6
#23704https://github.com/nodejs/node/pull/23704
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Nov 27, 2018https://github.com/nodejs/node/pull/23704#event-1988726556
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 27, 2018https://github.com/nodejs/node/pull/23704#issuecomment-441950832
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23704#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23704#ref-commit-86d3a47
https://github.com/refack
https://github.com/rvagg
build: configure default v8_optimized_debughttps://github.com/nodejs/node/commit/86d3a47a9e86e41e15b059f0cc6db91ce9593c9f
86d3a47https://github.com/nodejs/node/commit/86d3a47a9e86e41e15b059f0cc6db91ce9593c9f
#23704https://github.com/nodejs/node/pull/23704
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23704#ref-commit-0c70838
https://github.com/refack
https://github.com/rvagg
deps,v8: fix gypfile bughttps://github.com/nodejs/node/commit/0c708387c23aa59192d5b0990f951adbf5ca148b
0c70838https://github.com/nodejs/node/commit/0c708387c23aa59192d5b0990f951adbf5ca148b
#23704https://github.com/nodejs/node/pull/23704
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23704#ref-commit-24dd67f
https://github.com/refack
https://github.com/MylesBorins
build: configure default v8_optimized_debughttps://github.com/nodejs/node/commit/24dd67fe8fbfbe754d8ddf652ed8790e59d1542f
24dd67fhttps://github.com/nodejs/node/commit/24dd67fe8fbfbe754d8ddf652ed8790e59d1542f
#23704https://github.com/nodejs/node/pull/23704
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23704#ref-commit-c9ecaef
https://github.com/refack
https://github.com/MylesBorins
deps,v8: fix gypfile bughttps://github.com/nodejs/node/commit/c9ecaefb88aee98cc988ea19ea298f7d4203631a
c9ecaefhttps://github.com/nodejs/node/commit/c9ecaefb88aee98cc988ea19ea298f7d4203631a
#23704https://github.com/nodejs/node/pull/23704
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23704#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
Dec 3, 2018https://github.com/nodejs/node/pull/23704#event-2002235864
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 3, 2018https://github.com/nodejs/node/pull/23704#issuecomment-443818167
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 9, 2024 https://github.com/nodejs/node/pull/23704#ref-issue-2574106241
[rfc] V8 debug build CI? #55326 https://github.com/nodejs/node/issues/55326
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23704
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/23704/files/803fce20f9896de2a00914ea03f0873bbcaf2595
https://github.com/ryzokuken
ryzokuken https://github.com/ryzokuken
https://github.com/nodejs/node/pull/23704/files/803fce20f9896de2a00914ea03f0873bbcaf2595
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Please reload this pagehttps://github.com/nodejs/node/pull/23704
https://github.com/refack
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/hashseed
https://github.com/MylesBorins
https://github.com/joyeecheung
https://github.com/ryzokuken
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.