René's URL Explorer Experiment


Title: n-api: make per-Context-ness of napi_env explicit by addaleax · Pull Request #23689 · nodejs/node · GitHub

Open Graph Title: n-api: make per-Context-ness of napi_env explicit by addaleax · Pull Request #23689 · nodejs/node

X Title: n-api: make per-Context-ness of napi_env explicit by addaleax · Pull Request #23689 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Because instances of napi_env are created on a per-global-object basis and because most N-API functions refer to builtin JS objects, napi_env is essentially in 1:1 correspondence with v8::Context. ...

X Description: Because instances of napi_env are created on a per-global-object basis and because most N-API functions refer to builtin JS objects, napi_env is essentially in 1:1 correspondence with v8::Context. ...

Opengraph URL: https://github.com/nodejs/node/pull/23689

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1669f975-54f2-2daa-a7b9-6cd6aa1ba7fe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9028:3D126:2F449A:3CA013:69909CE4
html-safe-noncea8c07ccf05c5b16a4d6e711f5c5a20ca2042571c0faf2d67fde1b5456e3ace70
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDI4OjNEMTI2OjJGNDQ5QTozQ0EwMTM6Njk5MDlDRTQiLCJ2aXNpdG9yX2lkIjoiODcyNzYxNDQzNDc3ODg0ODQ4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2f72e61f36b746f7e2d6fe73e1b9aca0edc2dfe12cd54dbfd542e84d9e23fe9a
hovercard-subject-tagpull_request:223196185
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23689/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f21ae2b225cf6201325d82567df03b29c3a1150d2f2b3fb849940c8060b59711/nodejs/node/pull/23689
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f21ae2b225cf6201325d82567df03b29c3a1150d2f2b3fb849940c8060b59711/nodejs/node/pull/23689
og:image:altBecause instances of napi_env are created on a per-global-object basis and because most N-API functions refer to builtin JS objects, napi_env is essentially in 1:1 correspondence with v8::Context. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23689#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23689
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23689
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23689
Reloadhttps://github.com/nodejs/node/pull/23689
Reloadhttps://github.com/nodejs/node/pull/23689
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23689
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:napi-contexthttps://github.com/addaleax/node/tree/napi-context
Conversationhttps://github.com/nodejs/node/pull/23689
Commits2 (2)https://github.com/nodejs/node/pull/23689/commits
Checkshttps://github.com/nodejs/node/pull/23689/checks
Files changedhttps://github.com/nodejs/node/pull/23689/files
n-api: make per-Context-ness of napi_env explicithttps://github.com/nodejs/node/pull/23689#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:napi-contexthttps://github.com/addaleax/node/tree/napi-context
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 16, 2018https://github.com/nodejs/node/pull/23689#issue-370544304
Please reload this pagehttps://github.com/nodejs/node/pull/23689
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23689
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 16, 2018https://github.com/nodejs/node/pull/23689#issuecomment-430186314
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1260/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1260/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23689
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Oct 16, 2018https://github.com/nodejs/node/pull/23689#event-1906408559
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 16, 2018https://github.com/nodejs/node/pull/23689#issuecomment-430186452
Please reload this pagehttps://github.com/nodejs/node/pull/23689
https://ci.nodejs.org/job/node-test-pull-request/17894/https://ci.nodejs.org/job/node-test-pull-request/17894/
https://ci.nodejs.org/job/node-test-pull-request/17903/https://ci.nodejs.org/job/node-test-pull-request/17903/
Please reload this pagehttps://github.com/nodejs/node/pull/23689
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 16, 2018 https://github.com/nodejs/node/pull/23689#pullrequestreview-165193808
View reviewed changes https://github.com/nodejs/node/pull/23689/files
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 16, 2018 https://github.com/nodejs/node/pull/23689#pullrequestreview-165195703
View reviewed changes https://github.com/nodejs/node/pull/23689/files
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Oct 16, 2018 https://github.com/nodejs/node/pull/23689#pullrequestreview-165259873
View reviewed changes https://github.com/nodejs/node/pull/23689/files
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 16, 2018 https://github.com/nodejs/node/pull/23689#pullrequestreview-165373497
View reviewed changes https://github.com/nodejs/node/pull/23689/files
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 16, 2018 https://github.com/nodejs/node/pull/23689#pullrequestreview-165387956
View reviewed changes https://github.com/nodejs/node/pull/23689/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/23689#pullrequestreview-165387956
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23689
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 19, 2018https://github.com/nodejs/node/pull/23689#issuecomment-431431121
Please reload this pagehttps://github.com/nodejs/node/pull/23689
https://ci.nodejs.org/job/node-test-pull-request/17991/https://ci.nodejs.org/job/node-test-pull-request/17991/
Please reload this pagehttps://github.com/nodejs/node/pull/23689
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 20, 2018https://github.com/nodejs/node/pull/23689#event-1916048323
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018https://github.com/nodejs/node/pull/23689#issuecomment-431608925
Please reload this pagehttps://github.com/nodejs/node/pull/23689
node/src/node_api.cchttps://github.com/nodejs/node/blob/b3ae9150de99a9b7b92ceddb11cd9e43ea92c7cb/src/node_api.cc#L1156
b3ae915https://github.com/nodejs/node/commit/b3ae9150de99a9b7b92ceddb11cd9e43ea92c7cb
Please reload this pagehttps://github.com/nodejs/node/pull/23689
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018 https://github.com/nodejs/node/pull/23689#pullrequestreview-166759128
View reviewed changes https://github.com/nodejs/node/pull/23689/files
src/node_api.cchttps://github.com/nodejs/node/pull/23689/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc
Please reload this pagehttps://github.com/nodejs/node/pull/23689
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018 https://github.com/nodejs/node/pull/23689#pullrequestreview-166759678
View reviewed changes https://github.com/nodejs/node/pull/23689/files
src/node_api.cchttps://github.com/nodejs/node/pull/23689/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc
refackhttps://github.com/refack
Oct 20, 2018https://github.com/nodejs/node/pull/23689#discussion_r226837165
Please reload this pagehttps://github.com/nodejs/node/pull/23689
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23689
addaleaxhttps://github.com/addaleax
Oct 21, 2018https://github.com/nodejs/node/pull/23689#discussion_r226845459
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23689
addaleaxhttps://github.com/addaleax
October 21, 2018 03:59https://github.com/nodejs/node/pull/23689#commits-pushed-3fe948d
https://github.com/addaleax
n-api: make per-Context-ness of napi_env explicithttps://github.com/nodejs/node/pull/23689/commits/3fe948d1beeffe7d9fcd5e957c2ccb4ca3db144b
3fe948dhttps://github.com/nodejs/node/pull/23689/commits/3fe948d1beeffe7d9fcd5e957c2ccb4ca3db144b
https://github.com/addaleax
fixup! n-api: make per-Context-ness of napi_env explicithttps://github.com/nodejs/node/pull/23689/commits/2f3c0780b6af09c8eccf2b6794d20e990d93438e
2f3c078https://github.com/nodejs/node/pull/23689/commits/2f3c0780b6af09c8eccf2b6794d20e990d93438e
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/9024ab2a8e1724711be1f538eea24928c2ab9ad3..2f3c0780b6af09c8eccf2b6794d20e990d93438e
9024ab2https://github.com/nodejs/node/commit/9024ab2a8e1724711be1f538eea24928c2ab9ad3
2f3c078https://github.com/nodejs/node/commit/2f3c0780b6af09c8eccf2b6794d20e990d93438e
Compare https://github.com/nodejs/node/compare/9024ab2a8e1724711be1f538eea24928c2ab9ad3..2f3c0780b6af09c8eccf2b6794d20e990d93438e
October 21, 2018 02:02https://github.com/nodejs/node/pull/23689#event-1916461527
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Oct 24, 2018https://github.com/nodejs/node/pull/23689#issuecomment-432674448
https://ci.nodejs.org/job/node-test-pull-request/18115/https://ci.nodejs.org/job/node-test-pull-request/18115/
Please reload this pagehttps://github.com/nodejs/node/pull/23689
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 24, 2018https://github.com/nodejs/node/pull/23689#issuecomment-432765367
449c0cahttps://github.com/nodejs/node/commit/449c0ca9f1bf247089781d67a109ebc7e6c1d5a5
Please reload this pagehttps://github.com/nodejs/node/pull/23689
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 24, 2018https://github.com/nodejs/node/pull/23689#event-1924168599
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
October 24, 2018 18:00https://github.com/nodejs/node/pull/23689#event-1924170018
addaleaxhttps://github.com/addaleax
Oct 24, 2018 https://github.com/nodejs/node/pull/23689#ref-commit-449c0ca
https://github.com/addaleax
n-api: make per-Context-ness of napi_env explicithttps://github.com/nodejs/node/commit/449c0ca9f1bf247089781d67a109ebc7e6c1d5a5
449c0cahttps://github.com/nodejs/node/commit/449c0ca9f1bf247089781d67a109ebc7e6c1d5a5
#23689https://github.com/nodejs/node/pull/23689
targoshttps://github.com/targos
Oct 26, 2018 https://github.com/nodejs/node/pull/23689#ref-commit-914f95b
https://github.com/addaleax
https://github.com/targos
n-api: make per-Context-ness of napi_env explicithttps://github.com/nodejs/node/commit/914f95be273adf9c2f2ff1e8addde34dad69d379
914f95bhttps://github.com/nodejs/node/commit/914f95be273adf9c2f2ff1e8addde34dad69d379
#23689https://github.com/nodejs/node/pull/23689
https://github.com/targos
targoshttps://github.com/targos
Oct 27, 2018 https://github.com/nodejs/node/pull/23689#ref-pullrequest-374624819
Release proposal: v11.1.0 #23922 https://github.com/nodejs/node/pull/23922
targoshttps://github.com/targos
Nov 1, 2018 https://github.com/nodejs/node/pull/23689#ref-commit-97496f0
https://github.com/addaleax
https://github.com/targos
n-api: make per-Context-ness of napi_env explicithttps://github.com/nodejs/node/commit/97496f0fd998a3b6aff7970691b7148cd465d437
97496f0https://github.com/nodejs/node/commit/97496f0fd998a3b6aff7970691b7148cd465d437
#23689https://github.com/nodejs/node/pull/23689
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#245 https://github.com/beevelop/docker-android-nodejs/issues/245
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#246 https://github.com/beevelop/docker-android-nodejs/issues/246
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#247 https://github.com/beevelop/docker-android-nodejs/issues/247
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#248 https://github.com/beevelop/docker-android-nodejs/issues/248
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x
Nov 26, 2018https://github.com/nodejs/node/pull/23689#event-1988050185
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
Nov 26, 2018https://github.com/nodejs/node/pull/23689#event-1988050187
MylesBorinshttps://github.com/MylesBorins
Nov 26, 2018 https://github.com/nodejs/node/pull/23689#ref-commit-9b95160
https://github.com/addaleax
https://github.com/MylesBorins
n-api: make per-Context-ness of napi_env explicithttps://github.com/nodejs/node/commit/9b951601e2b88d8926fbf22c49aad8d0e9fbbffa
9b95160https://github.com/nodejs/node/commit/9b951601e2b88d8926fbf22c49aad8d0e9fbbffa
#23689https://github.com/nodejs/node/pull/23689
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 26, 2018https://github.com/nodejs/node/pull/23689#issuecomment-441820860
Please reload this pagehttps://github.com/nodejs/node/pull/23689
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23689#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23689#ref-commit-80e8d36
https://github.com/addaleax
https://github.com/rvagg
n-api: make per-Context-ness of napi_env explicithttps://github.com/nodejs/node/commit/80e8d362fdc912850c9ed6c11b3fa84a5a4ec643
80e8d36https://github.com/nodejs/node/commit/80e8d362fdc912850c9ed6c11b3fa84a5a4ec643
#23689https://github.com/nodejs/node/pull/23689
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23689#ref-commit-02a54ed
https://github.com/addaleax
https://github.com/MylesBorins
n-api: make per-Context-ness of napi_env explicithttps://github.com/nodejs/node/commit/02a54ed1fa840a516af2fbf9efce5f34953cfb49
02a54edhttps://github.com/nodejs/node/commit/02a54ed1fa840a516af2fbf9efce5f34953cfb49
#23689https://github.com/nodejs/node/pull/23689
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23689#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23689
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/23689/files/9024ab2a8e1724711be1f538eea24928c2ab9ad3
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23689/files/9024ab2a8e1724711be1f538eea24928c2ab9ad3
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/23689/files/9024ab2a8e1724711be1f538eea24928c2ab9ad3
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/23689/files/9024ab2a8e1724711be1f538eea24928c2ab9ad3
https://github.com/mmarchini
mmarchini https://github.com/mmarchini
https://github.com/nodejs/node/pull/23689/files/9024ab2a8e1724711be1f538eea24928c2ab9ad3
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/23689/files/9024ab2a8e1724711be1f538eea24928c2ab9ad3
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/23689
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/refack
https://github.com/mmarchini
https://github.com/MylesBorins
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/devsnek
https://github.com/mhdawson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.