René's URL Explorer Experiment


Title: src: add trace events for env.cc by jasnell · Pull Request #23674 · nodejs/node · GitHub

Open Graph Title: src: add trace events for env.cc by jasnell · Pull Request #23674 · nodejs/node

X Title: src: add trace events for env.cc by jasnell · Pull Request #23674 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Adds a new node.environment trace event category that captures simple lifecycle events for an Environment: This will be most useful for our own diagnostics around timers and such but it captures us...

X Description: Adds a new node.environment trace event category that captures simple lifecycle events for an Environment: This will be most useful for our own diagnostics around timers and such but it captures us...

Opengraph URL: https://github.com/nodejs/node/pull/23674

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8ca35c41-36c3-6e1a-8d37-f9ca92fe7c39
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id800E:3B5BF:F59691:13A8A1D:69906E4D
html-safe-noncec218c56e2901976430929169b65751dbb6dacfdb1468dcfb531b5ca5a63e2b1f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDBFOjNCNUJGOkY1OTY5MToxM0E4QTFEOjY5OTA2RTREIiwidmlzaXRvcl9pZCI6IjI4NDI5MTMxMzIxNTc4OTAxMjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc153ec6b8fadbae3340136407efa20e0181642d3c51b0f894b8f9567e46ccfa4
hovercard-subject-tagpull_request:222986713
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23674/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/189d3677b7080b89228288ee2392e27fab3a025b9430e8e36336ab773905baa3/nodejs/node/pull/23674
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/189d3677b7080b89228288ee2392e27fab3a025b9430e8e36336ab773905baa3/nodejs/node/pull/23674
og:image:altAdds a new node.environment trace event category that captures simple lifecycle events for an Environment: This will be most useful for our own diagnostics around timers and such but it captures us...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23674#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23674
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23674
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23674
Reloadhttps://github.com/nodejs/node/pull/23674
Reloadhttps://github.com/nodejs/node/pull/23674
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23674
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:trace-events-envhttps://github.com/jasnell/node/tree/trace-events-env
Conversationhttps://github.com/nodejs/node/pull/23674
Commits5 (5)https://github.com/nodejs/node/pull/23674/commits
Checkshttps://github.com/nodejs/node/pull/23674/checks
Files changedhttps://github.com/nodejs/node/pull/23674/files
src: add trace events for env.cchttps://github.com/nodejs/node/pull/23674#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:trace-events-envhttps://github.com/jasnell/node/tree/trace-events-env
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 15, 2018https://github.com/nodejs/node/pull/23674#issue-370269183
https://user-images.githubusercontent.com/439929/46967639-01308a00-d066-11e8-9ecc-2b401671153d.png
https://user-images.githubusercontent.com/439929/46967682-1f968580-d066-11e8-9cd9-4cb53bb19af4.png
https://user-images.githubusercontent.com/439929/46967718-3046fb80-d066-11e8-8a65-65be70e461e2.png
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23674
https://github.com/jasnell
src: add trace events for env.cchttps://github.com/nodejs/node/pull/23674/commits/cf1f5f0e141640ac5085accfad987413eb7b9b40
cf1f5f0https://github.com/nodejs/node/pull/23674/commits/cf1f5f0e141640ac5085accfad987413eb7b9b40
https://github.com/jasnell
jasnellhttps://github.com/jasnell
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
trace_events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atrace_events
Oct 15, 2018https://github.com/nodejs/node/pull/23674#event-1904760867
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 15, 2018https://github.com/nodejs/node/pull/23674#issuecomment-429945780
@jasnellhttps://github.com/jasnell
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1252/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1252/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23674
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Oct 15, 2018https://github.com/nodejs/node/pull/23674#event-1904761123
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 15, 2018 https://github.com/nodejs/node/pull/23674#pullrequestreview-164819760
View reviewed changes https://github.com/nodejs/node/pull/23674/files/cf1f5f0e141640ac5085accfad987413eb7b9b40
src/env.cchttps://github.com/nodejs/node/pull/23674/files/cf1f5f0e141640ac5085accfad987413eb7b9b40#diff-c546570c652a65d182b5c452e071328cdc3599e39b4bc390879b5c15dd545d58
Please reload this pagehttps://github.com/nodejs/node/pull/23674
src/env.cchttps://github.com/nodejs/node/pull/23674/files/cf1f5f0e141640ac5085accfad987413eb7b9b40#diff-c546570c652a65d182b5c452e071328cdc3599e39b4bc390879b5c15dd545d58
Please reload this pagehttps://github.com/nodejs/node/pull/23674
src/env.cchttps://github.com/nodejs/node/pull/23674/files/cf1f5f0e141640ac5085accfad987413eb7b9b40#diff-c546570c652a65d182b5c452e071328cdc3599e39b4bc390879b5c15dd545d58
addaleaxhttps://github.com/addaleax
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225257308
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
jasnellhttps://github.com/jasnell
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225258680
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
addaleaxhttps://github.com/addaleax
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225259671
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jasnellhttps://github.com/jasnell
#22712https://github.com/nodejs/node/pull/22712
Please reload this pagehttps://github.com/nodejs/node/pull/23674
jasnellhttps://github.com/jasnell
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225261234
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
https://github.com/jasnell
[Squash] nits, docs, and a test (oh my)https://github.com/nodejs/node/pull/23674/commits/b32b136171f85f6f155abe5b823c7bb8c2295bdf
b32b136https://github.com/nodejs/node/pull/23674/commits/b32b136171f85f6f155abe5b823c7bb8c2295bdf
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 15, 2018 https://github.com/nodejs/node/pull/23674#pullrequestreview-164824224
View reviewed changes https://github.com/nodejs/node/pull/23674/files/b32b136171f85f6f155abe5b823c7bb8c2295bdf
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/23674#pullrequestreview-164824224
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
src/env.cchttps://github.com/nodejs/node/pull/23674/files/cf1f5f0e141640ac5085accfad987413eb7b9b40#diff-c546570c652a65d182b5c452e071328cdc3599e39b4bc390879b5c15dd545d58
Please reload this pagehttps://github.com/nodejs/node/pull/23674
https://github.com/jasnell
[Squash] nithttps://github.com/nodejs/node/pull/23674/commits/065495fb3958219744eea5470b9565345833e05e
065495fhttps://github.com/nodejs/node/pull/23674/commits/065495fb3958219744eea5470b9565345833e05e
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Oct 15, 2018 https://github.com/nodejs/node/pull/23674#pullrequestreview-164825827
View reviewed changes https://github.com/nodejs/node/pull/23674/files/065495fb3958219744eea5470b9565345833e05e
src/env.cchttps://github.com/nodejs/node/pull/23674/files/065495fb3958219744eea5470b9565345833e05e#diff-c546570c652a65d182b5c452e071328cdc3599e39b4bc390879b5c15dd545d58
lundibundihttps://github.com/lundibundi
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225261200
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
test/parallel/test-trace-events-environment.jshttps://github.com/nodejs/node/pull/23674/files/065495fb3958219744eea5470b9565345833e05e#diff-5427b34b10c0cd4883f8c34907c00a59062bc5be85f657d13988d2960a0eacb0
lundibundihttps://github.com/lundibundi
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225262348
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
jasnellhttps://github.com/jasnell
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225331989
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
jasnellhttps://github.com/jasnell
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225335106
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
test/parallel/test-trace-events-environment.jshttps://github.com/nodejs/node/pull/23674/files/065495fb3958219744eea5470b9565345833e05e#diff-5427b34b10c0cd4883f8c34907c00a59062bc5be85f657d13988d2960a0eacb0
Please reload this pagehttps://github.com/nodejs/node/pull/23674
src/env.cchttps://github.com/nodejs/node/pull/23674/files/065495fb3958219744eea5470b9565345833e05e#diff-c546570c652a65d182b5c452e071328cdc3599e39b4bc390879b5c15dd545d58
lundibundihttps://github.com/lundibundi
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225263626
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
addaleaxhttps://github.com/addaleax
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225269028
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@lundibundihttps://github.com/lundibundi
node/deps/v8/include/libplatform/v8-tracing.hhttps://github.com/nodejs/node/blob/561e30d9ef581e86b36318fe22ebd1e82ab88754/deps/v8/include/libplatform/v8-tracing.h#L228
561e30dhttps://github.com/nodejs/node/commit/561e30d9ef581e86b36318fe22ebd1e82ab88754
Please reload this pagehttps://github.com/nodejs/node/pull/23674
lundibundihttps://github.com/lundibundi
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225273016
Please reload this pagehttps://github.com/nodejs/node/pull/23674
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/src/node_contextify.cchttps://github.com/nodejs/node/blob/561e30d9ef581e86b36318fe22ebd1e82ab88754/src/node_contextify.cc#L661-L662
561e30dhttps://github.com/nodejs/node/commit/561e30d9ef581e86b36318fe22ebd1e82ab88754
node/src/node_file.cchttps://github.com/nodejs/node/blob/561e30d9ef581e86b36318fe22ebd1e82ab88754/src/node_file.cc#L92-L93
561e30dhttps://github.com/nodejs/node/commit/561e30d9ef581e86b36318fe22ebd1e82ab88754
Please reload this pagehttps://github.com/nodejs/node/pull/23674
jasnellhttps://github.com/jasnell
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225332154
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
https://github.com/refack
refackhttps://github.com/refack
Oct 15, 2018 https://github.com/nodejs/node/pull/23674#pullrequestreview-164829836
View reviewed changes https://github.com/nodejs/node/pull/23674/files/065495fb3958219744eea5470b9565345833e05e
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/23674#pullrequestreview-164829836
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
test/parallel/test-trace-events-environment.jshttps://github.com/nodejs/node/pull/23674/files/065495fb3958219744eea5470b9565345833e05e#diff-5427b34b10c0cd4883f8c34907c00a59062bc5be85f657d13988d2960a0eacb0
Please reload this pagehttps://github.com/nodejs/node/pull/23674
test/parallel/test-trace-events-environment.jshttps://github.com/nodejs/node/pull/23674/files/065495fb3958219744eea5470b9565345833e05e#diff-5427b34b10c0cd4883f8c34907c00a59062bc5be85f657d13988d2960a0eacb0
Please reload this pagehttps://github.com/nodejs/node/pull/23674
test/parallel/test-trace-events-environment.jshttps://github.com/nodejs/node/pull/23674/files/065495fb3958219744eea5470b9565345833e05e#diff-5427b34b10c0cd4883f8c34907c00a59062bc5be85f657d13988d2960a0eacb0
refackhttps://github.com/refack
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225265101
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 15, 2018 https://github.com/nodejs/node/pull/23674#pullrequestreview-164833111
View reviewed changes https://github.com/nodejs/node/pull/23674/files/065495fb3958219744eea5470b9565345833e05e
test/parallel/test-trace-events-environment.jshttps://github.com/nodejs/node/pull/23674/files/065495fb3958219744eea5470b9565345833e05e#diff-5427b34b10c0cd4883f8c34907c00a59062bc5be85f657d13988d2960a0eacb0
richardlauhttps://github.com/richardlau
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225267005
Please reload this pagehttps://github.com/nodejs/node/pull/23674
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
jasnellhttps://github.com/jasnell
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225334883
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/23674
addaleaxhttps://github.com/addaleax
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225335819
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
jasnellhttps://github.com/jasnell
Oct 15, 2018https://github.com/nodejs/node/pull/23674#discussion_r225336788
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
https://github.com/jasnell
[Squash] nits and updateshttps://github.com/nodejs/node/pull/23674/commits/c2df5c892a535f4da800302089d3391fa63fe99e
c2df5c8https://github.com/nodejs/node/pull/23674/commits/c2df5c892a535f4da800302089d3391fa63fe99e
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 15, 2018https://github.com/nodejs/node/pull/23674#issuecomment-430040176
https://ci.nodejs.org/job/node-test-pull-request/17878/https://ci.nodejs.org/job/node-test-pull-request/17878/
Please reload this pagehttps://github.com/nodejs/node/pull/23674
https://github.com/refack
refackhttps://github.com/refack
Oct 15, 2018 https://github.com/nodejs/node/pull/23674#pullrequestreview-164927074
View reviewed changes https://github.com/nodejs/node/pull/23674/files/c2df5c892a535f4da800302089d3391fa63fe99e
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/23674#pullrequestreview-164927074
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
https://github.com/jasnell
jasnellhttps://github.com/jasnell
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 15, 2018https://github.com/nodejs/node/pull/23674#event-1905401602
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 16, 2018 https://github.com/nodejs/node/pull/23674#pullrequestreview-164945484
View reviewed changes https://github.com/nodejs/node/pull/23674/files/c2df5c892a535f4da800302089d3391fa63fe99e
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 16, 2018https://github.com/nodejs/node/pull/23674#issuecomment-430059682
https://ci.nodejs.org/job/node-test-pull-request/17882/https://ci.nodejs.org/job/node-test-pull-request/17882/
Please reload this pagehttps://github.com/nodejs/node/pull/23674
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Oct 16, 2018 https://github.com/nodejs/node/pull/23674#pullrequestreview-165004342
View reviewed changes https://github.com/nodejs/node/pull/23674/files/c2df5c892a535f4da800302089d3391fa63fe99e
test/parallel/test-trace-events-environment.jshttps://github.com/nodejs/node/pull/23674/files/c2df5c892a535f4da800302089d3391fa63fe99e#diff-5427b34b10c0cd4883f8c34907c00a59062bc5be85f657d13988d2960a0eacb0
lundibundihttps://github.com/lundibundi
Oct 16, 2018https://github.com/nodejs/node/pull/23674#discussion_r225413883
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23674
https://github.com/jasnell
[Squash] nithttps://github.com/nodejs/node/pull/23674/commits/472f9473d951497943bb5a7dde4122969df98a22
472f947https://github.com/nodejs/node/pull/23674/commits/472f9473d951497943bb5a7dde4122969df98a22
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 16, 2018https://github.com/nodejs/node/pull/23674#issuecomment-430265998
https://ci.nodejs.org/job/node-test-pull-request/17908/https://ci.nodejs.org/job/node-test-pull-request/17908/
Please reload this pagehttps://github.com/nodejs/node/pull/23674
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Oct 16, 2018 https://github.com/nodejs/node/pull/23674#pullrequestreview-165256600
View reviewed changes https://github.com/nodejs/node/pull/23674/files/472f9473d951497943bb5a7dde4122969df98a22
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 16, 2018 https://github.com/nodejs/node/pull/23674#ref-pullrequest-370724193
test: enable trace-events tests for workers #23698 https://github.com/nodejs/node/pull/23698
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 17, 2018https://github.com/nodejs/node/pull/23674#issuecomment-430655778
https://ci.nodejs.org/job/node-test-pull-request/17941/https://ci.nodejs.org/job/node-test-pull-request/17941/
Please reload this pagehttps://github.com/nodejs/node/pull/23674
Trotthttps://github.com/Trott
Oct 18, 2018 https://github.com/nodejs/node/pull/23674#ref-commit-72a48a2
https://github.com/jasnell
https://github.com/Trott
src: add trace events for env.cchttps://github.com/Trott/io.js/commit/72a48a2a0abb655e7387d09c3dc7550793ce4a6a
72a48a2https://github.com/Trott/io.js/commit/72a48a2a0abb655e7387d09c3dc7550793ce4a6a
nodejs#23674https://github.com/nodejs/node/pull/23674
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 18, 2018https://github.com/nodejs/node/pull/23674#issuecomment-430875473
72a48a2https://github.com/nodejs/node/commit/72a48a2a0abb655e7387d09c3dc7550793ce4a6a
Please reload this pagehttps://github.com/nodejs/node/pull/23674
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 18, 2018https://github.com/nodejs/node/pull/23674#event-1911251303
danbevhttps://github.com/danbev
Oct 19, 2018 https://github.com/nodejs/node/pull/23674#ref-commit-23f8b7d
https://github.com/richardlau
https://github.com/danbev
test: enable trace-events tests for workershttps://github.com/nodejs/node/commit/23f8b7d334db86a78464f8694c015afab6dedfc3
23f8b7dhttps://github.com/nodejs/node/commit/23f8b7d334db86a78464f8694c015afab6dedfc3
#23698https://github.com/nodejs/node/pull/23698
#23674 (comment)https://github.com/nodejs/node/pull/23674#discussion_r225335819
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Oct 20, 2018https://github.com/nodejs/node/pull/23674#event-1916075689
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 20, 2018https://github.com/nodejs/node/pull/23674#issuecomment-431553189
the guidehttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/23674
jasnellhttps://github.com/jasnell
Oct 21, 2018 https://github.com/nodejs/node/pull/23674#ref-commit-74ddae7
https://github.com/jasnell
src: add trace events for env.cchttps://github.com/nodejs/node/commit/74ddae783d91acc35528cd431eb3cf3f58deff95
74ddae7https://github.com/nodejs/node/commit/74ddae783d91acc35528cd431eb3cf3f58deff95
#23674https://github.com/nodejs/node/pull/23674
jasnellhttps://github.com/jasnell
Oct 21, 2018 https://github.com/nodejs/node/pull/23674#ref-commit-a3c6a8d
https://github.com/richardlau
https://github.com/jasnell
test: enable trace-events tests for workershttps://github.com/nodejs/node/commit/a3c6a8d1a8cda6e64ec03d1db05761ea0378c81b
a3c6a8dhttps://github.com/nodejs/node/commit/a3c6a8d1a8cda6e64ec03d1db05761ea0378c81b
#23698https://github.com/nodejs/node/pull/23698
#23674 (comment)https://github.com/nodejs/node/pull/23674#discussion_r225335819
richardlauhttps://github.com/richardlau
Nov 2, 2018 https://github.com/nodejs/node/pull/23674#ref-commit-9e39441
https://github.com/richardlau
test: enable trace-events tests for workershttps://github.com/richardlau/node-1/commit/9e39441acdc3a9b99af74057649f45e1275a4b6a
9e39441https://github.com/richardlau/node-1/commit/9e39441acdc3a9b99af74057649f45e1275a4b6a
nodejs#23882https://github.com/nodejs/node/pull/23882
nodejs#23698https://github.com/nodejs/node/pull/23698
nodejs#23674 (comment)https://github.com/nodejs/node/pull/23674#discussion_r225335819
MylesBorinshttps://github.com/MylesBorins
Nov 4, 2018 https://github.com/nodejs/node/pull/23674#ref-commit-8552bb4
https://github.com/richardlau
https://github.com/MylesBorins
test: enable trace-events tests for workershttps://github.com/nodejs/node/commit/8552bb406544baaed74203d0b9baf04e09466803
8552bb4https://github.com/nodejs/node/commit/8552bb406544baaed74203d0b9baf04e09466803
#23882https://github.com/nodejs/node/pull/23882
#23698https://github.com/nodejs/node/pull/23698
#23674 (comment)https://github.com/nodejs/node/pull/23674#discussion_r225335819
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23674#ref-commit-7c3848c
https://github.com/richardlau
https://github.com/rvagg
test: enable trace-events tests for workershttps://github.com/nodejs/node/commit/7c3848c032ca9d8a452948c2fd705ff4d17e4e5d
7c3848chttps://github.com/nodejs/node/commit/7c3848c032ca9d8a452948c2fd705ff4d17e4e5d
#23882https://github.com/nodejs/node/pull/23882
#23698https://github.com/nodejs/node/pull/23698
#23674 (comment)https://github.com/nodejs/node/pull/23674#discussion_r225335819
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23674#ref-commit-51ceaf5
https://github.com/richardlau
https://github.com/MylesBorins
test: enable trace-events tests for workershttps://github.com/nodejs/node/commit/51ceaf5bc1ca539d9c5e7be75ce456379cb97264
51ceaf5https://github.com/nodejs/node/commit/51ceaf5bc1ca539d9c5e7be75ce456379cb97264
#23882https://github.com/nodejs/node/pull/23882
#23698https://github.com/nodejs/node/pull/23698
#23674 (comment)https://github.com/nodejs/node/pull/23674#discussion_r225335819
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23674
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23674/files/065495fb3958219744eea5470b9565345833e05e
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/23674/files/065495fb3958219744eea5470b9565345833e05e
https://github.com/lundibundi
lundibundi https://github.com/lundibundi
https://github.com/nodejs/node/pull/23674/files/c2df5c892a535f4da800302089d3391fa63fe99e
https://github.com/ofrobots
ofrobots https://github.com/ofrobots
https://github.com/nodejs/node/pull/23674/files/c2df5c892a535f4da800302089d3391fa63fe99e
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/23674/files/c2df5c892a535f4da800302089d3391fa63fe99e
https://github.com/mmarchini
mmarchini https://github.com/mmarchini
https://github.com/nodejs/node/pull/23674/files/472f9473d951497943bb5a7dde4122969df98a22
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
trace_events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atrace_events
Please reload this pagehttps://github.com/nodejs/node/pull/23674
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/addaleax
https://github.com/ofrobots
https://github.com/refack
https://github.com/mmarchini
https://github.com/richardlau
https://github.com/lundibundi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.