René's URL Explorer Experiment


Title: Some fixes for Python 3 by cclauss · Pull Request #23669 · nodejs/node · GitHub

Open Graph Title: Some fixes for Python 3 by cclauss · Pull Request #23669 · nodejs/node

X Title: Some fixes for Python 3 by cclauss · Pull Request #23669 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Python 3 compatibility fixes as discussed in #23659 (comment) These changes get the test scores equivalent on the following two tests. python2 -m flake8 . --exclude=./deps/v8,./deps/npm/node_modul...

X Description: Python 3 compatibility fixes as discussed in #23659 (comment) These changes get the test scores equivalent on the following two tests. python2 -m flake8 . --exclude=./deps/v8,./deps/npm/node_modul...

Opengraph URL: https://github.com/nodejs/node/pull/23669

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cc3408b2-6b60-f6dd-100a-620de34022a2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9506:1D624E:5EA245:83AEBF:6A510465
html-safe-nonce0264067465f21ff3949c2c6bdb29d1e09faa97dd5cdb6cdd9aec80b94d3fae42
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTA2OjFENjI0RTo1RUEyNDU6ODNBRUJGOjZBNTEwNDY1IiwidmlzaXRvcl9pZCI6IjE0Nzg4NDc1MDA1MzQyMTk4NzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac787adf41986f3b2d4ac2fade9583ffa3c52a107ee80d829e043169c07a85b3bc
hovercard-subject-tagpull_request:222884469
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23669/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ca475133a43687db60c536bf8b7f53d22ae542bf87da6af38f8cd75758f9255d/nodejs/node/pull/23669
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ca475133a43687db60c536bf8b7f53d22ae542bf87da6af38f8cd75758f9255d/nodejs/node/pull/23669
og:image:altPython 3 compatibility fixes as discussed in #23659 (comment) These changes get the test scores equivalent on the following two tests. python2 -m flake8 . --exclude=./deps/v8,./deps/npm/node_modul...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecclauss
hostnamegithub.com
expected-hostnamegithub.com
None38906a4da4e3e9fd88dfeacee232f5932c0c5f7495de3b4efc53ddfac7173d12
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release90441ea9b98e7491aa6ebcd135fccce4e2396f48
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23669#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23669
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23669
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23669
Reloadhttps://github.com/nodejs/node/pull/23669
Reloadhttps://github.com/nodejs/node/pull/23669
Please reload this pagehttps://github.com/nodejs/node/pull/23669
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23669
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 980 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cclausshttps://github.com/cclauss
nodejs:masterhttps://github.com/nodejs/node/tree/master
cclauss:some-Python3-fixeshttps://github.com/cclauss/node/tree/some-Python3-fixes
Conversationhttps://github.com/nodejs/node/pull/23669
Commits5 (5)https://github.com/nodejs/node/pull/23669/commits
Checkshttps://github.com/nodejs/node/pull/23669/checks
Files changedhttps://github.com/nodejs/node/pull/23669/files
Some fixes for Python 3https://github.com/nodejs/node/pull/23669#top
cclausshttps://github.com/cclauss
nodejs:masterhttps://github.com/nodejs/node/tree/master
cclauss:some-Python3-fixeshttps://github.com/cclauss/node/tree/some-Python3-fixes
https://github.com/cclauss
cclausshttps://github.com/cclauss
Oct 15, 2018https://github.com/nodejs/node/pull/23669#issue-370135094
Please reload this pagehttps://github.com/nodejs/node/pull/23669
#23659 (comment)https://github.com/nodejs/node/issues/23659#issuecomment-429669030
flake8http://flake8.pycqa.org
@refackhttps://github.com/refack
@eirnymhttps://github.com/eirnym
Please reload this pagehttps://github.com/nodejs/node/pull/23669
Some fixes for Python 3https://github.com/nodejs/node/pull/23669/commits/897025c9c68798712f9f80c03b9f3e99a82ef087
897025chttps://github.com/nodejs/node/pull/23669/commits/897025c9c68798712f9f80c03b9f3e99a82ef087
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
openssl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Oct 15, 2018https://github.com/nodejs/node/pull/23669#event-1903915131
https://github.com/refack
refackhttps://github.com/refack
Oct 15, 2018https://github.com/nodejs/node/pull/23669#event-1905477822
https://github.com/Trott
Trotthttps://github.com/Trott
python https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython
Oct 16, 2018https://github.com/nodejs/node/pull/23669#event-1905762296
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 16, 2018https://github.com/nodejs/node/pull/23669#issuecomment-430098679
Please reload this pagehttps://github.com/nodejs/node/pull/23669
https://github.com/cclauss
cclausshttps://github.com/cclauss
Oct 16, 2018https://github.com/nodejs/node/pull/23669#issuecomment-430101932
openssl/openssl#7409https://github.com/openssl/openssl/pull/7409
Please reload this pagehttps://github.com/nodejs/node/pull/23669
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Oct 16, 2018 https://github.com/nodejs/node/pull/23669#pullrequestreview-165240723
View reviewed changes https://github.com/nodejs/node/pull/23669/files/897025c9c68798712f9f80c03b9f3e99a82ef087
configure.pyhttps://github.com/nodejs/node/pull/23669/files/897025c9c68798712f9f80c03b9f3e99a82ef087#diff-4d5f3192809ec1b9add6b33007e0c50031ad9a0a2f3f55a481b506468824db2c
Please reload this pagehttps://github.com/nodejs/node/pull/23669
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Oct 16, 2018https://github.com/nodejs/node/pull/23669#issuecomment-430296360
Please reload this pagehttps://github.com/nodejs/node/pull/23669
https://github.com/refack
refackhttps://github.com/refack
Oct 16, 2018https://github.com/nodejs/node/pull/23669#issuecomment-430434397
Please reload this pagehttps://github.com/nodejs/node/pull/23669
https://github.com/refack
refackhttps://github.com/refack
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Oct 16, 2018https://github.com/nodejs/node/pull/23669#event-1908181724
https://github.com/cclauss
cclausshttps://github.com/cclauss
Oct 17, 2018https://github.com/nodejs/node/pull/23669#issuecomment-430450592
@silverwindhttps://github.com/silverwind
Please reload this pagehttps://github.com/nodejs/node/pull/23669
https://github.com/cclauss
cclausshttps://github.com/cclauss
Oct 17, 2018 https://github.com/nodejs/node/pull/23669#pullrequestreview-165585468
View reviewed changes https://github.com/nodejs/node/pull/23669/files/897025c9c68798712f9f80c03b9f3e99a82ef087
deps/openssl/openssl/fuzz/helper.pyhttps://github.com/nodejs/node/pull/23669/files/897025c9c68798712f9f80c03b9f3e99a82ef087#diff-8dc5e8e580e953fe3991ed08ed939902cfa5f9a4cda3a37cdbb72f5e8bdb43f1
cclausshttps://github.com/cclauss
Oct 17, 2018https://github.com/nodejs/node/pull/23669#discussion_r225889632
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
openssl/openssl#7409https://github.com/openssl/openssl/pull/7409
Please reload this pagehttps://github.com/nodejs/node/pull/23669
https://github.com/srl295
srl295https://github.com/srl295
Oct 17, 2018 https://github.com/nodejs/node/pull/23669#pullrequestreview-165743271
View reviewed changes https://github.com/nodejs/node/pull/23669/files/897025c9c68798712f9f80c03b9f3e99a82ef087
tools/configure.d/nodedownload.pyhttps://github.com/nodejs/node/pull/23669/files/897025c9c68798712f9f80c03b9f3e99a82ef087#diff-9ffeba21b7c99470f8590c0c0a407126eb46d681ca21e2adc93c2d6348b31c44
Please reload this pagehttps://github.com/nodejs/node/pull/23669
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Oct 17, 2018https://github.com/nodejs/node/pull/23669#issuecomment-430714815
Please reload this pagehttps://github.com/nodejs/node/pull/23669
Please reload this pagehttps://github.com/nodejs/node/pull/23669
https://github.com/refack
refackhttps://github.com/refack
Oct 18, 2018 https://github.com/nodejs/node/pull/23669#ref-issue-371560890
request to move the refack/GYP repo to the org nodejs/admin#247 https://github.com/nodejs/admin/issues/247
Merge branch 'master' into some-Python3-fixeshttps://github.com/nodejs/node/pull/23669/commits/ee94a08e8e380759f713879d361338bacfa199f1
ee94a08https://github.com/nodejs/node/pull/23669/commits/ee94a08e8e380759f713879d361338bacfa199f1
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Oct 22, 2018 https://github.com/nodejs/node/pull/23669#pullrequestreview-167118228
View reviewed changes https://github.com/nodejs/node/pull/23669/files/ee94a08e8e380759f713879d361338bacfa199f1
tools/jinja2/_compat.pyhttps://github.com/nodejs/node/pull/23669/files/ee94a08e8e380759f713879d361338bacfa199f1#diff-4dd5ed5b7b9a9e98d936bb380d84b2519721acba159a9c9fe5ccb43f04b2cb7c
silverwindhttps://github.com/silverwind
Oct 22, 2018https://github.com/nodejs/node/pull/23669#discussion_r227145296
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23669
refackhttps://github.com/refack
Oct 23, 2018https://github.com/nodejs/node/pull/23669#discussion_r227467977
Please reload this pagehttps://github.com/nodejs/node/pull/23669
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node/blob/4458162cfaf8c1eed987323fbb21c86783a8e914/Makefile#L1221-L1223https://github.com/nodejs/node/blob/4458162cfaf8c1eed987323fbb21c86783a8e914/Makefile#L1221-L1223
Please reload this pagehttps://github.com/nodejs/node/pull/23669
October 23, 2018 18:54https://github.com/nodejs/node/pull/23669#commits-pushed-c26261d
No noqahttps://github.com/nodejs/node/pull/23669/commits/c26261d9b072dc176c8de8cb1ac2154221d8f238
c26261dhttps://github.com/nodejs/node/pull/23669/commits/c26261d9b072dc176c8de8cb1ac2154221d8f238
No noqahttps://github.com/nodejs/node/pull/23669/commits/78c664d183c1f7adc86a111107ad5a4755aebbe3
78c664dhttps://github.com/nodejs/node/pull/23669/commits/78c664d183c1f7adc86a111107ad5a4755aebbe3
No noqahttps://github.com/nodejs/node/pull/23669/commits/63273036450d7025b39a6fa0de134ec282db41d7
6327303https://github.com/nodejs/node/pull/23669/commits/63273036450d7025b39a6fa0de134ec282db41d7
test: Use print() function in both Python 2 and 3 #24485 https://github.com/nodejs/node/pull/24485
configure.py: Use print() function in both Python 2 and 3 #24484 https://github.com/nodejs/node/pull/24484
tools: Use print() function on both Python 2 and 3 #24486 https://github.com/nodejs/node/pull/24486
deps/npm: Use print() function on both Python 2 and 3 #24487 https://github.com/nodejs/node/pull/24487
https://github.com/refack
refackhttps://github.com/refack
Nov 19, 2018https://github.com/nodejs/node/pull/23669#issuecomment-440023451
@cclausshttps://github.com/cclauss
Please reload this pagehttps://github.com/nodejs/node/pull/23669
https://github.com/refack
refackhttps://github.com/refack
superseded https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asuperseded
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
openssl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl
Nov 19, 2018https://github.com/nodejs/node/pull/23669#event-1975621881
https://github.com/refack
refackhttps://github.com/refack
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Nov 19, 2018https://github.com/nodejs/node/pull/23669#event-1975622186
https://github.com/cclauss
cclausshttps://github.com/cclauss
Nov 19, 2018https://github.com/nodejs/node/pull/23669#event-1975793452
https://github.com/cclauss
cclausshttps://github.com/cclauss
November 19, 2018 21:27https://github.com/nodejs/node/pull/23669#event-1975793594
https://github.com/refack
refackhttps://github.com/refack
Mar 11, 2019https://github.com/nodejs/node/pull/23669#event-2192646804
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23669
https://github.com/srl295
srl295 https://github.com/srl295
https://github.com/nodejs/node/pull/23669/files/897025c9c68798712f9f80c03b9f3e99a82ef087
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/23669/files/ee94a08e8e380759f713879d361338bacfa199f1
https://github.com/silverwind
silverwind https://github.com/silverwind
https://github.com/nodejs/node/pull/23669/files/ee94a08e8e380759f713879d361338bacfa199f1
python https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython
Please reload this pagehttps://github.com/nodejs/node/pull/23669
https://github.com/cclauss
https://github.com/Trott
https://github.com/silverwind
https://github.com/refack
https://github.com/srl295
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.