René's URL Explorer Experiment


Title: [v10.x] bootstrapper: move internalBinding to NativeModule by addaleax · Pull Request #23661 · nodejs/node · GitHub

Open Graph Title: [v10.x] bootstrapper: move internalBinding to NativeModule by addaleax · Pull Request #23661 · nodejs/node

X Title: [v10.x] bootstrapper: move internalBinding to NativeModule by addaleax · Pull Request #23661 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Backport of #23025 One thing worth noting is that there were a large number of merge conflicts where v10.x used process.binding() and master used internalBinding(). I’ve decided to patch internalBi...

X Description: Backport of #23025 One thing worth noting is that there were a large number of merge conflicts where v10.x used process.binding() and master used internalBinding(). I’ve decided to patch internalBi...

Opengraph URL: https://github.com/nodejs/node/pull/23661

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8cee222b-b349-700e-0b10-f460a3cb0a44
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id95F8:226778:5DAA82:796F95:69904A8B
html-safe-nonce548e27149da96a900414854fb78d7c29e6b6b5c2ccbbf4afc493bdb6e8ab2d78
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUY4OjIyNjc3ODo1REFBODI6Nzk2Rjk1OjY5OTA0QThCIiwidmlzaXRvcl9pZCI6IjYzMzk3MDQ1NTE5Nzc3OTgyODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8198661f143a738fd8902824c203af9781ba186f33e6dfc47e9c01cc719cac2f
hovercard-subject-tagpull_request:222751512
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23661/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f7f2e26262373b26b9003cb6bafe845ce964cc412fd0a469cc85b3abb96719e2/nodejs/node/pull/23661
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f7f2e26262373b26b9003cb6bafe845ce964cc412fd0a469cc85b3abb96719e2/nodejs/node/pull/23661
og:image:altBackport of #23025 One thing worth noting is that there were a large number of merge conflicts where v10.x used process.binding() and master used internalBinding(). I’ve decided to patch internalBi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23661#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23661
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23661
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23661
Reloadhttps://github.com/nodejs/node/pull/23661
Reloadhttps://github.com/nodejs/node/pull/23661
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23661
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 707 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
addaleax:backport-23025https://github.com/addaleax/node/tree/backport-23025
Conversationhttps://github.com/nodejs/node/pull/23661
Commits2 (2)https://github.com/nodejs/node/pull/23661/commits
Checkshttps://github.com/nodejs/node/pull/23661/checks
Files changedhttps://github.com/nodejs/node/pull/23661/files
[v10.x] bootstrapper: move internalBinding to NativeModulehttps://github.com/nodejs/node/pull/23661#top
addaleaxhttps://github.com/addaleax
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
addaleax:backport-23025https://github.com/addaleax/node/tree/backport-23025
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 14, 2018https://github.com/nodejs/node/pull/23661#issue-369956335
#23025https://github.com/nodejs/node/pull/23025
Please reload this pagehttps://github.com/nodejs/node/pull/23661
https://github.com/devsnek
https://github.com/addaleax
bootstrapper: move internalBinding to NativeModulehttps://github.com/nodejs/node/pull/23661/commits/45ca385e2d40317a4e859c94ad153cfd29511a9e
45ca385https://github.com/nodejs/node/pull/23661/commits/45ca385e2d40317a4e859c94ad153cfd29511a9e
nodejs#23025https://github.com/nodejs/node/pull/23025
nodejs@2a9eb31https://github.com/nodejs/node/commit/2a9eb31
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 14, 2018https://github.com/nodejs/node/pull/23661#issuecomment-429673027
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1246/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1246/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23661
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
devsnekhttps://github.com/devsnek
joyeecheunghttps://github.com/joyeecheung
targoshttps://github.com/targos
October 14, 2018 23:36https://github.com/nodejs/node/pull/23661#event-1902842604
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x
Oct 14, 2018https://github.com/nodejs/node/pull/23661#event-1902842648
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 14, 2018https://github.com/nodejs/node/pull/23661#issuecomment-429673062
https://ci.nodejs.org/job/node-test-pull-request/17858/https://ci.nodejs.org/job/node-test-pull-request/17858/
Please reload this pagehttps://github.com/nodejs/node/pull/23661
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 14, 2018 https://github.com/nodejs/node/pull/23661#pullrequestreview-164520815
View reviewed changes https://github.com/nodejs/node/pull/23661/files/45ca385e2d40317a4e859c94ad153cfd29511a9e
https://github.com/targos
targoshttps://github.com/targos
Oct 15, 2018 https://github.com/nodejs/node/pull/23661#pullrequestreview-164627647
View reviewed changes https://github.com/nodejs/node/pull/23661/files/45ca385e2d40317a4e859c94ad153cfd29511a9e
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018 https://github.com/nodejs/node/pull/23661#pullrequestreview-164677131
View reviewed changes https://github.com/nodejs/node/pull/23661/files/45ca385e2d40317a4e859c94ad153cfd29511a9e
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 15, 2018 https://github.com/nodejs/node/pull/23661#pullrequestreview-164870437
View reviewed changes https://github.com/nodejs/node/pull/23661/files/45ca385e2d40317a4e859c94ad153cfd29511a9e
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 15, 2018 https://github.com/nodejs/node/pull/23661#pullrequestreview-164871456
View reviewed changes https://github.com/nodejs/node/pull/23661/files/45ca385e2d40317a4e859c94ad153cfd29511a9e
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 15, 2018https://github.com/nodejs/node/pull/23661#issuecomment-429992944
#23633https://github.com/nodejs/node/issues/23633
Please reload this pagehttps://github.com/nodejs/node/pull/23661
https://github.com/targos
targoshttps://github.com/targos
Oct 17, 2018https://github.com/nodejs/node/pull/23661#issuecomment-430738530
https://ci.nodejs.org/job/node-test-pull-request/17948/https://ci.nodejs.org/job/node-test-pull-request/17948/
Please reload this pagehttps://github.com/nodejs/node/pull/23661
https://github.com/addaleax
fixup! bootstrapper: move internalBinding to NativeModulehttps://github.com/nodejs/node/pull/23661/commits/0010eb9ffa534bfea2e541895708712dd469e9e8
0010eb9https://github.com/nodejs/node/pull/23661/commits/0010eb9ffa534bfea2e541895708712dd469e9e8
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 20, 2018https://github.com/nodejs/node/pull/23661#issuecomment-431547809
https://ci.nodejs.org/job/node-test-pull-request/18004/https://ci.nodejs.org/job/node-test-pull-request/18004/
Please reload this pagehttps://github.com/nodejs/node/pull/23661
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 20, 2018https://github.com/nodejs/node/pull/23661#issuecomment-431551681
5468509https://github.com/nodejs/node/commit/546850953294b9d2459f7700934444e5ac4b8e97
Please reload this pagehttps://github.com/nodejs/node/pull/23661
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 20, 2018https://github.com/nodejs/node/pull/23661#event-1916067477
addaleaxhttps://github.com/addaleax
Oct 20, 2018 https://github.com/nodejs/node/pull/23661#ref-commit-5468509
https://github.com/devsnek
https://github.com/addaleax
bootstrapper: move internalBinding to NativeModulehttps://github.com/nodejs/node/commit/546850953294b9d2459f7700934444e5ac4b8e97
5468509https://github.com/nodejs/node/commit/546850953294b9d2459f7700934444e5ac4b8e97
#23025https://github.com/nodejs/node/pull/23025
2a9eb31https://github.com/nodejs/node/commit/2a9eb31
#23661https://github.com/nodejs/node/pull/23661
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
October 20, 2018 05:45https://github.com/nodejs/node/pull/23661#event-1916067662
MylesBorinshttps://github.com/MylesBorins
Oct 30, 2018 https://github.com/nodejs/node/pull/23661#ref-commit-c39b910
https://github.com/devsnek
https://github.com/MylesBorins
bootstrapper: move internalBinding to NativeModulehttps://github.com/nodejs/node/commit/c39b910f6e750cacb69c3dc3e2609eaa43ed9f49
c39b910https://github.com/nodejs/node/commit/c39b910f6e750cacb69c3dc3e2609eaa43ed9f49
#23025https://github.com/nodejs/node/pull/23025
2a9eb31https://github.com/nodejs/node/commit/2a9eb31
#23661https://github.com/nodejs/node/pull/23661
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23661#ref-commit-4a0f2f8
https://github.com/devsnek
https://github.com/rvagg
bootstrapper: move internalBinding to NativeModulehttps://github.com/nodejs/node/commit/4a0f2f84e8819139bab14331d34f1cd6d19b5065
4a0f2f8https://github.com/nodejs/node/commit/4a0f2f84e8819139bab14331d34f1cd6d19b5065
#23025https://github.com/nodejs/node/pull/23025
2a9eb31https://github.com/nodejs/node/commit/2a9eb31
#23661https://github.com/nodejs/node/pull/23661
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23661#ref-commit-e872089
https://github.com/devsnek
https://github.com/MylesBorins
bootstrapper: move internalBinding to NativeModulehttps://github.com/nodejs/node/commit/e872089158e159a0a1e74b0e156fbc6f77b644b9
e872089https://github.com/nodejs/node/commit/e872089158e159a0a1e74b0e156fbc6f77b644b9
#23025https://github.com/nodejs/node/pull/23025
2a9eb31https://github.com/nodejs/node/commit/2a9eb31
#23661https://github.com/nodejs/node/pull/23661
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23661
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/23661/files/45ca385e2d40317a4e859c94ad153cfd29511a9e
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/23661/files/45ca385e2d40317a4e859c94ad153cfd29511a9e
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/23661/files/45ca385e2d40317a4e859c94ad153cfd29511a9e
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/23661/files/45ca385e2d40317a4e859c94ad153cfd29511a9e
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/23661/files/45ca385e2d40317a4e859c94ad153cfd29511a9e
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/23661
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/targos
https://github.com/joyeecheung
https://github.com/devsnek
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.