René's URL Explorer Experiment


Title: Code and learn rollup 2 by Trott · Pull Request #23651 · nodejs/node · GitHub

Open Graph Title: Code and learn rollup 2 by Trott · Pull Request #23651 · nodejs/node

X Title: Code and learn rollup 2 by Trott · Pull Request #23651 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Do not land. Rolling up 5 Code & Learn commits so I can run CI on them once rather than needing to run CI 5 times... #23470 #23471 #23472 #23473 #23474

X Description: Do not land. Rolling up 5 Code & Learn commits so I can run CI on them once rather than needing to run CI 5 times... #23470 #23471 #23472 #23473 #23474

Opengraph URL: https://github.com/nodejs/node/pull/23651

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9c6638ad-b14c-629e-928b-eb3884e32656
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADC6:BE627:9943F7:C48BF4:6990C8E1
html-safe-nonce427b70d60875a1d2c783139f7ab5610501dd47888186d0f18fdd8d778daf870b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREM2OkJFNjI3Ojk5NDNGNzpDNDhCRjQ6Njk5MEM4RTEiLCJ2aXNpdG9yX2lkIjoiMzM5MDM4MjQ5MDE0MTExNjY0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8d55793a7e2d2926d82ddca76c5843d8db662790d2cb34ef2c707b57e7e9ad4f
hovercard-subject-tagpull_request:222686156
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23651/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b1013c957ae85669fd4b727bc533ed868e62f81f42977ac3d21147439319927b/nodejs/node/pull/23651
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b1013c957ae85669fd4b727bc533ed868e62f81f42977ac3d21147439319927b/nodejs/node/pull/23651
og:image:altDo not land. Rolling up 5 Code & Learn commits so I can run CI on them once rather than needing to run CI 5 times... #23470 #23471 #23472 #23473 #23474
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23651#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23651
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23651
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23651
Reloadhttps://github.com/nodejs/node/pull/23651
Reloadhttps://github.com/nodejs/node/pull/23651
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23651
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:code-and-learn-rollup-2https://github.com/Trott/io.js/tree/code-and-learn-rollup-2
Conversationhttps://github.com/nodejs/node/pull/23651
Commits6 (6)https://github.com/nodejs/node/pull/23651/commits
Checkshttps://github.com/nodejs/node/pull/23651/checks
Files changedhttps://github.com/nodejs/node/pull/23651/files
Code and learn rollup 2https://github.com/nodejs/node/pull/23651#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:code-and-learn-rollup-2https://github.com/Trott/io.js/tree/code-and-learn-rollup-2
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 14, 2018https://github.com/nodejs/node/pull/23651#issue-369856748
#23470https://github.com/nodejs/node/pull/23470
#23471https://github.com/nodejs/node/pull/23471
#23472https://github.com/nodejs/node/pull/23472
#23473https://github.com/nodejs/node/pull/23473
#23474https://github.com/nodejs/node/pull/23474
Please reload this pagehttps://github.com/nodejs/node/pull/23651
October 13, 2018 17:55https://github.com/nodejs/node/pull/23651#commits-pushed-dcd9729
https://github.com/Trott
Flip Assertion Arguments for make-callback/test.jshttps://github.com/nodejs/node/pull/23651/commits/dcd97293d4030f1344a1e5e762caba159d423eda
dcd9729https://github.com/nodejs/node/pull/23651/commits/dcd97293d4030f1344a1e5e762caba159d423eda
https://github.com/Trott
src: remove delete MessagePort.prototype.hasRef;https://github.com/nodejs/node/pull/23651/commits/b5e8a725ae00d99e7d2ec777a32db512adc22c9e
b5e8a72https://github.com/nodejs/node/pull/23651/commits/b5e8a725ae00d99e7d2ec777a32db512adc22c9e
https://github.com/Trott
readline: assert without the use of event listenerhttps://github.com/nodejs/node/pull/23651/commits/ee9704dd82b08df78c0974863b43562103c8068e
ee9704dhttps://github.com/nodejs/node/pull/23651/commits/ee9704dd82b08df78c0974863b43562103c8068e
https://github.com/sheminusminus
https://github.com/Trott
test: correctly order assertion argumentshttps://github.com/nodejs/node/pull/23651/commits/f8ca6d63179e6acbc94f51fff19208807c19fcd1
f8ca6d6https://github.com/nodejs/node/pull/23651/commits/f8ca6d63179e6acbc94f51fff19208807c19fcd1
https://github.com/yitongding
https://github.com/Trott
test: swap actual and expected in assertionshttps://github.com/nodejs/node/pull/23651/commits/724843a7fce6479a927b86d25db678d49d9d9d04
724843ahttps://github.com/nodejs/node/pull/23651/commits/724843a7fce6479a927b86d25db678d49d9d9d04
https://github.com/yitongding
https://github.com/Trott
test: replace function with arrow functionhttps://github.com/nodejs/node/pull/23651/commits/99cdfb702c6a4308279f91ead818cf7c63a44401
99cdfb7https://github.com/nodejs/node/pull/23651/commits/99cdfb702c6a4308279f91ead818cf7c63a44401
https://github.com/Trott
Trotthttps://github.com/Trott
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Oct 14, 2018https://github.com/nodejs/node/pull/23651#event-1902399823
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 14, 2018https://github.com/nodejs/node/pull/23651#issuecomment-429588010
@Trotthttps://github.com/Trott
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1240/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1240/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23651
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Oct 14, 2018https://github.com/nodejs/node/pull/23651#event-1902399840
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 14, 2018https://github.com/nodejs/node/pull/23651#issuecomment-429588024
https://ci.nodejs.org/job/node-test-pull-request/17843/https://ci.nodejs.org/job/node-test-pull-request/17843/
Please reload this pagehttps://github.com/nodejs/node/pull/23651
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 14, 2018https://github.com/nodejs/node/pull/23651#issuecomment-429590899
Please reload this pagehttps://github.com/nodejs/node/pull/23651
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 14, 2018https://github.com/nodejs/node/pull/23651#event-1902415417
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:50https://github.com/nodejs/node/pull/23651#event-5890969192
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23651
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Please reload this pagehttps://github.com/nodejs/node/pull/23651
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/sheminusminus
https://github.com/yitongding
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.