René's URL Explorer Experiment


Title: crypto: simplify internal state handling by tniessen · Pull Request #23648 · nodejs/node · GitHub

Open Graph Title: crypto: simplify internal state handling by tniessen · Pull Request #23648 · nodejs/node

X Title: crypto: simplify internal state handling by tniessen · Pull Request #23648 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Uninitialized DH instances are never exposed to users, so this condition should always be true. (This also increases coverage 🎉) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes...

X Description: Uninitialized DH instances are never exposed to users, so this condition should always be true. (This also increases coverage 🎉) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes...

Opengraph URL: https://github.com/nodejs/node/pull/23648

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fa4961ac-0a4c-504d-8d8c-0565cec6a7d9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2F4:104452:807C92:A7E31F:6990AB65
html-safe-noncef3d9976965574804d1bb4eb1f5b7b329a5d0ba4e2e366bba385eea9d6052468a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkY0OjEwNDQ1Mjo4MDdDOTI6QTdFMzFGOjY5OTBBQjY1IiwidmlzaXRvcl9pZCI6IjI1MDkzMzc3MDI0NzU4MDM0OTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac468b6237eb89aa965e8aa7704964e3ab3d7c330ce3f21b4861ad1eb4a9f84606
hovercard-subject-tagpull_request:222676649
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23648/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4daa9a8dafbc5e0e3807f83b3227777a2f41b800f56772a18b8bfd28f41721d3/nodejs/node/pull/23648
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4daa9a8dafbc5e0e3807f83b3227777a2f41b800f56772a18b8bfd28f41721d3/nodejs/node/pull/23648
og:image:altUninitialized DH instances are never exposed to users, so this condition should always be true. (This also increases coverage 🎉) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23648#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23648
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23648
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23648
Reloadhttps://github.com/nodejs/node/pull/23648
Reloadhttps://github.com/nodejs/node/pull/23648
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23648
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-simplify-diffiehellman-internal-statehttps://github.com/tniessen/node/tree/crypto-simplify-diffiehellman-internal-state
Conversationhttps://github.com/nodejs/node/pull/23648
Commits2 (2)https://github.com/nodejs/node/pull/23648/commits
Checkshttps://github.com/nodejs/node/pull/23648/checks
Files changedhttps://github.com/nodejs/node/pull/23648/files
crypto: simplify internal state handlinghttps://github.com/nodejs/node/pull/23648#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-simplify-diffiehellman-internal-statehttps://github.com/tniessen/node/tree/crypto-simplify-diffiehellman-internal-state
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 13, 2018https://github.com/nodejs/node/pull/23648#issue-369842344
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23648
https://github.com/tniessen
crypto: simplify internal state handlinghttps://github.com/nodejs/node/pull/23648/commits/9cb55b7eefdeaf5e2819a8281393d50b14240cdc
9cb55b7https://github.com/nodejs/node/pull/23648/commits/9cb55b7eefdeaf5e2819a8281393d50b14240cdc
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 13, 2018https://github.com/nodejs/node/pull/23648#issuecomment-429576087
@tniessenhttps://github.com/tniessen
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1235/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1235/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23648
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Oct 13, 2018https://github.com/nodejs/node/pull/23648#event-1902338504
https://github.com/tniessen
fixup! crypto: simplify internal state handlinghttps://github.com/nodejs/node/pull/23648/commits/72d65f74e943840f342483a87da5228cb47fe942
72d65f7https://github.com/nodejs/node/pull/23648/commits/72d65f74e943840f342483a87da5228cb47fe942
https://github.com/refack
refackhttps://github.com/refack
Oct 13, 2018 https://github.com/nodejs/node/pull/23648#pullrequestreview-164478230
View reviewed changes https://github.com/nodejs/node/pull/23648/files/72d65f74e943840f342483a87da5228cb47fe942
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 13, 2018 https://github.com/nodejs/node/pull/23648#pullrequestreview-164479801
View reviewed changes https://github.com/nodejs/node/pull/23648/files/72d65f74e943840f342483a87da5228cb47fe942
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 14, 2018 https://github.com/nodejs/node/pull/23648#pullrequestreview-164507498
View reviewed changes https://github.com/nodejs/node/pull/23648/files/72d65f74e943840f342483a87da5228cb47fe942
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/23648#pullrequestreview-164507498
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23648
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 14, 2018https://github.com/nodejs/node/pull/23648#issuecomment-429665838
https://ci.nodejs.org/job/node-test-pull-request/17857/https://ci.nodejs.org/job/node-test-pull-request/17857/
Please reload this pagehttps://github.com/nodejs/node/pull/23648
tniessenhttps://github.com/tniessen
Oct 17, 2018 https://github.com/nodejs/node/pull/23648#ref-commit-e2f58c7
https://github.com/tniessen
crypto: simplify internal state handlinghttps://github.com/nodejs/node/commit/e2f58c71ddf0f91256cc85e6bb226a068256c5eb
e2f58c7https://github.com/nodejs/node/commit/e2f58c71ddf0f91256cc85e6bb226a068256c5eb
#23648https://github.com/nodejs/node/pull/23648
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 17, 2018https://github.com/nodejs/node/pull/23648#issuecomment-430704601
e2f58c7https://github.com/nodejs/node/commit/e2f58c71ddf0f91256cc85e6bb226a068256c5eb
Please reload this pagehttps://github.com/nodejs/node/pull/23648
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 17, 2018https://github.com/nodejs/node/pull/23648#event-1910118716
tniessenhttps://github.com/tniessen
Oct 17, 2018 https://github.com/nodejs/node/pull/23648#ref-commit-d536fa5
https://github.com/tniessen
crypto: remove DiffieHellman.initialised_https://github.com/tniessen/node/commit/d536fa5f62d7525ced6b3db01b7f5ed1c8f6c14b
d536fa5https://github.com/tniessen/node/commit/d536fa5f62d7525ced6b3db01b7f5ed1c8f6c14b
nodejs#23648https://github.com/nodejs/node/pull/23648
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 17, 2018 https://github.com/nodejs/node/pull/23648#ref-pullrequest-371183233
crypto: remove DiffieHellman.initialised_ #23717 https://github.com/nodejs/node/pull/23717
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23648#ref-commit-6975639
https://github.com/tniessen
https://github.com/jasnell
crypto: simplify internal state handlinghttps://github.com/nodejs/node/commit/697563965182c9559d813b414899677fe6c57d39
6975639https://github.com/nodejs/node/commit/697563965182c9559d813b414899677fe6c57d39
#23648https://github.com/nodejs/node/pull/23648
tniessenhttps://github.com/tniessen
Oct 19, 2018 https://github.com/nodejs/node/pull/23648#ref-commit-c0d86b9
https://github.com/tniessen
crypto: remove DiffieHellman.initialised_https://github.com/nodejs/node/commit/c0d86b9e6144e91fe48f29c0d7f0b61c11b49597
c0d86b9https://github.com/nodejs/node/commit/c0d86b9e6144e91fe48f29c0d7f0b61c11b49597
#23717https://github.com/nodejs/node/pull/23717
#23648https://github.com/nodejs/node/pull/23648
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018https://github.com/nodejs/node/pull/23648#issuecomment-431540222
Please reload this pagehttps://github.com/nodejs/node/pull/23648
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018https://github.com/nodejs/node/pull/23648#issuecomment-431541825
#23778https://github.com/nodejs/node/pull/23778
Please reload this pagehttps://github.com/nodejs/node/pull/23648
addaleaxhttps://github.com/addaleax
Oct 20, 2018 https://github.com/nodejs/node/pull/23648#ref-commit-7744e84
https://github.com/tniessen
https://github.com/addaleax
crypto: simplify internal state handlinghttps://github.com/nodejs/node/commit/7744e84057db3cd5b3e24b15ff92d8f0ac68a09b
7744e84https://github.com/nodejs/node/commit/7744e84057db3cd5b3e24b15ff92d8f0ac68a09b
#23648https://github.com/nodejs/node/pull/23648
addaleaxhttps://github.com/addaleax
Oct 20, 2018 https://github.com/nodejs/node/pull/23648#ref-commit-a37f7c2
https://github.com/tniessen
https://github.com/addaleax
crypto: remove DiffieHellman.initialised_https://github.com/nodejs/node/commit/a37f7c284cfb72fe79dac7d455b1befdb5f7b4e9
a37f7c2https://github.com/nodejs/node/commit/a37f7c284cfb72fe79dac7d455b1befdb5f7b4e9
#23717https://github.com/nodejs/node/pull/23717
#23648https://github.com/nodejs/node/pull/23648
jasnellhttps://github.com/jasnell
Oct 21, 2018 https://github.com/nodejs/node/pull/23648#ref-commit-f4d1d9c
https://github.com/tniessen
https://github.com/jasnell
crypto: remove DiffieHellman.initialised_https://github.com/nodejs/node/commit/f4d1d9cb3101a7b95ea5c465018b7fa75efab1d4
f4d1d9chttps://github.com/nodejs/node/commit/f4d1d9cb3101a7b95ea5c465018b7fa75efab1d4
#23717https://github.com/nodejs/node/pull/23717
#23648https://github.com/nodejs/node/pull/23648
MylesBorinshttps://github.com/MylesBorins
Oct 30, 2018 https://github.com/nodejs/node/pull/23648#ref-commit-3ca41dc
https://github.com/tniessen
https://github.com/MylesBorins
crypto: simplify internal state handlinghttps://github.com/nodejs/node/commit/3ca41dce5cdbaacb679ef86f2bd69688aad5bbc5
3ca41dchttps://github.com/nodejs/node/commit/3ca41dce5cdbaacb679ef86f2bd69688aad5bbc5
#23648https://github.com/nodejs/node/pull/23648
MylesBorinshttps://github.com/MylesBorins
Oct 30, 2018 https://github.com/nodejs/node/pull/23648#ref-commit-f216699
https://github.com/tniessen
https://github.com/MylesBorins
crypto: remove DiffieHellman.initialised_https://github.com/nodejs/node/commit/f216699ab42c19050f3278e93b657548ffa6d05a
f216699https://github.com/nodejs/node/commit/f216699ab42c19050f3278e93b657548ffa6d05a
#23717https://github.com/nodejs/node/pull/23717
#23648https://github.com/nodejs/node/pull/23648
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23648#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23648#ref-commit-ce0c125
https://github.com/tniessen
https://github.com/rvagg
crypto: simplify internal state handlinghttps://github.com/nodejs/node/commit/ce0c12537f4efbe67ba0b535f5e9e1b3002264e3
ce0c125https://github.com/nodejs/node/commit/ce0c12537f4efbe67ba0b535f5e9e1b3002264e3
#23648https://github.com/nodejs/node/pull/23648
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23648#ref-commit-be76a82
https://github.com/tniessen
https://github.com/rvagg
crypto: remove DiffieHellman.initialised_https://github.com/nodejs/node/commit/be76a82a5eea80e66f4d88ce2e34f5b47b21ac2d
be76a82https://github.com/nodejs/node/commit/be76a82a5eea80e66f4d88ce2e34f5b47b21ac2d
#23717https://github.com/nodejs/node/pull/23717
#23648https://github.com/nodejs/node/pull/23648
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23648#ref-commit-4b98ff2
https://github.com/tniessen
https://github.com/MylesBorins
crypto: simplify internal state handlinghttps://github.com/nodejs/node/commit/4b98ff299d3ff29c02cf68eecae38973efcc894b
4b98ff2https://github.com/nodejs/node/commit/4b98ff299d3ff29c02cf68eecae38973efcc894b
#23648https://github.com/nodejs/node/pull/23648
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23648#ref-commit-806242b
https://github.com/tniessen
https://github.com/MylesBorins
crypto: remove DiffieHellman.initialised_https://github.com/nodejs/node/commit/806242bf403fc1fa9d026b9246ea52f33484efdc
806242bhttps://github.com/nodejs/node/commit/806242bf403fc1fa9d026b9246ea52f33484efdc
#23717https://github.com/nodejs/node/pull/23717
#23648https://github.com/nodejs/node/pull/23648
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23648#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23648
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/23648/files/72d65f74e943840f342483a87da5228cb47fe942
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23648/files/72d65f74e943840f342483a87da5228cb47fe942
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/23648/files/72d65f74e943840f342483a87da5228cb47fe942
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/23648
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/refack
https://github.com/bnoordhuis
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.