René's URL Explorer Experiment


Title: src: refacor `MallocedBuffer` to it's usage scope by refack · Pull Request #23641 · nodejs/node · GitHub

Open Graph Title: src: refacor `MallocedBuffer` to it's usage scope by refack · Pull Request #23641 · nodejs/node

X Title: src: refacor `MallocedBuffer` to it's usage scope by refack · Pull Request #23641 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: As discussed in #23543 (review). MallocedBuffer is an unknown quantity as compared to std::unique_ptr. MallocedBuffer is a new utility and is node specific, so it's semantics are not clear to ...

X Description: As discussed in #23543 (review). MallocedBuffer is an unknown quantity as compared to std::unique_ptr. MallocedBuffer is a new utility and is node specific, so it's semantics are not clear...

Opengraph URL: https://github.com/nodejs/node/pull/23641

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2761d8cb-ed91-cd68-650e-932b86de0cbd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8886:242264:3B69D8:4A7465:69911B67
html-safe-noncea25c3f4eacab3c0179ffc5aad09ce9d91c792c7f769a678c02696f3184bbf3da
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODg2OjI0MjI2NDozQjY5RDg6NEE3NDY1OjY5OTExQjY3IiwidmlzaXRvcl9pZCI6IjU0NDcyNjIxNzk1MzQzNzk4NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1a49f73e00015071518ff317573dbcf0daed4802641ac6ae99ef668155ce3b03
hovercard-subject-tagpull_request:222662313
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23641/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0c06c998d59b42e3776df5d6411387d8368936d1b5dd0d8cff6c1f034212eb9c/nodejs/node/pull/23641
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0c06c998d59b42e3776df5d6411387d8368936d1b5dd0d8cff6c1f034212eb9c/nodejs/node/pull/23641
og:image:altAs discussed in #23543 (review). MallocedBuffer is an unknown quantity as compared to std::unique_ptr. MallocedBuffer is a new utility and is node specific, so it's semantics are not clear to ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerefack
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23641#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23641
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23641
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23641
Reloadhttps://github.com/nodejs/node/pull/23641
Reloadhttps://github.com/nodejs/node/pull/23641
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23641
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:refactor-MallocedBufferhttps://github.com/refack/node/tree/refactor-MallocedBuffer
Conversationhttps://github.com/nodejs/node/pull/23641
Commits19 (19)https://github.com/nodejs/node/pull/23641/commits
Checkshttps://github.com/nodejs/node/pull/23641/checks
Files changedhttps://github.com/nodejs/node/pull/23641/files
src: refacor MallocedBuffer to it's usage scopehttps://github.com/nodejs/node/pull/23641#top
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:refactor-MallocedBufferhttps://github.com/refack/node/tree/refactor-MallocedBuffer
https://github.com/refack
refackhttps://github.com/refack
Oct 13, 2018https://github.com/nodejs/node/pull/23641#issue-369820810
Please reload this pagehttps://github.com/nodejs/node/pull/23641
#23543 (review)https://github.com/nodejs/node/pull/23543#pullrequestreview-164467022
src: fix bug in MallocedBuffer #23434https://github.com/nodejs/node/pull/23434
MallocedBufferhttps://github.com/nodejs/node/blob/657ee7b0251234c11ddeb629936612f70bfbdb02/src/util.h#L430
#23543 (review)https://github.com/nodejs/node/pull/23543#pullrequestreview-164467022
#23434https://github.com/nodejs/node/pull/23434
https://ci.nodejs.org/job/node-test-pull-request/1​78​21https://ci.nodejs.org/job/node-test-pull-request/1%E2%80%8B78%E2%80%8B21
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23641
addaleaxhttps://github.com/addaleax
October 12, 2018 21:07https://github.com/nodejs/node/pull/23641#commits-pushed-3ab4146
deps: cherry-pick b0af309 from upstream V8https://github.com/nodejs/node/pull/23641/commits/3ab4146008bcee397bc76dbdf00e43647260218d
3ab4146https://github.com/nodejs/node/pull/23641/commits/3ab4146008bcee397bc76dbdf00e43647260218d
https://chromium-review.googlesource.com/1209283https://chromium-review.googlesource.com/1209283
nodejs#55695https://github.com/nodejs/node/pull/55695
v8/v8@b0af309https://github.com/v8/v8/commit/b0af30948505b68c843b538e109ab378d3750e37
nodejs#23415https://github.com/nodejs/node/pull/23415
https://github.com/rxiayth
https://github.com/addaleax
lib: migrate to getOptions in loaders.jshttps://github.com/nodejs/node/pull/23641/commits/849aa1e504330eead82e43fa26b731f2fe8c64f9
849aa1ehttps://github.com/nodejs/node/pull/23641/commits/849aa1e504330eead82e43fa26b731f2fe8c64f9
nodejs#23455https://github.com/nodejs/node/pull/23455
https://github.com/leomoreno
https://github.com/Trott
test: improve test coverage for fs modulehttps://github.com/nodejs/node/pull/23641/commits/c24e9633fbc72fc8e0f8b6d1e93a2f30b884791c
c24e963https://github.com/nodejs/node/pull/23641/commits/c24e9633fbc72fc8e0f8b6d1e93a2f30b884791c
nodejs#23601https://github.com/nodejs/node/pull/23601
https://github.com/ofrobots
src: reduce platform worker barrier lifetimehttps://github.com/nodejs/node/pull/23641/commits/9f7e3a404096db60438f6dc305b0a5fa4ecddae7
9f7e3a4https://github.com/nodejs/node/pull/23641/commits/9f7e3a404096db60438f6dc305b0a5fa4ecddae7
nodejs#23419https://github.com/nodejs/node/pull/23419
https://github.com/jungkumseok
https://github.com/Trott
test: fix assert.strictEqual arguments in test/parallel/test-c-ares.jshttps://github.com/nodejs/node/pull/23641/commits/64d65ed7ac1f31bb65dbcc7a7d0fe4e891297149
64d65edhttps://github.com/nodejs/node/pull/23641/commits/64d65ed7ac1f31bb65dbcc7a7d0fe4e891297149
nodejs#23448https://github.com/nodejs/node/pull/23448
https://github.com/khalidadil
https://github.com/Trott
repl: remove unused variable e from try catchhttps://github.com/nodejs/node/pull/23641/commits/f0c5c962ce971213c0c055b91bb747860defd492
f0c5c96https://github.com/nodejs/node/pull/23641/commits/f0c5c962ce971213c0c055b91bb747860defd492
nodejs#23449https://github.com/nodejs/node/pull/23449
https://github.com/jehaines
https://github.com/Trott
test: fix order of values in test assertionshttps://github.com/nodejs/node/pull/23641/commits/478fe0aaff48c6dcbb586e2f82ea3a5499250985
478fe0ahttps://github.com/nodejs/node/pull/23641/commits/478fe0aaff48c6dcbb586e2f82ea3a5499250985
nodejs#23450https://github.com/nodejs/node/pull/23450
https://github.com/widatama
https://github.com/Trott
test: fix http local address test assertionhttps://github.com/nodejs/node/pull/23641/commits/dee9d27923ecb4b9cc8aaa0e233d712d802c2d0c
dee9d27https://github.com/nodejs/node/pull/23641/commits/dee9d27923ecb4b9cc8aaa0e233d712d802c2d0c
nodejs#23451https://github.com/nodejs/node/pull/23451
https://github.com/mmisiarek
https://github.com/Trott
repl: remove unused variable from try catchhttps://github.com/nodejs/node/pull/23641/commits/c301518a456f36382a73ed9e36816061107b2444
c301518https://github.com/nodejs/node/pull/23641/commits/c301518a456f36382a73ed9e36816061107b2444
nodejs#23452https://github.com/nodejs/node/pull/23452
https://github.com/aeisenberg
https://github.com/Trott
test: replace assert.throws w/ common.expectsErrorhttps://github.com/nodejs/node/pull/23641/commits/0005846f033ae9866a6bc5dbbe7f73c6aeb67185
0005846https://github.com/nodejs/node/pull/23641/commits/0005846f033ae9866a6bc5dbbe7f73c6aeb67185
nodejs#23454https://github.com/nodejs/node/pull/23454
https://github.com/ivansieder
https://github.com/Trott
test: strictEqual correct order for http-information-processing testhttps://github.com/nodejs/node/pull/23641/commits/84b21eb377531ecdc78d4f84309edc13e5beb595
84b21ebhttps://github.com/nodejs/node/pull/23641/commits/84b21eb377531ecdc78d4f84309edc13e5beb595
nodejs#23456https://github.com/nodejs/node/pull/23456
https://github.com/andy-ganchrow
https://github.com/Trott
test: fix assert.strictEqual argument orderhttps://github.com/nodejs/node/pull/23641/commits/a2392704b2987073a2c918f349e91e7c5ecaed7c
a239270https://github.com/nodejs/node/pull/23641/commits/a2392704b2987073a2c918f349e91e7c5ecaed7c
nodejs#23457https://github.com/nodejs/node/pull/23457
https://github.com/pdxmholmes
https://github.com/Trott
lib: remove unused 'e' from catchhttps://github.com/nodejs/node/pull/23641/commits/68b46372a7ea0d7f2364531de167fa2f9f7ca865
68b4637https://github.com/nodejs/node/pull/23641/commits/68b46372a7ea0d7f2364531de167fa2f9f7ca865
nodejs#23458https://github.com/nodejs/node/pull/23458
https://github.com/epeden
https://github.com/Trott
test: swap assert.strictEqual args to actual, expectedhttps://github.com/nodejs/node/pull/23641/commits/767d4daeedfa1f336a9c652e13c154a55dcf92cd
767d4dahttps://github.com/nodejs/node/pull/23641/commits/767d4daeedfa1f336a9c652e13c154a55dcf92cd
nodejs#23459https://github.com/nodejs/node/pull/23459
https://github.com/mdaum
https://github.com/Trott
test: fix incorrect ordering of args in assert.strictEqual()https://github.com/nodejs/node/pull/23641/commits/657ee7b0251234c11ddeb629936612f70bfbdb02
657ee7bhttps://github.com/nodejs/node/pull/23641/commits/657ee7b0251234c11ddeb629936612f70bfbdb02
nodejs#23461https://github.com/nodejs/node/pull/23461
https://github.com/rmarkins-godaddy
https://github.com/Trott
test: correct assert testhttps://github.com/nodejs/node/pull/23641/commits/1c73990a7d7eba5296cded6bd4bd989a0bd636d3
1c73990https://github.com/nodejs/node/pull/23641/commits/1c73990a7d7eba5296cded6bd4bd989a0bd636d3
nodejs#23463https://github.com/nodejs/node/pull/23463
https://github.com/DennyScott
https://github.com/Trott
test: remove unused e variable in catch statementhttps://github.com/nodejs/node/pull/23641/commits/8691d8f5426517d3a17ec1a9532dc43d68ae38d4
8691d8fhttps://github.com/nodejs/node/pull/23641/commits/8691d8f5426517d3a17ec1a9532dc43d68ae38d4
nodejs#23465https://github.com/nodejs/node/pull/23465
https://github.com/refack
refackhttps://github.com/refack
addaleaxhttps://github.com/addaleax
joyeecheunghttps://github.com/joyeecheung
tniessenhttps://github.com/tniessen
October 13, 2018 17:02https://github.com/nodejs/node/pull/23641#event-1902245358
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 13, 2018https://github.com/nodejs/node/pull/23641#issuecomment-429558012
@refackhttps://github.com/refack
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1230/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1230/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23641
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Oct 13, 2018https://github.com/nodejs/node/pull/23641#event-1902245379
https://github.com/refack
refackhttps://github.com/refack
Oct 13, 2018https://github.com/nodejs/node/pull/23641#event-1902247293
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 13, 2018https://github.com/nodejs/node/pull/23641#issuecomment-429559093
Please reload this pagehttps://github.com/nodejs/node/pull/23641
Please reload this pagehttps://github.com/nodejs/node/pull/23641
https://github.com/refack
src: refacor MallocedBuffer to it's usage scopehttps://github.com/nodejs/node/pull/23641/commits/d16f0985fa858c77526eb9858c8cf97a34cad3bb
d16f098https://github.com/nodejs/node/pull/23641/commits/d16f0985fa858c77526eb9858c8cf97a34cad3bb
nodejs#23543 (review)https://github.com/nodejs/node/pull/23543#pullrequestreview-164467022
nodejs#23434https://github.com/nodejs/node/pull/23434
https://github.com/refack
refackhttps://github.com/refack
force-pushedhttps://github.com/nodejs/node/compare/20ea06d723f3c89a0b88a1018cb276a5195d510a..d16f0985fa858c77526eb9858c8cf97a34cad3bb
20ea06dhttps://github.com/nodejs/node/commit/20ea06d723f3c89a0b88a1018cb276a5195d510a
d16f098https://github.com/nodejs/node/commit/d16f0985fa858c77526eb9858c8cf97a34cad3bb
Compare https://github.com/nodejs/node/compare/20ea06d723f3c89a0b88a1018cb276a5195d510a..d16f0985fa858c77526eb9858c8cf97a34cad3bb
October 13, 2018 17:26https://github.com/nodejs/node/pull/23641#event-1902254803
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 13, 2018https://github.com/nodejs/node/pull/23641#issuecomment-429560055
@joyeecheunghttps://github.com/joyeecheung
#23434https://github.com/nodejs/node/pull/23434
Please reload this pagehttps://github.com/nodejs/node/pull/23641
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 13, 2018 https://github.com/nodejs/node/pull/23641#pullrequestreview-164470295
View reviewed changes https://github.com/nodejs/node/pull/23641/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/23641#pullrequestreview-164470295
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23641
https://github.com/refack
refackhttps://github.com/refack
Oct 13, 2018https://github.com/nodejs/node/pull/23641#issuecomment-429560196
https://en.cppreference.com/w/cpp/memory/unique_ptrhttps://en.cppreference.com/w/cpp/memory/unique_ptr
Please reload this pagehttps://github.com/nodejs/node/pull/23641
https://github.com/refack
refackhttps://github.com/refack
Oct 13, 2018https://github.com/nodejs/node/pull/23641#issuecomment-429560529
Please reload this pagehttps://github.com/nodejs/node/pull/23641
#23543https://github.com/nodejs/node/pull/23543
Please reload this pagehttps://github.com/nodejs/node/pull/23641
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 13, 2018https://github.com/nodejs/node/pull/23641#issuecomment-429560624
Please reload this pagehttps://github.com/nodejs/node/pull/23641
https://github.com/refack
refackhttps://github.com/refack
Oct 13, 2018https://github.com/nodejs/node/pull/23641#issuecomment-429560957
Please reload this pagehttps://github.com/nodejs/node/pull/23641
Please reload this pagehttps://github.com/nodejs/node/pull/23641
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 13, 2018https://github.com/nodejs/node/pull/23641#issuecomment-429561204
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23641
https://github.com/refack
src: malloced_unique_ptr & make_malloced_uniquehttps://github.com/nodejs/node/pull/23641/commits/5837d36cb6f1dc96795b5ec4387dcc302fa68bcf
5837d36https://github.com/nodejs/node/pull/23641/commits/5837d36cb6f1dc96795b5ec4387dcc302fa68bcf
https://github.com/refack
refackhttps://github.com/refack
Oct 13, 2018https://github.com/nodejs/node/pull/23641#issuecomment-429561964
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23641
https://github.com/refack
refackhttps://github.com/refack
Oct 13, 2018 https://github.com/nodejs/node/pull/23641#ref-pullrequest-369826201
src: malloced_unique_ptr & make_malloced_unique #23642 https://github.com/nodejs/node/pull/23642
https://github.com/refack
refackhttps://github.com/refack
Oct 13, 2018https://github.com/nodejs/node/pull/23641#issuecomment-429562792
#23642https://github.com/nodejs/node/pull/23642
Please reload this pagehttps://github.com/nodejs/node/pull/23641
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
force-pushedhttps://github.com/nodejs/node/compare/882e0225d5855a17dafa10820bf1a0b833df8dac..9ed4646df05b9593075bb0cd0b3ab420bae482a5
882e022https://github.com/nodejs/node/commit/882e0225d5855a17dafa10820bf1a0b833df8dac
9ed4646https://github.com/nodejs/node/commit/9ed4646df05b9593075bb0cd0b3ab420bae482a5
Compare https://github.com/nodejs/node/compare/882e0225d5855a17dafa10820bf1a0b833df8dac..9ed4646df05b9593075bb0cd0b3ab420bae482a5
October 13, 2018 18:22https://github.com/nodejs/node/pull/23641#event-1902276554
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 13, 2018https://github.com/nodejs/node/pull/23641#issuecomment-429565816
Please reload this pagehttps://github.com/nodejs/node/pull/23641
https://en.cppreference.com/w/cpp/memory/unique_ptrhttps://en.cppreference.com/w/cpp/memory/unique_ptr
@refackhttps://github.com/refack
#23641 (comment)https://github.com/nodejs/node/pull/23641#issuecomment-429560957
Please reload this pagehttps://github.com/nodejs/node/pull/23641
refackhttps://github.com/refack
Oct 13, 2018 https://github.com/nodejs/node/pull/23641#ref-commit-bca838b
https://github.com/refack
src: malloced_unique_ptr & make_malloced_uniquehttps://github.com/refack/node/commit/bca838b7ddc4f89458c1fe06d91cfeb28decbb14
bca838bhttps://github.com/refack/node/commit/bca838b7ddc4f89458c1fe06d91cfeb28decbb14
nodejs#23641https://github.com/nodejs/node/pull/23641
nodejs#23543 (review)https://github.com/nodejs/node/pull/23543#pullrequestreview-164467022
nodejs#23434https://github.com/nodejs/node/pull/23434
https://github.com/refack
refackhttps://github.com/refack
Oct 13, 2018 https://github.com/nodejs/node/pull/23641#ref-pullrequest-369845442
src: malloced_unique_ptr & make_malloced_unique #23649 https://github.com/nodejs/node/pull/23649
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018https://github.com/nodejs/node/pull/23641#issuecomment-431619063
Please reload this pagehttps://github.com/nodejs/node/pull/23641
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018https://github.com/nodejs/node/pull/23641#event-1916392117
https://github.com/refack
refackhttps://github.com/refack
October 20, 2018 21:22https://github.com/nodejs/node/pull/23641#event-1916392143
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018https://github.com/nodejs/node/pull/23641#event-1916393500
refackhttps://github.com/refack
Oct 20, 2018 https://github.com/nodejs/node/pull/23641#ref-commit-5bd49eb
https://github.com/refack
src: malloced_unique_ptr & make_malloced_uniquehttps://github.com/refack/node/commit/5bd49ebc4fe05dabc338297722912be8ccad5dde
5bd49ebhttps://github.com/refack/node/commit/5bd49ebc4fe05dabc338297722912be8ccad5dde
nodejs#23641https://github.com/nodejs/node/pull/23641
nodejs#23543 (review)https://github.com/nodejs/node/pull/23543#pullrequestreview-164467022
nodejs#23434https://github.com/nodejs/node/pull/23434
https://github.com/refack
refackhttps://github.com/refack
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Oct 29, 2018https://github.com/nodejs/node/pull/23641#event-1931052652
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23641
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23641/files/20ea06d723f3c89a0b88a1018cb276a5195d510a
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Please reload this pagehttps://github.com/nodejs/node/pull/23641
https://github.com/refack
https://github.com/nodejs-github-bot
https://github.com/joyeecheung
https://github.com/addaleax
https://github.com/rxiayth
https://github.com/leomoreno
https://github.com/ofrobots
https://github.com/jungkumseok
https://github.com/khalidadil
https://github.com/jehaines
https://github.com/widatama
https://github.com/mmisiarek
https://github.com/aeisenberg
https://github.com/ivansieder
https://github.com/andy-ganchrow
https://github.com/pdxmholmes
https://github.com/epeden
https://github.com/mdaum
https://github.com/rmarkins-godaddy
https://github.com/DennyScott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.