| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:07ae0102-3572-1466-9c94-5e5336e10601 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EC86:187C13:20F9F2:2A4BC4:6990307F |
| html-safe-nonce | 8143c69b03dcd48bdb5718e5e2f2abe4c36c06299ef48783d9db56ef70214174 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzg2OjE4N0MxMzoyMEY5RjI6MkE0QkM0OjY5OTAzMDdGIiwidmlzaXRvcl9pZCI6IjMyODM0MDQ2NzMwOTI5NTYyODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0f3a61c125911720a876d70f0370efd0eedd61d7b89501fa591461f61ca1aeda |
| hovercard-subject-tag | pull_request:222653017 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23639/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c11424e1a4e316177d49fba246a5ccdd94488b94670b41cf4ecc2ddaf78eea89/nodejs/node/pull/23639 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c11424e1a4e316177d49fba246a5ccdd94488b94670b41cf4ecc2ddaf78eea89/nodejs/node/pull/23639 |
| og:image:alt | Refs: #20628
Please 👍 to fast-track
CI: https://ci.nodejs.org/job/node-test-pull-request/17810/
https://ci.nodejs.org/job/node-test-pull-request/17812/
Checklist
make -j4 test (UNIX), or vcbuil... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | refack |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23639#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23639 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23639 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23639 |
| Reload | https://github.com/nodejs/node/pull/23639 |
| Reload | https://github.com/nodejs/node/pull/23639 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23639 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
709
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| refack:mark-new-flake | https://github.com/refack/node/tree/mark-new-flake |
| Conversation | https://github.com/nodejs/node/pull/23639 |
| Commits1 (1) | https://github.com/nodejs/node/pull/23639/commits |
| Checks | https://github.com/nodejs/node/pull/23639/checks |
| Files changed | https://github.com/nodejs/node/pull/23639/files |
| test: mark test-http2-session-timeout as flake on ARM | https://github.com/nodejs/node/pull/23639#top |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| refack:mark-new-flake | https://github.com/refack/node/tree/mark-new-flake |
|
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23639#issue-369806708 |
| Please reload this page | https://github.com/nodejs/node/pull/23639 |
| #20628 | https://github.com/nodejs/node/issues/20628 |
| https://ci.nodejs.org/job/node-test-pull-request/17810/ | https://ci.nodejs.org/job/node-test-pull-request/17810/ |
| https://ci.nodejs.org/job/node-test-pull-request/17812/ | https://ci.nodejs.org/job/node-test-pull-request/17812/ |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23639 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
flaky-test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23639#event-1902183935 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23639#event-1902183939 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Trott | https://github.com/Trott |
| October 13, 2018 14:22 | https://github.com/nodejs/node/pull/23639#event-1902183941 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23639#issuecomment-429546101 |
| @refack | https://github.com/refack |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1227/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1227/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/23639 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23639#issuecomment-429546153 |
| Please reload this page | https://github.com/nodejs/node/pull/23639 |
| Please reload this page | https://github.com/nodejs/node/pull/23639 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23639#ref-issue-321599502 |
|
Investigate flaky test-http2-session-timeout
#20628
| https://github.com/nodejs/node/issues/20628 |
|
| https://github.com/refack |
| test: mark test-http2-session-timeout as flake on ARM | https://github.com/nodejs/node/pull/23639/commits/47af82c189e4b54cd0a6fcab422644c75162325d |
| 47af82c | https://github.com/nodejs/node/pull/23639/commits/47af82c189e4b54cd0a6fcab422644c75162325d |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/f5a4120ca18dfdfae1c65931cf2e772f7c444a14..47af82c189e4b54cd0a6fcab422644c75162325d |
| f5a4120 | https://github.com/nodejs/node/commit/f5a4120ca18dfdfae1c65931cf2e772f7c444a14 |
| 47af82c | https://github.com/nodejs/node/commit/47af82c189e4b54cd0a6fcab422644c75162325d |
|
Compare
| https://github.com/nodejs/node/compare/f5a4120ca18dfdfae1c65931cf2e772f7c444a14..47af82c189e4b54cd0a6fcab422644c75162325d |
| October 13, 2018 15:36 | https://github.com/nodejs/node/pull/23639#event-1902212558 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23639#pullrequestreview-164469114 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23639/files/47af82c189e4b54cd0a6fcab422644c75162325d |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23639#event-1902240681 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23639#issuecomment-429561586 |
| 882e022 | https://github.com/nodejs/node/commit/882e0225d5855a17dafa10820bf1a0b833df8dac |
| Please reload this page | https://github.com/nodejs/node/pull/23639 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23639#event-1902264074 |
| addaleax | https://github.com/addaleax |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23639#ref-commit-882e022 |
|
| https://github.com/refack |
|
| https://github.com/addaleax |
| test: mark test-http2-session-timeout as flake on ARM | https://github.com/nodejs/node/commit/882e0225d5855a17dafa10820bf1a0b833df8dac |
| 882e022 | https://github.com/nodejs/node/commit/882e0225d5855a17dafa10820bf1a0b833df8dac |
| #23639 | https://github.com/nodejs/node/pull/23639 |
| #20628 | https://github.com/nodejs/node/issues/20628 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23639#event-1902287263 |
| https://github.com/refack |
| refack | https://github.com/refack |
| October 13, 2018 18:53 | https://github.com/nodejs/node/pull/23639#event-1902287293 |
| addaleax | https://github.com/addaleax |
|
Oct 14, 2018
| https://github.com/nodejs/node/pull/23639#ref-commit-59ecf06 |
|
| https://github.com/refack |
|
| https://github.com/addaleax |
| test: mark test-http2-session-timeout as flake on ARM | https://github.com/nodejs/node/commit/59ecf06eae8a0dbcad8ead8def1924a6c70c64eb |
| 59ecf06 | https://github.com/nodejs/node/commit/59ecf06eae8a0dbcad8ead8def1924a6c70c64eb |
| #23639 | https://github.com/nodejs/node/pull/23639 |
| #20628 | https://github.com/nodejs/node/issues/20628 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23639#ref-commit-5e68333 |
|
| https://github.com/refack |
|
| https://github.com/jasnell |
| test: mark test-http2-session-timeout as flake on ARM | https://github.com/nodejs/node/commit/5e68333eadf962b57c77eb71f69f00480de85bf0 |
| 5e68333 | https://github.com/nodejs/node/commit/5e68333eadf962b57c77eb71f69f00480de85bf0 |
| #23639 | https://github.com/nodejs/node/pull/23639 |
| #20628 | https://github.com/nodejs/node/issues/20628 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23639#ref-commit-75d4bf2 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| test: mark test-http2-session-timeout as flake on ARM | https://github.com/nodejs/node/commit/75d4bf23480bf4b6053ed524df949d4290bef777 |
| 75d4bf2 | https://github.com/nodejs/node/commit/75d4bf23480bf4b6053ed524df949d4290bef777 |
| #23639 | https://github.com/nodejs/node/pull/23639 |
| #20628 | https://github.com/nodejs/node/issues/20628 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/23639#ref-pullrequest-384882602 |
|
v10.13.1 proposal
#24675
| https://github.com/nodejs/node/pull/24675 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23639#ref-commit-9cfa1f6 |
|
| https://github.com/refack |
|
| https://github.com/rvagg |
| test: mark test-http2-session-timeout as flake on ARM | https://github.com/nodejs/node/commit/9cfa1f677628c16f9aa86930c8f543aa7e4d8c2f |
| 9cfa1f6 | https://github.com/nodejs/node/commit/9cfa1f677628c16f9aa86930c8f543aa7e4d8c2f |
| #23639 | https://github.com/nodejs/node/pull/23639 |
| #20628 | https://github.com/nodejs/node/issues/20628 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23639#ref-commit-51aa50c |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| test: mark test-http2-session-timeout as flake on ARM | https://github.com/nodejs/node/commit/51aa50c60c3920dbe50a88de605b58d40759c153 |
| 51aa50c | https://github.com/nodejs/node/commit/51aa50c60c3920dbe50a88de605b58d40759c153 |
| #23639 | https://github.com/nodejs/node/pull/23639 |
| #20628 | https://github.com/nodejs/node/issues/20628 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23639#ref-pullrequest-385836001 |
|
v10.14.2 proposal
#24727
| https://github.com/nodejs/node/pull/24727 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23639 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/23639/files/47af82c189e4b54cd0a6fcab422644c75162325d |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
flaky-test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/23639 |
|
| https://github.com/refack |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/Trott |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |