René's URL Explorer Experiment


Title: tls: prevent multiple connection errors by cjihrig · Pull Request #23636 · nodejs/node · GitHub

Open Graph Title: tls: prevent multiple connection errors by cjihrig · Pull Request #23636 · nodejs/node

X Title: tls: prevent multiple connection errors by cjihrig · Pull Request #23636 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: onConnectEnd(), which is called by TLSSocket, has a guard to prevent being called multiple times, but it does not prevent the OpenSSL error handler from being called, leading to multiple error even...

X Description: onConnectEnd(), which is called by TLSSocket, has a guard to prevent being called multiple times, but it does not prevent the OpenSSL error handler from being called, leading to multiple error even...

Opengraph URL: https://github.com/nodejs/node/pull/23636

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6be178b2-04f5-78e1-4c42-8e73e11d31bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F40:18F6E5:A0A5A9:CF8445:6990663D
html-safe-noncee8ba042c9e58932bf4523f50f9a4d2ac857f40a218ef4000640a0655295499af
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjQwOjE4RjZFNTpBMEE1QTk6Q0Y4NDQ1OjY5OTA2NjNEIiwidmlzaXRvcl9pZCI6IjM4MzQzMjc0MjEwMDUzNTg2NTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6bc2a82ddaa56050d7103420017a97d036410fa7cbe41685f5a51944f2cb5950
hovercard-subject-tagpull_request:222628425
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23636/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d04b16eaa5f434fa80154adb95af180464aef15b5553c80c32c60b0cfab24bd9/nodejs/node/pull/23636
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d04b16eaa5f434fa80154adb95af180464aef15b5553c80c32c60b0cfab24bd9/nodejs/node/pull/23636
og:image:altonConnectEnd(), which is called by TLSSocket, has a guard to prevent being called multiple times, but it does not prevent the OpenSSL error handler from being called, leading to multiple error even...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23636#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23636
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23636
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23636
Reloadhttps://github.com/nodejs/node/pull/23636
Reloadhttps://github.com/nodejs/node/pull/23636
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23636
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:23631https://github.com/cjihrig/node/tree/23631
Conversationhttps://github.com/nodejs/node/pull/23636
Commits1 (1)https://github.com/nodejs/node/pull/23636/commits
Checkshttps://github.com/nodejs/node/pull/23636/checks
Files changedhttps://github.com/nodejs/node/pull/23636/files
tls: prevent multiple connection errorshttps://github.com/nodejs/node/pull/23636#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:23631https://github.com/cjihrig/node/tree/23631
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 13, 2018https://github.com/nodejs/node/pull/23636#issue-369768214
Please reload this pagehttps://github.com/nodejs/node/pull/23636
#23631https://github.com/nodejs/node/issues/23631
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
https://ci.nodejs.org/job/node-test-pull-request/17937/https://ci.nodejs.org/job/node-test-pull-request/17937/
Please reload this pagehttps://github.com/nodejs/node/pull/23636
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 13, 2018https://github.com/nodejs/node/pull/23636#issuecomment-429511836
@cjihrighttps://github.com/cjihrig
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1223/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1223/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23636
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Oct 13, 2018https://github.com/nodejs/node/pull/23636#event-1902014756
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
force-pushedhttps://github.com/nodejs/node/compare/882e0225d5855a17dafa10820bf1a0b833df8dac..9ed4646df05b9593075bb0cd0b3ab420bae482a5
882e022https://github.com/nodejs/node/commit/882e0225d5855a17dafa10820bf1a0b833df8dac
9ed4646https://github.com/nodejs/node/commit/9ed4646df05b9593075bb0cd0b3ab420bae482a5
Compare https://github.com/nodejs/node/compare/882e0225d5855a17dafa10820bf1a0b833df8dac..9ed4646df05b9593075bb0cd0b3ab420bae482a5
October 13, 2018 18:22https://github.com/nodejs/node/pull/23636#event-1902276551
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 13, 2018https://github.com/nodejs/node/pull/23636#issuecomment-429571160
Please reload this pagehttps://github.com/nodejs/node/pull/23636
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 13, 2018https://github.com/nodejs/node/pull/23636#issuecomment-429572001
Please reload this pagehttps://github.com/nodejs/node/pull/23636
one from JShttps://github.com/nodejs/node/blob/master/lib/_tls_wrap.js#L1059
one from OpenSSLhttps://github.com/nodejs/node/blob/master/lib/_tls_wrap.js#L248
#23631https://github.com/nodejs/node/issues/23631
Please reload this pagehttps://github.com/nodejs/node/pull/23636
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 13, 2018https://github.com/nodejs/node/pull/23636#issuecomment-429572102
Please reload this pagehttps://github.com/nodejs/node/pull/23636
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 13, 2018 https://github.com/nodejs/node/pull/23636#pullrequestreview-164475356
View reviewed changes https://github.com/nodejs/node/pull/23636/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/93af4305ff6acbca539969876e767707a7cfbeac..924f898033703fe32a769a1a43f7d82e1ccaaa2f
93af430https://github.com/nodejs/node/commit/93af4305ff6acbca539969876e767707a7cfbeac
924f898https://github.com/nodejs/node/commit/924f898033703fe32a769a1a43f7d82e1ccaaa2f
Compare https://github.com/nodejs/node/compare/93af4305ff6acbca539969876e767707a7cfbeac..924f898033703fe32a769a1a43f7d82e1ccaaa2f
October 13, 2018 23:02https://github.com/nodejs/node/pull/23636#event-1902370994
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 13, 2018https://github.com/nodejs/node/pull/23636#issuecomment-429582451
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/23636
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 13, 2018 https://github.com/nodejs/node/pull/23636#pullrequestreview-164479217
View reviewed changes https://github.com/nodejs/node/pull/23636/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/23636#pullrequestreview-164479217
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23636
https://github.com/ameriania
amerianiahttps://github.com/ameriania
Oct 14, 2018 https://github.com/nodejs/node/pull/23636#pullrequestreview-164503106
View reviewed changes https://github.com/nodejs/node/pull/23636/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 16, 2018https://github.com/nodejs/node/pull/23636#issuecomment-430240329
#23631https://github.com/nodejs/node/issues/23631
@bnoordhuishttps://github.com/bnoordhuis
@tniessenhttps://github.com/tniessen
Please reload this pagehttps://github.com/nodejs/node/pull/23636
https://github.com/geek
geekhttps://github.com/geek
Oct 17, 2018 https://github.com/nodejs/node/pull/23636#pullrequestreview-165687955
View reviewed changes https://github.com/nodejs/node/pull/23636/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23636#pullrequestreview-165699501
View reviewed changes https://github.com/nodejs/node/pull/23636/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/487d81b2f2c860834093b2826f6c2bf79cc5a676..ef41ba3c02cac4cb7200bd39c3af95ff85d24596
487d81bhttps://github.com/nodejs/node/commit/487d81b2f2c860834093b2826f6c2bf79cc5a676
ef41ba3https://github.com/nodejs/node/commit/ef41ba3c02cac4cb7200bd39c3af95ff85d24596
Compare https://github.com/nodejs/node/compare/487d81b2f2c860834093b2826f6c2bf79cc5a676..ef41ba3c02cac4cb7200bd39c3af95ff85d24596
October 17, 2018 16:50https://github.com/nodejs/node/pull/23636#event-1910117535
https://github.com/cjihrig
tls: prevent multiple connection errorshttps://github.com/nodejs/node/pull/23636/commits/b94ce575f57fa883b93ce8948730577a9bde8603
b94ce57https://github.com/nodejs/node/pull/23636/commits/b94ce575f57fa883b93ce8948730577a9bde8603
nodejs#23636https://github.com/nodejs/node/pull/23636
nodejs#23631https://github.com/nodejs/node/issues/23631
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/ef41ba3c02cac4cb7200bd39c3af95ff85d24596..b94ce575f57fa883b93ce8948730577a9bde8603
ef41ba3https://github.com/nodejs/node/commit/ef41ba3c02cac4cb7200bd39c3af95ff85d24596
b94ce57https://github.com/nodejs/node/commit/b94ce575f57fa883b93ce8948730577a9bde8603
Compare https://github.com/nodejs/node/compare/ef41ba3c02cac4cb7200bd39c3af95ff85d24596..b94ce575f57fa883b93ce8948730577a9bde8603
October 17, 2018 16:51https://github.com/nodejs/node/pull/23636#event-1910120516
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
b94ce57https://github.com/nodejs/node/commit/b94ce575f57fa883b93ce8948730577a9bde8603
Oct 17, 2018https://github.com/nodejs/node/pull/23636#event-1910123775
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
October 17, 2018 16:52https://github.com/nodejs/node/pull/23636#event-1910124370
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23636#ref-commit-934eb7e
https://github.com/cjihrig
https://github.com/jasnell
tls: prevent multiple connection errorshttps://github.com/nodejs/node/commit/934eb7ec59cf7b16d9f542906168511475cb0ecf
934eb7ehttps://github.com/nodejs/node/commit/934eb7ec59cf7b16d9f542906168511475cb0ecf
#23636https://github.com/nodejs/node/pull/23636
#23631https://github.com/nodejs/node/issues/23631
addaleaxhttps://github.com/addaleax
Oct 20, 2018 https://github.com/nodejs/node/pull/23636#ref-commit-b5a5626
https://github.com/cjihrig
https://github.com/addaleax
tls: prevent multiple connection errorshttps://github.com/nodejs/node/commit/b5a5626955f5dbbf33a2346c1c2f3b1dbef34918
b5a5626https://github.com/nodejs/node/commit/b5a5626955f5dbbf33a2346c1c2f3b1dbef34918
#23636https://github.com/nodejs/node/pull/23636
#23631https://github.com/nodejs/node/issues/23631
MylesBorinshttps://github.com/MylesBorins
Oct 30, 2018 https://github.com/nodejs/node/pull/23636#ref-commit-81dc241
https://github.com/cjihrig
https://github.com/MylesBorins
tls: prevent multiple connection errorshttps://github.com/nodejs/node/commit/81dc2419f459e949b52c0d626c43342dcc71d1ec
81dc241https://github.com/nodejs/node/commit/81dc2419f459e949b52c0d626c43342dcc71d1ec
#23636https://github.com/nodejs/node/pull/23636
#23631https://github.com/nodejs/node/issues/23631
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23636#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23636#ref-commit-17589a5
https://github.com/cjihrig
https://github.com/rvagg
tls: prevent multiple connection errorshttps://github.com/nodejs/node/commit/17589a5c199dd151c461c2d9e21521a7c5826336
17589a5https://github.com/nodejs/node/commit/17589a5c199dd151c461c2d9e21521a7c5826336
#23636https://github.com/nodejs/node/pull/23636
#23631https://github.com/nodejs/node/issues/23631
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23636#ref-commit-ed0a97a
https://github.com/cjihrig
https://github.com/MylesBorins
tls: prevent multiple connection errorshttps://github.com/nodejs/node/commit/ed0a97a52446c1fa6a9cc006ce647983b669785f
ed0a97ahttps://github.com/nodejs/node/commit/ed0a97a52446c1fa6a9cc006ce647983b669785f
#23636https://github.com/nodejs/node/pull/23636
#23631https://github.com/nodejs/node/issues/23631
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23636#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23636
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23636/files/924f898033703fe32a769a1a43f7d82e1ccaaa2f
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23636/files/924f898033703fe32a769a1a43f7d82e1ccaaa2f
https://github.com/geek
geek https://github.com/geek
https://github.com/nodejs/node/pull/23636/files/924f898033703fe32a769a1a43f7d82e1ccaaa2f
https://github.com/ameriania
ameriania https://github.com/ameriania
https://github.com/nodejs/node/pull/23636/files/924f898033703fe32a769a1a43f7d82e1ccaaa2f
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/23636
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/jasnell
https://github.com/geek
https://github.com/ameriania
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.