René's URL Explorer Experiment


Title: [v10.x backport] test: refactor common.ddCommand() by Trott · Pull Request #23630 · nodejs/node · GitHub

Open Graph Title: [v10.x backport] test: refactor common.ddCommand() by Trott · Pull Request #23630 · nodejs/node

X Title: [v10.x backport] test: refactor common.ddCommand() by Trott · Pull Request #23630 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: backport of #23411 @addaleax

X Description: backport of #23411 @addaleax

Opengraph URL: https://github.com/nodejs/node/pull/23630

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bb8f757b-85ba-af93-a190-e2abd2d107e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC42:28B211:C9AA57:1045F35:6990BDAA
html-safe-nonce9d7155ff190c99ef488f657f373ce29b8e44db5c4caf7a08a0064013416ac2c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzQyOjI4QjIxMTpDOUFBNTc6MTA0NUYzNTo2OTkwQkRBQSIsInZpc2l0b3JfaWQiOiI3NzA2Mzc1MTgwMDYzMzkxMTQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2cc8877a8e3c5a8b4073388b2f943893781539d38fb6d695d90291f26835ac8f
hovercard-subject-tagpull_request:222603887
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23630/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b1013c957ae85669fd4b727bc533ed868e62f81f42977ac3d21147439319927b/nodejs/node/pull/23630
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b1013c957ae85669fd4b727bc533ed868e62f81f42977ac3d21147439319927b/nodejs/node/pull/23630
og:image:altbackport of #23411 @addaleax
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23630#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23630
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23630
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23630
Reloadhttps://github.com/nodejs/node/pull/23630
Reloadhttps://github.com/nodejs/node/pull/23630
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23630
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 705 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
Trott:backport-23411https://github.com/Trott/io.js/tree/backport-23411
Conversationhttps://github.com/nodejs/node/pull/23630
Commits16 (16)https://github.com/nodejs/node/pull/23630/commits
Checkshttps://github.com/nodejs/node/pull/23630/checks
Files changedhttps://github.com/nodejs/node/pull/23630/files
[v10.x backport] test: refactor common.ddCommand()https://github.com/nodejs/node/pull/23630#top
Trotthttps://github.com/Trott
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
Trott:backport-23411https://github.com/Trott/io.js/tree/backport-23411
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 12, 2018https://github.com/nodejs/node/pull/23630#issue-369733562
#23411https://github.com/nodejs/node/pull/23411
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/23630
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 12, 2018https://github.com/nodejs/node/pull/23630#issuecomment-429482338
@Trotthttps://github.com/Trott
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1219/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1219/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23630
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x
Oct 12, 2018https://github.com/nodejs/node/pull/23630#event-1901835800
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 12, 2018 https://github.com/nodejs/node/pull/23630#ref-pullrequest-368793615
test: refactor common.ddCommand() #23411 https://github.com/nodejs/node/pull/23411
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 12, 2018 https://github.com/nodejs/node/pull/23630#pullrequestreview-164431178
View reviewed changes https://github.com/nodejs/node/pull/23630/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 13, 2018 https://github.com/nodejs/node/pull/23630#pullrequestreview-164444264
View reviewed changes https://github.com/nodejs/node/pull/23630/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 13, 2018https://github.com/nodejs/node/pull/23630#issuecomment-429497626
https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/6096/consolehttps://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/6096/console
Please reload this pagehttps://github.com/nodejs/node/pull/23630
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 13, 2018 https://github.com/nodejs/node/pull/23630#ref-issue-369753072
Failing test on v10.x-staging #23633 https://github.com/nodejs/node/issues/23633
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 13, 2018https://github.com/nodejs/node/pull/23630#issuecomment-429499586
#23633https://github.com/nodejs/node/issues/23633
Please reload this pagehttps://github.com/nodejs/node/pull/23630
oyydhttps://github.com/oyyd
October 12, 2018 20:14https://github.com/nodejs/node/pull/23630#commits-pushed-6d151ad
https://github.com/oyyd
https://github.com/Trott
tls: make StreamWrap work correctly in "drain" callbackhttps://github.com/nodejs/node/pull/23630/commits/6d151ad89f9cf0d3783f16817a71513969065471
6d151adhttps://github.com/nodejs/node/pull/23630/commits/6d151ad89f9cf0d3783f16817a71513969065471
nodejs#23294https://github.com/nodejs/node/pull/23294
https://github.com/dyatlov
https://github.com/Trott
src: revert removal of SecureContext _external getterhttps://github.com/nodejs/node/pull/23630/commits/f2b473452435b9316db7fa9d618e4c1f214dc9cb
f2b4734https://github.com/nodejs/node/pull/23630/commits/f2b473452435b9316db7fa9d618e4c1f214dc9cb
nodejs#21711https://github.com/nodejs/node/pull/21711
https://github.com/sagitsofan
https://github.com/Trott
lib: http server, friendly error messageshttps://github.com/nodejs/node/pull/23630/commits/ad59bbdb736e3000f518949d991d707d4d1698d5
ad59bbdhttps://github.com/nodejs/node/pull/23630/commits/ad59bbdb736e3000f518949d991d707d4d1698d5
nodejs#22936https://github.com/nodejs/node/issues/22936
nodejs#22995https://github.com/nodejs/node/pull/22995
https://github.com/gireeshpunathil
https://github.com/Trott
src: improve SSL version extraction logichttps://github.com/nodejs/node/pull/23630/commits/736d6d1682405653733d84c594f0c2930bf07aff
736d6d1https://github.com/nodejs/node/pull/23630/commits/736d6d1682405653733d84c594f0c2930bf07aff
nodejs#23050https://github.com/nodejs/node/pull/23050
https://github.com/tniessen
https://github.com/Trott
src: fix bug in MallocedBuffer constructorhttps://github.com/nodejs/node/pull/23630/commits/2218a38f62505f2216d9929b21b4a2a15a2be527
2218a38https://github.com/nodejs/node/pull/23630/commits/2218a38f62505f2216d9929b21b4a2a15a2be527
nodejs#23434https://github.com/nodejs/node/pull/23434
https://github.com/Trott
doc: revise security-reporting text in READMEhttps://github.com/nodejs/node/pull/23630/commits/4b0c0f19e4222f00734fff656c80a384460244a9
4b0c0f1https://github.com/nodejs/node/pull/23630/commits/4b0c0f19e4222f00734fff656c80a384460244a9
nodejs#23407https://github.com/nodejs/node/pull/23407
https://github.com/joesepi
https://github.com/Trott
test: fixing assertion value orderhttps://github.com/nodejs/node/pull/23630/commits/f6a2af587a4e81274e0b3c8fe000e2d231d833ee
f6a2af5https://github.com/nodejs/node/pull/23630/commits/f6a2af587a4e81274e0b3c8fe000e2d231d833ee
nodejs#23574https://github.com/nodejs/node/pull/23574
https://github.com/et4891
https://github.com/Trott
test: fix assert.strictEqual argument orderhttps://github.com/nodejs/node/pull/23630/commits/4089a553c062812d4a96b0f5ce95a8700da54919
4089a55https://github.com/nodejs/node/pull/23630/commits/4089a553c062812d4a96b0f5ce95a8700da54919
nodejs#23518https://github.com/nodejs/node/pull/23518
https://github.com/lundibundi
https://github.com/Trott
test: improve test-gc-http-client-connabortedhttps://github.com/nodejs/node/pull/23630/commits/584470c0b89f276e6b8de603bf9d1887e2acc9f3
584470chttps://github.com/nodejs/node/pull/23630/commits/584470c0b89f276e6b8de603bf9d1887e2acc9f3
nodejs#23193https://github.com/nodejs/node/pull/23193
https://github.com/lundibundi
https://github.com/Trott
test: improve test-gc-http-client-onerrorhttps://github.com/nodejs/node/pull/23630/commits/0d7328d954cbac20fa68ecd78fc645e62cc6c922
0d7328dhttps://github.com/nodejs/node/pull/23630/commits/0d7328d954cbac20fa68ecd78fc645e62cc6c922
nodejs#23196https://github.com/nodejs/node/pull/23196
https://github.com/addaleax
https://github.com/Trott
test: move some gc tests back to parallel/, unmark flakyhttps://github.com/nodejs/node/pull/23630/commits/35f9218b6def0808826ea412460d8bce5b00495d
35f9218https://github.com/nodejs/node/pull/23630/commits/35f9218b6def0808826ea412460d8bce5b00495d
nodejs#23336https://github.com/nodejs/node/pull/23336
nodejs#23356https://github.com/nodejs/node/pull/23356
https://github.com/addaleax
https://github.com/Trott
zlib: generate error code names in C++https://github.com/nodejs/node/pull/23630/commits/e86b6aa9ed49348176be9f685ae617f39daf6b7d
e86b6aahttps://github.com/nodejs/node/pull/23630/commits/e86b6aa9ed49348176be9f685ae617f39daf6b7d
nodejs#23413https://github.com/nodejs/node/pull/23413
https://github.com/sam-github
https://github.com/Trott
doc: describe SNI host name formathttps://github.com/nodejs/node/pull/23630/commits/3a533d6755f7451cb90d892689ecb0f9c49a936e
3a533d6https://github.com/nodejs/node/pull/23630/commits/3a533d6755f7451cb90d892689ecb0f9c49a936e
nodejs#23329https://github.com/nodejs/node/pull/23329
nodejs#23357https://github.com/nodejs/node/pull/23357
nodejs#23329https://github.com/nodejs/node/pull/23329
https://github.com/starkwang
https://github.com/Trott
http: reduce duplicated code for cleaning parserhttps://github.com/nodejs/node/pull/23630/commits/7c9b37e2eb17535fb906c546a4ded9dda1143f4b
7c9b37ehttps://github.com/nodejs/node/pull/23630/commits/7c9b37e2eb17535fb906c546a4ded9dda1143f4b
nodejs#23351https://github.com/nodejs/node/pull/23351
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/2d4d546bcb2a896b9771753f90e1dacb2e706d0b..7c9b37e2eb17535fb906c546a4ded9dda1143f4b
2d4d546https://github.com/nodejs/node/commit/2d4d546bcb2a896b9771753f90e1dacb2e706d0b
7c9b37ehttps://github.com/nodejs/node/commit/7c9b37e2eb17535fb906c546a4ded9dda1143f4b
Compare https://github.com/nodejs/node/compare/2d4d546bcb2a896b9771753f90e1dacb2e706d0b..7c9b37e2eb17535fb906c546a4ded9dda1143f4b
October 13, 2018 03:15https://github.com/nodejs/node/pull/23630#event-1901984592
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 13, 2018https://github.com/nodejs/node/pull/23630#issuecomment-429506718
#23633https://github.com/nodejs/node/issues/23633
https://ci.nodejs.org/job/node-test-pull-request/1​77​94https://ci.nodejs.org/job/node-test-pull-request/1%E2%80%8B77%E2%80%8B94
Please reload this pagehttps://github.com/nodejs/node/pull/23630
Trotthttps://github.com/Trott
October 12, 2018 20:18https://github.com/nodejs/node/pull/23630#commits-pushed-79a2b00
https://github.com/Trott
test: refactor common.ddCommand()https://github.com/nodejs/node/pull/23630/commits/79a2b005b3acf642bab09e65d5b59790782342d7
79a2b00https://github.com/nodejs/node/pull/23630/commits/79a2b005b3acf642bab09e65d5b59790782342d7
nodejs#23411https://github.com/nodejs/node/pull/23411
https://github.com/Trott
test: rename common.ddCommand()https://github.com/nodejs/node/pull/23630/commits/ea510a681ea2d24a066effcb5106129a994e0882
ea510a6https://github.com/nodejs/node/pull/23630/commits/ea510a681ea2d24a066effcb5106129a994e0882
nodejs#23411https://github.com/nodejs/node/pull/23411
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/89b0fd16a477806cca409f0fcf8f4333d83db685..ea510a681ea2d24a066effcb5106129a994e0882
89b0fd1https://github.com/nodejs/node/commit/89b0fd16a477806cca409f0fcf8f4333d83db685
ea510a6https://github.com/nodejs/node/commit/ea510a681ea2d24a066effcb5106129a994e0882
Compare https://github.com/nodejs/node/compare/89b0fd16a477806cca409f0fcf8f4333d83db685..ea510a681ea2d24a066effcb5106129a994e0882
October 13, 2018 03:18https://github.com/nodejs/node/pull/23630#event-1901985582
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 13, 2018https://github.com/nodejs/node/pull/23630#issuecomment-429514394
Please reload this pagehttps://github.com/nodejs/node/pull/23630
https://ci.nodejs.org/job/node-test-pull-request/17807/https://ci.nodejs.org/job/node-test-pull-request/17807/
Please reload this pagehttps://github.com/nodejs/node/pull/23630
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 13, 2018 https://github.com/nodejs/node/pull/23630#pullrequestreview-164455651
View reviewed changes https://github.com/nodejs/node/pull/23630/files/ea510a681ea2d24a066effcb5106129a994e0882
https://github.com/targos
targoshttps://github.com/targos
force-pushedhttps://github.com/nodejs/node/compare/7c9b37e2eb17535fb906c546a4ded9dda1143f4b..8def0379b73cb993fbf4bb92618cf1db0a7dedff
7c9b37ehttps://github.com/nodejs/node/commit/7c9b37e2eb17535fb906c546a4ded9dda1143f4b
8def037https://github.com/nodejs/node/commit/8def0379b73cb993fbf4bb92618cf1db0a7dedff
Compare https://github.com/nodejs/node/compare/7c9b37e2eb17535fb906c546a4ded9dda1143f4b..8def0379b73cb993fbf4bb92618cf1db0a7dedff
October 13, 2018 14:14https://github.com/nodejs/node/pull/23630#event-1902180989
targoshttps://github.com/targos
Oct 13, 2018 https://github.com/nodejs/node/pull/23630#ref-commit-bb4da05
https://github.com/Trott
https://github.com/targos
test: refactor common.ddCommand()https://github.com/nodejs/node/commit/bb4da056cf32f1c0d99638f61982feb366b8cb0c
bb4da05https://github.com/nodejs/node/commit/bb4da056cf32f1c0d99638f61982feb366b8cb0c
#23630https://github.com/nodejs/node/pull/23630
#23411https://github.com/nodejs/node/pull/23411
targoshttps://github.com/targos
Oct 13, 2018 https://github.com/nodejs/node/pull/23630#ref-commit-8def037
https://github.com/Trott
https://github.com/targos
test: rename common.ddCommand()https://github.com/nodejs/node/commit/8def0379b73cb993fbf4bb92618cf1db0a7dedff
8def037https://github.com/nodejs/node/commit/8def0379b73cb993fbf4bb92618cf1db0a7dedff
#23630https://github.com/nodejs/node/pull/23630
#23411https://github.com/nodejs/node/pull/23411
https://github.com/targos
targoshttps://github.com/targos
Oct 13, 2018https://github.com/nodejs/node/pull/23630#issuecomment-429545583
bb4da05https://github.com/nodejs/node/commit/bb4da056cf32f1c0d99638f61982feb366b8cb0c
8def037https://github.com/nodejs/node/commit/8def0379b73cb993fbf4bb92618cf1db0a7dedff
Please reload this pagehttps://github.com/nodejs/node/pull/23630
https://github.com/targos
targoshttps://github.com/targos
Oct 13, 2018https://github.com/nodejs/node/pull/23630#event-1902181231
MylesBorinshttps://github.com/MylesBorins
Oct 30, 2018 https://github.com/nodejs/node/pull/23630#ref-commit-2f84a18
https://github.com/Trott
https://github.com/MylesBorins
test: refactor common.ddCommand()https://github.com/nodejs/node/commit/2f84a189c73e00983f6d350f6f7b105cc5a22c04
2f84a18https://github.com/nodejs/node/commit/2f84a189c73e00983f6d350f6f7b105cc5a22c04
#23630https://github.com/nodejs/node/pull/23630
#23411https://github.com/nodejs/node/pull/23411
MylesBorinshttps://github.com/MylesBorins
Oct 30, 2018 https://github.com/nodejs/node/pull/23630#ref-commit-2d32922
https://github.com/Trott
https://github.com/MylesBorins
test: rename common.ddCommand()https://github.com/nodejs/node/commit/2d3292225f653a8133b296b69005856cbeb64b8b
2d32922https://github.com/nodejs/node/commit/2d3292225f653a8133b296b69005856cbeb64b8b
#23630https://github.com/nodejs/node/pull/23630
#23411https://github.com/nodejs/node/pull/23411
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23630#ref-commit-1a810b1
https://github.com/Trott
https://github.com/rvagg
test: refactor common.ddCommand()https://github.com/nodejs/node/commit/1a810b1922dc9a14fabb169f829969310fd43cb0
1a810b1https://github.com/nodejs/node/commit/1a810b1922dc9a14fabb169f829969310fd43cb0
#23630https://github.com/nodejs/node/pull/23630
#23411https://github.com/nodejs/node/pull/23411
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23630#ref-commit-43b426f
https://github.com/Trott
https://github.com/rvagg
test: rename common.ddCommand()https://github.com/nodejs/node/commit/43b426f68dcd8e58bf5f3c6361ae7c71c98db802
43b426fhttps://github.com/nodejs/node/commit/43b426f68dcd8e58bf5f3c6361ae7c71c98db802
#23630https://github.com/nodejs/node/pull/23630
#23411https://github.com/nodejs/node/pull/23411
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23630#ref-commit-1cdfd1a
https://github.com/Trott
https://github.com/MylesBorins
test: refactor common.ddCommand()https://github.com/nodejs/node/commit/1cdfd1ae03091701409154df80b1a6e82d81a3e6
1cdfd1ahttps://github.com/nodejs/node/commit/1cdfd1ae03091701409154df80b1a6e82d81a3e6
#23630https://github.com/nodejs/node/pull/23630
#23411https://github.com/nodejs/node/pull/23411
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23630#ref-commit-9003c74
https://github.com/Trott
https://github.com/MylesBorins
test: rename common.ddCommand()https://github.com/nodejs/node/commit/9003c74f16c67b0d521e8ee7004941c307ef527d
9003c74https://github.com/nodejs/node/commit/9003c74f16c67b0d521e8ee7004941c307ef527d
#23630https://github.com/nodejs/node/pull/23630
#23411https://github.com/nodejs/node/pull/23411
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:50https://github.com/nodejs/node/pull/23630#event-5890969204
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23630
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23630/files/89b0fd16a477806cca409f0fcf8f4333d83db685
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/23630/files/89b0fd16a477806cca409f0fcf8f4333d83db685
https://github.com/thefourtheye
thefourtheye https://github.com/thefourtheye
https://github.com/nodejs/node/pull/23630/files/ea510a681ea2d24a066effcb5106129a994e0882
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/23630
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/targos
https://github.com/thefourtheye
https://github.com/addaleax
https://github.com/oyyd
https://github.com/dyatlov
https://github.com/sagitsofan
https://github.com/gireeshpunathil
https://github.com/tniessen
https://github.com/joesepi
https://github.com/et4891
https://github.com/lundibundi
https://github.com/sam-github
https://github.com/starkwang
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.