| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bb8f757b-85ba-af93-a190-e2abd2d107e1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BC42:28B211:C9AA57:1045F35:6990BDAA |
| html-safe-nonce | 9d7155ff190c99ef488f657f373ce29b8e44db5c4caf7a08a0064013416ac2c1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzQyOjI4QjIxMTpDOUFBNTc6MTA0NUYzNTo2OTkwQkRBQSIsInZpc2l0b3JfaWQiOiI3NzA2Mzc1MTgwMDYzMzkxMTQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2cc8877a8e3c5a8b4073388b2f943893781539d38fb6d695d90291f26835ac8f |
| hovercard-subject-tag | pull_request:222603887 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23630/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b1013c957ae85669fd4b727bc533ed868e62f81f42977ac3d21147439319927b/nodejs/node/pull/23630 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b1013c957ae85669fd4b727bc533ed868e62f81f42977ac3d21147439319927b/nodejs/node/pull/23630 |
| og:image:alt | backport of #23411
@addaleax |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23630#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23630 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23630 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23630 |
| Reload | https://github.com/nodejs/node/pull/23630 |
| Reload | https://github.com/nodejs/node/pull/23630 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23630 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
705
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| Trott:backport-23411 | https://github.com/Trott/io.js/tree/backport-23411 |
| Conversation | https://github.com/nodejs/node/pull/23630 |
| Commits16 (16) | https://github.com/nodejs/node/pull/23630/commits |
| Checks | https://github.com/nodejs/node/pull/23630/checks |
| Files changed | https://github.com/nodejs/node/pull/23630/files |
| [v10.x backport] test: refactor common.ddCommand() | https://github.com/nodejs/node/pull/23630#top |
| Trott | https://github.com/Trott |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| Trott:backport-23411 | https://github.com/Trott/io.js/tree/backport-23411 |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23630#issue-369733562 |
| #23411 | https://github.com/nodejs/node/pull/23411 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/23630 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23630#issuecomment-429482338 |
| @Trott | https://github.com/Trott |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1219/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1219/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/23630 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23630#event-1901835800 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23630#ref-pullrequest-368793615 |
|
test: refactor common.ddCommand()
#23411
| https://github.com/nodejs/node/pull/23411 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23630#pullrequestreview-164431178 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23630/files |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23630#pullrequestreview-164444264 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23630/files |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23630#issuecomment-429497626 |
| https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/6096/console | https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/6096/console |
| Please reload this page | https://github.com/nodejs/node/pull/23630 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23630#ref-issue-369753072 |
|
Failing test on v10.x-staging
#23633
| https://github.com/nodejs/node/issues/23633 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23630#issuecomment-429499586 |
| #23633 | https://github.com/nodejs/node/issues/23633 |
| Please reload this page | https://github.com/nodejs/node/pull/23630 |
| oyyd | https://github.com/oyyd |
| October 12, 2018 20:14 | https://github.com/nodejs/node/pull/23630#commits-pushed-6d151ad |
|
| https://github.com/oyyd |
|
| https://github.com/Trott |
| tls: make StreamWrap work correctly in "drain" callback | https://github.com/nodejs/node/pull/23630/commits/6d151ad89f9cf0d3783f16817a71513969065471 |
| 6d151ad | https://github.com/nodejs/node/pull/23630/commits/6d151ad89f9cf0d3783f16817a71513969065471 |
| nodejs#23294 | https://github.com/nodejs/node/pull/23294 |
|
| https://github.com/dyatlov |
|
| https://github.com/Trott |
| src: revert removal of SecureContext _external getter | https://github.com/nodejs/node/pull/23630/commits/f2b473452435b9316db7fa9d618e4c1f214dc9cb |
| f2b4734 | https://github.com/nodejs/node/pull/23630/commits/f2b473452435b9316db7fa9d618e4c1f214dc9cb |
| nodejs#21711 | https://github.com/nodejs/node/pull/21711 |
|
| https://github.com/sagitsofan |
|
| https://github.com/Trott |
| lib: http server, friendly error messages | https://github.com/nodejs/node/pull/23630/commits/ad59bbdb736e3000f518949d991d707d4d1698d5 |
| ad59bbd | https://github.com/nodejs/node/pull/23630/commits/ad59bbdb736e3000f518949d991d707d4d1698d5 |
| nodejs#22936 | https://github.com/nodejs/node/issues/22936 |
| nodejs#22995 | https://github.com/nodejs/node/pull/22995 |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/Trott |
| src: improve SSL version extraction logic | https://github.com/nodejs/node/pull/23630/commits/736d6d1682405653733d84c594f0c2930bf07aff |
| 736d6d1 | https://github.com/nodejs/node/pull/23630/commits/736d6d1682405653733d84c594f0c2930bf07aff |
| nodejs#23050 | https://github.com/nodejs/node/pull/23050 |
|
| https://github.com/tniessen |
|
| https://github.com/Trott |
| src: fix bug in MallocedBuffer constructor | https://github.com/nodejs/node/pull/23630/commits/2218a38f62505f2216d9929b21b4a2a15a2be527 |
| 2218a38 | https://github.com/nodejs/node/pull/23630/commits/2218a38f62505f2216d9929b21b4a2a15a2be527 |
| nodejs#23434 | https://github.com/nodejs/node/pull/23434 |
|
| https://github.com/Trott |
| doc: revise security-reporting text in README | https://github.com/nodejs/node/pull/23630/commits/4b0c0f19e4222f00734fff656c80a384460244a9 |
| 4b0c0f1 | https://github.com/nodejs/node/pull/23630/commits/4b0c0f19e4222f00734fff656c80a384460244a9 |
| nodejs#23407 | https://github.com/nodejs/node/pull/23407 |
|
| https://github.com/joesepi |
|
| https://github.com/Trott |
| test: fixing assertion value order | https://github.com/nodejs/node/pull/23630/commits/f6a2af587a4e81274e0b3c8fe000e2d231d833ee |
| f6a2af5 | https://github.com/nodejs/node/pull/23630/commits/f6a2af587a4e81274e0b3c8fe000e2d231d833ee |
| nodejs#23574 | https://github.com/nodejs/node/pull/23574 |
|
| https://github.com/et4891 |
|
| https://github.com/Trott |
| test: fix assert.strictEqual argument order | https://github.com/nodejs/node/pull/23630/commits/4089a553c062812d4a96b0f5ce95a8700da54919 |
| 4089a55 | https://github.com/nodejs/node/pull/23630/commits/4089a553c062812d4a96b0f5ce95a8700da54919 |
| nodejs#23518 | https://github.com/nodejs/node/pull/23518 |
|
| https://github.com/lundibundi |
|
| https://github.com/Trott |
| test: improve test-gc-http-client-connaborted | https://github.com/nodejs/node/pull/23630/commits/584470c0b89f276e6b8de603bf9d1887e2acc9f3 |
| 584470c | https://github.com/nodejs/node/pull/23630/commits/584470c0b89f276e6b8de603bf9d1887e2acc9f3 |
| nodejs#23193 | https://github.com/nodejs/node/pull/23193 |
|
| https://github.com/lundibundi |
|
| https://github.com/Trott |
| test: improve test-gc-http-client-onerror | https://github.com/nodejs/node/pull/23630/commits/0d7328d954cbac20fa68ecd78fc645e62cc6c922 |
| 0d7328d | https://github.com/nodejs/node/pull/23630/commits/0d7328d954cbac20fa68ecd78fc645e62cc6c922 |
| nodejs#23196 | https://github.com/nodejs/node/pull/23196 |
|
| https://github.com/addaleax |
|
| https://github.com/Trott |
| test: move some gc tests back to parallel/, unmark flaky | https://github.com/nodejs/node/pull/23630/commits/35f9218b6def0808826ea412460d8bce5b00495d |
| 35f9218 | https://github.com/nodejs/node/pull/23630/commits/35f9218b6def0808826ea412460d8bce5b00495d |
| nodejs#23336 | https://github.com/nodejs/node/pull/23336 |
| nodejs#23356 | https://github.com/nodejs/node/pull/23356 |
|
| https://github.com/addaleax |
|
| https://github.com/Trott |
| zlib: generate error code names in C++ | https://github.com/nodejs/node/pull/23630/commits/e86b6aa9ed49348176be9f685ae617f39daf6b7d |
| e86b6aa | https://github.com/nodejs/node/pull/23630/commits/e86b6aa9ed49348176be9f685ae617f39daf6b7d |
| nodejs#23413 | https://github.com/nodejs/node/pull/23413 |
|
| https://github.com/sam-github |
|
| https://github.com/Trott |
| doc: describe SNI host name format | https://github.com/nodejs/node/pull/23630/commits/3a533d6755f7451cb90d892689ecb0f9c49a936e |
| 3a533d6 | https://github.com/nodejs/node/pull/23630/commits/3a533d6755f7451cb90d892689ecb0f9c49a936e |
| nodejs#23329 | https://github.com/nodejs/node/pull/23329 |
| nodejs#23357 | https://github.com/nodejs/node/pull/23357 |
| nodejs#23329 | https://github.com/nodejs/node/pull/23329 |
|
| https://github.com/starkwang |
|
| https://github.com/Trott |
| http: reduce duplicated code for cleaning parser | https://github.com/nodejs/node/pull/23630/commits/7c9b37e2eb17535fb906c546a4ded9dda1143f4b |
| 7c9b37e | https://github.com/nodejs/node/pull/23630/commits/7c9b37e2eb17535fb906c546a4ded9dda1143f4b |
| nodejs#23351 | https://github.com/nodejs/node/pull/23351 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/2d4d546bcb2a896b9771753f90e1dacb2e706d0b..7c9b37e2eb17535fb906c546a4ded9dda1143f4b |
| 2d4d546 | https://github.com/nodejs/node/commit/2d4d546bcb2a896b9771753f90e1dacb2e706d0b |
| 7c9b37e | https://github.com/nodejs/node/commit/7c9b37e2eb17535fb906c546a4ded9dda1143f4b |
|
Compare
| https://github.com/nodejs/node/compare/2d4d546bcb2a896b9771753f90e1dacb2e706d0b..7c9b37e2eb17535fb906c546a4ded9dda1143f4b |
| October 13, 2018 03:15 | https://github.com/nodejs/node/pull/23630#event-1901984592 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23630#issuecomment-429506718 |
| #23633 | https://github.com/nodejs/node/issues/23633 |
| https://ci.nodejs.org/job/node-test-pull-request/17794 | https://ci.nodejs.org/job/node-test-pull-request/1%E2%80%8B77%E2%80%8B94 |
| Please reload this page | https://github.com/nodejs/node/pull/23630 |
| Trott | https://github.com/Trott |
| October 12, 2018 20:18 | https://github.com/nodejs/node/pull/23630#commits-pushed-79a2b00 |
|
| https://github.com/Trott |
| test: refactor common.ddCommand() | https://github.com/nodejs/node/pull/23630/commits/79a2b005b3acf642bab09e65d5b59790782342d7 |
| 79a2b00 | https://github.com/nodejs/node/pull/23630/commits/79a2b005b3acf642bab09e65d5b59790782342d7 |
| nodejs#23411 | https://github.com/nodejs/node/pull/23411 |
|
| https://github.com/Trott |
| test: rename common.ddCommand() | https://github.com/nodejs/node/pull/23630/commits/ea510a681ea2d24a066effcb5106129a994e0882 |
| ea510a6 | https://github.com/nodejs/node/pull/23630/commits/ea510a681ea2d24a066effcb5106129a994e0882 |
| nodejs#23411 | https://github.com/nodejs/node/pull/23411 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/89b0fd16a477806cca409f0fcf8f4333d83db685..ea510a681ea2d24a066effcb5106129a994e0882 |
| 89b0fd1 | https://github.com/nodejs/node/commit/89b0fd16a477806cca409f0fcf8f4333d83db685 |
| ea510a6 | https://github.com/nodejs/node/commit/ea510a681ea2d24a066effcb5106129a994e0882 |
|
Compare
| https://github.com/nodejs/node/compare/89b0fd16a477806cca409f0fcf8f4333d83db685..ea510a681ea2d24a066effcb5106129a994e0882 |
| October 13, 2018 03:18 | https://github.com/nodejs/node/pull/23630#event-1901985582 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23630#issuecomment-429514394 |
| Please reload this page | https://github.com/nodejs/node/pull/23630 |
| https://ci.nodejs.org/job/node-test-pull-request/17807/ | https://ci.nodejs.org/job/node-test-pull-request/17807/ |
| Please reload this page | https://github.com/nodejs/node/pull/23630 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23630#pullrequestreview-164455651 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23630/files/ea510a681ea2d24a066effcb5106129a994e0882 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/7c9b37e2eb17535fb906c546a4ded9dda1143f4b..8def0379b73cb993fbf4bb92618cf1db0a7dedff |
| 7c9b37e | https://github.com/nodejs/node/commit/7c9b37e2eb17535fb906c546a4ded9dda1143f4b |
| 8def037 | https://github.com/nodejs/node/commit/8def0379b73cb993fbf4bb92618cf1db0a7dedff |
|
Compare
| https://github.com/nodejs/node/compare/7c9b37e2eb17535fb906c546a4ded9dda1143f4b..8def0379b73cb993fbf4bb92618cf1db0a7dedff |
| October 13, 2018 14:14 | https://github.com/nodejs/node/pull/23630#event-1902180989 |
| targos | https://github.com/targos |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23630#ref-commit-bb4da05 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: refactor common.ddCommand() | https://github.com/nodejs/node/commit/bb4da056cf32f1c0d99638f61982feb366b8cb0c |
| bb4da05 | https://github.com/nodejs/node/commit/bb4da056cf32f1c0d99638f61982feb366b8cb0c |
| #23630 | https://github.com/nodejs/node/pull/23630 |
| #23411 | https://github.com/nodejs/node/pull/23411 |
| targos | https://github.com/targos |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23630#ref-commit-8def037 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: rename common.ddCommand() | https://github.com/nodejs/node/commit/8def0379b73cb993fbf4bb92618cf1db0a7dedff |
| 8def037 | https://github.com/nodejs/node/commit/8def0379b73cb993fbf4bb92618cf1db0a7dedff |
| #23630 | https://github.com/nodejs/node/pull/23630 |
| #23411 | https://github.com/nodejs/node/pull/23411 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23630#issuecomment-429545583 |
| bb4da05 | https://github.com/nodejs/node/commit/bb4da056cf32f1c0d99638f61982feb366b8cb0c |
| 8def037 | https://github.com/nodejs/node/commit/8def0379b73cb993fbf4bb92618cf1db0a7dedff |
| Please reload this page | https://github.com/nodejs/node/pull/23630 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23630#event-1902181231 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23630#ref-commit-2f84a18 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: refactor common.ddCommand() | https://github.com/nodejs/node/commit/2f84a189c73e00983f6d350f6f7b105cc5a22c04 |
| 2f84a18 | https://github.com/nodejs/node/commit/2f84a189c73e00983f6d350f6f7b105cc5a22c04 |
| #23630 | https://github.com/nodejs/node/pull/23630 |
| #23411 | https://github.com/nodejs/node/pull/23411 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23630#ref-commit-2d32922 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: rename common.ddCommand() | https://github.com/nodejs/node/commit/2d3292225f653a8133b296b69005856cbeb64b8b |
| 2d32922 | https://github.com/nodejs/node/commit/2d3292225f653a8133b296b69005856cbeb64b8b |
| #23630 | https://github.com/nodejs/node/pull/23630 |
| #23411 | https://github.com/nodejs/node/pull/23411 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23630#ref-commit-1a810b1 |
|
| https://github.com/Trott |
|
| https://github.com/rvagg |
| test: refactor common.ddCommand() | https://github.com/nodejs/node/commit/1a810b1922dc9a14fabb169f829969310fd43cb0 |
| 1a810b1 | https://github.com/nodejs/node/commit/1a810b1922dc9a14fabb169f829969310fd43cb0 |
| #23630 | https://github.com/nodejs/node/pull/23630 |
| #23411 | https://github.com/nodejs/node/pull/23411 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23630#ref-commit-43b426f |
|
| https://github.com/Trott |
|
| https://github.com/rvagg |
| test: rename common.ddCommand() | https://github.com/nodejs/node/commit/43b426f68dcd8e58bf5f3c6361ae7c71c98db802 |
| 43b426f | https://github.com/nodejs/node/commit/43b426f68dcd8e58bf5f3c6361ae7c71c98db802 |
| #23630 | https://github.com/nodejs/node/pull/23630 |
| #23411 | https://github.com/nodejs/node/pull/23411 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23630#ref-commit-1cdfd1a |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: refactor common.ddCommand() | https://github.com/nodejs/node/commit/1cdfd1ae03091701409154df80b1a6e82d81a3e6 |
| 1cdfd1a | https://github.com/nodejs/node/commit/1cdfd1ae03091701409154df80b1a6e82d81a3e6 |
| #23630 | https://github.com/nodejs/node/pull/23630 |
| #23411 | https://github.com/nodejs/node/pull/23411 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23630#ref-commit-9003c74 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: rename common.ddCommand() | https://github.com/nodejs/node/commit/9003c74f16c67b0d521e8ee7004941c307ef527d |
| 9003c74 | https://github.com/nodejs/node/commit/9003c74f16c67b0d521e8ee7004941c307ef527d |
| #23630 | https://github.com/nodejs/node/pull/23630 |
| #23411 | https://github.com/nodejs/node/pull/23411 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:50 | https://github.com/nodejs/node/pull/23630#event-5890969204 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23630 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/23630/files/89b0fd16a477806cca409f0fcf8f4333d83db685 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/23630/files/89b0fd16a477806cca409f0fcf8f4333d83db685 |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/23630/files/ea510a681ea2d24a066effcb5106129a994e0882 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/23630 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/richardlau |
|
| https://github.com/targos |
|
| https://github.com/thefourtheye |
|
| https://github.com/addaleax |
|
| https://github.com/oyyd |
|
| https://github.com/dyatlov |
|
| https://github.com/sagitsofan |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/tniessen |
|
| https://github.com/joesepi |
|
| https://github.com/et4891 |
|
| https://github.com/lundibundi |
|
| https://github.com/sam-github |
|
| https://github.com/starkwang |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |