René's URL Explorer Experiment


Title: test: correct order of assert args in client response domain test by sheminusminus · Pull Request #23604 · nodejs/node · GitHub

Open Graph Title: test: correct order of assert args in client response domain test by sheminusminus · Pull Request #23604 · nodejs/node

X Title: test: correct order of assert args in client response domain test by sheminusminus · Pull Request #23604 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/23604

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:05f0ee25-d285-1d27-d5b2-62c1a664dff7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEDC8:1FD20B:7CAC82:9EA64A:69914B84
html-safe-nonce866001dac986700a6fde537120db9f92752d86d219ae3bc8ab733b68b5817187
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFREM4OjFGRDIwQjo3Q0FDODI6OUVBNjRBOjY5OTE0Qjg0IiwidmlzaXRvcl9pZCI6IjUxMzc0Mjg4NDgwMjgyNDA3NzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace0c2a5d9e214345d83b233d6422afc3d7deb119ab8ad4cac9a1479a0b0f11765
hovercard-subject-tagpull_request:222552604
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23604/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3a1ff5432aa7cb96a281096509b767254f84f2c95531b4fa1fd54b7edfa26d73/nodejs/node/pull/23604
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3a1ff5432aa7cb96a281096509b767254f84f2c95531b4fa1fd54b7edfa26d73/nodejs/node/pull/23604
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesheminusminus
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23604#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23604
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23604
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23604
Reloadhttps://github.com/nodejs/node/pull/23604
Reloadhttps://github.com/nodejs/node/pull/23604
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23604
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
sheminusminushttps://github.com/sheminusminus
nodejs:masterhttps://github.com/nodejs/node/tree/master
sheminusminus:swap-asserts-resp-domainhttps://github.com/sheminusminus/node/tree/swap-asserts-resp-domain
Conversationhttps://github.com/nodejs/node/pull/23604
Commits2 (2)https://github.com/nodejs/node/pull/23604/commits
Checkshttps://github.com/nodejs/node/pull/23604/checks
Files changedhttps://github.com/nodejs/node/pull/23604/files
test: correct order of assert args in client response domain testhttps://github.com/nodejs/node/pull/23604#top
sheminusminushttps://github.com/sheminusminus
nodejs:masterhttps://github.com/nodejs/node/tree/master
sheminusminus:swap-asserts-resp-domainhttps://github.com/sheminusminus/node/tree/swap-asserts-resp-domain
https://github.com/sheminusminus
sheminusminushttps://github.com/sheminusminus
Oct 12, 2018https://github.com/nodejs/node/pull/23604#issue-369665873
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23604
https://github.com/sheminusminus
test: correct order of assert args in client response domain testhttps://github.com/nodejs/node/pull/23604/commits/e5244e5dbc37144d724eeee3bde2a844625c9664
e5244e5https://github.com/nodejs/node/pull/23604/commits/e5244e5dbc37144d724eeee3bde2a844625c9664
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Oct 12, 2018https://github.com/nodejs/node/pull/23604#event-1901430154
https://github.com/jasnell
jasnellhttps://github.com/jasnell
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Oct 12, 2018https://github.com/nodejs/node/pull/23604#event-1901434951
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 12, 2018 https://github.com/nodejs/node/pull/23604#pullrequestreview-164364652
View reviewed changes https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 12, 2018 https://github.com/nodejs/node/pull/23604#pullrequestreview-164393988
View reviewed changes https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Oct 12, 2018https://github.com/nodejs/node/pull/23604#event-1901614314
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 12, 2018 https://github.com/nodejs/node/pull/23604#pullrequestreview-164398264
View reviewed changes https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 13, 2018 https://github.com/nodejs/node/pull/23604#pullrequestreview-164444621
View reviewed changes https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Oct 13, 2018 https://github.com/nodejs/node/pull/23604#pullrequestreview-164451222
View reviewed changes https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Oct 13, 2018 https://github.com/nodejs/node/pull/23604#pullrequestreview-164451258
View reviewed changes https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
test/parallel/test-http-client-response-domain.jshttps://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664#diff-d48ac429eb2c0324f67e1479a29e41bf58eb707e43c56a40bb318d206f778003
gireeshpunathilhttps://github.com/gireeshpunathil
Oct 13, 2018https://github.com/nodejs/node/pull/23604#discussion_r224949629
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@sheminusminushttps://github.com/sheminusminus
Please reload this pagehttps://github.com/nodejs/node/pull/23604
sheminusminushttps://github.com/sheminusminus
Oct 14, 2018https://github.com/nodejs/node/pull/23604#discussion_r224991205
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@gireeshpunathilhttps://github.com/gireeshpunathil
Please reload this pagehttps://github.com/nodejs/node/pull/23604
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 13, 2018 https://github.com/nodejs/node/pull/23604#pullrequestreview-164457147
View reviewed changes https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
https://github.com/ameriania
amerianiahttps://github.com/ameriania
Oct 13, 2018 https://github.com/nodejs/node/pull/23604#pullrequestreview-164458016
View reviewed changes https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
https://github.com/sheminusminus
replace onerror callback with arrow functionhttps://github.com/nodejs/node/pull/23604/commits/8f4353e151ee6bc172cc1b5a1803e9ec34ef17b4
8f4353ehttps://github.com/nodejs/node/pull/23604/commits/8f4353e151ee6bc172cc1b5a1803e9ec34ef17b4
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018 https://github.com/nodejs/node/pull/23604#ref-commit-afbd48c
https://github.com/sheminusminus
https://github.com/BridgeAR
test: fix order of assert args in client response domain testhttps://github.com/BridgeAR/node/commit/afbd48cb55b3d606a962eef97fb9db0e77071a67
afbd48chttps://github.com/BridgeAR/node/commit/afbd48cb55b3d606a962eef97fb9db0e77071a67
nodejs#23604https://github.com/nodejs/node/pull/23604
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018 https://github.com/nodejs/node/pull/23604#ref-commit-febb765
https://github.com/sheminusminus
https://github.com/BridgeAR
test: fix order of assert args in client response domain testhttps://github.com/BridgeAR/node/commit/febb7656e3dc336952319f91b02efbc898b9c65a
febb765https://github.com/BridgeAR/node/commit/febb7656e3dc336952319f91b02efbc898b9c65a
nodejs#23604https://github.com/nodejs/node/pull/23604
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018https://github.com/nodejs/node/pull/23604#issuecomment-429857630
febb765https://github.com/nodejs/node/commit/febb7656e3dc336952319f91b02efbc898b9c65a
@sheminusminushttps://github.com/sheminusminus
Please reload this pagehttps://github.com/nodejs/node/pull/23604
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018https://github.com/nodejs/node/pull/23604#event-1904127226
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23604#ref-commit-d778f9e
https://github.com/sheminusminus
https://github.com/jasnell
test: fix order of assert args in client response domain testhttps://github.com/nodejs/node/commit/d778f9e1f0404f91c950404c4d01dcc3e46720ba
d778f9ehttps://github.com/nodejs/node/commit/d778f9e1f0404f91c950404c4d01dcc3e46720ba
#23604https://github.com/nodejs/node/pull/23604
addaleaxhttps://github.com/addaleax
Oct 20, 2018 https://github.com/nodejs/node/pull/23604#ref-commit-f80d915
https://github.com/sheminusminus
https://github.com/addaleax
test: fix order of assert args in client response domain testhttps://github.com/nodejs/node/commit/f80d915333cf73ee29dd7532e1ca7b06321b0ae4
f80d915https://github.com/nodejs/node/commit/f80d915333cf73ee29dd7532e1ca7b06321b0ae4
#23604https://github.com/nodejs/node/pull/23604
MylesBorinshttps://github.com/MylesBorins
Oct 30, 2018 https://github.com/nodejs/node/pull/23604#ref-commit-af6528a
https://github.com/sheminusminus
https://github.com/MylesBorins
test: fix order of assert args in client response domain testhttps://github.com/nodejs/node/commit/af6528ab85b55474e6d1240b3696ac9c3705b755
af6528ahttps://github.com/nodejs/node/commit/af6528ab85b55474e6d1240b3696ac9c3705b755
#23604https://github.com/nodejs/node/pull/23604
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23604#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23604#ref-commit-66b7775
https://github.com/sheminusminus
https://github.com/rvagg
test: fix order of assert args in client response domain testhttps://github.com/nodejs/node/commit/66b7775c5105451f869ac709ed366dd575a1f685
66b7775https://github.com/nodejs/node/commit/66b7775c5105451f869ac709ed366dd575a1f685
#23604https://github.com/nodejs/node/pull/23604
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23604#ref-commit-591af98
https://github.com/sheminusminus
https://github.com/MylesBorins
test: fix order of assert args in client response domain testhttps://github.com/nodejs/node/commit/591af98268888e11779c393cf136cc09eeb967a2
591af98https://github.com/nodejs/node/commit/591af98268888e11779c393cf136cc09eeb967a2
#23604https://github.com/nodejs/node/pull/23604
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23604#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23604
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
https://github.com/thefourtheye
thefourtheye https://github.com/thefourtheye
https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
https://github.com/ameriania
ameriania https://github.com/ameriania
https://github.com/nodejs/node/pull/23604/files/e5244e5dbc37144d724eeee3bde2a844625c9664
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/23604
https://github.com/sheminusminus
https://github.com/BridgeAR
https://github.com/jasnell
https://github.com/thefourtheye
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/gireeshpunathil
https://github.com/ameriania
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.