René's URL Explorer Experiment


Title: test: Covering the case when fs-read get invalid argument for file ha… by leomoreno · Pull Request #23601 · nodejs/node · GitHub

Open Graph Title: test: Covering the case when fs-read get invalid argument for file ha… by leomoreno · Pull Request #23601 · nodejs/node

X Title: test: Covering the case when fs-read get invalid argument for file ha… by leomoreno · Pull Request #23601 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: fs read checks that first parameter is a valid FileHandle object. Here we are wrapping that case with test. [ X ] make -j4 test (UNIX), or vcbuild test (Windows) passes [ X ] tests and/or benchmar...

X Description: fs read checks that first parameter is a valid FileHandle object. Here we are wrapping that case with test. [ X ] make -j4 test (UNIX), or vcbuild test (Windows) passes [ X ] tests and/or benchmar...

Opengraph URL: https://github.com/nodejs/node/pull/23601

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:03946f41-c99e-ecf6-eaac-a7d5779798a3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B6A:C4F19:1114B90:159D671:69902A69
html-safe-nonce7c01526bac26841d37cc33573097f0fb918137f9fdfdab9ed8cf321908e471ff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjZBOkM0RjE5OjExMTRCOTA6MTU5RDY3MTo2OTkwMkE2OSIsInZpc2l0b3JfaWQiOiI0NTU4MTQ3MDAyMjkwOTQwNTIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac301943f96adf914ca1ca5e69a45016ae0bbf7010bdf606337dc8813249616265
hovercard-subject-tagpull_request:222552003
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23601/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0ec1218a2810fe46390be2f9fa8fa7383826235f33e1f5cd1e098e5898cd8edf/nodejs/node/pull/23601
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0ec1218a2810fe46390be2f9fa8fa7383826235f33e1f5cd1e098e5898cd8edf/nodejs/node/pull/23601
og:image:altfs read checks that first parameter is a valid FileHandle object. Here we are wrapping that case with test. [ X ] make -j4 test (UNIX), or vcbuild test (Windows) passes [ X ] tests and/or benchmar...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameleomoreno
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23601#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23601
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23601
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23601
Reloadhttps://github.com/nodejs/node/pull/23601
Reloadhttps://github.com/nodejs/node/pull/23601
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23601
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
leomorenohttps://github.com/leomoreno
nodejs:masterhttps://github.com/nodejs/node/tree/master
leomoreno:coverage-fd-invalid-arg-typehttps://github.com/leomoreno/node-1/tree/coverage-fd-invalid-arg-type
Conversationhttps://github.com/nodejs/node/pull/23601
Commits1 (1)https://github.com/nodejs/node/pull/23601/commits
Checkshttps://github.com/nodejs/node/pull/23601/checks
Files changedhttps://github.com/nodejs/node/pull/23601/files
test: Covering the case when fs-read get invalid argument for file ha…https://github.com/nodejs/node/pull/23601#top
leomorenohttps://github.com/leomoreno
nodejs:masterhttps://github.com/nodejs/node/tree/master
leomoreno:coverage-fd-invalid-arg-typehttps://github.com/leomoreno/node-1/tree/coverage-fd-invalid-arg-type
https://github.com/leomoreno
leomorenohttps://github.com/leomoreno
Oct 12, 2018https://github.com/nodejs/node/pull/23601#issue-369664972
Please reload this pagehttps://github.com/nodejs/node/pull/23601
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Oct 12, 2018https://github.com/nodejs/node/pull/23601#event-1901425679
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 12, 2018 https://github.com/nodejs/node/pull/23601#pullrequestreview-164364341
View reviewed changes https://github.com/nodejs/node/pull/23601/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 12, 2018 https://github.com/nodejs/node/pull/23601#pullrequestreview-164365680
View reviewed changes https://github.com/nodejs/node/pull/23601/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Oct 12, 2018https://github.com/nodejs/node/pull/23601#event-1901441392
https://github.com/jasnell
jasnellhttps://github.com/jasnell
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Oct 12, 2018https://github.com/nodejs/node/pull/23601#event-1901441483
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 12, 2018https://github.com/nodejs/node/pull/23601#issuecomment-429449821
https://ci.nodejs.org/job/node-test-pull-request/17760/https://ci.nodejs.org/job/node-test-pull-request/17760/
Please reload this pagehttps://github.com/nodejs/node/pull/23601
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 12, 2018https://github.com/nodejs/node/pull/23601#event-1901612763
https://github.com/leomoreno
test: improve test coverage for fs modulehttps://github.com/nodejs/node/pull/23601/commits/36e9adab62cc30e89d98b96fd9cca7baa32155b0
36e9adahttps://github.com/nodejs/node/pull/23601/commits/36e9adab62cc30e89d98b96fd9cca7baa32155b0
https://github.com/leomoreno
leomorenohttps://github.com/leomoreno
force-pushedhttps://github.com/nodejs/node/compare/4f173464b55a5f886544ef72b47b77a90b612b21..36e9adab62cc30e89d98b96fd9cca7baa32155b0
4f17346https://github.com/nodejs/node/commit/4f173464b55a5f886544ef72b47b77a90b612b21
36e9adahttps://github.com/nodejs/node/commit/36e9adab62cc30e89d98b96fd9cca7baa32155b0
Compare https://github.com/nodejs/node/compare/4f173464b55a5f886544ef72b47b77a90b612b21..36e9adab62cc30e89d98b96fd9cca7baa32155b0
October 12, 2018 20:21https://github.com/nodejs/node/pull/23601#event-1901623625
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 12, 2018 https://github.com/nodejs/node/pull/23601#pullrequestreview-164400098
View reviewed changes https://github.com/nodejs/node/pull/23601/files/36e9adab62cc30e89d98b96fd9cca7baa32155b0
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 12, 2018https://github.com/nodejs/node/pull/23601#issuecomment-429482581
Please reload this pagehttps://github.com/nodejs/node/pull/23601
https://github.com/Trott
Trotthttps://github.com/Trott
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Oct 12, 2018https://github.com/nodejs/node/pull/23601#event-1901837533
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 12, 2018https://github.com/nodejs/node/pull/23601#issuecomment-429487994
https://ci.nodejs.org/job/node-test-pull-request/17782/https://ci.nodejs.org/job/node-test-pull-request/17782/
Please reload this pagehttps://github.com/nodejs/node/pull/23601
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 13, 2018 https://github.com/nodejs/node/pull/23601#pullrequestreview-164440928
View reviewed changes https://github.com/nodejs/node/pull/23601/files/36e9adab62cc30e89d98b96fd9cca7baa32155b0
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Oct 13, 2018 https://github.com/nodejs/node/pull/23601#pullrequestreview-164449632
View reviewed changes https://github.com/nodejs/node/pull/23601/files/36e9adab62cc30e89d98b96fd9cca7baa32155b0
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Oct 13, 2018 https://github.com/nodejs/node/pull/23601#pullrequestreview-164451172
View reviewed changes https://github.com/nodejs/node/pull/23601/files/36e9adab62cc30e89d98b96fd9cca7baa32155b0
Trotthttps://github.com/Trott
Oct 13, 2018 https://github.com/nodejs/node/pull/23601#ref-commit-c24e963
https://github.com/leomoreno
https://github.com/Trott
test: improve test coverage for fs modulehttps://github.com/Trott/io.js/commit/c24e9633fbc72fc8e0f8b6d1e93a2f30b884791c
c24e963https://github.com/Trott/io.js/commit/c24e9633fbc72fc8e0f8b6d1e93a2f30b884791c
nodejs#23601https://github.com/nodejs/node/pull/23601
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 13, 2018https://github.com/nodejs/node/pull/23601#issuecomment-429511376
c24e963https://github.com/nodejs/node/commit/c24e9633fbc72fc8e0f8b6d1e93a2f30b884791c
Please reload this pagehttps://github.com/nodejs/node/pull/23601
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 13, 2018https://github.com/nodejs/node/pull/23601#event-1902012081
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 13, 2018https://github.com/nodejs/node/pull/23601#issuecomment-429511385
https://www.nodetodo.org/next-steps/https://www.nodetodo.org/next-steps/
Please reload this pagehttps://github.com/nodejs/node/pull/23601
https://github.com/leomoreno
leomorenohttps://github.com/leomoreno
October 15, 2018 17:16https://github.com/nodejs/node/pull/23601#event-1904710831
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23601#ref-commit-db2be04
https://github.com/leomoreno
https://github.com/jasnell
test: improve test coverage for fs modulehttps://github.com/nodejs/node/commit/db2be04eb8e12814ef48d8a97c316c64b587261a
db2be04https://github.com/nodejs/node/commit/db2be04eb8e12814ef48d8a97c316c64b587261a
#23601https://github.com/nodejs/node/pull/23601
addaleaxhttps://github.com/addaleax
Oct 20, 2018 https://github.com/nodejs/node/pull/23601#ref-commit-3f63297
https://github.com/leomoreno
https://github.com/addaleax
test: improve test coverage for fs modulehttps://github.com/nodejs/node/commit/3f63297fe8e10e54122f211c6ae573112a9f74cc
3f63297https://github.com/nodejs/node/commit/3f63297fe8e10e54122f211c6ae573112a9f74cc
#23601https://github.com/nodejs/node/pull/23601
MylesBorinshttps://github.com/MylesBorins
Oct 30, 2018 https://github.com/nodejs/node/pull/23601#ref-commit-8e7a12f
https://github.com/leomoreno
https://github.com/MylesBorins
test: improve test coverage for fs modulehttps://github.com/nodejs/node/commit/8e7a12f4500c702731313591d64726031ab8c4d2
8e7a12fhttps://github.com/nodejs/node/commit/8e7a12f4500c702731313591d64726031ab8c4d2
#23601https://github.com/nodejs/node/pull/23601
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23601#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23601#ref-commit-29c981f
https://github.com/leomoreno
https://github.com/rvagg
test: improve test coverage for fs modulehttps://github.com/nodejs/node/commit/29c981f47406d0612fb1f322f9b33a0d45b1c15e
29c981fhttps://github.com/nodejs/node/commit/29c981f47406d0612fb1f322f9b33a0d45b1c15e
#23601https://github.com/nodejs/node/pull/23601
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23601#ref-commit-3e143df
https://github.com/leomoreno
https://github.com/MylesBorins
test: improve test coverage for fs modulehttps://github.com/nodejs/node/commit/3e143dfdd93a3309ef8f3008aeee0fa5b049ad3d
3e143dfhttps://github.com/nodejs/node/commit/3e143dfdd93a3309ef8f3008aeee0fa5b049ad3d
#23601https://github.com/nodejs/node/pull/23601
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23601#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23601
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23601/files/4f173464b55a5f886544ef72b47b77a90b612b21
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23601/files/4f173464b55a5f886544ef72b47b77a90b612b21
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23601/files/36e9adab62cc30e89d98b96fd9cca7baa32155b0
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/23601/files/36e9adab62cc30e89d98b96fd9cca7baa32155b0
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/23601/files/36e9adab62cc30e89d98b96fd9cca7baa32155b0
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/23601/files/36e9adab62cc30e89d98b96fd9cca7baa32155b0
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/23601
https://github.com/leomoreno
https://github.com/addaleax
https://github.com/Trott
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/gireeshpunathil
https://github.com/BridgeAR
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.