René's URL Explorer Experiment


Title: test: fix race condition in repl history test by evanlucas · Pull Request #2358 · nodejs/node · GitHub

Open Graph Title: test: fix race condition in repl history test by evanlucas · Pull Request #2358 · nodejs/node

X Title: test: fix race condition in repl history test by evanlucas · Pull Request #2358 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Previously, there were cases when the end event could be emitted before the flushHistory event. This change makes the next test fire off after the specified event based on the test. Ref: #2319 R=@F...

X Description: Previously, there were cases when the end event could be emitted before the flushHistory event. This change makes the next test fire off after the specified event based on the test. Ref: #2319 R=@F...

Opengraph URL: https://github.com/nodejs/node/pull/2358

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1bc71e08-ddaa-7563-4eab-c6bb794da298
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD048:C0192:16DF4C4:1FBDF6A:6A4EA7C2
html-safe-nonce2d918c96691311d225a626484c80967b88346249ccc53dfb7fe8e8f8bca36091
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDQ4OkMwMTkyOjE2REY0QzQ6MUZCREY2QTo2QTRFQTdDMiIsInZpc2l0b3JfaWQiOiI3OTc4NzAzNzA2MTAyMDgxNDc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7ebfa8ac628e8ecf3632716af2a0e76d0c16221c17fce75cda7d074e0adbf6c4
hovercard-subject-tagpull_request:42234657
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/2358/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9c10f62dde05d1863405775edb3948b74736456315f38c755f1310e177473b1f/nodejs/node/pull/2358
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9c10f62dde05d1863405775edb3948b74736456315f38c755f1310e177473b1f/nodejs/node/pull/2358
og:image:altPreviously, there were cases when the end event could be emitted before the flushHistory event. This change makes the next test fire off after the specified event based on the test. Ref: #2319 R=@F...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameevanlucas
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/2358#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2358
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2358
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/2358
Reloadhttps://github.com/nodejs/node/pull/2358
Reloadhttps://github.com/nodejs/node/pull/2358
Please reload this pagehttps://github.com/nodejs/node/pull/2358
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/2358
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
evanlucashttps://github.com/evanlucas
nodejs:masterhttps://github.com/nodejs/node/tree/master
evanlucas:fixreplhistorytesthttps://github.com/evanlucas/node/tree/fixreplhistorytest
Conversationhttps://github.com/nodejs/node/pull/2358
Commits1 (1)https://github.com/nodejs/node/pull/2358/commits
Checkshttps://github.com/nodejs/node/pull/2358/checks
Files changedhttps://github.com/nodejs/node/pull/2358/files
test: fix race condition in repl history testhttps://github.com/nodejs/node/pull/2358#top
evanlucashttps://github.com/evanlucas
nodejs:masterhttps://github.com/nodejs/node/tree/master
evanlucas:fixreplhistorytesthttps://github.com/evanlucas/node/tree/fixreplhistorytest
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Aug 12, 2015https://github.com/nodejs/node/pull/2358#issue-100533506
#2319https://github.com/nodejs/node/issues/2319
@Fishrock123https://github.com/Fishrock123
Please reload this pagehttps://github.com/nodejs/node/pull/2358
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Aug 12, 2015https://github.com/nodejs/node/pull/2358#event-380264813
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Aug 12, 2015https://github.com/nodejs/node/pull/2358#event-380326175
https://github.com/evanlucas
test: fix race condition in repl history testhttps://github.com/nodejs/node/pull/2358/commits/44e8c4b7050000a399c25ed8f5f4800ef8e033a6
44e8c4bhttps://github.com/nodejs/node/pull/2358/commits/44e8c4b7050000a399c25ed8f5f4800ef8e033a6
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
force-pushedhttps://github.com/nodejs/node/compare/96dd3b9283856fea74136c1b5849c387316a03d0..44e8c4b7050000a399c25ed8f5f4800ef8e033a6
96dd3b9https://github.com/nodejs/node/commit/96dd3b9283856fea74136c1b5849c387316a03d0
44e8c4bhttps://github.com/nodejs/node/commit/44e8c4b7050000a399c25ed8f5f4800ef8e033a6
Compare https://github.com/nodejs/node/compare/96dd3b9283856fea74136c1b5849c387316a03d0..44e8c4b7050000a399c25ed8f5f4800ef8e033a6
August 12, 2015 13:52https://github.com/nodejs/node/pull/2358#event-380326645
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 12, 2015https://github.com/nodejs/node/pull/2358#issuecomment-130327572
Please reload this pagehttps://github.com/nodejs/node/pull/2358
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Aug 12, 2015 https://github.com/nodejs/node/pull/2358#ref-issue-99552423
sequential/test-repl-persistent-history is failing on OS X #2319 https://github.com/nodejs/node/issues/2319
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Aug 12, 2015https://github.com/nodejs/node/pull/2358#issuecomment-130359288
Please reload this pagehttps://github.com/nodejs/node/pull/2358
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Aug 12, 2015https://github.com/nodejs/node/pull/2358#issuecomment-130365541
https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/234/https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/234/
Please reload this pagehttps://github.com/nodejs/node/pull/2358
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Aug 12, 2015https://github.com/nodejs/node/pull/2358#issuecomment-130407069
https://jenkins-iojs.nodesource.com/job/node-test-pull-request/78/https://jenkins-iojs.nodesource.com/job/node-test-pull-request/78/
Please reload this pagehttps://github.com/nodejs/node/pull/2358
Fishrock123https://github.com/Fishrock123
Aug 13, 2015 https://github.com/nodejs/node/pull/2358#discussion-diff-36993828
View reviewed changes https://github.com/nodejs/node/pull/2358/files/44e8c4b7050000a399c25ed8f5f4800ef8e033a6#diff-e0e0a6dc638c85ab0451ff2aba7eaa6476d4ec6c3253e74d8d6c3c8dd850d18a
test/sequential/test-repl-persistent-history.jshttps://github.com/nodejs/node/pull/2358/files#diff-e0e0a6dc638c85ab0451ff2aba7eaa6476d4ec6c3253e74d8d6c3c8dd850d18a
Fishrock123https://github.com/Fishrock123
Aug 13, 2015https://github.com/nodejs/node/pull/2358#discussion_r36993828
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2358
Fishrock123https://github.com/Fishrock123
Aug 13, 2015https://github.com/nodejs/node/pull/2358#discussion_r36995240
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#2356https://github.com/nodejs/node/pull/2356
Please reload this pagehttps://github.com/nodejs/node/pull/2358
evanlucashttps://github.com/evanlucas
Aug 13, 2015https://github.com/nodejs/node/pull/2358#discussion_r37008342
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2358
Fishrock123https://github.com/Fishrock123
Aug 13, 2015https://github.com/nodejs/node/pull/2358#discussion_r37012840
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2358
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Aug 13, 2015https://github.com/nodejs/node/pull/2358#issuecomment-130761429
Please reload this pagehttps://github.com/nodejs/node/pull/2358
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Aug 13, 2015https://github.com/nodejs/node/pull/2358#issuecomment-130820123
@evanlucashttps://github.com/evanlucas
Fishrock123@9a0fabbhttps://github.com/Fishrock123/node/commit/9a0fabbc5cbef9d4a41d0bc9cd1cf70159bf2328
Please reload this pagehttps://github.com/nodejs/node/pull/2358
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Aug 13, 2015https://github.com/nodejs/node/pull/2358#issuecomment-130820729
Please reload this pagehttps://github.com/nodejs/node/pull/2358
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Aug 14, 2015https://github.com/nodejs/node/pull/2358#issuecomment-130895054
#2356https://github.com/nodejs/node/pull/2356
Please reload this pagehttps://github.com/nodejs/node/pull/2358
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Aug 14, 2015https://github.com/nodejs/node/pull/2358#event-382074588
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2358
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/2358
https://github.com/evanlucas
https://github.com/cjihrig
https://github.com/Fishrock123
https://github.com/silverwind
https://github.com/thefourtheye
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.