| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e3f92bca-74d7-93dc-c69c-03bf3ed5a166 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8BE4:6B18B:2B0835:36E39B:69906796 |
| html-safe-nonce | 8f6e85509f29d58cd56db57302b23776047902bcc5a62346a8c686409bdfbd46 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkU0OjZCMThCOjJCMDgzNTozNkUzOUI6Njk5MDY3OTYiLCJ2aXNpdG9yX2lkIjoiNDg0MDg3MjA4NTA2NzY4NzgzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 797436ebad877c41d472768d6c65d953727b3d6cf271250427511b46cff16720 |
| hovercard-subject-tag | pull_request:222546272 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23575/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/75a6a10b94fc2056ec49d3230299d589e6eabfb44b6c48fc7ddb58c077295b58/nodejs/node/pull/23575 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/75a6a10b94fc2056ec49d3230299d589e6eabfb44b6c48fc7ddb58c077295b58/nodejs/node/pull/23575 |
| og:image:alt | Expected
The test should make use of strictEqual() according to the docs with the first value being the actual, and second being the expected
Actual
The use of strictEqual() in the test uses the pa... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lirantal |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23575#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23575 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23575 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23575 |
| Reload | https://github.com/nodejs/node/pull/23575 |
| Reload | https://github.com/nodejs/node/pull/23575 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23575 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
706
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| lirantal | https://github.com/lirantal |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/23575 |
| Commits0 (0) | https://github.com/nodejs/node/pull/23575/commits |
| Checks | https://github.com/nodejs/node/pull/23575/checks |
| Files changed | https://github.com/nodejs/node/pull/23575/files |
| test: fix arguments ordering for assertions to match the docs | https://github.com/nodejs/node/pull/23575#top |
| lirantal | https://github.com/lirantal |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/lirantal |
| lirantal | https://github.com/lirantal |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23575#issue-369657272 |
| Please reload this page | https://github.com/nodejs/node/pull/23575 |
| docs | https://nodejs.org/api/assert.html#assert_assert_strictequal_actual_expected_message |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23575 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23575#event-1901379442 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23575#event-1901381058 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23575#pullrequestreview-164355885 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23575/files |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23575#pullrequestreview-164413039 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23575/files |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23575#pullrequestreview-164423902 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23575/files |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23575#pullrequestreview-164426455 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23575/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
module
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23575#event-1901854674 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23575#pullrequestreview-164450549 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23575/files |
| test/parallel/test-require-resolve.js | https://github.com/nodejs/node/pull/23575/files#diff-ff2b47aa6a273ba768683756d7eebd19094b48678dba010539507914e5c885a3 |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23575#discussion_r224948993 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23575 |
| lirantal | https://github.com/lirantal |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23575#discussion_r224949488 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @gireeshpunathil | https://github.com/gireeshpunathil |
| 91a465c#diff-a00e02f229f04b6262da068e8df33ed5 | https://github.com/nodejs/node/commit/91a465c460a1525103611a03ca277b061f320228#diff-a00e02f229f04b6262da068e8df33ed5 |
| b1506f7#diff-a00e02f229f04b6262da068e8df33ed5 | https://github.com/nodejs/node/commit/b1506f713c8866c47d17b0d7fe76fd5c6697ef42#diff-a00e02f229f04b6262da068e8df33ed5 |
| Please reload this page | https://github.com/nodejs/node/pull/23575 |
| thefourtheye | https://github.com/thefourtheye |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23575#discussion_r224954727 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23575 |
| lirantal | https://github.com/lirantal |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23575#discussion_r224960813 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23575 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23575#pullrequestreview-164450551 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23575/files |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23575#pullrequestreview-164457261 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23575/files |
| test/parallel/test-require-resolve.js | https://github.com/nodejs/node/pull/23575/files#diff-ff2b47aa6a273ba768683756d7eebd19094b48678dba010539507914e5c885a3 |
| thefourtheye | https://github.com/thefourtheye |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23575#discussion_r224954727 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23575 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/882e0225d5855a17dafa10820bf1a0b833df8dac..9ed4646df05b9593075bb0cd0b3ab420bae482a5 |
| 882e022 | https://github.com/nodejs/node/commit/882e0225d5855a17dafa10820bf1a0b833df8dac |
| 9ed4646 | https://github.com/nodejs/node/commit/9ed4646df05b9593075bb0cd0b3ab420bae482a5 |
|
Compare
| https://github.com/nodejs/node/compare/882e0225d5855a17dafa10820bf1a0b833df8dac..9ed4646df05b9593075bb0cd0b3ab420bae482a5 |
| October 13, 2018 18:22 | https://github.com/nodejs/node/pull/23575#event-1902276381 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23575#ref-commit-c596bcc |
|
| https://github.com/lirantal |
|
| https://github.com/BridgeAR |
| test: fix arguments ordering for assertions to match the docs | https://github.com/BridgeAR/node/commit/c596bcc4ff9108fd357d78011712af18e212e712 |
| c596bcc | https://github.com/BridgeAR/node/commit/c596bcc4ff9108fd357d78011712af18e212e712 |
| nodejs#23575 | https://github.com/nodejs/node/pull/23575 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 16, 2018 | https://github.com/nodejs/node/pull/23575#issuecomment-430204605 |
| @lirantal | https://github.com/lirantal |
| Please reload this page | https://github.com/nodejs/node/pull/23575 |
| https://github.com/lirantal |
| lirantal | https://github.com/lirantal |
| Oct 16, 2018 | https://github.com/nodejs/node/pull/23575#event-1906569735 |
| https://github.com/lirantal |
| lirantal | https://github.com/lirantal |
| Oct 16, 2018 | https://github.com/nodejs/node/pull/23575#issuecomment-430207545 |
| @addaleax | https://github.com/addaleax |
| c596bcc#diff-a00e02f229f04b6262da068e8df33ed5 | https://github.com/nodejs/node/commit/c596bcc4ff9108fd357d78011712af18e212e712#diff-a00e02f229f04b6262da068e8df33ed5 |
| Please reload this page | https://github.com/nodejs/node/pull/23575 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23575#ref-commit-d35965b |
|
| https://github.com/lirantal |
|
| https://github.com/jasnell |
| test: fix arguments ordering for assertions to match the docs | https://github.com/nodejs/node/commit/d35965bbf9d165cfe289ce7370876582cf5ab61f |
| d35965b | https://github.com/nodejs/node/commit/d35965bbf9d165cfe289ce7370876582cf5ab61f |
| #23575 | https://github.com/nodejs/node/pull/23575 |
| addaleax | https://github.com/addaleax |
|
Oct 20, 2018
| https://github.com/nodejs/node/pull/23575#ref-commit-80a78dc |
|
| https://github.com/lirantal |
|
| https://github.com/addaleax |
| test: fix arguments ordering for assertions to match the docs | https://github.com/nodejs/node/commit/80a78dca7fa27696e5ef3552229c156a64b92673 |
| 80a78dc | https://github.com/nodejs/node/commit/80a78dca7fa27696e5ef3552229c156a64b92673 |
| #23575 | https://github.com/nodejs/node/pull/23575 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23575#ref-commit-2a3ba01 |
|
| https://github.com/lirantal |
|
| https://github.com/MylesBorins |
| test: fix arguments ordering for assertions to match the docs | https://github.com/nodejs/node/commit/2a3ba01b08e9df590476c3067d8e5cc0bc085043 |
| 2a3ba01 | https://github.com/nodejs/node/commit/2a3ba01b08e9df590476c3067d8e5cc0bc085043 |
| #23575 | https://github.com/nodejs/node/pull/23575 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/23575#ref-pullrequest-384882602 |
|
v10.13.1 proposal
#24675
| https://github.com/nodejs/node/pull/24675 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23575#ref-commit-98915f1 |
|
| https://github.com/lirantal |
|
| https://github.com/rvagg |
| test: fix arguments ordering for assertions to match the docs | https://github.com/nodejs/node/commit/98915f18735ff1caa93993dcc329217bc2235def |
| 98915f1 | https://github.com/nodejs/node/commit/98915f18735ff1caa93993dcc329217bc2235def |
| #23575 | https://github.com/nodejs/node/pull/23575 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23575#ref-commit-8f1cea6 |
|
| https://github.com/lirantal |
|
| https://github.com/MylesBorins |
| test: fix arguments ordering for assertions to match the docs | https://github.com/nodejs/node/commit/8f1cea6e18f36939358178143251396cbe09ec01 |
| 8f1cea6 | https://github.com/nodejs/node/commit/8f1cea6e18f36939358178143251396cbe09ec01 |
| #23575 | https://github.com/nodejs/node/pull/23575 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23575#ref-pullrequest-385836001 |
|
v10.14.2 proposal
#24727
| https://github.com/nodejs/node/pull/24727 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23575 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/23575/files/09353a76e932b889b547234c1faab99b8c7f7a12 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/23575/files/09353a76e932b889b547234c1faab99b8c7f7a12 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/23575/files/09353a76e932b889b547234c1faab99b8c7f7a12 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/23575/files/09353a76e932b889b547234c1faab99b8c7f7a12 |
|
| https://github.com/digitalinfinity |
|
digitalinfinity
| https://github.com/digitalinfinity |
|
| https://github.com/nodejs/node/pull/23575/files/09353a76e932b889b547234c1faab99b8c7f7a12 |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/23575/files/09353a76e932b889b547234c1faab99b8c7f7a12 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
module
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/23575 |
|
| https://github.com/lirantal |
|
| https://github.com/addaleax |
|
| https://github.com/digitalinfinity |
|
| https://github.com/thefourtheye |
|
| https://github.com/cjihrig |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/BridgeAR |
|
| https://github.com/trivikr |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |