René's URL Explorer Experiment


Title: test: fix assert.strictEqual() parameter order by lotharthesavior · Pull Request #23564 · nodejs/node · GitHub

Open Graph Title: test: fix assert.strictEqual() parameter order by lotharthesavior · Pull Request #23564 · nodejs/node

X Title: test: fix assert.strictEqual() parameter order by lotharthesavior · Pull Request #23564 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: …follow the order actual-value->expected-value. According to the documentation, the strictEqual assertions should follow the order actual-value -> expected-value. This PR is changing the curr...

X Description: …follow the order actual-value->expected-value. According to the documentation, the strictEqual assertions should follow the order actual-value -> expected-value. This PR is changing ...

Opengraph URL: https://github.com/nodejs/node/pull/23564

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bcb522cb-268d-9fc8-7bda-1565498d293d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA4F2:F2C3E:30997B:3F6075:699067AE
html-safe-nonce6235aac4ccbd3a7c2c6a492c91165fe08f3c9b7e3e7b45e35f062feeeb406db9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEYyOkYyQzNFOjMwOTk3QjozRjYwNzU6Njk5MDY3QUUiLCJ2aXNpdG9yX2lkIjoiNTk3NDUxMTgyNzkyMDM4MTg3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac56c7f0214c0f2a596b121eaed0f630bd24cb0fa360c272578730e0b818cfd60f
hovercard-subject-tagpull_request:222544055
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23564/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d6d9c94dd6163c20b8098360b30c5df8e712f088b288e014501e86e717eb0c78/nodejs/node/pull/23564
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d6d9c94dd6163c20b8098360b30c5df8e712f088b288e014501e86e717eb0c78/nodejs/node/pull/23564
og:image:alt…follow the order actual-value->expected-value. According to the documentation, the strictEqual assertions should follow the order actual-value -> expected-value. This PR is changing the curr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelotharthesavior
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23564#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23564
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23564
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23564
Reloadhttps://github.com/nodejs/node/pull/23564
Reloadhttps://github.com/nodejs/node/pull/23564
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23564
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
lotharthesaviorhttps://github.com/lotharthesavior
nodejs:masterhttps://github.com/nodejs/node/tree/master
lotharthesavior:masterhttps://github.com/lotharthesavior/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/23564
Commits1 (1)https://github.com/nodejs/node/pull/23564/commits
Checkshttps://github.com/nodejs/node/pull/23564/checks
Files changedhttps://github.com/nodejs/node/pull/23564/files
test: fix assert.strictEqual() parameter orderhttps://github.com/nodejs/node/pull/23564#top
lotharthesaviorhttps://github.com/lotharthesavior
nodejs:masterhttps://github.com/nodejs/node/tree/master
lotharthesavior:masterhttps://github.com/lotharthesavior/node/tree/master
https://github.com/lotharthesavior
lotharthesaviorhttps://github.com/lotharthesavior
Oct 12, 2018https://github.com/nodejs/node/pull/23564#issue-369654471
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23564
https://github.com/lotharthesavior
test: Reordered parameters to the test-tcp-wrap-connect, so the param…https://github.com/nodejs/node/pull/23564/commits/91bd5fb38ee251984ea257cea7b2dd29c3214d48
91bd5fbhttps://github.com/nodejs/node/pull/23564/commits/91bd5fb38ee251984ea257cea7b2dd29c3214d48
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Oct 12, 2018https://github.com/nodejs/node/pull/23564#event-1901362731
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Oct 12, 2018https://github.com/nodejs/node/pull/23564#event-1901364328
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 12, 2018 https://github.com/nodejs/node/pull/23564#pullrequestreview-164351991
View reviewed changes https://github.com/nodejs/node/pull/23564/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 12, 2018 https://github.com/nodejs/node/pull/23564#pullrequestreview-164352025
View reviewed changes https://github.com/nodejs/node/pull/23564/files
https://github.com/refack
refackhttps://github.com/refack
Oct 12, 2018 https://github.com/nodejs/node/pull/23564#pullrequestreview-164352190
View reviewed changes https://github.com/nodejs/node/pull/23564/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 12, 2018https://github.com/nodejs/node/pull/23564#issuecomment-429411869
@lotharthesaviorhttps://github.com/lotharthesavior
Please reload this pagehttps://github.com/nodejs/node/pull/23564
https://github.com/lotharthesavior
lotharthesaviorhttps://github.com/lotharthesavior
force-pushedhttps://github.com/nodejs/node/compare/53a5addfd98fe1c2a8f811a5789ce93d4bce09ef..91bd5fb38ee251984ea257cea7b2dd29c3214d48
53a5addhttps://github.com/nodejs/node/commit/53a5addfd98fe1c2a8f811a5789ce93d4bce09ef
91bd5fbhttps://github.com/nodejs/node/commit/91bd5fb38ee251984ea257cea7b2dd29c3214d48
Compare https://github.com/nodejs/node/compare/53a5addfd98fe1c2a8f811a5789ce93d4bce09ef..91bd5fb38ee251984ea257cea7b2dd29c3214d48
October 12, 2018 18:12https://github.com/nodejs/node/pull/23564#event-1901375202
https://github.com/lotharthesavior
lotharthesaviorhttps://github.com/lotharthesavior
Oct 12, 2018https://github.com/nodejs/node/pull/23564#issuecomment-429416309
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/23564
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 12, 2018https://github.com/nodejs/node/pull/23564#issuecomment-429417243
@lotharthesaviorhttps://github.com/lotharthesavior
Please reload this pagehttps://github.com/nodejs/node/pull/23564
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 12, 2018 https://github.com/nodejs/node/pull/23564#pullrequestreview-164415485
View reviewed changes https://github.com/nodejs/node/pull/23564/files/91bd5fb38ee251984ea257cea7b2dd29c3214d48
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 12, 2018https://github.com/nodejs/node/pull/23564#event-1901743149
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Oct 12, 2018 https://github.com/nodejs/node/pull/23564#pullrequestreview-164428994
View reviewed changes https://github.com/nodejs/node/pull/23564/files/91bd5fb38ee251984ea257cea7b2dd29c3214d48
test/parallel/test-tcp-wrap-connect.jshttps://github.com/nodejs/node/pull/23564/files/91bd5fb38ee251984ea257cea7b2dd29c3214d48#diff-71917e1f847bac0ffd2c5cc9f0d9ea50e26cacce592cc888d2c077336ee76e2f
trivikrhttps://github.com/trivikr
Oct 12, 2018https://github.com/nodejs/node/pull/23564#discussion_r224931090
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23564
lotharthesaviorhttps://github.com/lotharthesavior
Oct 12, 2018https://github.com/nodejs/node/pull/23564#discussion_r224931955
Please reload this pagehttps://github.com/nodejs/node/pull/23564
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@trivikrhttps://github.com/trivikr
Please reload this pagehttps://github.com/nodejs/node/pull/23564
trivikrhttps://github.com/trivikr
Oct 13, 2018https://github.com/nodejs/node/pull/23564#discussion_r224948062
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23564
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018https://github.com/nodejs/node/pull/23564#discussion_r225172198
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23564
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Oct 13, 2018 https://github.com/nodejs/node/pull/23564#pullrequestreview-164449683
View reviewed changes https://github.com/nodejs/node/pull/23564/files/91bd5fb38ee251984ea257cea7b2dd29c3214d48
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018 https://github.com/nodejs/node/pull/23564#ref-commit-eabed63
https://github.com/lotharthesavior
https://github.com/BridgeAR
test: fix assert.strictEqual() argument orderhttps://github.com/BridgeAR/node/commit/eabed63e5aa4e5e169710a311294a91c682e05cc
eabed63https://github.com/BridgeAR/node/commit/eabed63e5aa4e5e169710a311294a91c682e05cc
nodejs#23564https://github.com/nodejs/node/pull/23564
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018 https://github.com/nodejs/node/pull/23564#ref-commit-aee771c
https://github.com/lotharthesavior
https://github.com/BridgeAR
test: fix assert.strictEqual() argument orderhttps://github.com/BridgeAR/node/commit/aee771c73c5ae80b1c39d5c8cb92579033ba48b2
aee771chttps://github.com/BridgeAR/node/commit/aee771c73c5ae80b1c39d5c8cb92579033ba48b2
nodejs#23564https://github.com/nodejs/node/pull/23564
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018https://github.com/nodejs/node/pull/23564#issuecomment-429859909
aee771chttps://github.com/nodejs/node/commit/aee771c73c5ae80b1c39d5c8cb92579033ba48b2
@lotharthesaviorhttps://github.com/lotharthesavior
Please reload this pagehttps://github.com/nodejs/node/pull/23564
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018https://github.com/nodejs/node/pull/23564#event-1904144288
https://github.com/lotharthesavior
lotharthesaviorhttps://github.com/lotharthesavior
Oct 15, 2018https://github.com/nodejs/node/pull/23564#issuecomment-429914311
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/23564
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23564#ref-commit-ca24bcf
https://github.com/lotharthesavior
https://github.com/jasnell
test: fix assert.strictEqual() argument orderhttps://github.com/nodejs/node/commit/ca24bcf57140dacc6333f1eb1058c77810225964
ca24bcfhttps://github.com/nodejs/node/commit/ca24bcf57140dacc6333f1eb1058c77810225964
#23564https://github.com/nodejs/node/pull/23564
addaleaxhttps://github.com/addaleax
Oct 20, 2018 https://github.com/nodejs/node/pull/23564#ref-commit-7f5b37c
https://github.com/lotharthesavior
https://github.com/addaleax
test: fix assert.strictEqual() argument orderhttps://github.com/nodejs/node/commit/7f5b37c2b9eb1bfd5791ff4ae1e29e8a04a33cd9
7f5b37chttps://github.com/nodejs/node/commit/7f5b37c2b9eb1bfd5791ff4ae1e29e8a04a33cd9
#23564https://github.com/nodejs/node/pull/23564
MylesBorinshttps://github.com/MylesBorins
Oct 30, 2018 https://github.com/nodejs/node/pull/23564#ref-commit-e0b4dab
https://github.com/lotharthesavior
https://github.com/MylesBorins
test: fix assert.strictEqual() argument orderhttps://github.com/nodejs/node/commit/e0b4dab58657e80c75950efcb31eedd1ed20e4a5
e0b4dabhttps://github.com/nodejs/node/commit/e0b4dab58657e80c75950efcb31eedd1ed20e4a5
#23564https://github.com/nodejs/node/pull/23564
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23564#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23564#ref-commit-eb0c78a
https://github.com/lotharthesavior
https://github.com/rvagg
test: fix assert.strictEqual() argument orderhttps://github.com/nodejs/node/commit/eb0c78a5381860b7a14f40031c9a2beac36407f8
eb0c78ahttps://github.com/nodejs/node/commit/eb0c78a5381860b7a14f40031c9a2beac36407f8
#23564https://github.com/nodejs/node/pull/23564
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23564#ref-commit-46ca12f
https://github.com/lotharthesavior
https://github.com/MylesBorins
test: fix assert.strictEqual() argument orderhttps://github.com/nodejs/node/commit/46ca12f81ee3bb52f039061301766bf8f9de5695
46ca12fhttps://github.com/nodejs/node/commit/46ca12f81ee3bb52f039061301766bf8f9de5695
#23564https://github.com/nodejs/node/pull/23564
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23564#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23564
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/23564/files/91bd5fb38ee251984ea257cea7b2dd29c3214d48
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/23564/files/91bd5fb38ee251984ea257cea7b2dd29c3214d48
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23564/files/53a5addfd98fe1c2a8f811a5789ce93d4bce09ef
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23564/files/53a5addfd98fe1c2a8f811a5789ce93d4bce09ef
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/23564/files/91bd5fb38ee251984ea257cea7b2dd29c3214d48
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/23564/files/53a5addfd98fe1c2a8f811a5789ce93d4bce09ef
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/23564
https://github.com/lotharthesavior
https://github.com/addaleax
https://github.com/BridgeAR
https://github.com/refack
https://github.com/jasnell
https://github.com/gireeshpunathil
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.