René's URL Explorer Experiment


Title: test: increase test coverage for readfile with withFileTypes option by christian-bromann · Pull Request #23557 · nodejs/node · GitHub

Open Graph Title: test: increase test coverage for readfile with withFileTypes option by christian-bromann · Pull Request #23557 · nodejs/node

X Title: test: increase test coverage for readfile with withFileTypes option by christian-bromann · Pull Request #23557 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: According to the test coverage report a test case was missings checking if an error is passed into the callback for readdir calls with withFileTypes option. Checklist make -j4 test (UNIX), or v...

X Description: According to the test coverage report a test case was missings checking if an error is passed into the callback for readdir calls with withFileTypes option. Checklist make -j4 test (UNIX), or v...

Opengraph URL: https://github.com/nodejs/node/pull/23557

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c0f006ae-e9f7-12af-cfe0-bfbbdd2e0e2b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB34:11DBF6:E2E9EE:1261FE4:69906773
html-safe-nonced9e29ef1a0f8d608d09eb53646f11c700b18e28163bc6c082f508366eb048b8e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjM0OjExREJGNjpFMkU5RUU6MTI2MUZFNDo2OTkwNjc3MyIsInZpc2l0b3JfaWQiOiIzODM2MzU1OTU1NTM0MDk2MjQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3d71ed3a635ae8f0ec9436062ca40224059c65ef9f1a7b90df171aef2513a9b1
hovercard-subject-tagpull_request:222542905
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23557/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/50c49046633b53578b9a014b2de7f2669160eeb7802ad935dd0b0940979e2140/nodejs/node/pull/23557
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/50c49046633b53578b9a014b2de7f2669160eeb7802ad935dd0b0940979e2140/nodejs/node/pull/23557
og:image:altAccording to the test coverage report a test case was missings checking if an error is passed into the callback for readdir calls with withFileTypes option. Checklist make -j4 test (UNIX), or v...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechristian-bromann
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23557#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23557
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23557
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23557
Reloadhttps://github.com/nodejs/node/pull/23557
Reloadhttps://github.com/nodejs/node/pull/23557
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23557
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
christian-bromannhttps://github.com/christian-bromann
nodejs:masterhttps://github.com/nodejs/node/tree/master
christian-bromann:test-coverage-readdirhttps://github.com/christian-bromann/node/tree/test-coverage-readdir
Conversationhttps://github.com/nodejs/node/pull/23557
Commits1 (1)https://github.com/nodejs/node/pull/23557/commits
Checkshttps://github.com/nodejs/node/pull/23557/checks
Files changedhttps://github.com/nodejs/node/pull/23557/files
test: increase test coverage for readfile with withFileTypes optionhttps://github.com/nodejs/node/pull/23557#top
christian-bromannhttps://github.com/christian-bromann
nodejs:masterhttps://github.com/nodejs/node/tree/master
christian-bromann:test-coverage-readdirhttps://github.com/christian-bromann/node/tree/test-coverage-readdir
https://github.com/christian-bromann
christian-bromannhttps://github.com/christian-bromann
Oct 12, 2018https://github.com/nodejs/node/pull/23557#issue-369653006
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23557
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Oct 12, 2018https://github.com/nodejs/node/pull/23557#event-1901353944
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 12, 2018 https://github.com/nodejs/node/pull/23557#pullrequestreview-164352599
View reviewed changes https://github.com/nodejs/node/pull/23557/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Oct 12, 2018https://github.com/nodejs/node/pull/23557#event-1901367989
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 12, 2018 https://github.com/nodejs/node/pull/23557#pullrequestreview-164417236
View reviewed changes https://github.com/nodejs/node/pull/23557/files
test/parallel/test-fs-readdir-types.jshttps://github.com/nodejs/node/pull/23557/files#diff-1da0f4945cba52332a26000de806f888b28174bcc093a8d24e7d29b34cc1d8d9
BridgeARhttps://github.com/BridgeAR
Oct 12, 2018https://github.com/nodejs/node/pull/23557#discussion_r224921575
Please reload this pagehttps://github.com/nodejs/node/pull/23557
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23557
christian-bromannhttps://github.com/christian-bromann
Oct 12, 2018https://github.com/nodejs/node/pull/23557#discussion_r224926627
Please reload this pagehttps://github.com/nodejs/node/pull/23557
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/23557
BridgeARhttps://github.com/BridgeAR
Oct 17, 2018https://github.com/nodejs/node/pull/23557#discussion_r225833350
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23557
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 13, 2018 https://github.com/nodejs/node/pull/23557#pullrequestreview-164441383
View reviewed changes https://github.com/nodejs/node/pull/23557/files
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Oct 13, 2018 https://github.com/nodejs/node/pull/23557#pullrequestreview-164449790
View reviewed changes https://github.com/nodejs/node/pull/23557/files
https://github.com/christian-bromann
test: increase test coverage for readfile with withFileTypes optionhttps://github.com/nodejs/node/pull/23557/commits/e4151af0989f24ae74da67f38ca5b33b87253754
e4151afhttps://github.com/nodejs/node/pull/23557/commits/e4151af0989f24ae74da67f38ca5b33b87253754
https://github.com/christian-bromann
christian-bromannhttps://github.com/christian-bromann
force-pushedhttps://github.com/nodejs/node/compare/e07d92b0d551f7ced118586bc623f8867f9544e4..e4151af0989f24ae74da67f38ca5b33b87253754
e07d92bhttps://github.com/nodejs/node/commit/e07d92b0d551f7ced118586bc623f8867f9544e4
e4151afhttps://github.com/nodejs/node/commit/e4151af0989f24ae74da67f38ca5b33b87253754
Compare https://github.com/nodejs/node/compare/e07d92b0d551f7ced118586bc623f8867f9544e4..e4151af0989f24ae74da67f38ca5b33b87253754
October 15, 2018 16:48https://github.com/nodejs/node/pull/23557#event-1904643812
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 16, 2018https://github.com/nodejs/node/pull/23557#issuecomment-430202766
https://ci.nodejs.org/job/node-test-pull-request/17895/https://ci.nodejs.org/job/node-test-pull-request/17895/
Please reload this pagehttps://github.com/nodejs/node/pull/23557
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 16, 2018https://github.com/nodejs/node/pull/23557#event-1906537021
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23557#pullrequestreview-165654295
View reviewed changes https://github.com/nodejs/node/pull/23557/files/e4151af0989f24ae74da67f38ca5b33b87253754
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Oct 18, 2018https://github.com/nodejs/node/pull/23557#issuecomment-430874236
https://ci.nodejs.org/job/node-test-pull-request/17963/https://ci.nodejs.org/job/node-test-pull-request/17963/
Please reload this pagehttps://github.com/nodejs/node/pull/23557
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 21, 2018https://github.com/nodejs/node/pull/23557#issuecomment-431637160
6c5e97fhttps://github.com/nodejs/node/commit/6c5e97f2f0928851d613ce90a84a8f8baaba5083
https://www.nodetodo.org/next-steps/https://www.nodetodo.org/next-steps/
Please reload this pagehttps://github.com/nodejs/node/pull/23557
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 21, 2018https://github.com/nodejs/node/pull/23557#event-1916488165
addaleaxhttps://github.com/addaleax
Oct 21, 2018 https://github.com/nodejs/node/pull/23557#ref-commit-6c5e97f
https://github.com/christian-bromann
https://github.com/addaleax
test: increase coverage for readfile with withFileTypeshttps://github.com/nodejs/node/commit/6c5e97f2f0928851d613ce90a84a8f8baaba5083
6c5e97fhttps://github.com/nodejs/node/commit/6c5e97f2f0928851d613ce90a84a8f8baaba5083
#23557https://github.com/nodejs/node/pull/23557
jasnellhttps://github.com/jasnell
Oct 21, 2018 https://github.com/nodejs/node/pull/23557#ref-commit-b19f339
https://github.com/christian-bromann
https://github.com/jasnell
test: increase coverage for readfile with withFileTypeshttps://github.com/nodejs/node/commit/b19f339bcf613a8bb3b1b8f370e0e2043f93a2b7
b19f339https://github.com/nodejs/node/commit/b19f339bcf613a8bb3b1b8f370e0e2043f93a2b7
#23557https://github.com/nodejs/node/pull/23557
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
Nov 26, 2018https://github.com/nodejs/node/pull/23557#event-1987322536
MylesBorinshttps://github.com/MylesBorins
Nov 26, 2018 https://github.com/nodejs/node/pull/23557#ref-commit-874371d
https://github.com/christian-bromann
https://github.com/MylesBorins
test: increase coverage for readfile with withFileTypeshttps://github.com/nodejs/node/commit/874371df890706150c6c0053d202836e248e8949
874371dhttps://github.com/nodejs/node/commit/874371df890706150c6c0053d202836e248e8949
#23557https://github.com/nodejs/node/pull/23557
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23557#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23557#ref-commit-1eda951
https://github.com/christian-bromann
https://github.com/rvagg
test: increase coverage for readfile with withFileTypeshttps://github.com/nodejs/node/commit/1eda9512aaf954a815435f230b728e40fdf6a276
1eda951https://github.com/nodejs/node/commit/1eda9512aaf954a815435f230b728e40fdf6a276
#23557https://github.com/nodejs/node/pull/23557
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23557#ref-commit-9979c71
https://github.com/christian-bromann
https://github.com/MylesBorins
test: increase coverage for readfile with withFileTypeshttps://github.com/nodejs/node/commit/9979c71d67a2adf8c86ed8bebffde55ba8cbfb98
9979c71https://github.com/nodejs/node/commit/9979c71d67a2adf8c86ed8bebffde55ba8cbfb98
#23557https://github.com/nodejs/node/pull/23557
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23557#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23557
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/23557/files/e4151af0989f24ae74da67f38ca5b33b87253754
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23557/files/e4151af0989f24ae74da67f38ca5b33b87253754
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23557/files/e07d92b0d551f7ced118586bc623f8867f9544e4
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23557/files/e07d92b0d551f7ced118586bc623f8867f9544e4
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/23557/files/e07d92b0d551f7ced118586bc623f8867f9544e4
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/23557
https://github.com/christian-bromann
https://github.com/addaleax
https://github.com/apapirovski
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/gireeshpunathil
https://github.com/BridgeAR
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.