| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3d0aa567-6ae0-3b20-7387-c050ec029bcd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 912A:BCC83:74AE8:9612E:69902A7F |
| html-safe-nonce | 0ebf5a39f865f7d31699636b77ea92e4ba5ee70cc0dd0a51175856496c7d9e76 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTJBOkJDQzgzOjc0QUU4Ojk2MTJFOjY5OTAyQTdGIiwidmlzaXRvcl9pZCI6IjQ5NTAyOTc5ODE5MzQ5MDU5ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 096e9a4276820208420085cf99d229cb8e83a3b16dfab607b1f8aee7e9ec349e |
| hovercard-subject-tag | pull_request:222541201 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23552/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bbbc4afd4e0eea5898ca67e48b7ea1a6f5ae7508e2a49f4aa1c16b1159a0a4a3/nodejs/node/pull/23552 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bbbc4afd4e0eea5898ca67e48b7ea1a6f5ae7508e2a49f4aa1c16b1159a0a4a3/nodejs/node/pull/23552 |
| og:image:alt | The argument order in the strictEqual check against stderr is in the
wrong order. The first argument is now the actual value and the second
argument is the expected value.
Checklist
make -j4 test... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | crpahl |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23552#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23552 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23552 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23552 |
| Reload | https://github.com/nodejs/node/pull/23552 |
| Reload | https://github.com/nodejs/node/pull/23552 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23552 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
709
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| crpahl | https://github.com/crpahl |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| crpahl:strict-equal-update | https://github.com/crpahl/node/tree/strict-equal-update |
| Conversation | https://github.com/nodejs/node/pull/23552 |
| Commits1 (1) | https://github.com/nodejs/node/pull/23552/commits |
| Checks | https://github.com/nodejs/node/pull/23552/checks |
| Files changed | https://github.com/nodejs/node/pull/23552/files |
| test: update strictEqual arguments order | https://github.com/nodejs/node/pull/23552#top |
| crpahl | https://github.com/crpahl |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| crpahl:strict-equal-update | https://github.com/crpahl/node/tree/strict-equal-update |
|
| https://github.com/crpahl |
| crpahl | https://github.com/crpahl |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23552#issue-369650836 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23552 |
|
| https://github.com/crpahl |
| test: update strictEqual arguments order | https://github.com/nodejs/node/pull/23552/commits/bec03b00b60afe09249f9ad8fefe64bbdc58c058 |
| bec03b0 | https://github.com/nodejs/node/pull/23552/commits/bec03b00b60afe09249f9ad8fefe64bbdc58c058 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23552#event-1901340926 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23552#pullrequestreview-164348704 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23552/files/bec03b00b60afe09249f9ad8fefe64bbdc58c058 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| https://github.com/nodejs/node/pull/23552#pullrequestreview-164348704 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23552 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23552#pullrequestreview-164348770 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23552/files/bec03b00b60afe09249f9ad8fefe64bbdc58c058 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23552#event-1901443756 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23552#pullrequestreview-164418061 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23552/files/bec03b00b60afe09249f9ad8fefe64bbdc58c058 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23552#pullrequestreview-164445026 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23552/files/bec03b00b60afe09249f9ad8fefe64bbdc58c058 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23552#pullrequestreview-164449868 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23552/files/bec03b00b60afe09249f9ad8fefe64bbdc58c058 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23552#pullrequestreview-164465359 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23552/files/bec03b00b60afe09249f9ad8fefe64bbdc58c058 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23552#ref-commit-33b18b9 |
|
| https://github.com/crpahl |
|
| https://github.com/BridgeAR |
| test: update strictEqual arguments order | https://github.com/BridgeAR/node/commit/33b18b9134ad2c6d8f21f85486ed200add4cee09 |
| 33b18b9 | https://github.com/BridgeAR/node/commit/33b18b9134ad2c6d8f21f85486ed200add4cee09 |
| nodejs#23552 | https://github.com/nodejs/node/pull/23552 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23552#ref-commit-f034606 |
|
| https://github.com/crpahl |
|
| https://github.com/BridgeAR |
| test: update strictEqual arguments order | https://github.com/BridgeAR/node/commit/f0346065a7fad3ed1b22159b92a6e5a9bafb2851 |
| f034606 | https://github.com/BridgeAR/node/commit/f0346065a7fad3ed1b22159b92a6e5a9bafb2851 |
| nodejs#23552 | https://github.com/nodejs/node/pull/23552 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Oct 15, 2018 | https://github.com/nodejs/node/pull/23552#issuecomment-429787351 |
| f034606 | https://github.com/nodejs/node/commit/f0346065a7fad3ed1b22159b92a6e5a9bafb2851 |
| @crpahl | https://github.com/crpahl |
| Please reload this page | https://github.com/nodejs/node/pull/23552 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Oct 15, 2018 | https://github.com/nodejs/node/pull/23552#event-1903639542 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23552#ref-commit-0d9e54b |
|
| https://github.com/crpahl |
|
| https://github.com/jasnell |
| test: update strictEqual arguments order | https://github.com/nodejs/node/commit/0d9e54b3d61e6b0d286172b3b5a3e1238eb64433 |
| 0d9e54b | https://github.com/nodejs/node/commit/0d9e54b3d61e6b0d286172b3b5a3e1238eb64433 |
| #23552 | https://github.com/nodejs/node/pull/23552 |
| addaleax | https://github.com/addaleax |
|
Oct 20, 2018
| https://github.com/nodejs/node/pull/23552#ref-commit-4a1f542 |
|
| https://github.com/crpahl |
|
| https://github.com/addaleax |
| test: update strictEqual arguments order | https://github.com/nodejs/node/commit/4a1f542296beb50c95733040cfe39cbb742e9599 |
| 4a1f542 | https://github.com/nodejs/node/commit/4a1f542296beb50c95733040cfe39cbb742e9599 |
| #23552 | https://github.com/nodejs/node/pull/23552 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23552#ref-commit-04769c4 |
|
| https://github.com/crpahl |
|
| https://github.com/MylesBorins |
| test: update strictEqual arguments order | https://github.com/nodejs/node/commit/04769c457318bbaee1d77f038cde03c6f53f9d14 |
| 04769c4 | https://github.com/nodejs/node/commit/04769c457318bbaee1d77f038cde03c6f53f9d14 |
| #23552 | https://github.com/nodejs/node/pull/23552 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/23552#ref-pullrequest-384882602 |
|
v10.13.1 proposal
#24675
| https://github.com/nodejs/node/pull/24675 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23552#ref-commit-6a6e669 |
|
| https://github.com/crpahl |
|
| https://github.com/rvagg |
| test: update strictEqual arguments order | https://github.com/nodejs/node/commit/6a6e669217e354150a77d0dd4e3b252241800a5b |
| 6a6e669 | https://github.com/nodejs/node/commit/6a6e669217e354150a77d0dd4e3b252241800a5b |
| #23552 | https://github.com/nodejs/node/pull/23552 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23552#ref-commit-9a79824 |
|
| https://github.com/crpahl |
|
| https://github.com/MylesBorins |
| test: update strictEqual arguments order | https://github.com/nodejs/node/commit/9a7982434820664e66c17b6db5e5331354527a0c |
| 9a79824 | https://github.com/nodejs/node/commit/9a7982434820664e66c17b6db5e5331354527a0c |
| #23552 | https://github.com/nodejs/node/pull/23552 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23552#ref-pullrequest-385836001 |
|
v10.14.2 proposal
#24727
| https://github.com/nodejs/node/pull/24727 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23552 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/23552/files/bec03b00b60afe09249f9ad8fefe64bbdc58c058 |
|
| https://github.com/gabrielschulhof |
|
gabrielschulhof
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs/node/pull/23552/files/bec03b00b60afe09249f9ad8fefe64bbdc58c058 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/23552/files/bec03b00b60afe09249f9ad8fefe64bbdc58c058 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/23552/files/bec03b00b60afe09249f9ad8fefe64bbdc58c058 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/23552/files/bec03b00b60afe09249f9ad8fefe64bbdc58c058 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/23552/files/bec03b00b60afe09249f9ad8fefe64bbdc58c058 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/23552 |
|
| https://github.com/crpahl |
|
| https://github.com/BridgeAR |
|
| https://github.com/jasnell |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/cjihrig |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/trivikr |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |