| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6c24c14b-65aa-1873-87a9-0bdcf19fd2a8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9608:124E5D:23C103:2E283A:69903D13 |
| html-safe-nonce | f5182e83f9a5823d240036aefa51520c94e53151d5a01928c3652de8514becdf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjA4OjEyNEU1RDoyM0MxMDM6MkUyODNBOjY5OTAzRDEzIiwidmlzaXRvcl9pZCI6IjkyNDc1OTg5NDI4Nzk5MDAzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0784fc2fd57b6e867320d15e8c84841ba0d2631f5c591c021b8ea7c31705a00d |
| hovercard-subject-tag | pull_request:222539102 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23542/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/039f456004d770f21dc52462a5db0df63ef908ed2dd61c1456f0652c55c531e3/nodejs/node/pull/23542 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/039f456004d770f21dc52462a5db0df63ef908ed2dd61c1456f0652c55c531e3/nodejs/node/pull/23542 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | erin-bush |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23542#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23542 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23542 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23542 |
| Reload | https://github.com/nodejs/node/pull/23542 |
| Reload | https://github.com/nodejs/node/pull/23542 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23542 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
708
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| erin-bush | https://github.com/erin-bush |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| erin-bush:buffer-copy-test-assert-equals | https://github.com/erin-bush/node/tree/buffer-copy-test-assert-equals |
| Conversation | https://github.com/nodejs/node/pull/23542 |
| Commits1 (1) | https://github.com/nodejs/node/pull/23542/commits |
| Checks | https://github.com/nodejs/node/pull/23542/checks |
| Files changed | https://github.com/nodejs/node/pull/23542/files |
| test(pummel/test-net-pingpong-delay): swap expected and actual arguments in assert.strictEqual() | https://github.com/nodejs/node/pull/23542#top |
| erin-bush | https://github.com/erin-bush |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| erin-bush:buffer-copy-test-assert-equals | https://github.com/erin-bush/node/tree/buffer-copy-test-assert-equals |
|
| https://github.com/erin-bush |
| erin-bush | https://github.com/erin-bush |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23542#issue-369648143 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23542 |
|
| https://github.com/erin-bush |
| test(pummel/test-net-pingpong-delay): swap expected and actual argume… | https://github.com/nodejs/node/pull/23542/commits/7354abf63c15a784c70dd77ce4aba7cb6564229b |
| 7354abf | https://github.com/nodejs/node/pull/23542/commits/7354abf63c15a784c70dd77ce4aba7cb6564229b |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23542#event-1901323179 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23542#event-1901323918 |
| https://github.com/WaleedAshraf |
| WaleedAshraf | https://github.com/WaleedAshraf |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23542#pullrequestreview-164345813 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23542/files/7354abf63c15a784c70dd77ce4aba7cb6564229b |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23542#pullrequestreview-164345888 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23542/files/7354abf63c15a784c70dd77ce4aba7cb6564229b |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23542#pullrequestreview-164347321 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23542/files/7354abf63c15a784c70dd77ce4aba7cb6564229b |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23542#pullrequestreview-164445818 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23542/files/7354abf63c15a784c70dd77ce4aba7cb6564229b |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23542#pullrequestreview-164448559 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23542/files/7354abf63c15a784c70dd77ce4aba7cb6564229b |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23542#pullrequestreview-164465596 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23542/files/7354abf63c15a784c70dd77ce4aba7cb6564229b |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23542#pullrequestreview-164539730 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23542/files/7354abf63c15a784c70dd77ce4aba7cb6564229b |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23542#ref-commit-ae3b34b |
|
| https://github.com/erin-bush |
|
| https://github.com/BridgeAR |
| test: swap expected and actual arguments in assert.strictEqual() | https://github.com/BridgeAR/node/commit/ae3b34b3ac329183675e815253a1e6aa1361c4b8 |
| ae3b34b | https://github.com/BridgeAR/node/commit/ae3b34b3ac329183675e815253a1e6aa1361c4b8 |
| nodejs#23542 | https://github.com/nodejs/node/pull/23542 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23542#ref-commit-d83d3ed |
|
| https://github.com/erin-bush |
|
| https://github.com/BridgeAR |
| test: swap expected and actual arguments in assert.strictEqual() | https://github.com/BridgeAR/node/commit/d83d3ed2bcbe9532f834408fa8f1c7f66d92db4c |
| d83d3ed | https://github.com/BridgeAR/node/commit/d83d3ed2bcbe9532f834408fa8f1c7f66d92db4c |
| nodejs#23542 | https://github.com/nodejs/node/pull/23542 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Oct 15, 2018 | https://github.com/nodejs/node/pull/23542#issuecomment-429789729 |
| d83d3ed | https://github.com/nodejs/node/commit/d83d3ed2bcbe9532f834408fa8f1c7f66d92db4c |
| @erin-bush | https://github.com/erin-bush |
| Please reload this page | https://github.com/nodejs/node/pull/23542 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Oct 15, 2018 | https://github.com/nodejs/node/pull/23542#event-1903654227 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23542#ref-commit-ea90776 |
|
| https://github.com/erin-bush |
|
| https://github.com/jasnell |
| test: swap expected and actual arguments in assert.strictEqual() | https://github.com/nodejs/node/commit/ea907762277bd43003d74f33a250cf9cec5a21ed |
| ea90776 | https://github.com/nodejs/node/commit/ea907762277bd43003d74f33a250cf9cec5a21ed |
| #23542 | https://github.com/nodejs/node/pull/23542 |
| addaleax | https://github.com/addaleax |
|
Oct 20, 2018
| https://github.com/nodejs/node/pull/23542#ref-commit-b99cde1 |
|
| https://github.com/erin-bush |
|
| https://github.com/addaleax |
| test: swap expected and actual arguments in assert.strictEqual() | https://github.com/nodejs/node/commit/b99cde1de033ea2cd9ebe84cfaa943cc95e45501 |
| b99cde1 | https://github.com/nodejs/node/commit/b99cde1de033ea2cd9ebe84cfaa943cc95e45501 |
| #23542 | https://github.com/nodejs/node/pull/23542 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23542#ref-commit-adc89e3 |
|
| https://github.com/erin-bush |
|
| https://github.com/MylesBorins |
| test: swap expected and actual arguments in assert.strictEqual() | https://github.com/nodejs/node/commit/adc89e30cf4ffab59668fa2d106967603420823e |
| adc89e3 | https://github.com/nodejs/node/commit/adc89e30cf4ffab59668fa2d106967603420823e |
| #23542 | https://github.com/nodejs/node/pull/23542 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/23542#ref-pullrequest-384882602 |
|
v10.13.1 proposal
#24675
| https://github.com/nodejs/node/pull/24675 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23542#ref-commit-77e1c40 |
|
| https://github.com/erin-bush |
|
| https://github.com/rvagg |
| test: swap expected and actual arguments in assert.strictEqual() | https://github.com/nodejs/node/commit/77e1c400d5e26d96b6bb7f268e75eb755a373062 |
| 77e1c40 | https://github.com/nodejs/node/commit/77e1c400d5e26d96b6bb7f268e75eb755a373062 |
| #23542 | https://github.com/nodejs/node/pull/23542 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23542#ref-commit-a8501e4 |
|
| https://github.com/erin-bush |
|
| https://github.com/MylesBorins |
| test: swap expected and actual arguments in assert.strictEqual() | https://github.com/nodejs/node/commit/a8501e4ade3535f76dd1d91bbffedead54f10f4e |
| a8501e4 | https://github.com/nodejs/node/commit/a8501e4ade3535f76dd1d91bbffedead54f10f4e |
| #23542 | https://github.com/nodejs/node/pull/23542 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23542#ref-pullrequest-385836001 |
|
v10.14.2 proposal
#24727
| https://github.com/nodejs/node/pull/24727 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23542 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/23542/files/7354abf63c15a784c70dd77ce4aba7cb6564229b |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/23542/files/7354abf63c15a784c70dd77ce4aba7cb6564229b |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/23542/files/7354abf63c15a784c70dd77ce4aba7cb6564229b |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/23542/files/7354abf63c15a784c70dd77ce4aba7cb6564229b |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/23542/files/7354abf63c15a784c70dd77ce4aba7cb6564229b |
|
| https://github.com/WaleedAshraf |
|
WaleedAshraf
| https://github.com/WaleedAshraf |
|
| https://github.com/nodejs/node/pull/23542/files/7354abf63c15a784c70dd77ce4aba7cb6564229b |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/23542 |
|
| https://github.com/erin-bush |
|
| https://github.com/BridgeAR |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/WaleedAshraf |
|
| https://github.com/trivikr |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |