| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9a6dce84-2a5b-43f5-40ec-3a1ca7302a5a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 889E:1EB8D6:A9D15A:DD993C:699083BF |
| html-safe-nonce | d8fc8e443364b63a4cb288d91d282a4f2ce95a5d1889011c84619964f7d08c37 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODlFOjFFQjhENjpBOUQxNUE6REQ5OTNDOjY5OTA4M0JGIiwidmlzaXRvcl9pZCI6IjUyOTc0NTM4NDkwOTg4Nzk5MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e6975048a55e9b8d69e07f5330a26037b78355388fb67e449af8a71961996e22 |
| hovercard-subject-tag | pull_request:222538290 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23537/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1b8ac4bd5efd49d62888c7406d0b05a5507dfc24ed48bf12cb52dfcad3e538ca/nodejs/node/pull/23537 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1b8ac4bd5efd49d62888c7406d0b05a5507dfc24ed48bf12cb52dfcad3e538ca/nodejs/node/pull/23537 |
| og:image:alt | test: switch strictEqual parameters - actual first before expected
In the documentation, assert.strictEqual() the actual comes before the expected value.
This commit fixes test/pummel/test-exec.js ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | chrisbautista |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23537#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23537 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23537 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23537 |
| Reload | https://github.com/nodejs/node/pull/23537 |
| Reload | https://github.com/nodejs/node/pull/23537 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23537 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
706
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| chrisbautista | https://github.com/chrisbautista |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/23537 |
| Commits1 (1) | https://github.com/nodejs/node/pull/23537/commits |
| Checks | https://github.com/nodejs/node/pull/23537/checks |
| Files changed | https://github.com/nodejs/node/pull/23537/files |
| test: switch strictEqual parameters - actual first before expected | https://github.com/nodejs/node/pull/23537#top |
| chrisbautista | https://github.com/chrisbautista |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/chrisbautista |
| chrisbautista | https://github.com/chrisbautista |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23537#issue-369646998 |
| https://nodejs.org/api/assert.html#assert_assert_strictequal_actual_expected_message | https://nodejs.org/api/assert.html#assert_assert_strictequal_actual_expected_message |
| Please reload this page | https://github.com/nodejs/node/pull/23537 |
|
| https://github.com/chrisbautista |
| test: switch strictEqual parameters - actual first before expected | https://github.com/nodejs/node/pull/23537/commits/f8aefe1899d1a6e00c51822852eda8b5922961a2 |
| f8aefe1 | https://github.com/nodejs/node/pull/23537/commits/f8aefe1899d1a6e00c51822852eda8b5922961a2 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23537#event-1901316706 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23537#event-1901323099 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23537#pullrequestreview-164346172 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23537/files/f8aefe1899d1a6e00c51822852eda8b5922961a2 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23537#pullrequestreview-164445717 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23537/files/f8aefe1899d1a6e00c51822852eda8b5922961a2 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23537#pullrequestreview-164448648 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23537/files/f8aefe1899d1a6e00c51822852eda8b5922961a2 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23537#pullrequestreview-164465682 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23537/files/f8aefe1899d1a6e00c51822852eda8b5922961a2 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23537#pullrequestreview-164540292 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23537/files/f8aefe1899d1a6e00c51822852eda8b5922961a2 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23537#ref-commit-bde6c4b |
|
| https://github.com/chrisbautista |
|
| https://github.com/BridgeAR |
| test: switch strictEqual parameters - actual first before expected | https://github.com/BridgeAR/node/commit/bde6c4bc41b41ed96df4653dc08478e7b76eb00f |
| bde6c4b | https://github.com/BridgeAR/node/commit/bde6c4bc41b41ed96df4653dc08478e7b76eb00f |
| nodejs#23537 | https://github.com/nodejs/node/pull/23537 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23537#ref-commit-9631190 |
|
| https://github.com/chrisbautista |
|
| https://github.com/BridgeAR |
| test: switch strictEqual parameters - actual first before expected | https://github.com/BridgeAR/node/commit/96311903e87eeaabbd3ab0fddab205ee6000cdce |
| 9631190 | https://github.com/BridgeAR/node/commit/96311903e87eeaabbd3ab0fddab205ee6000cdce |
| nodejs#23537 | https://github.com/nodejs/node/pull/23537 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Oct 15, 2018 | https://github.com/nodejs/node/pull/23537#issuecomment-429788801 |
| 9631190 | https://github.com/nodejs/node/commit/96311903e87eeaabbd3ab0fddab205ee6000cdce |
| Please reload this page | https://github.com/nodejs/node/pull/23537 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Oct 15, 2018 | https://github.com/nodejs/node/pull/23537#event-1903648411 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23537#ref-commit-bea0819 |
|
| https://github.com/chrisbautista |
|
| https://github.com/jasnell |
| test: switch strictEqual parameters - actual first before expected | https://github.com/nodejs/node/commit/bea08191265c120f31b1e3b176b7ea7bc436f952 |
| bea0819 | https://github.com/nodejs/node/commit/bea08191265c120f31b1e3b176b7ea7bc436f952 |
| #23537 | https://github.com/nodejs/node/pull/23537 |
| addaleax | https://github.com/addaleax |
|
Oct 20, 2018
| https://github.com/nodejs/node/pull/23537#ref-commit-6643ad9 |
|
| https://github.com/chrisbautista |
|
| https://github.com/addaleax |
| test: switch strictEqual parameters - actual first before expected | https://github.com/nodejs/node/commit/6643ad9dd758ccfed39783ca558ec315aa917d9e |
| 6643ad9 | https://github.com/nodejs/node/commit/6643ad9dd758ccfed39783ca558ec315aa917d9e |
| #23537 | https://github.com/nodejs/node/pull/23537 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23537#ref-commit-8d583a7 |
|
| https://github.com/chrisbautista |
|
| https://github.com/MylesBorins |
| test: switch strictEqual parameters - actual first before expected | https://github.com/nodejs/node/commit/8d583a7b408e23656865e8d604a97db741ac6ac4 |
| 8d583a7 | https://github.com/nodejs/node/commit/8d583a7b408e23656865e8d604a97db741ac6ac4 |
| #23537 | https://github.com/nodejs/node/pull/23537 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/23537#ref-pullrequest-384882602 |
|
v10.13.1 proposal
#24675
| https://github.com/nodejs/node/pull/24675 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23537#ref-commit-9960be4 |
|
| https://github.com/chrisbautista |
|
| https://github.com/rvagg |
| test: switch strictEqual parameters - actual first before expected | https://github.com/nodejs/node/commit/9960be40d769716480712b21fc384cc12d281ac0 |
| 9960be4 | https://github.com/nodejs/node/commit/9960be40d769716480712b21fc384cc12d281ac0 |
| #23537 | https://github.com/nodejs/node/pull/23537 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23537#ref-commit-29db84a |
|
| https://github.com/chrisbautista |
|
| https://github.com/MylesBorins |
| test: switch strictEqual parameters - actual first before expected | https://github.com/nodejs/node/commit/29db84a7cc1f478c7b9771a3e90ed5b1154fed68 |
| 29db84a | https://github.com/nodejs/node/commit/29db84a7cc1f478c7b9771a3e90ed5b1154fed68 |
| #23537 | https://github.com/nodejs/node/pull/23537 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23537#ref-pullrequest-385836001 |
|
v10.14.2 proposal
#24727
| https://github.com/nodejs/node/pull/24727 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23537 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/23537/files/f8aefe1899d1a6e00c51822852eda8b5922961a2 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/23537/files/f8aefe1899d1a6e00c51822852eda8b5922961a2 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/23537/files/f8aefe1899d1a6e00c51822852eda8b5922961a2 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/23537/files/f8aefe1899d1a6e00c51822852eda8b5922961a2 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/23537/files/f8aefe1899d1a6e00c51822852eda8b5922961a2 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/23537 |
|
| https://github.com/chrisbautista |
|
| https://github.com/BridgeAR |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/trivikr |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |