René's URL Explorer Experiment


Title: Net test asserts by frony · Pull Request #23534 · nodejs/node · GitHub

Open Graph Title: Net test asserts by frony · Pull Request #23534 · nodejs/node

X Title: Net test asserts by frony · Pull Request #23534 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Revert arguments for assert and ensure that the first argument is always the actual value being tested Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks ...

X Description: Revert arguments for assert and ensure that the first argument is always the actual value being tested Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks ...

Opengraph URL: https://github.com/nodejs/node/pull/23534

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cceec1e7-8f2a-c066-1f27-529b2d3bcff5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA674:A47A9:13F60CF:197AFCB:69903150
html-safe-noncebdb885010e8cd98ba9a103ed96e67cf4168f072df296e93302fd0ea7c9617f55
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjc0OkE0N0E5OjEzRjYwQ0Y6MTk3QUZDQjo2OTkwMzE1MCIsInZpc2l0b3JfaWQiOiI1MTYxNzk5MjQ0MDg0OTQ5MzI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8ec6b927907c3e9bd74f7fc4dc818545913067ed8affc8fab5ea34021acf881e
hovercard-subject-tagpull_request:222538178
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23534/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cf46ab101b4a15db697eed6753fce380bf09821a77155c0c0cefe60e62c3459c/nodejs/node/pull/23534
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cf46ab101b4a15db697eed6753fce380bf09821a77155c0c0cefe60e62c3459c/nodejs/node/pull/23534
og:image:altRevert arguments for assert and ensure that the first argument is always the actual value being tested Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefrony
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23534#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23534
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23534
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23534
Reloadhttps://github.com/nodejs/node/pull/23534
Reloadhttps://github.com/nodejs/node/pull/23534
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23534
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
fronyhttps://github.com/frony
nodejs:masterhttps://github.com/nodejs/node/tree/master
frony:net-test-assertshttps://github.com/frony/node/tree/net-test-asserts
Conversationhttps://github.com/nodejs/node/pull/23534
Commits1 (1)https://github.com/nodejs/node/pull/23534/commits
Checkshttps://github.com/nodejs/node/pull/23534/checks
Files changedhttps://github.com/nodejs/node/pull/23534/files
Net test assertshttps://github.com/nodejs/node/pull/23534#top
fronyhttps://github.com/frony
nodejs:masterhttps://github.com/nodejs/node/tree/master
frony:net-test-assertshttps://github.com/frony/node/tree/net-test-asserts
https://github.com/frony
fronyhttps://github.com/frony
Oct 12, 2018https://github.com/nodejs/node/pull/23534#issue-369646831
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23534
https://github.com/frony
test: Reorder asserts argumentshttps://github.com/nodejs/node/pull/23534/commits/17a66d76956c63aa5cf5aa12307fd3038fc95e06
17a66d7https://github.com/nodejs/node/pull/23534/commits/17a66d76956c63aa5cf5aa12307fd3038fc95e06
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
meta https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta
Oct 12, 2018https://github.com/nodejs/node/pull/23534#event-1901315755
https://github.com/targos
targoshttps://github.com/targos
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Oct 12, 2018https://github.com/nodejs/node/pull/23534#event-1901323087
https://github.com/frony
fronyhttps://github.com/frony
force-pushedhttps://github.com/nodejs/node/compare/f3bbfe1e8f9d97de0e8c3fb973b46927f3db4881..17a66d76956c63aa5cf5aa12307fd3038fc95e06
f3bbfe1https://github.com/nodejs/node/commit/f3bbfe1e8f9d97de0e8c3fb973b46927f3db4881
17a66d7https://github.com/nodejs/node/commit/17a66d76956c63aa5cf5aa12307fd3038fc95e06
Compare https://github.com/nodejs/node/compare/f3bbfe1e8f9d97de0e8c3fb973b46927f3db4881..17a66d76956c63aa5cf5aa12307fd3038fc95e06
October 12, 2018 17:46https://github.com/nodejs/node/pull/23534#event-1901324662
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 12, 2018 https://github.com/nodejs/node/pull/23534#pullrequestreview-164346310
View reviewed changes https://github.com/nodejs/node/pull/23534/files/17a66d76956c63aa5cf5aa12307fd3038fc95e06
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 13, 2018 https://github.com/nodejs/node/pull/23534#pullrequestreview-164445685
View reviewed changes https://github.com/nodejs/node/pull/23534/files/17a66d76956c63aa5cf5aa12307fd3038fc95e06
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Oct 13, 2018 https://github.com/nodejs/node/pull/23534#pullrequestreview-164448723
View reviewed changes https://github.com/nodejs/node/pull/23534/files/17a66d76956c63aa5cf5aa12307fd3038fc95e06
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Oct 13, 2018 https://github.com/nodejs/node/pull/23534#pullrequestreview-164465667
View reviewed changes https://github.com/nodejs/node/pull/23534/files/17a66d76956c63aa5cf5aa12307fd3038fc95e06
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018 https://github.com/nodejs/node/pull/23534#pullrequestreview-164538368
View reviewed changes https://github.com/nodejs/node/pull/23534/files/17a66d76956c63aa5cf5aa12307fd3038fc95e06
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018 https://github.com/nodejs/node/pull/23534#ref-commit-edb388d
https://github.com/frony
https://github.com/BridgeAR
test: reorder asserts argumentshttps://github.com/BridgeAR/node/commit/edb388d9b72a016747fb1c858b7ec36e239ac273
edb388dhttps://github.com/BridgeAR/node/commit/edb388d9b72a016747fb1c858b7ec36e239ac273
nodejs#23534https://github.com/nodejs/node/pull/23534
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018 https://github.com/nodejs/node/pull/23534#ref-commit-c3ebc02
https://github.com/frony
https://github.com/BridgeAR
test: reorder asserts argumentshttps://github.com/BridgeAR/node/commit/c3ebc028d2ebb2c2ab7ce908f57d37ac93f90c20
c3ebc02https://github.com/BridgeAR/node/commit/c3ebc028d2ebb2c2ab7ce908f57d37ac93f90c20
nodejs#23534https://github.com/nodejs/node/pull/23534
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018https://github.com/nodejs/node/pull/23534#issuecomment-429792510
c3ebc02https://github.com/nodejs/node/commit/c3ebc028d2ebb2c2ab7ce908f57d37ac93f90c20
@fronyhttps://github.com/frony
Please reload this pagehttps://github.com/nodejs/node/pull/23534
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 15, 2018https://github.com/nodejs/node/pull/23534#event-1903672900
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23534#ref-commit-ffab8ba
https://github.com/frony
https://github.com/jasnell
test: reorder asserts argumentshttps://github.com/nodejs/node/commit/ffab8ba33f5aa980ddab342f5d8aae6c4944f35d
ffab8bahttps://github.com/nodejs/node/commit/ffab8ba33f5aa980ddab342f5d8aae6c4944f35d
#23534https://github.com/nodejs/node/pull/23534
addaleaxhttps://github.com/addaleax
Oct 20, 2018 https://github.com/nodejs/node/pull/23534#ref-commit-179499c
https://github.com/frony
https://github.com/addaleax
test: reorder asserts argumentshttps://github.com/nodejs/node/commit/179499c59a2433f6b92c1d2e0aa852a5409794f4
179499chttps://github.com/nodejs/node/commit/179499c59a2433f6b92c1d2e0aa852a5409794f4
#23534https://github.com/nodejs/node/pull/23534
MylesBorinshttps://github.com/MylesBorins
Oct 30, 2018 https://github.com/nodejs/node/pull/23534#ref-commit-474b401
https://github.com/frony
https://github.com/MylesBorins
test: reorder asserts argumentshttps://github.com/nodejs/node/commit/474b401794b63614da12fe003273440dd5aefe43
474b401https://github.com/nodejs/node/commit/474b401794b63614da12fe003273440dd5aefe43
#23534https://github.com/nodejs/node/pull/23534
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23534#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23534#ref-commit-a557e0f
https://github.com/frony
https://github.com/rvagg
test: reorder asserts argumentshttps://github.com/nodejs/node/commit/a557e0ffb7096052c6b49452a1f7f4debe46784e
a557e0fhttps://github.com/nodejs/node/commit/a557e0ffb7096052c6b49452a1f7f4debe46784e
#23534https://github.com/nodejs/node/pull/23534
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23534#ref-commit-3c5d312
https://github.com/frony
https://github.com/MylesBorins
test: reorder asserts argumentshttps://github.com/nodejs/node/commit/3c5d31266232fe7a0fea3d0c1088b190377da020
3c5d312https://github.com/nodejs/node/commit/3c5d31266232fe7a0fea3d0c1088b190377da020
#23534https://github.com/nodejs/node/pull/23534
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23534#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23534
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23534/files/17a66d76956c63aa5cf5aa12307fd3038fc95e06
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23534/files/17a66d76956c63aa5cf5aa12307fd3038fc95e06
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/23534/files/17a66d76956c63aa5cf5aa12307fd3038fc95e06
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/23534/files/17a66d76956c63aa5cf5aa12307fd3038fc95e06
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/23534/files/17a66d76956c63aa5cf5aa12307fd3038fc95e06
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
meta https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta
Please reload this pagehttps://github.com/nodejs/node/pull/23534
https://github.com/frony
https://github.com/BridgeAR
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/gireeshpunathil
https://github.com/trivikr
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.