| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c7c7c9f5-28e2-bd4d-6eac-43742a1fd63a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C372:87397:A160FA:D16034:69906866 |
| html-safe-nonce | 7f0fbb6d57e5d7e56632b74b1686ce31f47effcbd6b9bba507913642c942ffad |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzcyOjg3Mzk3OkExNjBGQTpEMTYwMzQ6Njk5MDY4NjYiLCJ2aXNpdG9yX2lkIjoiNzkwODkwNDU0NzU4OTg0MzA0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4e1f80d2d538db37a6c35206058cab5c57b6ba5cd68d8e1f4dbc7dd8dc74ad71 |
| hovercard-subject-tag | pull_request:222535511 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23516/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bb0487e655752f3ceb6f1335d4d13f7a871acb9309ebcc42c2a9006cc67cab71/nodejs/node/pull/23516 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bb0487e655752f3ceb6f1335d4d13f7a871acb9309ebcc42c2a9006cc67cab71/nodejs/node/pull/23516 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | takdeerkaur |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23516#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23516 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23516 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23516 |
| Reload | https://github.com/nodejs/node/pull/23516 |
| Reload | https://github.com/nodejs/node/pull/23516 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23516 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
706
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| takdeerkaur | https://github.com/takdeerkaur |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| takdeerkaur:fix-assert | https://github.com/takdeerkaur/node/tree/fix-assert |
| Conversation | https://github.com/nodejs/node/pull/23516 |
| Commits1 (1) | https://github.com/nodejs/node/pull/23516/commits |
| Checks | https://github.com/nodejs/node/pull/23516/checks |
| Files changed | https://github.com/nodejs/node/pull/23516/files |
| test: fix assert.strictEqual arg order in test-tls-ecdh-multiple.js | https://github.com/nodejs/node/pull/23516#top |
| takdeerkaur | https://github.com/takdeerkaur |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| takdeerkaur:fix-assert | https://github.com/takdeerkaur/node/tree/fix-assert |
|
| https://github.com/takdeerkaur |
| takdeerkaur | https://github.com/takdeerkaur |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23516#issue-369642854 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23516 |
|
| https://github.com/takdeerkaur |
| test: fix assert.strictEqual arg order in test-tls-ecdh-multiple.js | https://github.com/nodejs/node/pull/23516/commits/dcad6d612bd428767c0e4d6ff20e23db2654896c |
| dcad6d6 | https://github.com/nodejs/node/pull/23516/commits/dcad6d612bd428767c0e4d6ff20e23db2654896c |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23516#event-1901293699 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23516#event-1901299257 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23516#pullrequestreview-164349864 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23516/files/dcad6d612bd428767c0e4d6ff20e23db2654896c |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23516#pullrequestreview-164358270 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23516/files/dcad6d612bd428767c0e4d6ff20e23db2654896c |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23516#pullrequestreview-164446271 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23516/files/dcad6d612bd428767c0e4d6ff20e23db2654896c |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23516#pullrequestreview-164469527 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23516/files/dcad6d612bd428767c0e4d6ff20e23db2654896c |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23516#pullrequestreview-164536936 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23516/files/dcad6d612bd428767c0e4d6ff20e23db2654896c |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23516#ref-commit-074be5b |
|
| https://github.com/takdeerkaur |
|
| https://github.com/BridgeAR |
| test: fix assert.strictEqual arg order in test-tls-ecdh-multiple.js | https://github.com/BridgeAR/node/commit/074be5b0c761b7eb78c00357dd2f18c2b5b549b1 |
| 074be5b | https://github.com/BridgeAR/node/commit/074be5b0c761b7eb78c00357dd2f18c2b5b549b1 |
| nodejs#23516 | https://github.com/nodejs/node/pull/23516 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23516#ref-commit-8f68ed9 |
|
| https://github.com/takdeerkaur |
|
| https://github.com/BridgeAR |
| test: fix assert.strictEqual arg order in test-tls-ecdh-multiple.js | https://github.com/BridgeAR/node/commit/8f68ed92fc262f374f7a37cfe99ab4404e0c6d33 |
| 8f68ed9 | https://github.com/BridgeAR/node/commit/8f68ed92fc262f374f7a37cfe99ab4404e0c6d33 |
| nodejs#23516 | https://github.com/nodejs/node/pull/23516 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Oct 15, 2018 | https://github.com/nodejs/node/pull/23516#issuecomment-429793664 |
| 8f68ed9 | https://github.com/nodejs/node/commit/8f68ed92fc262f374f7a37cfe99ab4404e0c6d33 |
| @takdeerkaur | https://github.com/takdeerkaur |
| Please reload this page | https://github.com/nodejs/node/pull/23516 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Oct 15, 2018 | https://github.com/nodejs/node/pull/23516#event-1903681221 |
| https://github.com/takdeerkaur |
| takdeerkaur | https://github.com/takdeerkaur |
| Oct 15, 2018 | https://github.com/nodejs/node/pull/23516#issuecomment-429945788 |
| Please reload this page | https://github.com/nodejs/node/pull/23516 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23516#ref-commit-1eea1aa |
|
| https://github.com/takdeerkaur |
|
| https://github.com/jasnell |
| test: fix assert.strictEqual arg order in test-tls-ecdh-multiple.js | https://github.com/nodejs/node/commit/1eea1aa51331deb2721f6e95218965313928f0c1 |
| 1eea1aa | https://github.com/nodejs/node/commit/1eea1aa51331deb2721f6e95218965313928f0c1 |
| #23516 | https://github.com/nodejs/node/pull/23516 |
| addaleax | https://github.com/addaleax |
|
Oct 20, 2018
| https://github.com/nodejs/node/pull/23516#ref-commit-7f1e8d8 |
|
| https://github.com/takdeerkaur |
|
| https://github.com/addaleax |
| test: fix assert.strictEqual arg order in test-tls-ecdh-multiple.js | https://github.com/nodejs/node/commit/7f1e8d89d95f5155f8c5df79186511035eb2784d |
| 7f1e8d8 | https://github.com/nodejs/node/commit/7f1e8d89d95f5155f8c5df79186511035eb2784d |
| #23516 | https://github.com/nodejs/node/pull/23516 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23516#ref-commit-161cbbb |
|
| https://github.com/takdeerkaur |
|
| https://github.com/MylesBorins |
| test: fix assert.strictEqual arg order in test-tls-ecdh-multiple.js | https://github.com/nodejs/node/commit/161cbbb97ac3fa121a7714b2a14cc21baf8aed53 |
| 161cbbb | https://github.com/nodejs/node/commit/161cbbb97ac3fa121a7714b2a14cc21baf8aed53 |
| #23516 | https://github.com/nodejs/node/pull/23516 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/23516#ref-pullrequest-384882602 |
|
v10.13.1 proposal
#24675
| https://github.com/nodejs/node/pull/24675 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23516#ref-commit-bc537ec |
|
| https://github.com/takdeerkaur |
|
| https://github.com/rvagg |
| test: fix assert.strictEqual arg order in test-tls-ecdh-multiple.js | https://github.com/nodejs/node/commit/bc537ec3c31a394717e4f1691b526dfb996328eb |
| bc537ec | https://github.com/nodejs/node/commit/bc537ec3c31a394717e4f1691b526dfb996328eb |
| #23516 | https://github.com/nodejs/node/pull/23516 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23516#ref-commit-1e0a969 |
|
| https://github.com/takdeerkaur |
|
| https://github.com/MylesBorins |
| test: fix assert.strictEqual arg order in test-tls-ecdh-multiple.js | https://github.com/nodejs/node/commit/1e0a969b85efa94c55602c4265b8cda0d9462fb2 |
| 1e0a969 | https://github.com/nodejs/node/commit/1e0a969b85efa94c55602c4265b8cda0d9462fb2 |
| #23516 | https://github.com/nodejs/node/pull/23516 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23516#ref-pullrequest-385836001 |
|
v10.14.2 proposal
#24727
| https://github.com/nodejs/node/pull/24727 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23516 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/23516/files/dcad6d612bd428767c0e4d6ff20e23db2654896c |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/23516/files/dcad6d612bd428767c0e4d6ff20e23db2654896c |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/23516/files/dcad6d612bd428767c0e4d6ff20e23db2654896c |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/23516/files/dcad6d612bd428767c0e4d6ff20e23db2654896c |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/23516/files/dcad6d612bd428767c0e4d6ff20e23db2654896c |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/23516 |
|
| https://github.com/takdeerkaur |
|
| https://github.com/BridgeAR |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/trivikr |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |