| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:534ca922-33b8-765b-fc01-b6f6d7ace84b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BCB4:18B2A3:5E5393:7A806E:69904A67 |
| html-safe-nonce | d301016fdb35ab8e0f84009756613673b1f570e3f0a9efdb200a17dacdecce43 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0I0OjE4QjJBMzo1RTUzOTM6N0E4MDZFOjY5OTA0QTY3IiwidmlzaXRvcl9pZCI6IjczOTIzMDEwMDY0MzkwNzQ0MDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 47a9352e90fce2d5bdc5dbb4ce9ecc33a92044f5d7023ebe91e8fdd1bf20048d |
| hovercard-subject-tag | pull_request:222532125 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23494/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d1967d5e23f0bf08b2ea93a54ac58d2164b92735f87a6974d3ccb6fadf5a5386/nodejs/node/pull/23494 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d1967d5e23f0bf08b2ea93a54ac58d2164b92735f87a6974d3ccb6fadf5a5386/nodejs/node/pull/23494 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | scabhi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23494#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23494 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23494 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23494 |
| Reload | https://github.com/nodejs/node/pull/23494 |
| Reload | https://github.com/nodejs/node/pull/23494 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23494 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
707
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| scabhi | https://github.com/scabhi |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| scabhi:master | https://github.com/scabhi/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/23494 |
| Commits3 (3) | https://github.com/nodejs/node/pull/23494/commits |
| Checks | https://github.com/nodejs/node/pull/23494/checks |
| Files changed | https://github.com/nodejs/node/pull/23494/files |
| test: corrected assertion parameters on test/known_issues/test-inspector-cluster-port-clash.js | https://github.com/nodejs/node/pull/23494#top |
| scabhi | https://github.com/scabhi |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| scabhi:master | https://github.com/scabhi/node/tree/master |
|
| https://github.com/scabhi |
| scabhi | https://github.com/scabhi |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23494#issue-369637873 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23494 |
| scabhi | https://github.com/scabhi |
| October 12, 2018 09:55 | https://github.com/nodejs/node/pull/23494#commits-pushed-9a0a5c9 |
|
| https://github.com/scabhi |
| fixed assertion, reversed argument in strictqual to reflect documenta… | https://github.com/nodejs/node/pull/23494/commits/9a0a5c999d9ffbd98a8a84adca4fc5c0a2aa22ef |
| 9a0a5c9 | https://github.com/nodejs/node/pull/23494/commits/9a0a5c999d9ffbd98a8a84adca4fc5c0a2aa22ef |
|
| https://github.com/scabhi |
| test: reversed arguments in strictqual to reflect documentation | https://github.com/nodejs/node/pull/23494/commits/bdb957dc8b1c1068779d59f12470951caf8673a2 |
| bdb957d | https://github.com/nodejs/node/pull/23494/commits/bdb957dc8b1c1068779d59f12470951caf8673a2 |
|
| https://github.com/scabhi |
| Merge branch 'master' of | https://github.com/nodejs/node/pull/23494/commits/baac96442f05dace0149f91e35bd0c92feb9a30d |
| https://github.com/scabhi/node | https://github.com/scabhi/node |
| baac964 | https://github.com/nodejs/node/pull/23494/commits/baac96442f05dace0149f91e35bd0c92feb9a30d |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23494#event-1901265896 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23494#pullrequestreview-164334541 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23494/files/baac96442f05dace0149f91e35bd0c92feb9a30d |
| https://github.com/targos |
| targos | https://github.com/targos |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23494#event-1901278264 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23494#pullrequestreview-164351525 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23494/files/baac96442f05dace0149f91e35bd0c92feb9a30d |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23494#pullrequestreview-164352130 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23494/files/baac96442f05dace0149f91e35bd0c92feb9a30d |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23494#pullrequestreview-164432672 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23494/files/baac96442f05dace0149f91e35bd0c92feb9a30d |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23494#pullrequestreview-164533192 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23494/files/baac96442f05dace0149f91e35bd0c92feb9a30d |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23494#ref-commit-9780ab2 |
|
| https://github.com/scabhi |
|
| https://github.com/BridgeAR |
| test: reversed arguments in strictqual to reflect documentation | https://github.com/BridgeAR/node/commit/9780ab2d35707dab6acfb80a52d680f3ca99889b |
| 9780ab2 | https://github.com/BridgeAR/node/commit/9780ab2d35707dab6acfb80a52d680f3ca99889b |
| nodejs#23494 | https://github.com/nodejs/node/pull/23494 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 15, 2018
| https://github.com/nodejs/node/pull/23494#ref-commit-3fda986 |
|
| https://github.com/scabhi |
|
| https://github.com/BridgeAR |
| test: reversed arguments in strictqual to reflect documentation | https://github.com/BridgeAR/node/commit/3fda9860ec9c18ace9d0e78f0bc911cdc4b722dd |
| 3fda986 | https://github.com/BridgeAR/node/commit/3fda9860ec9c18ace9d0e78f0bc911cdc4b722dd |
| nodejs#23494 | https://github.com/nodejs/node/pull/23494 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Oct 15, 2018 | https://github.com/nodejs/node/pull/23494#issuecomment-429798135 |
| 3fda986 | https://github.com/nodejs/node/commit/3fda9860ec9c18ace9d0e78f0bc911cdc4b722dd |
| @scabhi | https://github.com/scabhi |
| Please reload this page | https://github.com/nodejs/node/pull/23494 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Oct 15, 2018 | https://github.com/nodejs/node/pull/23494#event-1903705476 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23494#ref-commit-6973596 |
|
| https://github.com/scabhi |
|
| https://github.com/jasnell |
| test: reversed arguments in strictqual to reflect documentation | https://github.com/nodejs/node/commit/697359637a5d28f79dc30b10fc0ba48f8088f34d |
| 6973596 | https://github.com/nodejs/node/commit/697359637a5d28f79dc30b10fc0ba48f8088f34d |
| #23494 | https://github.com/nodejs/node/pull/23494 |
| addaleax | https://github.com/addaleax |
|
Oct 20, 2018
| https://github.com/nodejs/node/pull/23494#ref-commit-3c780c8 |
|
| https://github.com/scabhi |
|
| https://github.com/addaleax |
| test: reversed arguments in strictqual to reflect documentation | https://github.com/nodejs/node/commit/3c780c8a0baf8827a4b451aebe7fd4a076a3fc95 |
| 3c780c8 | https://github.com/nodejs/node/commit/3c780c8a0baf8827a4b451aebe7fd4a076a3fc95 |
| #23494 | https://github.com/nodejs/node/pull/23494 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23494#ref-commit-e9f1746 |
|
| https://github.com/scabhi |
|
| https://github.com/MylesBorins |
| test: reversed arguments in strictqual to reflect documentation | https://github.com/nodejs/node/commit/e9f17464a836b648abafd48c67069cda99913624 |
| e9f1746 | https://github.com/nodejs/node/commit/e9f17464a836b648abafd48c67069cda99913624 |
| #23494 | https://github.com/nodejs/node/pull/23494 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/23494#ref-pullrequest-384882602 |
|
v10.13.1 proposal
#24675
| https://github.com/nodejs/node/pull/24675 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23494#ref-commit-ac8fbc5 |
|
| https://github.com/scabhi |
|
| https://github.com/rvagg |
| test: reversed arguments in strictqual to reflect documentation | https://github.com/nodejs/node/commit/ac8fbc5290b888c9a9a1d3d5b43381d363bf7623 |
| ac8fbc5 | https://github.com/nodejs/node/commit/ac8fbc5290b888c9a9a1d3d5b43381d363bf7623 |
| #23494 | https://github.com/nodejs/node/pull/23494 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23494#ref-commit-91ec313 |
|
| https://github.com/scabhi |
|
| https://github.com/MylesBorins |
| test: reversed arguments in strictqual to reflect documentation | https://github.com/nodejs/node/commit/91ec3137fc352bc5a4f461d25add687dfd210bb5 |
| 91ec313 | https://github.com/nodejs/node/commit/91ec3137fc352bc5a4f461d25add687dfd210bb5 |
| #23494 | https://github.com/nodejs/node/pull/23494 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23494#ref-pullrequest-385836001 |
|
v10.14.2 proposal
#24727
| https://github.com/nodejs/node/pull/24727 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23494 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/23494/files/baac96442f05dace0149f91e35bd0c92feb9a30d |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/23494/files/baac96442f05dace0149f91e35bd0c92feb9a30d |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/23494/files/baac96442f05dace0149f91e35bd0c92feb9a30d |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/23494/files/baac96442f05dace0149f91e35bd0c92feb9a30d |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/23494/files/baac96442f05dace0149f91e35bd0c92feb9a30d |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/23494 |
|
| https://github.com/scabhi |
|
| https://github.com/BridgeAR |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/trivikr |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |