| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3086361d-4d83-5c1f-a11b-c7bb9167f22e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C2B0:1B8BC6:28EE3D:33C156:6990679B |
| html-safe-nonce | 694a6d78840461f632eeb67ceb01bc65ad72cef21ea06ebdcd1b6ae13256a8f5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkIwOjFCOEJDNjoyOEVFM0Q6MzNDMTU2OjY5OTA2NzlCIiwidmlzaXRvcl9pZCI6IjQ4MzczMjQzMTYyODY5MTM1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 66c190d3ec46f0df72b298eaef94303d671a1eb7f4d546fde5a51893d4a6c70a |
| hovercard-subject-tag | pull_request:222529386 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23472/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fa6159d21a85abb95d86efbbccb4341971fe04117b3818cbefe43ff9c1b7bd53/nodejs/node/pull/23472 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fa6159d21a85abb95d86efbbccb4341971fe04117b3818cbefe43ff9c1b7bd53/nodejs/node/pull/23472 |
| og:image:alt | Removes the unneccesary usage of the process.exit event listener
(NodeJS code and learn)
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
d... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lianmakesthings |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23472#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23472 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23472 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23472 |
| Reload | https://github.com/nodejs/node/pull/23472 |
| Reload | https://github.com/nodejs/node/pull/23472 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23472 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
706
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| lianmakesthings | https://github.com/lianmakesthings |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lianmakesthings:remove_usage_of_process_exit_event_listener | https://github.com/lianmakesthings/node/tree/remove_usage_of_process_exit_event_listener |
| Conversation | https://github.com/nodejs/node/pull/23472 |
| Commits1 (1) | https://github.com/nodejs/node/pull/23472/commits |
| Checks | https://github.com/nodejs/node/pull/23472/checks |
| Files changed | https://github.com/nodejs/node/pull/23472/files |
| readline: remove usage of process exit event listener | https://github.com/nodejs/node/pull/23472#top |
| lianmakesthings | https://github.com/lianmakesthings |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lianmakesthings:remove_usage_of_process_exit_event_listener | https://github.com/lianmakesthings/node/tree/remove_usage_of_process_exit_event_listener |
|
| https://github.com/lianmakesthings |
| lianmakesthings | https://github.com/lianmakesthings |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23472#issue-369633925 |
| Please reload this page | https://github.com/nodejs/node/pull/23472 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23472 |
| readline: assert without the use of event listener | https://github.com/nodejs/node/pull/23472/commits/5fb36b8a1bc2b2c51601d2c74426f186857bd487 |
| 5fb36b8 | https://github.com/nodejs/node/pull/23472/commits/5fb36b8a1bc2b2c51601d2c74426f186857bd487 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23472#event-1901242651 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23472#pullrequestreview-164331389 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23472/files/5fb36b8a1bc2b2c51601d2c74426f186857bd487 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23472#event-1901278165 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23472#pullrequestreview-164344720 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23472/files/5fb36b8a1bc2b2c51601d2c74426f186857bd487 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23472#pullrequestreview-164345302 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23472/files/5fb36b8a1bc2b2c51601d2c74426f186857bd487 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23472#pullrequestreview-164449705 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23472/files/5fb36b8a1bc2b2c51601d2c74426f186857bd487 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23472#pullrequestreview-164470715 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23472/files/5fb36b8a1bc2b2c51601d2c74426f186857bd487 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Oct 14, 2018
| https://github.com/nodejs/node/pull/23472#ref-pullrequest-369856748 |
|
Code and learn rollup 2
#23651
| https://github.com/nodejs/node/pull/23651 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 14, 2018 | https://github.com/nodejs/node/pull/23472#issuecomment-429588045 |
| https://ci.nodejs.org/job/node-test-pull-request/17843/ | https://ci.nodejs.org/job/node-test-pull-request/17843/ |
| Please reload this page | https://github.com/nodejs/node/pull/23472 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 14, 2018 | https://github.com/nodejs/node/pull/23472#issuecomment-429591089 |
| Please reload this page | https://github.com/nodejs/node/pull/23472 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
readline
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Oct 14, 2018 | https://github.com/nodejs/node/pull/23472#event-1902416231 |
| Trott | https://github.com/Trott |
|
Oct 14, 2018
| https://github.com/nodejs/node/pull/23472#ref-commit-f569ecf |
|
| https://github.com/Trott |
| readline: assert without the use of event listener | https://github.com/Trott/io.js/commit/f569ecf7b387df33e54683eb5bef690a16b045ac |
| f569ecf | https://github.com/Trott/io.js/commit/f569ecf7b387df33e54683eb5bef690a16b045ac |
| nodejs#23472 | https://github.com/nodejs/node/pull/23472 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 14, 2018 | https://github.com/nodejs/node/pull/23472#issuecomment-429593077 |
| f569ecf | https://github.com/nodejs/node/commit/f569ecf7b387df33e54683eb5bef690a16b045ac |
| https://www.nodetodo.org/next-steps/ | https://www.nodetodo.org/next-steps/ |
| Please reload this page | https://github.com/nodejs/node/pull/23472 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 14, 2018 | https://github.com/nodejs/node/pull/23472#event-1902425551 |
| addaleax | https://github.com/addaleax |
|
Oct 14, 2018
| https://github.com/nodejs/node/pull/23472#ref-commit-3b0b3d6 |
|
| https://github.com/addaleax |
| readline: assert without the use of event listener | https://github.com/nodejs/node/commit/3b0b3d677bcd4c43b27a8f8014d831221750ee11 |
| 3b0b3d6 | https://github.com/nodejs/node/commit/3b0b3d677bcd4c43b27a8f8014d831221750ee11 |
| #23472 | https://github.com/nodejs/node/pull/23472 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23472#ref-commit-3c329be |
|
| https://github.com/jasnell |
| readline: assert without the use of event listener | https://github.com/nodejs/node/commit/3c329bee05239403061babc8bb383c25ec25d967 |
| 3c329be | https://github.com/nodejs/node/commit/3c329bee05239403061babc8bb383c25ec25d967 |
| #23472 | https://github.com/nodejs/node/pull/23472 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23472#ref-commit-5e1b9c3 |
|
| https://github.com/MylesBorins |
| readline: assert without the use of event listener | https://github.com/nodejs/node/commit/5e1b9c3c9101a1e3040aff95ca714a320ecc210b |
| 5e1b9c3 | https://github.com/nodejs/node/commit/5e1b9c3c9101a1e3040aff95ca714a320ecc210b |
| #23472 | https://github.com/nodejs/node/pull/23472 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/23472#ref-pullrequest-384882602 |
|
v10.13.1 proposal
#24675
| https://github.com/nodejs/node/pull/24675 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23472#ref-commit-a552cb6 |
|
| https://github.com/rvagg |
| readline: assert without the use of event listener | https://github.com/nodejs/node/commit/a552cb654c7bb3cc40bbaa34da24db082c4ccbe6 |
| a552cb6 | https://github.com/nodejs/node/commit/a552cb654c7bb3cc40bbaa34da24db082c4ccbe6 |
| #23472 | https://github.com/nodejs/node/pull/23472 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23472#ref-commit-f11907c |
|
| https://github.com/MylesBorins |
| readline: assert without the use of event listener | https://github.com/nodejs/node/commit/f11907c32dc940d64d105a2476e1eea42d3ff078 |
| f11907c | https://github.com/nodejs/node/commit/f11907c32dc940d64d105a2476e1eea42d3ff078 |
| #23472 | https://github.com/nodejs/node/pull/23472 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23472#ref-pullrequest-385836001 |
|
v10.14.2 proposal
#24727
| https://github.com/nodejs/node/pull/24727 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23472 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/23472/files/5fb36b8a1bc2b2c51601d2c74426f186857bd487 |
|
| https://github.com/codebytere |
|
codebytere
| https://github.com/codebytere |
|
| https://github.com/nodejs/node/pull/23472/files/5fb36b8a1bc2b2c51601d2c74426f186857bd487 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/23472/files/5fb36b8a1bc2b2c51601d2c74426f186857bd487 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/23472/files/5fb36b8a1bc2b2c51601d2c74426f186857bd487 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/23472/files/5fb36b8a1bc2b2c51601d2c74426f186857bd487 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
readline
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/23472 |
|
| https://github.com/lianmakesthings |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
|
| https://github.com/cjihrig |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/trivikr |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |