| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f28a4b52-869a-9058-4732-c1c0f80fa267 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EBE2:17C38B:296536C:352EB9C:699030A7 |
| html-safe-nonce | d021d346c20a88f7a9a71c838b04b9687e932dbbf6668e1fb1da65be3c59013d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkUyOjE3QzM4QjoyOTY1MzZDOjM1MkVCOUM6Njk5MDMwQTciLCJ2aXNpdG9yX2lkIjoiMzc0NTU2MjM4MjcxMTE0MDUxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 449fad2ee4125485b9b99106914847d6bc76ed983d978af81f9a275a7c5441d2 |
| hovercard-subject-tag | pull_request:222520918 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23449/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6472874c483c08f9d65c8d4665f3fbba23cb53597071a83e97c811d6c046f2b9/nodejs/node/pull/23449 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6472874c483c08f9d65c8d4665f3fbba23cb53597071a83e97c811d6c046f2b9/nodejs/node/pull/23449 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | khalidadil |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23449#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23449 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23449 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23449 |
| Reload | https://github.com/nodejs/node/pull/23449 |
| Reload | https://github.com/nodejs/node/pull/23449 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23449 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
709
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| khalidadil | https://github.com/khalidadil |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| khalidadil:master | https://github.com/khalidadil/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/23449 |
| Commits1 (1) | https://github.com/nodejs/node/pull/23449/commits |
| Checks | https://github.com/nodejs/node/pull/23449/checks |
| Files changed | https://github.com/nodejs/node/pull/23449/files |
| repl: remove unused variable e from try catch | https://github.com/nodejs/node/pull/23449#top |
| khalidadil | https://github.com/khalidadil |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| khalidadil:master | https://github.com/khalidadil/node/tree/master |
|
| https://github.com/khalidadil |
| khalidadil | https://github.com/khalidadil |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23449#issue-369622401 |
| Please reload this page | https://github.com/nodejs/node/pull/23449 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23449 |
|
| https://github.com/khalidadil |
| repl: remove unused variable e from try catch | https://github.com/nodejs/node/pull/23449/commits/e0526eeb83f9820f92214a1271f111368366d8c3 |
| e0526ee | https://github.com/nodejs/node/pull/23449/commits/e0526eeb83f9820f92214a1271f111368366d8c3 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
repl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23449#event-1901174156 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23449#pullrequestreview-164319809 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23449/files/e0526eeb83f9820f92214a1271f111368366d8c3 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23449#event-1901188542 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23449#pullrequestreview-164321836 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23449/files/e0526eeb83f9820f92214a1271f111368366d8c3 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23449#pullrequestreview-164326500 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23449/files/e0526eeb83f9820f92214a1271f111368366d8c3 |
| https://github.com/WaleedAshraf |
| WaleedAshraf | https://github.com/WaleedAshraf |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/23449#pullrequestreview-164346353 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23449/files/e0526eeb83f9820f92214a1271f111368366d8c3 |
| lib/repl.js | https://github.com/nodejs/node/pull/23449/files/e0526eeb83f9820f92214a1271f111368366d8c3#diff-392b628f0a5eb047b1117351e6eedcefb8ec70a48933479e0e9bdc711a04f047 |
| WaleedAshraf | https://github.com/WaleedAshraf |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/23449#discussion_r224867164 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23449 |
| thefourtheye | https://github.com/thefourtheye |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23449#discussion_r224953435 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23449 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23449#issuecomment-429512100 |
| https://ci.nodejs.org/job/node-test-pull-request/17800 | https://ci.nodejs.org/job/node-test-pull-request/17800 |
| Please reload this page | https://github.com/nodejs/node/pull/23449 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23449#pullrequestreview-164455810 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23449/files/e0526eeb83f9820f92214a1271f111368366d8c3 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23449#issuecomment-429545725 |
| Please reload this page | https://github.com/nodejs/node/pull/23449 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23449#event-1902182071 |
| Trott | https://github.com/Trott |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23449#ref-commit-f0c5c96 |
|
| https://github.com/khalidadil |
|
| https://github.com/Trott |
| repl: remove unused variable e from try catch | https://github.com/Trott/io.js/commit/f0c5c962ce971213c0c055b91bb747860defd492 |
| f0c5c96 | https://github.com/Trott/io.js/commit/f0c5c962ce971213c0c055b91bb747860defd492 |
| nodejs#23449 | https://github.com/nodejs/node/pull/23449 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23449#issuecomment-429553541 |
| Please reload this page | https://github.com/nodejs/node/pull/23449 |
| https://www.nodetodo.org/next-steps/ | https://www.nodetodo.org/next-steps/ |
| Please reload this page | https://github.com/nodejs/node/pull/23449 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 13, 2018 | https://github.com/nodejs/node/pull/23449#event-1902223764 |
| addaleax | https://github.com/addaleax |
|
Oct 14, 2018
| https://github.com/nodejs/node/pull/23449#ref-commit-4a17d0d |
|
| https://github.com/khalidadil |
|
| https://github.com/addaleax |
| repl: remove unused variable e from try catch | https://github.com/nodejs/node/commit/4a17d0d2cc96faf8602b550c94ae1616c51cbe4a |
| 4a17d0d | https://github.com/nodejs/node/commit/4a17d0d2cc96faf8602b550c94ae1616c51cbe4a |
| #23449 | https://github.com/nodejs/node/pull/23449 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23449#ref-commit-4ed1fba |
|
| https://github.com/khalidadil |
|
| https://github.com/jasnell |
| repl: remove unused variable e from try catch | https://github.com/nodejs/node/commit/4ed1fba7400b921a9e297d0b77d48423542071f7 |
| 4ed1fba | https://github.com/nodejs/node/commit/4ed1fba7400b921a9e297d0b77d48423542071f7 |
| #23449 | https://github.com/nodejs/node/pull/23449 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23449#ref-commit-18060f2 |
|
| https://github.com/khalidadil |
|
| https://github.com/MylesBorins |
| repl: remove unused variable e from try catch | https://github.com/nodejs/node/commit/18060f2d1229c8c28b8b048345bf2b88e469bb5e |
| 18060f2 | https://github.com/nodejs/node/commit/18060f2d1229c8c28b8b048345bf2b88e469bb5e |
| #23449 | https://github.com/nodejs/node/pull/23449 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/23449#ref-pullrequest-384882602 |
|
v10.13.1 proposal
#24675
| https://github.com/nodejs/node/pull/24675 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23449#ref-commit-451c160 |
|
| https://github.com/khalidadil |
|
| https://github.com/rvagg |
| repl: remove unused variable e from try catch | https://github.com/nodejs/node/commit/451c160b9d99e7f33c02c7ef362555866d027178 |
| 451c160 | https://github.com/nodejs/node/commit/451c160b9d99e7f33c02c7ef362555866d027178 |
| #23449 | https://github.com/nodejs/node/pull/23449 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23449#ref-commit-4c0e7b4 |
|
| https://github.com/khalidadil |
|
| https://github.com/MylesBorins |
| repl: remove unused variable e from try catch | https://github.com/nodejs/node/commit/4c0e7b4d66d194bf4c66684df6f988bb029296b1 |
| 4c0e7b4 | https://github.com/nodejs/node/commit/4c0e7b4d66d194bf4c66684df6f988bb029296b1 |
| #23449 | https://github.com/nodejs/node/pull/23449 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23449#ref-pullrequest-385836001 |
|
v10.14.2 proposal
#24727
| https://github.com/nodejs/node/pull/24727 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23449 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/23449/files/e0526eeb83f9820f92214a1271f111368366d8c3 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/23449/files/e0526eeb83f9820f92214a1271f111368366d8c3 |
|
| https://github.com/BethGriggs |
|
BethGriggs
| https://github.com/BethGriggs |
|
| https://github.com/nodejs/node/pull/23449/files/e0526eeb83f9820f92214a1271f111368366d8c3 |
|
| https://github.com/WaleedAshraf |
|
WaleedAshraf
| https://github.com/WaleedAshraf |
|
| https://github.com/nodejs/node/pull/23449/files/e0526eeb83f9820f92214a1271f111368366d8c3 |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/23449/files/e0526eeb83f9820f92214a1271f111368366d8c3 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
repl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl |
| Please reload this page | https://github.com/nodejs/node/pull/23449 |
|
| https://github.com/khalidadil |
|
| https://github.com/Trott |
|
| https://github.com/thefourtheye |
|
| https://github.com/cjihrig |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/BethGriggs |
|
| https://github.com/WaleedAshraf |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |