René's URL Explorer Experiment


Title: tls: handle empty cert in checkServerIndentity by mike-zorn · Pull Request #2343 · nodejs/node · GitHub

Open Graph Title: tls: handle empty cert in checkServerIndentity by mike-zorn · Pull Request #2343 · nodejs/node

X Title: tls: handle empty cert in checkServerIndentity by mike-zorn · Pull Request #2343 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This resolves nodejs/node-v0.x-archive#9272. tlsSocket.getPeerCertificate will return an empty object when the peer does not provide a certificate, but, prior to this, when the certificate is empty...

X Description: This resolves nodejs/node-v0.x-archive#9272. tlsSocket.getPeerCertificate will return an empty object when the peer does not provide a certificate, but, prior to this, when the certificate is empty...

Opengraph URL: https://github.com/nodejs/node/pull/2343

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a7adab15-8392-84a1-859d-146eac114bc4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC0C:2C03D:22584AA:2F3AA8B:6A4ECB1F
html-safe-nonced2fd7bdb6dc02b6d6e1f295f5b34c7ca7bac54b27d5150025475ef7044d45d83
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzBDOjJDMDNEOjIyNTg0QUE6MkYzQUE4Qjo2QTRFQ0IxRiIsInZpc2l0b3JfaWQiOiI4MjE1NzEyMjMzNTYyMjI5NTM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac10f7b2a3e4da97fe1d6d7fa8b5da6cae53b2b7541fe250f01fe4d92392dda4bc
hovercard-subject-tagpull_request:42036922
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/2343/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a884b3eaa7955c234b71bf92ffe60c92f90e36b4e0755f77c89530f1c24fb93f/nodejs/node/pull/2343
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a884b3eaa7955c234b71bf92ffe60c92f90e36b4e0755f77c89530f1c24fb93f/nodejs/node/pull/2343
og:image:altThis resolves nodejs/node-v0.x-archive#9272. tlsSocket.getPeerCertificate will return an empty object when the peer does not provide a certificate, but, prior to this, when the certificate is empty...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemike-zorn
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/2343#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2343
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2343
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/2343
Reloadhttps://github.com/nodejs/node/pull/2343
Reloadhttps://github.com/nodejs/node/pull/2343
Please reload this pagehttps://github.com/nodejs/node/pull/2343
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/2343
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mike-zornhttps://github.com/mike-zorn
nodejs:masterhttps://github.com/nodejs/node/tree/master
mike-zorn:masterhttps://github.com/mike-zorn/io.js/tree/master
Conversationhttps://github.com/nodejs/node/pull/2343
Commits1 (1)https://github.com/nodejs/node/pull/2343/commits
Checkshttps://github.com/nodejs/node/pull/2343/checks
Files changedhttps://github.com/nodejs/node/pull/2343/files
tls: handle empty cert in checkServerIndentityhttps://github.com/nodejs/node/pull/2343#top
mike-zornhttps://github.com/mike-zorn
nodejs:masterhttps://github.com/nodejs/node/tree/master
mike-zorn:masterhttps://github.com/mike-zorn/io.js/tree/master
https://github.com/mike-zorn
mike-zornhttps://github.com/mike-zorn
Aug 10, 2015https://github.com/nodejs/node/pull/2343#issue-100104372
nodejs/node-v0.x-archive#9272https://github.com/nodejs/node-v0.x-archive/issues/9272
Please reload this pagehttps://github.com/nodejs/node/pull/2343
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Aug 10, 2015https://github.com/nodejs/node/pull/2343#event-378267541
mscdexhttps://github.com/mscdex
Aug 10, 2015 https://github.com/nodejs/node/pull/2343#discussion-diff-36671409
View reviewed changes https://github.com/nodejs/node/pull/2343/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027
lib/tls.jshttps://github.com/nodejs/node/pull/2343/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027
mscdexhttps://github.com/mscdex
Aug 10, 2015https://github.com/nodejs/node/pull/2343#discussion_r36671409
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2343
mike-zornhttps://github.com/mike-zorn
Aug 10, 2015https://github.com/nodejs/node/pull/2343#discussion_r36672524
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2343
tls: handle empty cert in checkServerIndentityhttps://github.com/nodejs/node/pull/2343/commits/e3cc0cf9d68626ebfcce2a8358c82aea70131046
e3cc0cfhttps://github.com/nodejs/node/pull/2343/commits/e3cc0cf9d68626ebfcce2a8358c82aea70131046
nodejs/node-v0.x-archive#9272https://github.com/nodejs/node-v0.x-archive/issues/9272
https://github.com/mike-zorn
mike-zornhttps://github.com/mike-zorn
force-pushedhttps://github.com/nodejs/node/compare/047ba66be20e543521099fdbc201558facdef2e9..e3cc0cf9d68626ebfcce2a8358c82aea70131046
047ba66https://github.com/nodejs/node/commit/047ba66be20e543521099fdbc201558facdef2e9
e3cc0cfhttps://github.com/nodejs/node/commit/e3cc0cf9d68626ebfcce2a8358c82aea70131046
Compare https://github.com/nodejs/node/compare/047ba66be20e543521099fdbc201558facdef2e9..e3cc0cf9d68626ebfcce2a8358c82aea70131046
August 10, 2015 19:21https://github.com/nodejs/node/pull/2343#event-378354804
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Aug 11, 2015https://github.com/nodejs/node/pull/2343#issuecomment-129722109
Please reload this pagehttps://github.com/nodejs/node/pull/2343
https://github.com/indutny
indutnyhttps://github.com/indutny
Aug 11, 2015https://github.com/nodejs/node/pull/2343#issuecomment-129736212
Please reload this pagehttps://github.com/nodejs/node/pull/2343
https://github.com/mike-zorn
mike-zornhttps://github.com/mike-zorn
Aug 11, 2015https://github.com/nodejs/node/pull/2343#issuecomment-129879205
Please reload this pagehttps://github.com/nodejs/node/pull/2343
https://github.com/indutny
indutnyhttps://github.com/indutny
Aug 13, 2015https://github.com/nodejs/node/pull/2343#issuecomment-130631542
@rvagghttps://github.com/rvagg
Please reload this pagehttps://github.com/nodejs/node/pull/2343
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 14, 2015https://github.com/nodejs/node/pull/2343#issuecomment-131255913
https://jenkins-iojs.nodesource.com/job/node-test-pull-request/https://jenkins-iojs.nodesource.com/job/node-test-pull-request/
https://jenkins-iojs.nodesource.com/job/node-test-pull-request/90/https://jenkins-iojs.nodesource.com/job/node-test-pull-request/90/
Please reload this pagehttps://github.com/nodejs/node/pull/2343
https://github.com/c0b41
c0b41https://github.com/c0b41
Aug 18, 2015 https://github.com/nodejs/node/pull/2343#ref-issue-101760984
TLSSocket Error ttezel/twit#201 https://github.com/ttezel/twit/issues/201
https://github.com/c0b41
c0b41https://github.com/c0b41
Aug 21, 2015https://github.com/nodejs/node/pull/2343#issuecomment-133233708
Please reload this pagehttps://github.com/nodejs/node/pull/2343
https://github.com/shigeki
shigekihttps://github.com/shigeki
Aug 21, 2015https://github.com/nodejs/node/pull/2343#issuecomment-133235766
https://jenkins-iojs.nodesource.com/job/node-test-pull-request/122/https://jenkins-iojs.nodesource.com/job/node-test-pull-request/122/
Please reload this pagehttps://github.com/nodejs/node/pull/2343
https://github.com/shigeki
shigekihttps://github.com/shigeki
Aug 21, 2015https://github.com/nodejs/node/pull/2343#issuecomment-133247071
nodejs/node-v0.x-archive#8960https://github.com/nodejs/node-v0.x-archive/issues/8960
#2464https://github.com/nodejs/node/issues/2464
Please reload this pagehttps://github.com/nodejs/node/pull/2343
shigekihttps://github.com/shigeki
Aug 21, 2015 https://github.com/nodejs/node/pull/2343#ref-commit-f1810ed
tls: handle empty cert in checkServerIndentityhttps://github.com/nodejs/node/commit/f1810ed1b86cbbe5560a96839f5320b4be6ec5f7
f1810edhttps://github.com/nodejs/node/commit/f1810ed1b86cbbe5560a96839f5320b4be6ec5f7
nodejs/node-v0.x-archive#9272https://github.com/nodejs/node-v0.x-archive/issues/9272
#2343https://github.com/nodejs/node/pull/2343
https://github.com/shigeki
shigekihttps://github.com/shigeki
Aug 21, 2015https://github.com/nodejs/node/pull/2343#issuecomment-133259072
f1810edhttps://github.com/nodejs/node/commit/f1810ed1b86cbbe5560a96839f5320b4be6ec5f7
Please reload this pagehttps://github.com/nodejs/node/pull/2343
https://github.com/shigeki
shigekihttps://github.com/shigeki
Aug 21, 2015https://github.com/nodejs/node/pull/2343#event-388382612
rvagghttps://github.com/rvagg
Aug 21, 2015 https://github.com/nodejs/node/pull/2343#ref-commit-d9b70f9
https://github.com/rvagg
tls: handle empty cert in checkServerIndentityhttps://github.com/nodejs/node/commit/d9b70f9cbfe1d76a516378afa0ade0818d45bfd4
d9b70f9https://github.com/nodejs/node/commit/d9b70f9cbfe1d76a516378afa0ade0818d45bfd4
nodejs/node-v0.x-archive#9272https://github.com/nodejs/node-v0.x-archive/issues/9272
#2343https://github.com/nodejs/node/pull/2343
Release proposal: v3.2.0 #2506 https://github.com/nodejs/node/pull/2506
Release proposal: v3.2.0 #2511 https://github.com/nodejs/node/pull/2511
Release proposal: v3.2.0 #2512 https://github.com/nodejs/node/pull/2512
jsonnhttps://github.com/jsonn
Sep 9, 2015 https://github.com/nodejs/node/pull/2343#ref-commit-33b3766
Update to 4.0.0https://github.com/jsonn/pkgsrc/commit/33b3766530c9de4a54b95c97cc3f1c4dfc57c845
33b3766https://github.com/jsonn/pkgsrc/commit/33b3766530c9de4a54b95c97cc3f1c4dfc57c845
[Snyk] Security upgrade marked from 0.3.19 to 4.0.10 solebox/node#27 https://github.com/solebox/node/pull/27
[Snyk] Security upgrade marked from 0.3.19 to 4.0.10 s4sc/node#26 https://github.com/s4sc/node/pull/26
[Snyk] Security upgrade marked from 0.3.6 to 4.0.10 GregorFendt/node#20 https://github.com/GregorFendt/node/pull/20
[Snyk] Security upgrade marked from 0.3.6 to 4.0.10 saurabharch/node#25 https://github.com/saurabharch/node/pull/25
[Snyk] Security upgrade marked from 0.3.6 to 4.0.10 KamilPolivka/node#24 https://github.com/KamilPolivka/node/pull/24
[Snyk] Security upgrade marked from 0.3.6 to 4.0.10 nigelhanlon/node#3 https://github.com/nigelhanlon/node/pull/3
[Snyk] Security upgrade marked from 0.3.19 to 4.0.10 erdun/node#44 https://github.com/erdun/node/pull/44
[Snyk] Security upgrade marked from 0.3.6 to 4.0.10 saeedahassan/node#38 https://github.com/saeedahassan/node/pull/38
[Snyk] Security upgrade marked from 0.3.6 to 4.0.10 olegnn/node#38 https://github.com/olegnn/node/pull/38
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Jan 31, 2022 https://github.com/nodejs/node/pull/2343#ref-pullrequest-1119459637
[Snyk] Security upgrade marked from 0.3.19 to 4.0.10 enterstudio/node#25 https://github.com/enterstudio/node/pull/25
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Jun 24, 2022 https://github.com/nodejs/node/pull/2343#ref-pullrequest-1283446216
[Snyk] Fix for 7 vulnerabilities adamlaska/node#70 https://github.com/adamlaska/node/pull/70
mskhttps://github.com/msk
May 11, 2026 https://github.com/nodejs/node/pull/2343#ref-commit-e40913a
https://github.com/ryoon
Update to 4.0.0https://github.com/msk/pkgsrc/commit/e40913a84d8a2f34a1cfb92bd22db143bc1e0c52
e40913ahttps://github.com/msk/pkgsrc/commit/e40913a84d8a2f34a1cfb92bd22db143bc1e0c52
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2343
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
tls.checkServerIdentity throws TypeError: Cannot read property 'CN' of undefined (tls.js:182:37) https://github.com/nodejs/node-v0.x-archive/issues/9272
Please reload this pagehttps://github.com/nodejs/node/pull/2343
https://github.com/mike-zorn
https://github.com/thefourtheye
https://github.com/indutny
https://github.com/bnoordhuis
https://github.com/c0b41
https://github.com/shigeki
https://github.com/mscdex
https://github.com/Fishrock123
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.