René's URL Explorer Experiment


Title: crypto: reduce memory usage of SignFinal by tniessen · Pull Request #23427 · nodejs/node · GitHub

Open Graph Title: crypto: reduce memory usage of SignFinal by tniessen · Pull Request #23427 · nodejs/node

X Title: crypto: reduce memory usage of SignFinal by tniessen · Pull Request #23427 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The fixed-size buffer on the stack is unnecessary and way too large for most applications. This change removes it and allocates the required memory directly instead of copying into heap later. Che...

X Description: The fixed-size buffer on the stack is unnecessary and way too large for most applications. This change removes it and allocates the required memory directly instead of copying into heap later. Che...

Opengraph URL: https://github.com/nodejs/node/pull/23427

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:48240533-994b-ecff-cf1b-93140c26edba
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF6A:2086C7:5CD1482:8319371:6A4FC296
html-safe-nonce72a99ae07ec99a3c3ea70ad7933ef20c82409d8f6ce758f4a8531a4aca96ad8e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjZBOjIwODZDNzo1Q0QxNDgyOjgzMTkzNzE6NkE0RkMyOTYiLCJ2aXNpdG9yX2lkIjoiODMxODY0NzU2NzI2MTg3Njg4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbb82e3218fbb587dd4426c50672748fc11763900115c28f8e106070a0dfb2454
hovercard-subject-tagpull_request:222240885
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23427/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f8c9314d45a8944501a369646e5e3c4beeff784ee4c2163d91f60b9c35d86067/nodejs/node/pull/23427
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f8c9314d45a8944501a369646e5e3c4beeff784ee4c2163d91f60b9c35d86067/nodejs/node/pull/23427
og:image:altThe fixed-size buffer on the stack is unnecessary and way too large for most applications. This change removes it and allocates the required memory directly instead of copying into heap later. Che...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None7d8f8209b188a80e19a6957836ab9229715797be5db1a04163963c674ccc33f6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseea848e83cf3bf3613dd7b13d52965a684fd23ec5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23427#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23427
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23427
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23427
Reloadhttps://github.com/nodejs/node/pull/23427
Reloadhttps://github.com/nodejs/node/pull/23427
Please reload this pagehttps://github.com/nodejs/node/pull/23427
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23427
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-reduce-sign-memhttps://github.com/tniessen/node/tree/crypto-reduce-sign-mem
Conversationhttps://github.com/nodejs/node/pull/23427
Commits4 (4)https://github.com/nodejs/node/pull/23427/commits
Checkshttps://github.com/nodejs/node/pull/23427/checks
Files changedhttps://github.com/nodejs/node/pull/23427/files
crypto: reduce memory usage of SignFinalhttps://github.com/nodejs/node/pull/23427#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-reduce-sign-memhttps://github.com/tniessen/node/tree/crypto-reduce-sign-mem
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 11, 2018https://github.com/nodejs/node/pull/23427#issue-369256064
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 11, 2018https://github.com/nodejs/node/pull/23427#issuecomment-429075002
@tniessenhttps://github.com/tniessen
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1204/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1204/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Oct 11, 2018https://github.com/nodejs/node/pull/23427#event-1899031140
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Oct 11, 2018 https://github.com/nodejs/node/pull/23427#pullrequestreview-163977759
View reviewed changes https://github.com/nodejs/node/pull/23427/files
src/node_crypto.cchttps://github.com/nodejs/node/pull/23427/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
sam-githubhttps://github.com/sam-github
Oct 11, 2018https://github.com/nodejs/node/pull/23427#discussion_r224575393
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Oct 11, 2018 https://github.com/nodejs/node/pull/23427#pullrequestreview-163978758
View reviewed changes https://github.com/nodejs/node/pull/23427/files
src/node_crypto.cchttps://github.com/nodejs/node/pull/23427/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
sam-githubhttps://github.com/sam-github
Oct 11, 2018https://github.com/nodejs/node/pull/23427#discussion_r224576259
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Oct 11, 2018 https://github.com/nodejs/node/pull/23427#pullrequestreview-163979938
View reviewed changes https://github.com/nodejs/node/pull/23427/files
src/node_crypto.cchttps://github.com/nodejs/node/pull/23427/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
sam-githubhttps://github.com/sam-github
Oct 11, 2018https://github.com/nodejs/node/pull/23427#discussion_r224577209
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 11, 2018 https://github.com/nodejs/node/pull/23427#pullrequestreview-164016068
View reviewed changes https://github.com/nodejs/node/pull/23427/files
src/node_crypto.cchttps://github.com/nodejs/node/pull/23427/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
bnoordhuishttps://github.com/bnoordhuis
Oct 11, 2018https://github.com/nodejs/node/pull/23427#discussion_r224604907
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
src/node_crypto.cchttps://github.com/nodejs/node/pull/23427/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
bnoordhuishttps://github.com/bnoordhuis
Oct 11, 2018https://github.com/nodejs/node/pull/23427#discussion_r224606094
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/tniessen
crypto: reduce memory usage of SignFinalhttps://github.com/nodejs/node/pull/23427/commits/4b4b71b7d4df268b3e74c3f434682399bc50ce69
4b4b71bhttps://github.com/nodejs/node/pull/23427/commits/4b4b71b7d4df268b3e74c3f434682399bc50ce69
https://github.com/tniessen
tniessenhttps://github.com/tniessen
force-pushedhttps://github.com/nodejs/node/compare/bff5fd8326abd7ce0e20701e98dedb2f3a5fe3cf..4b4b71b7d4df268b3e74c3f434682399bc50ce69
bff5fd8https://github.com/nodejs/node/commit/bff5fd8326abd7ce0e20701e98dedb2f3a5fe3cf
4b4b71bhttps://github.com/nodejs/node/commit/4b4b71b7d4df268b3e74c3f434682399bc50ce69
Compare https://github.com/nodejs/node/compare/bff5fd8326abd7ce0e20701e98dedb2f3a5fe3cf..4b4b71b7d4df268b3e74c3f434682399bc50ce69
October 12, 2018 21:29https://github.com/nodejs/node/pull/23427#event-1901741087
https://github.com/tniessen
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23427
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 12, 2018 https://github.com/nodejs/node/pull/23427#pullrequestreview-164417921
View reviewed changes https://github.com/nodejs/node/pull/23427/files/4b4b71b7d4df268b3e74c3f434682399bc50ce69
src/node_crypto.cchttps://github.com/nodejs/node/pull/23427/files/4b4b71b7d4df268b3e74c3f434682399bc50ce69#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
addaleaxhttps://github.com/addaleax
Oct 12, 2018https://github.com/nodejs/node/pull/23427#discussion_r224922101
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
tniessenhttps://github.com/tniessen
Oct 12, 2018https://github.com/nodejs/node/pull/23427#discussion_r224922457
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
refackhttps://github.com/refack
Oct 15, 2018https://github.com/nodejs/node/pull/23427#discussion_r225016595
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/tniessen
fixup! crypto: reduce memory usage of SignFinalhttps://github.com/nodejs/node/pull/23427/commits/e5bd9d0f90fd95b631fb05555b3cd03261e7936c
e5bd9d0https://github.com/nodejs/node/pull/23427/commits/e5bd9d0f90fd95b631fb05555b3cd03261e7936c
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 14, 2018 https://github.com/nodejs/node/pull/23427#pullrequestreview-164512654
View reviewed changes https://github.com/nodejs/node/pull/23427/files/e5bd9d0f90fd95b631fb05555b3cd03261e7936c
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 14, 2018https://github.com/nodejs/node/pull/23427#issuecomment-429659008
https://ci.nodejs.org/job/node-test-pull-request/17853/https://ci.nodejs.org/job/node-test-pull-request/17853/
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/Guillerbr
Guillerbrhttps://github.com/Guillerbr
Oct 14, 2018https://github.com/nodejs/node/pull/23427#issuecomment-429660227
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 14, 2018https://github.com/nodejs/node/pull/23427#issuecomment-429665623
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 14, 2018https://github.com/nodejs/node/pull/23427#issuecomment-429666093
@tniessenhttps://github.com/tniessen
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 14, 2018https://github.com/nodejs/node/pull/23427#issuecomment-429667233
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/refack
refackhttps://github.com/refack
Oct 14, 2018 https://github.com/nodejs/node/pull/23427#pullrequestreview-164518719
View reviewed changes https://github.com/nodejs/node/pull/23427/files/e5bd9d0f90fd95b631fb05555b3cd03261e7936c
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/23427#pullrequestreview-164518719
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
src/node_crypto.cchttps://github.com/nodejs/node/pull/23427/files/e5bd9d0f90fd95b631fb05555b3cd03261e7936c#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
refackhttps://github.com/refack
Oct 14, 2018https://github.com/nodejs/node/pull/23427#discussion_r225012679
Please reload this pagehttps://github.com/nodejs/node/pull/23427
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
src/node_crypto.cchttps://github.com/nodejs/node/pull/23427/files/e5bd9d0f90fd95b631fb05555b3cd03261e7936c#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
refackhttps://github.com/refack
Oct 14, 2018https://github.com/nodejs/node/pull/23427#discussion_r225012712
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/refack
refackhttps://github.com/refack
Oct 14, 2018 https://github.com/nodejs/node/pull/23427#pullrequestreview-164519188
View reviewed changes https://github.com/nodejs/node/pull/23427/files/e5bd9d0f90fd95b631fb05555b3cd03261e7936c
src/node_crypto.cchttps://github.com/nodejs/node/pull/23427/files/e5bd9d0f90fd95b631fb05555b3cd03261e7936c#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
refackhttps://github.com/refack
Oct 14, 2018https://github.com/nodejs/node/pull/23427#discussion_r225013126
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
addaleaxhttps://github.com/addaleax
Oct 14, 2018https://github.com/nodejs/node/pull/23427#discussion_r225013331
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23427
refackhttps://github.com/refack
Oct 14, 2018https://github.com/nodejs/node/pull/23427#discussion_r225015179
Please reload this pagehttps://github.com/nodejs/node/pull/23427
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Local Variableshttps://google.github.io/styleguide/cppguide.html#Local_Variables
Output Parametershttps://google.github.io/styleguide/cppguide.html#Output_Parameters
C++11https://google.github.io/styleguide/cppguide.html#C++11
ES.20http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-always
F.20http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#f20-for-out-output-values-prefer-return-values-to-output-parameters
ES.1http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-lib
Please reload this pagehttps://github.com/nodejs/node/pull/23427
addaleaxhttps://github.com/addaleax
Oct 14, 2018https://github.com/nodejs/node/pull/23427#discussion_r225015424
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
refackhttps://github.com/refack
Oct 15, 2018https://github.com/nodejs/node/pull/23427#discussion_r225015821
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@tniessenhttps://github.com/tniessen
node/src/node_crypto.cchttps://github.com/nodejs/node/blob/e5bd9d0f90fd95b631fb05555b3cd03261e7936c/src/node_crypto.cc#L3542
e5bd9d0https://github.com/nodejs/node/commit/e5bd9d0f90fd95b631fb05555b3cd03261e7936c
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/tniessen
fixup! crypto: reduce memory usage of SignFinalhttps://github.com/nodejs/node/pull/23427/commits/202d506106664051ac76c5ebf54f952b27c017ae
202d506https://github.com/nodejs/node/pull/23427/commits/202d506106664051ac76c5ebf54f952b27c017ae
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018 https://github.com/nodejs/node/pull/23427#pullrequestreview-165771894
View reviewed changes https://github.com/nodejs/node/pull/23427/files/202d506106664051ac76c5ebf54f952b27c017ae
src/node_crypto.cchttps://github.com/nodejs/node/pull/23427/files/e5bd9d0f90fd95b631fb05555b3cd03261e7936c..202d506106664051ac76c5ebf54f952b27c017ae#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
refackhttps://github.com/refack
Oct 17, 2018https://github.com/nodejs/node/pull/23427#discussion_r226043464
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018 https://github.com/nodejs/node/pull/23427#pullrequestreview-165774053
View reviewed changes https://github.com/nodejs/node/pull/23427/files/202d506106664051ac76c5ebf54f952b27c017ae
src/node_crypto.cchttps://github.com/nodejs/node/pull/23427/files/e5bd9d0f90fd95b631fb05555b3cd03261e7936c..202d506106664051ac76c5ebf54f952b27c017ae#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
refackhttps://github.com/refack
Oct 17, 2018https://github.com/nodejs/node/pull/23427#discussion_r226045311
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018 https://github.com/nodejs/node/pull/23427#pullrequestreview-165775485
View reviewed changes https://github.com/nodejs/node/pull/23427/files/202d506106664051ac76c5ebf54f952b27c017ae
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018https://github.com/nodejs/node/pull/23427#issuecomment-430738909
@tniessenhttps://github.com/tniessen
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/tniessen
fixup! crypto: reduce memory usage of SignFinalhttps://github.com/nodejs/node/pull/23427/commits/27f59473d55e03f8546182d4569f1ddfb160df38
27f5947https://github.com/nodejs/node/pull/23427/commits/27f59473d55e03f8546182d4569f1ddfb160df38
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018 https://github.com/nodejs/node/pull/23427#pullrequestreview-165828848
View reviewed changes https://github.com/nodejs/node/pull/23427/files/27f59473d55e03f8546182d4569f1ddfb160df38
src/util.hhttps://github.com/nodejs/node/pull/23427/files/202d506106664051ac76c5ebf54f952b27c017ae..27f59473d55e03f8546182d4569f1ddfb160df38#diff-40ab92941994ec9418dbb76ae46d5aef0e4cb8b034f2be2b31562bb9aca8070f
refackhttps://github.com/refack
Oct 17, 2018https://github.com/nodejs/node/pull/23427#discussion_r226088494
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018 https://github.com/nodejs/node/pull/23427#pullrequestreview-165828871
View reviewed changes https://github.com/nodejs/node/pull/23427/files/27f59473d55e03f8546182d4569f1ddfb160df38
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 17, 2018https://github.com/nodejs/node/pull/23427#issuecomment-430788395
Please reload this pagehttps://github.com/nodejs/node/pull/23427
@refackhttps://github.com/refack
https://ci.nodejs.org/job/node-test-pull-request/17950/https://ci.nodejs.org/job/node-test-pull-request/17950/
https://ci.nodejs.org/job/node-test-pull-request/17989/https://ci.nodejs.org/job/node-test-pull-request/17989/
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 19, 2018https://github.com/nodejs/node/pull/23427#issuecomment-431519078
7bd2912https://github.com/nodejs/node/commit/7bd2912669c8975523b6d77269d29207d3ea9769
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 19, 2018https://github.com/nodejs/node/pull/23427#event-1915872012
tniessenhttps://github.com/tniessen
Oct 19, 2018 https://github.com/nodejs/node/pull/23427#ref-commit-7bd2912
https://github.com/tniessen
crypto: reduce memory usage of SignFinalhttps://github.com/nodejs/node/commit/7bd2912669c8975523b6d77269d29207d3ea9769
7bd2912https://github.com/nodejs/node/commit/7bd2912669c8975523b6d77269d29207d3ea9769
#23427https://github.com/nodejs/node/pull/23427
addaleaxhttps://github.com/addaleax
Oct 20, 2018 https://github.com/nodejs/node/pull/23427#ref-commit-b004648
https://github.com/addaleax
src: use more explicit return type in Sign::SignFinal()https://github.com/addaleax/node/commit/b0046488a30d55050b1fd6c49e466ed627300432
b004648https://github.com/addaleax/node/commit/b0046488a30d55050b1fd6c49e466ed627300432
nodejs#23427https://github.com/nodejs/node/pull/23427
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 20, 2018 https://github.com/nodejs/node/pull/23427#ref-pullrequest-372167496
src: use more explicit return type in Sign::SignFinal() #23779 https://github.com/nodejs/node/pull/23779
addaleaxhttps://github.com/addaleax
Oct 21, 2018 https://github.com/nodejs/node/pull/23427#ref-commit-20282b1
https://github.com/addaleax
src: use more explicit return type in Sign::SignFinal()https://github.com/nodejs/node/commit/20282b1cb0389553421c4c5b14de198c5dfff50b
20282b1https://github.com/nodejs/node/commit/20282b1cb0389553421c4c5b14de198c5dfff50b
#23427https://github.com/nodejs/node/pull/23427
#23779https://github.com/nodejs/node/pull/23779
jasnellhttps://github.com/jasnell
Oct 21, 2018 https://github.com/nodejs/node/pull/23427#ref-commit-1ad660b
https://github.com/tniessen
https://github.com/jasnell
crypto: reduce memory usage of SignFinalhttps://github.com/nodejs/node/commit/1ad660b72d6cea260188dc7d29b8199c8c84bffd
1ad660bhttps://github.com/nodejs/node/commit/1ad660b72d6cea260188dc7d29b8199c8c84bffd
#23427https://github.com/nodejs/node/pull/23427
jasnellhttps://github.com/jasnell
Oct 21, 2018 https://github.com/nodejs/node/pull/23427#ref-commit-b8cb60f
https://github.com/addaleax
https://github.com/jasnell
src: use more explicit return type in Sign::SignFinal()https://github.com/nodejs/node/commit/b8cb60fcb913c56c8938e41024db6b7dead94e02
b8cb60fhttps://github.com/nodejs/node/commit/b8cb60fcb913c56c8938e41024db6b7dead94e02
#23427https://github.com/nodejs/node/pull/23427
#23779https://github.com/nodejs/node/pull/23779
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x
Nov 26, 2018https://github.com/nodejs/node/pull/23427#event-1987308910
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 26, 2018https://github.com/nodejs/node/pull/23427#issuecomment-441710475
Please reload this pagehttps://github.com/nodejs/node/pull/23427
codebyterehttps://github.com/codebytere
Dec 13, 2018 https://github.com/nodejs/node/pull/23427#ref-commit-acd7312
https://github.com/tniessen
https://github.com/codebytere
crypto: reduce memory usage of SignFinalhttps://github.com/nodejs/node/commit/acd7312ef291a9df94616bb81cb074374c61c092
acd7312https://github.com/nodejs/node/commit/acd7312ef291a9df94616bb81cb074374c61c092
#23427https://github.com/nodejs/node/pull/23427
https://github.com/codebytere
codebyterehttps://github.com/codebytere
backported-to-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x
lts-watch-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x
Dec 13, 2018https://github.com/nodejs/node/pull/23427#event-2025035090
MylesBorinshttps://github.com/MylesBorins
Dec 26, 2018 https://github.com/nodejs/node/pull/23427#ref-commit-4749640
https://github.com/tniessen
https://github.com/MylesBorins
crypto: reduce memory usage of SignFinalhttps://github.com/nodejs/node/commit/4749640b2e3bf412647af322baa653f96b22c31c
4749640https://github.com/nodejs/node/commit/4749640b2e3bf412647af322baa653f96b22c31c
#23427https://github.com/nodejs/node/pull/23427
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jan 4, 2019 https://github.com/nodejs/node/pull/23427#ref-pullrequest-396037210
v10.15.1 proposal #25346 https://github.com/nodejs/node/pull/25346
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#280 https://github.com/beevelop/docker-android-nodejs/issues/280
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#258 https://github.com/beevelop/docker-nodejs/issues/258
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#281 https://github.com/beevelop/docker-android-nodejs/issues/281
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#259 https://github.com/beevelop/docker-nodejs/issues/259
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#282 https://github.com/beevelop/docker-android-nodejs/issues/282
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#260 https://github.com/beevelop/docker-nodejs/issues/260
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#283 https://github.com/beevelop/docker-android-nodejs/issues/283
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#261 https://github.com/beevelop/docker-nodejs/issues/261
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#284 https://github.com/beevelop/docker-android-nodejs/issues/284
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#262 https://github.com/beevelop/docker-nodejs/issues/262
BethGriggshttps://github.com/BethGriggs
Oct 18, 2019 https://github.com/nodejs/node/pull/23427#ref-commit-1bb5102
https://github.com/addaleax
https://github.com/BethGriggs
src: use more explicit return type in Sign::SignFinal()https://github.com/nodejs/node/commit/1bb51029998c7a53b78828a7a0c2f312768fc71e
1bb5102https://github.com/nodejs/node/commit/1bb51029998c7a53b78828a7a0c2f312768fc71e
#23427https://github.com/nodejs/node/pull/23427
#23779https://github.com/nodejs/node/pull/23779
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23427
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/23427/files/bff5fd8326abd7ce0e20701e98dedb2f3a5fe3cf
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23427/files/e5bd9d0f90fd95b631fb05555b3cd03261e7936c
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/23427/files/bff5fd8326abd7ce0e20701e98dedb2f3a5fe3cf
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/23427/files/27f59473d55e03f8546182d4569f1ddfb160df38
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/23427
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/Guillerbr
https://github.com/refack
https://github.com/MylesBorins
https://github.com/sam-github
https://github.com/bnoordhuis
https://github.com/codebytere
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.