René's URL Explorer Experiment


Title: [v10.x backport] async_hooks: add missing async_hooks destroys in AsyncReset by basti1302 · Pull Request #23404 · nodejs/node · GitHub

Open Graph Title: [v10.x backport] async_hooks: add missing async_hooks destroys in AsyncReset by basti1302 · Pull Request #23404 · nodejs/node

X Title: [v10.x backport] async_hooks: add missing async_hooks destroys in AsyncReset by basti1302 · Pull Request #23404 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This adds missing async_hooks destroy calls for sockets (in _http_agent.js) and HTTP parsers. We need to emit a destroy in AsyncWrap#AsyncReset before assigning a new async_id when the instance has...

X Description: This adds missing async_hooks destroy calls for sockets (in _http_agent.js) and HTTP parsers. We need to emit a destroy in AsyncWrap#AsyncReset before assigning a new async_id when the instance has...

Mail addresses
matteo.collina@gmail.com
anna@addaleax.net
jasnell@gmail.com

Opengraph URL: https://github.com/nodejs/node/pull/23404

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:d9153f82-6be9-6331-05db-b431503ff092
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB588:DAB28:1168C1C:169DE85:6990D2F6
html-safe-nonceb7217eeb40da1eb633ad973c40989410d85498ee998a439022a96a7cbd247785
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTg4OkRBQjI4OjExNjhDMUM6MTY5REU4NTo2OTkwRDJGNiIsInZpc2l0b3JfaWQiOiIzNzA1NDAwNzcwNTkxNTExMjg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac87bf085bd7d266f64b96f3a5726a5e0a7fdcccc2c0233832982edec2c8f766df
hovercard-subject-tagpull_request:221731684
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/23404
twitter:imagehttps://opengraph.githubassets.com/712e91f19e143a119c340187649a72160814dee5930581922b13d0971fa84ba3/nodejs/node/pull/23404
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/712e91f19e143a119c340187649a72160814dee5930581922b13d0971fa84ba3/nodejs/node/pull/23404
og:image:altThis adds missing async_hooks destroy calls for sockets (in _http_agent.js) and HTTP parsers. We need to emit a destroy in AsyncWrap#AsyncReset before assigning a new async_id when the instance has...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebasti1302
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23404#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23404
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23404
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23404
Reloadhttps://github.com/nodejs/node/pull/23404
Reloadhttps://github.com/nodejs/node/pull/23404
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23404
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 705 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
basti1302https://github.com/basti1302
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
basti1302:backport-10-23272https://github.com/basti1302/node/tree/backport-10-23272
Conversationhttps://github.com/nodejs/node/pull/23404
Commits1 (1)https://github.com/nodejs/node/pull/23404/commits
Checkshttps://github.com/nodejs/node/pull/23404/checks
Files changedhttps://github.com/nodejs/node/pull/23404/files
[v10.x backport] async_hooks: add missing async_hooks destroys in AsyncResethttps://github.com/nodejs/node/pull/23404#top
basti1302https://github.com/basti1302
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
basti1302:backport-10-23272https://github.com/basti1302/node/tree/backport-10-23272
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 10, 2018https://github.com/nodejs/node/pull/23404#issue-368592695
Please reload this pagehttps://github.com/nodejs/node/pull/23404
#23272https://github.com/nodejs/node/pull/23272
#19859https://github.com/nodejs/node/issues/19859
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23404
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x
Oct 10, 2018https://github.com/nodejs/node/pull/23404#event-1895088247
https://github.com/targos
targoshttps://github.com/targos
force-pushedhttps://github.com/nodejs/node/compare/d16486b215b81e1c0e60dac573446c03425b6f1a..7c0d6ac0bddc8e68a8dbe35c771d2304326d128c
d16486bhttps://github.com/nodejs/node/commit/d16486b215b81e1c0e60dac573446c03425b6f1a
7c0d6achttps://github.com/nodejs/node/commit/7c0d6ac0bddc8e68a8dbe35c771d2304326d128c
Compare https://github.com/nodejs/node/compare/d16486b215b81e1c0e60dac573446c03425b6f1a..7c0d6ac0bddc8e68a8dbe35c771d2304326d128c
October 10, 2018 13:42https://github.com/nodejs/node/pull/23404#event-1895549035
https://github.com/basti1302
basti1302https://github.com/basti1302
force-pushedhttps://github.com/nodejs/node/compare/9ce5392908d554548016799b8a778b93ac64a0f7..6d973c7fb1501fd23ecc412cf62b931a6f4def86
9ce5392https://github.com/nodejs/node/commit/9ce5392908d554548016799b8a778b93ac64a0f7
6d973c7https://github.com/nodejs/node/commit/6d973c7fb1501fd23ecc412cf62b931a6f4def86
Compare https://github.com/nodejs/node/compare/9ce5392908d554548016799b8a778b93ac64a0f7..6d973c7fb1501fd23ecc412cf62b931a6f4def86
October 10, 2018 16:48https://github.com/nodejs/node/pull/23404#event-1896072763
https://github.com/basti1302
async_hooks: add missing async_hooks destroys in AsyncResethttps://github.com/nodejs/node/pull/23404/commits/c650dfbde0a54a4c69b2397dd7af719f526f222c
c650dfbhttps://github.com/nodejs/node/pull/23404/commits/c650dfbde0a54a4c69b2397dd7af719f526f222c
nodejs#23272https://github.com/nodejs/node/pull/23272
nodejs#19859https://github.com/nodejs/node/issues/19859
https://github.com/basti1302
basti1302https://github.com/basti1302
force-pushedhttps://github.com/nodejs/node/compare/6d973c7fb1501fd23ecc412cf62b931a6f4def86..c650dfbde0a54a4c69b2397dd7af719f526f222c
6d973c7https://github.com/nodejs/node/commit/6d973c7fb1501fd23ecc412cf62b931a6f4def86
c650dfbhttps://github.com/nodejs/node/commit/c650dfbde0a54a4c69b2397dd7af719f526f222c
Compare https://github.com/nodejs/node/compare/6d973c7fb1501fd23ecc412cf62b931a6f4def86..c650dfbde0a54a4c69b2397dd7af719f526f222c
October 10, 2018 16:54https://github.com/nodejs/node/pull/23404#event-1896085852
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 11, 2018 https://github.com/nodejs/node/pull/23404#ref-pullrequest-367092245
Fix two missing async hooks destroy calls #23272 https://github.com/nodejs/node/pull/23272
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 11, 2018 https://github.com/nodejs/node/pull/23404#pullrequestreview-163649840
View reviewed changes https://github.com/nodejs/node/pull/23404/files/c650dfbde0a54a4c69b2397dd7af719f526f222c
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 11, 2018https://github.com/nodejs/node/pull/23404#issuecomment-428821460
https://ci.nodejs.org/job/node-test-pull-request/17736/https://ci.nodejs.org/job/node-test-pull-request/17736/
Please reload this pagehttps://github.com/nodejs/node/pull/23404
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 11, 2018 https://github.com/nodejs/node/pull/23404#ref-pullrequest-368789547
[v8.x backport] async_hooks: add missing async_hooks destroys in AsyncReset #23410 https://github.com/nodejs/node/pull/23410
https://github.com/targos
targoshttps://github.com/targos
force-pushedhttps://github.com/nodejs/node/compare/7c9b37e2eb17535fb906c546a4ded9dda1143f4b..8def0379b73cb993fbf4bb92618cf1db0a7dedff
7c9b37ehttps://github.com/nodejs/node/commit/7c9b37e2eb17535fb906c546a4ded9dda1143f4b
8def037https://github.com/nodejs/node/commit/8def0379b73cb993fbf4bb92618cf1db0a7dedff
Compare https://github.com/nodejs/node/compare/7c9b37e2eb17535fb906c546a4ded9dda1143f4b..8def0379b73cb993fbf4bb92618cf1db0a7dedff
October 13, 2018 14:14https://github.com/nodejs/node/pull/23404#event-1902180985
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 15, 2018https://github.com/nodejs/node/pull/23404#issuecomment-429718524
Please reload this pagehttps://github.com/nodejs/node/pull/23404
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/3f63297fe8e10e54122f211c6ae573112a9f74cc..8e7a12f4500c702731313591d64726031ab8c4d2
3f63297https://github.com/nodejs/node/commit/3f63297fe8e10e54122f211c6ae573112a9f74cc
8e7a12fhttps://github.com/nodejs/node/commit/8e7a12f4500c702731313591d64726031ab8c4d2
Compare https://github.com/nodejs/node/compare/3f63297fe8e10e54122f211c6ae573112a9f74cc..8e7a12f4500c702731313591d64726031ab8c4d2
October 30, 2018 08:43https://github.com/nodejs/node/pull/23404#event-1934378129
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Nov 1, 2018https://github.com/nodejs/node/pull/23404#issuecomment-435065756
https://ci.nodejs.org/job/node-test-pull-request/18277/https://ci.nodejs.org/job/node-test-pull-request/18277/
Please reload this pagehttps://github.com/nodejs/node/pull/23404
MylesBorinshttps://github.com/MylesBorins
Nov 4, 2018 https://github.com/nodejs/node/pull/23404#ref-commit-8345a82
https://github.com/basti1302
https://github.com/MylesBorins
async_hooks: add missing async_hooks destroys in AsyncResethttps://github.com/nodejs/node/commit/8345a8227d3b73f6bc538602dbaf416771a0d71c
8345a82https://github.com/nodejs/node/commit/8345a8227d3b73f6bc538602dbaf416771a0d71c
#23404https://github.com/nodejs/node/pull/23404
#23272https://github.com/nodejs/node/pull/23272
#19859https://github.com/nodejs/node/issues/19859
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 4, 2018https://github.com/nodejs/node/pull/23404#issuecomment-435665938
8345a82https://github.com/nodejs/node/commit/8345a8227d3b73f6bc538602dbaf416771a0d71c
Please reload this pagehttps://github.com/nodejs/node/pull/23404
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 4, 2018https://github.com/nodejs/node/pull/23404#event-1944798090
https://github.com/basti1302
basti1302https://github.com/basti1302
November 4, 2018 13:54https://github.com/nodejs/node/pull/23404#event-1944830116
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23404#ref-commit-5706282
https://github.com/basti1302
https://github.com/rvagg
async_hooks: add missing async_hooks destroys in AsyncResethttps://github.com/nodejs/node/commit/570628226fe2e3842a14b85cff178a0251ed8acf
5706282https://github.com/nodejs/node/commit/570628226fe2e3842a14b85cff178a0251ed8acf
#23404https://github.com/nodejs/node/pull/23404
#23272https://github.com/nodejs/node/pull/23272
#19859https://github.com/nodejs/node/issues/19859
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23404#ref-commit-6a21d3e
https://github.com/basti1302
https://github.com/MylesBorins
async_hooks: add missing async_hooks destroys in AsyncResethttps://github.com/nodejs/node/commit/6a21d3e72fc3f23a9ad06b3fae756472b5148235
6a21d3ehttps://github.com/nodejs/node/commit/6a21d3e72fc3f23a9ad06b3fae756472b5148235
#23404https://github.com/nodejs/node/pull/23404
#23272https://github.com/nodejs/node/pull/23272
#19859https://github.com/nodejs/node/issues/19859
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23404
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23404/files/c650dfbde0a54a4c69b2397dd7af719f526f222c
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/23404
https://github.com/basti1302
https://github.com/addaleax
https://github.com/BethGriggs
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.