René's URL Explorer Experiment


Title: build: restore js2c direct dependency on config.gypi by refack · Pull Request #23355 · nodejs/node · GitHub

Open Graph Title: build: restore js2c direct dependency on config.gypi by refack · Pull Request #23355 · nodejs/node

X Title: build: restore js2c direct dependency on config.gypi by refack · Pull Request #23355 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #23352 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Fixes: #23352 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/23355

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:53ef3f55-7274-a7fc-9827-075b9d7bf6a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCAFE:229272:CA52D:FF4DF:69913316
html-safe-noncee473dfa3b23ec5521757b0f5ef7eeafb50f1a84a44baaf0f6ee99f6d1d9448dd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUZFOjIyOTI3MjpDQTUyRDpGRjRERjo2OTkxMzMxNiIsInZpc2l0b3JfaWQiOiI2NjQzNzkyNTIyOTEyMDE5MjIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2b842109cbc930190197290d7cf4b3ec66a2abb3a9edcfd09a2b177c1c696812
hovercard-subject-tagpull_request:221465640
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23355/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4fc770999506753e8b96575d11b4aee815c910df0219439fc4405c2afe4f5339/nodejs/node/pull/23355
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4fc770999506753e8b96575d11b4aee815c910df0219439fc4405c2afe4f5339/nodejs/node/pull/23355
og:image:altFixes: #23352 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerefack
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23355#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23355
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23355
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23355
Reloadhttps://github.com/nodejs/node/pull/23355
Reloadhttps://github.com/nodejs/node/pull/23355
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23355
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 710 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:fix-js2c-config.gypi-dependenacyhttps://github.com/refack/node/tree/fix-js2c-config.gypi-dependenacy
Conversationhttps://github.com/nodejs/node/pull/23355
Commits1 (1)https://github.com/nodejs/node/pull/23355/commits
Checkshttps://github.com/nodejs/node/pull/23355/checks
Files changedhttps://github.com/nodejs/node/pull/23355/files
build: restore js2c direct dependency on config.gypihttps://github.com/nodejs/node/pull/23355#top
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:fix-js2c-config.gypi-dependenacyhttps://github.com/refack/node/tree/fix-js2c-config.gypi-dependenacy
https://github.com/refack
refackhttps://github.com/refack
Oct 9, 2018https://github.com/nodejs/node/pull/23355#issue-368244293
#23352https://github.com/nodejs/node/issues/23352
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23355
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 9, 2018https://github.com/nodejs/node/pull/23355#issuecomment-428217891
@refackhttps://github.com/refack
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1181/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1181/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23355
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Oct 9, 2018https://github.com/nodejs/node/pull/23355#event-1893029337
https://github.com/refack
refackhttps://github.com/refack
danbevhttps://github.com/danbev
joyeecheunghttps://github.com/joyeecheung
richardlauhttps://github.com/richardlau
October 9, 2018 14:37https://github.com/nodejs/node/pull/23355#event-1893030001
https://github.com/refack
refackhttps://github.com/refack
Oct 9, 2018https://github.com/nodejs/node/pull/23355#event-1893030130
https://github.com/refack
refackhttps://github.com/refack
regression https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aregression
Oct 9, 2018https://github.com/nodejs/node/pull/23355#event-1893030401
https://github.com/refack
refackhttps://github.com/refack
Oct 9, 2018 https://github.com/nodejs/node/pull/23355#ref-issue-368123159
Running configure twice will most likely cause test failures #23352 https://github.com/nodejs/node/issues/23352
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 9, 2018 https://github.com/nodejs/node/pull/23355#pullrequestreview-163013986
View reviewed changes https://github.com/nodejs/node/pull/23355/files
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 9, 2018 https://github.com/nodejs/node/pull/23355#pullrequestreview-163055990
View reviewed changes https://github.com/nodejs/node/pull/23355/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 9, 2018 https://github.com/nodejs/node/pull/23355#pullrequestreview-163122002
View reviewed changes https://github.com/nodejs/node/pull/23355/files
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2018 https://github.com/nodejs/node/pull/23355#pullrequestreview-163171537
View reviewed changes https://github.com/nodejs/node/pull/23355/files
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2018https://github.com/nodejs/node/pull/23355#issuecomment-428424865
@refackhttps://github.com/refack
black linehttps://travis-ci.com/nodejs/node/jobs/150637907#L752
Please reload this pagehttps://github.com/nodejs/node/pull/23355
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 10, 2018https://github.com/nodejs/node/pull/23355#issuecomment-428425505
nodejs/core-validate-commit#29 (comment)https://github.com/nodejs/core-validate-commit/pull/29#issuecomment-428320152
Please reload this pagehttps://github.com/nodejs/node/pull/23355
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2018 https://github.com/nodejs/node/pull/23355#ref-pullrequest-367558634
src: fix use of deprecated ToObject() #23314 https://github.com/nodejs/node/pull/23314
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2018https://github.com/nodejs/node/pull/23355#issuecomment-428427187
https://ci.nodejs.org/job/node-test-pull-request/17717/https://ci.nodejs.org/job/node-test-pull-request/17717/
Please reload this pagehttps://github.com/nodejs/node/pull/23355
https://github.com/refack
refackhttps://github.com/refack
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Oct 10, 2018https://github.com/nodejs/node/pull/23355#event-1895721690
https://github.com/refack
refackhttps://github.com/refack
Oct 10, 2018https://github.com/nodejs/node/pull/23355#issuecomment-428598938
Please reload this pagehttps://github.com/nodejs/node/pull/23355
https://github.com/refack
build: restore js2c direct dependency on config.gypihttps://github.com/nodejs/node/pull/23355/commits/484e4db46dfea8d90d83847972d121daef7b0ffe
484e4dbhttps://github.com/nodejs/node/pull/23355/commits/484e4db46dfea8d90d83847972d121daef7b0ffe
nodejs#23355https://github.com/nodejs/node/pull/23355
nodejs#23352https://github.com/nodejs/node/issues/23352
https://github.com/refack
refackhttps://github.com/refack
force-pushedhttps://github.com/nodejs/node/compare/7bd8623d2825b21939362d51bf1787dba36d23e0..484e4db46dfea8d90d83847972d121daef7b0ffe
7bd8623https://github.com/nodejs/node/commit/7bd8623d2825b21939362d51bf1787dba36d23e0
484e4dbhttps://github.com/nodejs/node/commit/484e4db46dfea8d90d83847972d121daef7b0ffe
Compare https://github.com/nodejs/node/compare/7bd8623d2825b21939362d51bf1787dba36d23e0..484e4db46dfea8d90d83847972d121daef7b0ffe
October 10, 2018 14:43https://github.com/nodejs/node/pull/23355#event-1895729739
https://github.com/refack
refackhttps://github.com/refack
Oct 10, 2018https://github.com/nodejs/node/pull/23355#issuecomment-428600960
Please reload this pagehttps://github.com/nodejs/node/pull/23355
https://github.com/refack
refackhttps://github.com/refack
484e4dbhttps://github.com/nodejs/node/commit/484e4db46dfea8d90d83847972d121daef7b0ffe
Oct 10, 2018https://github.com/nodejs/node/pull/23355#event-1895739306
https://github.com/refack
refackhttps://github.com/refack
October 10, 2018 14:47https://github.com/nodejs/node/pull/23355#event-1895740695
targoshttps://github.com/targos
Oct 10, 2018 https://github.com/nodejs/node/pull/23355#ref-commit-e6484c2
https://github.com/refack
https://github.com/targos
build: restore js2c direct dependency on config.gypihttps://github.com/nodejs/node/commit/e6484c2c1193d8067e01477497b7dfbb4d8ccab3
e6484c2https://github.com/nodejs/node/commit/e6484c2c1193d8067e01477497b7dfbb4d8ccab3
#23355https://github.com/nodejs/node/pull/23355
#23352https://github.com/nodejs/node/issues/23352
https://github.com/targos
targoshttps://github.com/targos
Oct 10, 2018 https://github.com/nodejs/node/pull/23355#ref-pullrequest-367548700
Release proposal: v10.12.0 #23313 https://github.com/nodejs/node/pull/23313
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#225 https://github.com/beevelop/docker-nodejs/issues/225
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#239 https://github.com/beevelop/docker-android-nodejs/issues/239
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#226 https://github.com/beevelop/docker-nodejs/issues/226
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#240 https://github.com/beevelop/docker-android-nodejs/issues/240
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#227 https://github.com/beevelop/docker-nodejs/issues/227
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#241 https://github.com/beevelop/docker-android-nodejs/issues/241
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#242 https://github.com/beevelop/docker-android-nodejs/issues/242
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#228 https://github.com/beevelop/docker-nodejs/issues/228
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#243 https://github.com/beevelop/docker-android-nodejs/issues/243
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#229 https://github.com/beevelop/docker-nodejs/issues/229
https://github.com/refack
refackhttps://github.com/refack
Oct 12, 2018https://github.com/nodejs/node/pull/23355#event-1899617779
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23355#ref-commit-ec3740c
https://github.com/refack
https://github.com/jasnell
build: restore js2c direct dependency on config.gypihttps://github.com/nodejs/node/commit/ec3740c9ed72892d1eec134201d0c46f7da0799a
ec3740chttps://github.com/nodejs/node/commit/ec3740c9ed72892d1eec134201d0c46f7da0799a
#23355https://github.com/nodejs/node/pull/23355
#23352https://github.com/nodejs/node/issues/23352
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23355
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23355/files/7bd8623d2825b21939362d51bf1787dba36d23e0
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/23355/files/7bd8623d2825b21939362d51bf1787dba36d23e0
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/23355/files/7bd8623d2825b21939362d51bf1787dba36d23e0
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/23355/files/7bd8623d2825b21939362d51bf1787dba36d23e0
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
regression https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aregression
Running configure twice will most likely cause test failures https://github.com/nodejs/node/issues/23352
Please reload this pagehttps://github.com/nodejs/node/pull/23355
https://github.com/refack
https://github.com/nodejs-github-bot
https://github.com/danbev
https://github.com/richardlau
https://github.com/addaleax
https://github.com/joyeecheung
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.