René's URL Explorer Experiment


Title: worker: improve integration with native addons by addaleax · Pull Request #23319 · nodejs/node · GitHub

Open Graph Title: worker: improve integration with native addons by addaleax · Pull Request #23319 · nodejs/node

X Title: worker: improve integration with native addons by addaleax · Pull Request #23319 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Native addons are now unloaded if all Environments referring to it have been cleaned up, except if it also loaded by the main Environment. /cc @gabrielschulhof Who I remember had some suggestions f...

X Description: Native addons are now unloaded if all Environments referring to it have been cleaned up, except if it also loaded by the main Environment. /cc @gabrielschulhof Who I remember had some suggestions f...

Opengraph URL: https://github.com/nodejs/node/pull/23319

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:880b707a-0667-9d2c-c28c-6f317e34f633
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E74:47EDE:3D970E6:57BCF20:6A4FE117
html-safe-nonce8b7d30ba25e072f667a172dcb293ee135cd7cf0b75429cebeb976ffc9a2216b5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTc0OjQ3RURFOjNEOTcwRTY6NTdCQ0YyMDo2QTRGRTExNyIsInZpc2l0b3JfaWQiOiI1NDU2MDk3NDgxMzI1NTM1NTExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac000f67708f3632e91e0ff6e4d202390b38eef564c30f4902b84bcaff1321db2b
hovercard-subject-tagpull_request:220979830
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23319/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fa7ebf98f443f39f6e0991f80b639c29f46289f03f925f66c0adb4a2ddc18377/nodejs/node/pull/23319
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fa7ebf98f443f39f6e0991f80b639c29f46289f03f925f66c0adb4a2ddc18377/nodejs/node/pull/23319
og:image:altNative addons are now unloaded if all Environments referring to it have been cleaned up, except if it also loaded by the main Environment. /cc @gabrielschulhof Who I remember had some suggestions f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23319#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23319
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23319
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23319
Reloadhttps://github.com/nodejs/node/pull/23319
Reloadhttps://github.com/nodejs/node/pull/23319
Please reload this pagehttps://github.com/nodejs/node/pull/23319
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23319
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 974 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-addonshttps://github.com/addaleax/node/tree/worker-addons
Conversationhttps://github.com/nodejs/node/pull/23319
Commits3 (3)https://github.com/nodejs/node/pull/23319/commits
Checkshttps://github.com/nodejs/node/pull/23319/checks
Files changedhttps://github.com/nodejs/node/pull/23319/files
worker: improve integration with native addonshttps://github.com/nodejs/node/pull/23319#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-addonshttps://github.com/addaleax/node/tree/worker-addons
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 7, 2018https://github.com/nodejs/node/pull/23319#issue-367603428
Please reload this pagehttps://github.com/nodejs/node/pull/23319
@gabrielschulhofhttps://github.com/gabrielschulhof
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23319
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 7, 2018https://github.com/nodejs/node/pull/23319#issuecomment-427695027
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1159/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1159/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23319
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
gabrielschulhofhttps://github.com/gabrielschulhof
October 7, 2018 23:07https://github.com/nodejs/node/pull/23319#event-1889223227
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Oct 7, 2018https://github.com/nodejs/node/pull/23319#event-1889223236
https://github.com/addaleax
worker: improve integration with native addonshttps://github.com/nodejs/node/pull/23319/commits/efc57aa2d66ffd1d7ecf995be17b4824d7ed1bc4
efc57aahttps://github.com/nodejs/node/pull/23319/commits/efc57aa2d66ffd1d7ecf995be17b4824d7ed1bc4
ayojs/ayo#118https://github.com/ayojs/ayo/pull/118
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/654099cb1bebe0447477ada17fecaae46ddad87e..efc57aa2d66ffd1d7ecf995be17b4824d7ed1bc4
654099chttps://github.com/nodejs/node/commit/654099cb1bebe0447477ada17fecaae46ddad87e
efc57aahttps://github.com/nodejs/node/commit/efc57aa2d66ffd1d7ecf995be17b4824d7ed1bc4
Compare https://github.com/nodejs/node/compare/654099cb1bebe0447477ada17fecaae46ddad87e..efc57aa2d66ffd1d7ecf995be17b4824d7ed1bc4
October 7, 2018 23:07https://github.com/nodejs/node/pull/23319#event-1889223374
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Oct 7, 2018https://github.com/nodejs/node/pull/23319#event-1889223386
https://github.com/addaleax
fixup! worker: improve integration with native addonshttps://github.com/nodejs/node/pull/23319/commits/f93bca3707c3fa925ba1ae180798ed9d7b85b65a
f93bca3https://github.com/nodejs/node/pull/23319/commits/f93bca3707c3fa925ba1ae180798ed9d7b85b65a
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 7, 2018https://github.com/nodejs/node/pull/23319#issuecomment-427696267
https://github.com/nodejs/node/blob/master/doc/api/addons.md#context-aware-addonshttps://github.com/nodejs/node/blob/master/doc/api/addons.md#context-aware-addons
Please reload this pagehttps://github.com/nodejs/node/pull/23319
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Oct 7, 2018https://github.com/nodejs/node/pull/23319#event-1889235596
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 7, 2018https://github.com/nodejs/node/pull/23319#issuecomment-427697469
@richardlauhttps://github.com/richardlau
Please reload this pagehttps://github.com/nodejs/node/pull/23319
https://github.com/addaleax
squash! worker: improve integration with native addonshttps://github.com/nodejs/node/pull/23319/commits/b7685b69c2a4157384167169cb3501bef1b7256d
b7685b6https://github.com/nodejs/node/pull/23319/commits/b7685b69c2a4157384167169cb3501bef1b7256d
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/1eb48bb1a9307d8db88fcf17f33a350466997605..b7685b69c2a4157384167169cb3501bef1b7256d
1eb48bbhttps://github.com/nodejs/node/commit/1eb48bb1a9307d8db88fcf17f33a350466997605
b7685b6https://github.com/nodejs/node/commit/b7685b69c2a4157384167169cb3501bef1b7256d
Compare https://github.com/nodejs/node/compare/1eb48bb1a9307d8db88fcf17f33a350466997605..b7685b69c2a4157384167169cb3501bef1b7256d
October 7, 2018 23:52https://github.com/nodejs/node/pull/23319#event-1889238397
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 8, 2018 https://github.com/nodejs/node/pull/23319#pullrequestreview-162487632
View reviewed changes https://github.com/nodejs/node/pull/23319/files/b7685b69c2a4157384167169cb3501bef1b7256d
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 20, 2018https://github.com/nodejs/node/pull/23319#issuecomment-440429978
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/23319
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 25, 2018https://github.com/nodejs/node/pull/23319#issuecomment-441417800
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/23319
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 1, 2018 https://github.com/nodejs/node/pull/23319#pullrequestreview-180536033
View reviewed changes https://github.com/nodejs/node/pull/23319/files/b7685b69c2a4157384167169cb3501bef1b7256d
test/addons/worker-addon/binding.cchttps://github.com/nodejs/node/pull/23319/files/b7685b69c2a4157384167169cb3501bef1b7256d#diff-036225db1df1c53166c18fb21fffb10e1d4d3e6dcf59d659c7822c594a1136e8
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 1, 2018https://github.com/nodejs/node/pull/23319#discussion_r238074672
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23319
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 1, 2018 https://github.com/nodejs/node/pull/23319#pullrequestreview-180536783
View reviewed changes https://github.com/nodejs/node/pull/23319/files/b7685b69c2a4157384167169cb3501bef1b7256d
test/addons/dlopen-ping-pong/test.jshttps://github.com/nodejs/node/pull/23319/files/b7685b69c2a4157384167169cb3501bef1b7256d#diff-6490dd0b187d313dd0021a1f323186f2259b24790bbfbb84b3fe8864546c024d
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 1, 2018https://github.com/nodejs/node/pull/23319#discussion_r238075335
Please reload this pagehttps://github.com/nodejs/node/pull/23319
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
our docshttps://nodejs.org/docs/latest/api/addons.html#addons_context_aware_addons
Please reload this pagehttps://github.com/nodejs/node/pull/23319
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 4, 2018https://github.com/nodejs/node/pull/23319#issuecomment-444293671
Please reload this pagehttps://github.com/nodejs/node/pull/23319
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 6, 2018 https://github.com/nodejs/node/pull/23319#ref-pullrequest-388017650
src: unload native addons when the environment is destroyed #24861 https://github.com/nodejs/node/pull/24861
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 7, 2018 https://github.com/nodejs/node/pull/23319#ref-commit-c991280
https://github.com/addaleax
test,doc: add tests and docs for addon unloadinghttps://github.com/gabrielschulhof/node/commit/c991280c889986ed2f044070e93977a2f24e285c
c991280https://github.com/gabrielschulhof/node/commit/c991280c889986ed2f044070e93977a2f24e285c
nodejs#23319https://github.com/nodejs/node/pull/23319
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 7, 2018 https://github.com/nodejs/node/pull/23319#ref-commit-005cbc9
src: unload addons when environment quitshttps://github.com/gabrielschulhof/node/commit/005cbc9c269623a20bcdee635109f2bde82d1484
005cbc9https://github.com/gabrielschulhof/node/commit/005cbc9c269623a20bcdee635109f2bde82d1484
nodejs#23319https://github.com/nodejs/node/pull/23319
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 10, 2018https://github.com/nodejs/node/pull/23319#issuecomment-445981061
@gabrielschulhofhttps://github.com/gabrielschulhof
#24861https://github.com/nodejs/node/pull/24861
Please reload this pagehttps://github.com/nodejs/node/pull/23319
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 10, 2018https://github.com/nodejs/node/pull/23319#event-2017104474
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
December 10, 2018 21:31https://github.com/nodejs/node/pull/23319#event-2017104662
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
superseded https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asuperseded
Dec 10, 2018https://github.com/nodejs/node/pull/23319#event-2017105404
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 20, 2018 https://github.com/nodejs/node/pull/23319#ref-commit-622e348
https://github.com/addaleax
test,doc: add tests and docs for addon unloadinghttps://github.com/nodejs/node/commit/622e348d8f70a4ec006ee1ce9207a6a5bc3fc325
622e348https://github.com/nodejs/node/commit/622e348d8f70a4ec006ee1ce9207a6a5bc3fc325
#23319https://github.com/nodejs/node/pull/23319
#24861https://github.com/nodejs/node/pull/24861
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 20, 2018 https://github.com/nodejs/node/pull/23319#ref-commit-13abc6a
src: unload addons when environment quitshttps://github.com/nodejs/node/commit/13abc6adfb9f6a53618ca7d533d31b6a5d26dcec
13abc6ahttps://github.com/nodejs/node/commit/13abc6adfb9f6a53618ca7d533d31b6a5d26dcec
#23319https://github.com/nodejs/node/pull/23319
#24861https://github.com/nodejs/node/pull/24861
MylesBorinshttps://github.com/MylesBorins
Dec 25, 2018 https://github.com/nodejs/node/pull/23319#ref-commit-8e8c651
https://github.com/addaleax
https://github.com/MylesBorins
test,doc: add tests and docs for addon unloadinghttps://github.com/nodejs/node/commit/8e8c651e4047653a43291013835f70e9cd4a4eb0
8e8c651https://github.com/nodejs/node/commit/8e8c651e4047653a43291013835f70e9cd4a4eb0
#23319https://github.com/nodejs/node/pull/23319
#24861https://github.com/nodejs/node/pull/24861
MylesBorinshttps://github.com/MylesBorins
Dec 25, 2018 https://github.com/nodejs/node/pull/23319#ref-commit-a44910d
https://github.com/MylesBorins
src: unload addons when environment quitshttps://github.com/nodejs/node/commit/a44910df5e3051f21371f8805e2d6547b4901e09
a44910dhttps://github.com/nodejs/node/commit/a44910df5e3051f21371f8805e2d6547b4901e09
#23319https://github.com/nodejs/node/pull/23319
#24861https://github.com/nodejs/node/pull/24861
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 28, 2018 https://github.com/nodejs/node/pull/23319#ref-commit-1c2b202
https://github.com/addaleax
test,doc: add tests and docs for addon unloadinghttps://github.com/gabrielschulhof/node/commit/1c2b202227d0ccf34455f075fdcfb9f31c424f3b
1c2b202https://github.com/gabrielschulhof/node/commit/1c2b202227d0ccf34455f075fdcfb9f31c424f3b
nodejs#23319https://github.com/nodejs/node/pull/23319
nodejs#24861https://github.com/nodejs/node/pull/24861
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 28, 2018 https://github.com/nodejs/node/pull/23319#ref-commit-fdf2e3c
src: unload addons when environment quitshttps://github.com/gabrielschulhof/node/commit/fdf2e3c1155ced426c1f721d768107ab85858c62
fdf2e3chttps://github.com/gabrielschulhof/node/commit/fdf2e3c1155ced426c1f721d768107ab85858c62
nodejs#23319https://github.com/nodejs/node/pull/23319
nodejs#24861https://github.com/nodejs/node/pull/24861
targoshttps://github.com/targos
Jan 1, 2019 https://github.com/nodejs/node/pull/23319#ref-commit-95353c7
https://github.com/addaleax
https://github.com/targos
test,doc: add tests and docs for addon unloadinghttps://github.com/nodejs/node/commit/95353c7c207866a738196e6381b7ccf6e2c87773
95353c7https://github.com/nodejs/node/commit/95353c7c207866a738196e6381b7ccf6e2c87773
#23319https://github.com/nodejs/node/pull/23319
#25258https://github.com/nodejs/node/pull/25258
#24861https://github.com/nodejs/node/pull/24861
targoshttps://github.com/targos
Jan 1, 2019 https://github.com/nodejs/node/pull/23319#ref-commit-d718625
https://github.com/targos
src: unload addons when environment quitshttps://github.com/nodejs/node/commit/d7186252df043bdb693b47f34898e39a32b2c70a
d718625https://github.com/nodejs/node/commit/d7186252df043bdb693b47f34898e39a32b2c70a
#23319https://github.com/nodejs/node/pull/23319
#25258https://github.com/nodejs/node/pull/25258
#24861https://github.com/nodejs/node/pull/24861
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/23319#ref-commit-7ec59dc
https://github.com/refack
test,doc: add tests and docs for addon unloadinghttps://github.com/refack/node/commit/7ec59dc2f661946d5ca6dac787357a3135026a69
7ec59dchttps://github.com/refack/node/commit/7ec59dc2f661946d5ca6dac787357a3135026a69
nodejs#23319https://github.com/nodejs/node/pull/23319
nodejs#24861https://github.com/nodejs/node/pull/24861
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/23319#ref-commit-d8e7b49
https://github.com/refack
src: unload addons when environment quitshttps://github.com/refack/node/commit/d8e7b49b704df926c815407f92b7bda8b4e54156
d8e7b49https://github.com/refack/node/commit/d8e7b49b704df926c815407f92b7bda8b4e54156
nodejs#23319https://github.com/nodejs/node/pull/23319
nodejs#24861https://github.com/nodejs/node/pull/24861
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 18, 2019 https://github.com/nodejs/node/pull/23319#ref-pullrequest-400930376
src: restrict unloading addons to Worker threads #25577 https://github.com/nodejs/node/pull/25577
addaleaxhttps://github.com/addaleax
Jan 22, 2019 https://github.com/nodejs/node/pull/23319#ref-commit-0934abd
https://github.com/addaleax
src: restrict unloading addons to Worker threadshttps://github.com/addaleax/node/commit/0934abdb28ccdeac13ac00ce0ea33941340bbb2c
0934abdhttps://github.com/addaleax/node/commit/0934abdb28ccdeac13ac00ce0ea33941340bbb2c
nodejs#23319https://github.com/nodejs/node/pull/23319
nodejs#24861https://github.com/nodejs/node/pull/24861
nodejs#23319https://github.com/nodejs/node/pull/23319
danbevhttps://github.com/danbev
Jan 23, 2019 https://github.com/nodejs/node/pull/23319#ref-commit-ef1c639
https://github.com/addaleax
https://github.com/danbev
src: restrict unloading addons to Worker threadshttps://github.com/nodejs/node/commit/ef1c639db562f103a66fb5c09e098540347c599f
ef1c639https://github.com/nodejs/node/commit/ef1c639db562f103a66fb5c09e098540347c599f
#23319https://github.com/nodejs/node/pull/23319
#25577https://github.com/nodejs/node/pull/25577
#24861https://github.com/nodejs/node/pull/24861
#23319https://github.com/nodejs/node/pull/23319
addaleaxhttps://github.com/addaleax
Jan 23, 2019 https://github.com/nodejs/node/pull/23319#ref-commit-55768c0
https://github.com/addaleax
src: restrict unloading addons to Worker threadshttps://github.com/nodejs/node/commit/55768c0079d8381b464b99507b6c7f123729a6e6
55768c0https://github.com/nodejs/node/commit/55768c0079d8381b464b99507b6c7f123729a6e6
#23319https://github.com/nodejs/node/pull/23319
#25577https://github.com/nodejs/node/pull/25577
#24861https://github.com/nodejs/node/pull/24861
#23319https://github.com/nodejs/node/pull/23319
addaleaxhttps://github.com/addaleax
Feb 17, 2019 https://github.com/nodejs/node/pull/23319#ref-commit-22d2284
https://github.com/addaleax
worker: improve integration with native addonshttps://github.com/addaleax/node/commit/22d2284226eb9eb2893f8dde0193c9f5903a13ba
22d2284https://github.com/addaleax/node/commit/22d2284226eb9eb2893f8dde0193c9f5903a13ba
nodejs#23319https://github.com/nodejs/node/pull/23319
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 17, 2019 https://github.com/nodejs/node/pull/23319#ref-pullrequest-411247567
worker: improve integration with native addons (take II) #26175 https://github.com/nodejs/node/pull/26175
addaleaxhttps://github.com/addaleax
Feb 20, 2019 https://github.com/nodejs/node/pull/23319#ref-commit-49781f3
https://github.com/addaleax
worker: improve integration with native addonshttps://github.com/addaleax/node/commit/49781f3a057e35a7695597b55fd002066585a918
49781f3https://github.com/addaleax/node/commit/49781f3a057e35a7695597b55fd002066585a918
nodejs#23319https://github.com/nodejs/node/pull/23319
addaleaxhttps://github.com/addaleax
Feb 22, 2019 https://github.com/nodejs/node/pull/23319#ref-commit-8ebd339
https://github.com/addaleax
worker: improve integration with native addonshttps://github.com/nodejs/node/commit/8ebd339031cf9826629ad780dd35fee130e95985
8ebd339https://github.com/nodejs/node/commit/8ebd339031cf9826629ad780dd35fee130e95985
#23319https://github.com/nodejs/node/pull/23319
#26175https://github.com/nodejs/node/pull/26175
#21481https://github.com/nodejs/node/issues/21481
#21783https://github.com/nodejs/node/issues/21783
#25662https://github.com/nodejs/node/issues/25662
#20239https://github.com/nodejs/node/issues/20239
addaleaxhttps://github.com/addaleax
Feb 25, 2019 https://github.com/nodejs/node/pull/23319#ref-commit-07b2ee2
https://github.com/addaleax
worker: improve integration with native addonshttps://github.com/nodejs/node/commit/07b2ee275361e02adde4e1894a53d8a1f59c5a86
07b2ee2https://github.com/nodejs/node/commit/07b2ee275361e02adde4e1894a53d8a1f59c5a86
#23319https://github.com/nodejs/node/pull/23319
#26175https://github.com/nodejs/node/pull/26175
#21481https://github.com/nodejs/node/issues/21481
#21783https://github.com/nodejs/node/issues/21783
#25662https://github.com/nodejs/node/issues/25662
#20239https://github.com/nodejs/node/issues/20239
rvagghttps://github.com/rvagg
Feb 28, 2019 https://github.com/nodejs/node/pull/23319#ref-commit-a9a2c58
https://github.com/addaleax
https://github.com/rvagg
worker: improve integration with native addonshttps://github.com/nodejs/node/commit/a9a2c5869c29db3222533e6c5fb3511226753bf4
a9a2c58https://github.com/nodejs/node/commit/a9a2c5869c29db3222533e6c5fb3511226753bf4
#23319https://github.com/nodejs/node/pull/23319
#26175https://github.com/nodejs/node/pull/26175
#21481https://github.com/nodejs/node/issues/21481
#21783https://github.com/nodejs/node/issues/21783
#25662https://github.com/nodejs/node/issues/25662
#20239https://github.com/nodejs/node/issues/20239
https://github.com/tshemsedinov
tshemsedinovhttps://github.com/tshemsedinov
Mar 2, 2019 https://github.com/nodejs/node/pull/23319#ref-issue-416391587
Require for native add-ons in worker_threads metarhia/Metarhia#34 https://github.com/metarhia/Metarhia/issues/34
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23319
https://github.com/gabrielschulhof
gabrielschulhof https://github.com/gabrielschulhof
https://github.com/nodejs/node/pull/23319/files/b7685b69c2a4157384167169cb3501bef1b7256d
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23319/files/b7685b69c2a4157384167169cb3501bef1b7256d
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Please reload this pagehttps://github.com/nodejs/node/pull/23319
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/Trott
https://github.com/gabrielschulhof
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.