René's URL Explorer Experiment


Title: src: fix use of deprecated ToObject() by cjihrig · Pull Request #23314 · nodejs/node · GitHub

Open Graph Title: src: fix use of deprecated ToObject() by cjihrig · Pull Request #23314 · nodejs/node

X Title: src: fix use of deprecated ToObject() by cjihrig · Pull Request #23314 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/23314

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2fc83870-6da5-8d26-59dd-b4f3bc9c3368
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE462:10BE49:1970FE8:201E859:69917BD6
html-safe-nonced3f25992a31fa31144d25332f33f064b1d62cb4fe388d45ab33a437820c0ee09
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDYyOjEwQkU0OToxOTcwRkU4OjIwMUU4NTk6Njk5MTdCRDYiLCJ2aXNpdG9yX2lkIjoiNTkxODQwMzc3NTMyNDg0NzA2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8a76bcaa1741b1f6d3aa937dd43d420cad5a75214b84753508a9a73d7b1f47d3
hovercard-subject-tagpull_request:220950676
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23314/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/00dc68462639c7ba3c4dae64b64042d3b8767ffe7da5a5c30233c30d047f2481/nodejs/node/pull/23314
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/00dc68462639c7ba3c4dae64b64042d3b8767ffe7da5a5c30233c30d047f2481/nodejs/node/pull/23314
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23314#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23314
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23314
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23314
Reloadhttps://github.com/nodejs/node/pull/23314
Reloadhttps://github.com/nodejs/node/pull/23314
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23314
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:deprshttps://github.com/cjihrig/node/tree/deprs
Conversationhttps://github.com/nodejs/node/pull/23314
Commits2 (2)https://github.com/nodejs/node/pull/23314/commits
Checkshttps://github.com/nodejs/node/pull/23314/checks
Files changedhttps://github.com/nodejs/node/pull/23314/files
src: fix use of deprecated ToObject()https://github.com/nodejs/node/pull/23314#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:deprshttps://github.com/cjihrig/node/tree/deprs
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 7, 2018https://github.com/nodejs/node/pull/23314#issue-367558634
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23314
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 7, 2018https://github.com/nodejs/node/pull/23314#issuecomment-427656791
@cjihrighttps://github.com/cjihrig
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1156/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1156/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23314
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http_parser https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp_parser
Oct 7, 2018https://github.com/nodejs/node/pull/23314#event-1889022835
https://github.com/targos
targoshttps://github.com/targos
Oct 7, 2018 https://github.com/nodejs/node/pull/23314#pullrequestreview-162292303
View reviewed changes https://github.com/nodejs/node/pull/23314/files
src/exceptions.cchttps://github.com/nodejs/node/pull/23314/files#diff-bae87be6dce6f3aa000e3962f2c003c10c1e1159dadf06b7c6e9f75dbbf8b05e
Please reload this pagehttps://github.com/nodejs/node/pull/23314
src/node_http_parser.cchttps://github.com/nodejs/node/pull/23314/files#diff-bbcf7a115fe4680f3a7c076a487c89bd4ce935e7d2a726cfcb3f69331705e25e
targoshttps://github.com/targos
Oct 7, 2018https://github.com/nodejs/node/pull/23314#discussion_r223215635
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23314
targoshttps://github.com/targos
Oct 8, 2018https://github.com/nodejs/node/pull/23314#discussion_r223378275
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/23314
refackhttps://github.com/refack
Oct 8, 2018https://github.com/nodejs/node/pull/23314#discussion_r223383768
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23314
addaleaxhttps://github.com/addaleax
Oct 8, 2018https://github.com/nodejs/node/pull/23314#discussion_r223439305
Please reload this pagehttps://github.com/nodejs/node/pull/23314
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/23314
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 7, 2018 https://github.com/nodejs/node/pull/23314#pullrequestreview-162295284
View reviewed changes https://github.com/nodejs/node/pull/23314/files
src/exceptions.cchttps://github.com/nodejs/node/pull/23314/files#diff-bae87be6dce6f3aa000e3962f2c003c10c1e1159dadf06b7c6e9f75dbbf8b05e
Please reload this pagehttps://github.com/nodejs/node/pull/23314
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 8, 2018 https://github.com/nodejs/node/pull/23314#pullrequestreview-162333073
View reviewed changes https://github.com/nodejs/node/pull/23314/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 8, 2018 https://github.com/nodejs/node/pull/23314#pullrequestreview-162488253
View reviewed changes https://github.com/nodejs/node/pull/23314/files
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 8, 2018 https://github.com/nodejs/node/pull/23314#pullrequestreview-162588492
View reviewed changes https://github.com/nodejs/node/pull/23314/files
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2018https://github.com/nodejs/node/pull/23314#issuecomment-428425823
Please reload this pagehttps://github.com/nodejs/node/pull/23314
https://ci.nodejs.org/job/node-test-pull-request/17716/https://ci.nodejs.org/job/node-test-pull-request/17716/
blank linehttps://ci.nodejs.org/job/node-test-pull-request/17716/
alreadyhttps://github.com/nodejs/node/pull/23355#issuecomment-428425505
Please reload this pagehttps://github.com/nodejs/node/pull/23314
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2018https://github.com/nodejs/node/pull/23314#issuecomment-428545209
Please reload this pagehttps://github.com/nodejs/node/pull/23314
node-test-commit-linuxhttps://ci.nodejs.org/job/node-test-commit-linux/22216/
node-test-commit-armhttps://ci.nodejs.org/job/node-test-commit-arm/19084/
node-test-commit-arm-fannedhttps://ci.nodejs.org/job/node-test-commit-arm-fanned/3956/
Please reload this pagehttps://github.com/nodejs/node/pull/23314
cjihrighttps://github.com/cjihrig
October 10, 2018 10:31https://github.com/nodejs/node/pull/23314#commits-pushed-59d2bd9
https://github.com/cjihrig
src: fix ToObject() usage in exceptions.cchttps://github.com/nodejs/node/pull/23314/commits/59d2bd9fb5da1606ce673246aa5ca9fe17c7dd53
59d2bd9https://github.com/nodejs/node/pull/23314/commits/59d2bd9fb5da1606ce673246aa5ca9fe17c7dd53
nodejs#23314https://github.com/nodejs/node/pull/23314
https://github.com/cjihrig
src: fix ToObject() usage in node_http_parser.cchttps://github.com/nodejs/node/pull/23314/commits/20de5f3fa2c96897ae92ac27a1883b5d266d6ca1
20de5f3https://github.com/nodejs/node/pull/23314/commits/20de5f3fa2c96897ae92ac27a1883b5d266d6ca1
nodejs#23314https://github.com/nodejs/node/pull/23314
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/89ca374a812a6e34be38b1f237ed97d977ae9209..20de5f3fa2c96897ae92ac27a1883b5d266d6ca1
89ca374https://github.com/nodejs/node/commit/89ca374a812a6e34be38b1f237ed97d977ae9209
20de5f3https://github.com/nodejs/node/commit/20de5f3fa2c96897ae92ac27a1883b5d266d6ca1
Compare https://github.com/nodejs/node/compare/89ca374a812a6e34be38b1f237ed97d977ae9209..20de5f3fa2c96897ae92ac27a1883b5d266d6ca1
October 10, 2018 14:32https://github.com/nodejs/node/pull/23314#event-1895697593
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
20de5f3https://github.com/nodejs/node/commit/20de5f3fa2c96897ae92ac27a1883b5d266d6ca1
Oct 10, 2018https://github.com/nodejs/node/pull/23314#event-1895701364
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
October 10, 2018 14:34https://github.com/nodejs/node/pull/23314#event-1895701928
targoshttps://github.com/targos
Oct 10, 2018 https://github.com/nodejs/node/pull/23314#ref-commit-5228ec4
https://github.com/cjihrig
https://github.com/targos
src: fix ToObject() usage in exceptions.cchttps://github.com/nodejs/node/commit/5228ec4410605651192137890da5c41ac5755bcc
5228ec4https://github.com/nodejs/node/commit/5228ec4410605651192137890da5c41ac5755bcc
#23314https://github.com/nodejs/node/pull/23314
targoshttps://github.com/targos
Oct 10, 2018 https://github.com/nodejs/node/pull/23314#ref-commit-cd69e1b
https://github.com/cjihrig
https://github.com/targos
src: fix ToObject() usage in node_http_parser.cchttps://github.com/nodejs/node/commit/cd69e1b6c3e07946b53548b72228c432e2993a79
cd69e1bhttps://github.com/nodejs/node/commit/cd69e1b6c3e07946b53548b72228c432e2993a79
#23314https://github.com/nodejs/node/pull/23314
https://github.com/targos
targoshttps://github.com/targos
Oct 10, 2018 https://github.com/nodejs/node/pull/23314#ref-pullrequest-367548700
Release proposal: v10.12.0 #23313 https://github.com/nodejs/node/pull/23313
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#225 https://github.com/beevelop/docker-nodejs/issues/225
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#239 https://github.com/beevelop/docker-android-nodejs/issues/239
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#226 https://github.com/beevelop/docker-nodejs/issues/226
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#240 https://github.com/beevelop/docker-android-nodejs/issues/240
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#227 https://github.com/beevelop/docker-nodejs/issues/227
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#241 https://github.com/beevelop/docker-android-nodejs/issues/241
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#242 https://github.com/beevelop/docker-android-nodejs/issues/242
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#228 https://github.com/beevelop/docker-nodejs/issues/228
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#243 https://github.com/beevelop/docker-android-nodejs/issues/243
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#229 https://github.com/beevelop/docker-nodejs/issues/229
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23314#ref-commit-5d69627
https://github.com/cjihrig
https://github.com/jasnell
src: fix ToObject() usage in exceptions.cchttps://github.com/nodejs/node/commit/5d696273155a81f139a99ae8f2cad913fa60ef38
5d69627https://github.com/nodejs/node/commit/5d696273155a81f139a99ae8f2cad913fa60ef38
#23314https://github.com/nodejs/node/pull/23314
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23314#ref-commit-153c0dc
https://github.com/cjihrig
https://github.com/jasnell
src: fix ToObject() usage in node_http_parser.cchttps://github.com/nodejs/node/commit/153c0dc7af48c12bff5fac48ad79c62935789ade
153c0dchttps://github.com/nodejs/node/commit/153c0dc7af48c12bff5fac48ad79c62935789ade
#23314https://github.com/nodejs/node/pull/23314
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23314
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23314/files/89ca374a812a6e34be38b1f237ed97d977ae9209
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/23314/files/89ca374a812a6e34be38b1f237ed97d977ae9209
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23314/files/89ca374a812a6e34be38b1f237ed97d977ae9209
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/23314/files/89ca374a812a6e34be38b1f237ed97d977ae9209
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/23314/files/89ca374a812a6e34be38b1f237ed97d977ae9209
https://github.com/thefourtheye
thefourtheye https://github.com/thefourtheye
https://github.com/nodejs/node/pull/23314/files/89ca374a812a6e34be38b1f237ed97d977ae9209
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http_parser https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp_parser
Please reload this pagehttps://github.com/nodejs/node/pull/23314
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/danbev
https://github.com/refack
https://github.com/jasnell
https://github.com/thefourtheye
https://github.com/addaleax
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.