| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:ce0704aa-2d61-4491-32e0-6275cab2d619 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B95A:1D8A21:139C36:1B4C3E:69976920 |
| html-safe-nonce | f36190728af0b3f72a072a81992f2b26c26672c2744f672c9226716a996c0da8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTVBOjFEOEEyMToxMzlDMzY6MUI0QzNFOjY5OTc2OTIwIiwidmlzaXRvcl9pZCI6IjkzMjk5OTE3OTE2MDQ4MDAzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5b30f101873688053850d37003d64fea13e4423dbb3b4cecb913f0b52a495d9c |
| hovercard-subject-tag | pull_request:220847783 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612 |
| twitter:image | https://avatars.githubusercontent.com/u/96947?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/96947?s=400&v=4 |
| og:image:alt | Fixes: nodejs/node-v8#81
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f6df5422af98e8455c055522f48ada1a19fab299cf47471bdd590f8b7291770 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9b5cbb0725d622d54f9a26cbf0adbfbe35459c44 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23286%2Fcommits%2F193ee7390852b9f8c6b693005dcdeceb635fc612 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23286%2Fcommits%2F193ee7390852b9f8c6b693005dcdeceb635fc612 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612 |
| Reload | https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612 |
| Reload | https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.8k
| https://github.com/nodejs/node/issues |
|
Pull requests
712
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| refack | https://github.com/refack |
| nodejs:canary-base | https://github.com/nodejs/node/tree/canary-base |
| refack:mips-atomics | https://github.com/refack/node/tree/mips-atomics |
|
Conversation
13
| https://github.com/nodejs/node/pull/23286 |
|
Commits
9
| https://github.com/nodejs/node/pull/23286/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/23286/checks |
|
Files changed
| https://github.com/nodejs/node/pull/23286/files |
| Please reload this page | https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612 |
|
deps,v8: link with atomic for platforms lacking CAS
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#top |
|
Show all changes
9 commits
| https://github.com/nodejs/node/pull/23286/files |
|
c679d80
deps: update V8 to 7.1.0
targos Oct 5, 2018
| https://github.com/nodejs/node/pull/23286/commits/c679d806b38c54af2e2a4aa5bec3219015abf5ce |
|
7adef39
build: reset embedder string to "-node.0"
targos Oct 5, 2018
| https://github.com/nodejs/node/pull/23286/commits/7adef3912675b5b944b30c014a51b811682bd6e0 |
|
37bb409
src: update NODE_MODULE_VERSION to 68
targos Oct 5, 2018
| https://github.com/nodejs/node/pull/23286/commits/37bb409066ecf62e45db7c16cd8623f928e9075f |
|
193ee73
deps: update v8.gyp
targos Aug 29, 2018
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612 |
|
34671d2
deps: update v8.gyp
targos Oct 5, 2018
| https://github.com/nodejs/node/pull/23286/commits/34671d2912495ff9032e6f8db78e3fc2d5a46610 |
|
d172625
deps: V8 sync gypfiles with 7.1
refack Oct 4, 2018
| https://github.com/nodejs/node/pull/23286/commits/d17262581e4b66218584adb8b1c3ed23edb9307e |
|
f84d485
deps,v8: link with `atomic` for platforms lacking CAS
refack Oct 5, 2018
| https://github.com/nodejs/node/pull/23286/commits/f84d4859fc2310b6a36d050a683adeefe675d226 |
|
6e24dcc
temprary fix for CI
refack Oct 2, 2018
| https://github.com/nodejs/node/pull/23286/commits/6e24dcca961b36d22351a62757717bd70783de30 |
|
24ffb72
fixup! 1
refack Oct 5, 2018
| https://github.com/nodejs/node/pull/23286/commits/24ffb7256789ef0ed3c5e30087bdf0506a865e91 |
|
Clear filters
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612 |
| Please reload this page | https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612 |
| Please reload this page | https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612 |
|
Prev
| https://github.com/nodejs/node/pull/23286/commits/37bb409066ecf62e45db7c16cd8623f928e9075f |
|
Next
| https://github.com/nodejs/node/pull/23286/commits/34671d2912495ff9032e6f8db78e3fc2d5a46610 |
| Please reload this page | https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612 |
|
| https://github.com/targos |
| targos | https://github.com/nodejs/node/commits?author=targos |
| deps/v8/gypfiles/v8.gyp | https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
View file
| https://github.com/refack/node/blob/193ee7390852b9f8c6b693005dcdeceb635fc612/deps/v8/gypfiles/v8.gyp |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/23286/commits/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |