René's URL Explorer Experiment


Title: deps,v8: link with `atomic` for platforms lacking CAS by refack · Pull Request #23286 · nodejs/node · GitHub

Open Graph Title: deps,v8: link with `atomic` for platforms lacking CAS by refack · Pull Request #23286 · nodejs/node

X Title: deps,v8: link with `atomic` for platforms lacking CAS by refack · Pull Request #23286 · nodejs/node

Description: Fixes: nodejs/node-v8#81 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Open Graph Description: Fixes: nodejs/node-v8#81 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Fixes: nodejs/node-v8#81 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/23286

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1540b7de-de94-f78f-626f-65aac48fd9ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC98:14FC13:1CFF65B:266EE1F:696AFDC6
html-safe-nonce9b903cfacf888b173ca56ce8685db040f28f173b32a478080dcb9c230cc3cb3f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzk4OjE0RkMxMzoxQ0ZGNjVCOjI2NkVFMUY6Njk2QUZEQzYiLCJ2aXNpdG9yX2lkIjoiMTQ5MTgyNzkwNTI5OTkzODc1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3081470a110cac91e0423cbac6ccefea97d8e3ccba07dda6bcbc587591c29030
hovercard-subject-tagpull_request:220847783
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23286/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b2e9c47fd4fa4b946871a6bc31115150c2f5de85887e16603d84c298b66a987e/nodejs/node/pull/23286
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b2e9c47fd4fa4b946871a6bc31115150c2f5de85887e16603d84c298b66a987e/nodejs/node/pull/23286
og:image:altFixes: nodejs/node-v8#81 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerefack
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23286#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23286
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23286
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23286
Reloadhttps://github.com/nodejs/node/pull/23286
Reloadhttps://github.com/nodejs/node/pull/23286
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23286
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 692 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/23286
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/23286#issue-comment-box
refackhttps://github.com/refack
nodejs:canary-basehttps://github.com/nodejs/node/tree/canary-base
refack:mips-atomicshttps://github.com/refack/node/tree/mips-atomics
deps,v8: link with atomic for platforms lacking CAS https://github.com/nodejs/node/pull/23286#top
refackhttps://github.com/refack
nodejs:canary-basehttps://github.com/nodejs/node/tree/canary-base
refack:mips-atomicshttps://github.com/refack/node/tree/mips-atomics
Conversation 13 https://github.com/nodejs/node/pull/23286
Commits 9 https://github.com/nodejs/node/pull/23286/commits
Checks 0 https://github.com/nodejs/node/pull/23286/checks
Files changed https://github.com/nodejs/node/pull/23286/files
Please reload this pagehttps://github.com/nodejs/node/pull/23286
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/refack
refackhttps://github.com/refack
Oct 5, 2018https://github.com/nodejs/node/pull/23286#issue-367398600
Please reload this pagehttps://github.com/nodejs/node/pull/23286
nodejs/node-v8#81https://github.com/nodejs/node-v8/issues/81
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23286
targoshttps://github.com/targos
October 5, 2018 07:52https://github.com/nodejs/node/pull/23286#commits-pushed-c679d80
https://github.com/targos
deps: update V8 to 7.1.0https://github.com/nodejs/node/pull/23286/commits/c679d806b38c54af2e2a4aa5bec3219015abf5ce
c679d80https://github.com/nodejs/node/pull/23286/commits/c679d806b38c54af2e2a4aa5bec3219015abf5ce
https://github.com/targos
build: reset embedder string to "-node.0"https://github.com/nodejs/node/pull/23286/commits/7adef3912675b5b944b30c014a51b811682bd6e0
7adef39https://github.com/nodejs/node/pull/23286/commits/7adef3912675b5b944b30c014a51b811682bd6e0
https://github.com/targos
src: update NODE_MODULE_VERSION to 68https://github.com/nodejs/node/pull/23286/commits/37bb409066ecf62e45db7c16cd8623f928e9075f
37bb409https://github.com/nodejs/node/pull/23286/commits/37bb409066ecf62e45db7c16cd8623f928e9075f
https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.mdhttps://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
https://github.com/targos
deps: update v8.gyphttps://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612
193ee73https://github.com/nodejs/node/pull/23286/commits/193ee7390852b9f8c6b693005dcdeceb635fc612
https://github.com/targos
deps: update v8.gyphttps://github.com/nodejs/node/pull/23286/commits/34671d2912495ff9032e6f8db78e3fc2d5a46610
34671d2https://github.com/nodejs/node/pull/23286/commits/34671d2912495ff9032e6f8db78e3fc2d5a46610
https://github.com/refack
https://github.com/targos
deps: V8 sync gypfiles with 7.1https://github.com/nodejs/node/pull/23286/commits/d17262581e4b66218584adb8b1c3ed23edb9307e
d172625https://github.com/nodejs/node/pull/23286/commits/d17262581e4b66218584adb8b1c3ed23edb9307e
https://github.com/refack
deps,v8: link with atomic for platforms lacking CAShttps://github.com/nodejs/node/pull/23286/commits/f84d4859fc2310b6a36d050a683adeefe675d226
f84d485https://github.com/nodejs/node/pull/23286/commits/f84d4859fc2310b6a36d050a683adeefe675d226
nodejs/node-v8#81https://github.com/nodejs/node-v8/issues/81
https://github.com/refack
refackhttps://github.com/refack
targoshttps://github.com/targos
October 5, 2018 23:30https://github.com/nodejs/node/pull/23286#event-1888288952
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 5, 2018https://github.com/nodejs/node/pull/23286#issuecomment-427524876
@refackhttps://github.com/refack
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1133/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1133/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23286
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Oct 5, 2018https://github.com/nodejs/node/pull/23286#event-1888289007
https://github.com/refack
temprary fix for CIhttps://github.com/nodejs/node/pull/23286/commits/6e24dcca961b36d22351a62757717bd70783de30
6e24dcchttps://github.com/nodejs/node/pull/23286/commits/6e24dcca961b36d22351a62757717bd70783de30
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 5, 2018 https://github.com/nodejs/node/pull/23286#pullrequestreview-162231866
View reviewed changes https://github.com/nodejs/node/pull/23286/files/6e24dcca961b36d22351a62757717bd70783de30
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/23286#pullrequestreview-162231866
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23286
Makefilehttps://github.com/nodejs/node/pull/23286/files/6e24dcca961b36d22351a62757717bd70783de30#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
addaleaxhttps://github.com/addaleax
Oct 5, 2018https://github.com/nodejs/node/pull/23286#discussion_r223160825
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23286
refackhttps://github.com/refack
Oct 5, 2018https://github.com/nodejs/node/pull/23286#discussion_r223161746
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
6e24dcchttps://github.com/nodejs/node/commit/6e24dcca961b36d22351a62757717bd70783de30
#23257https://github.com/nodejs/node/pull/23257
#22006https://github.com/nodejs/node/issues/22006
Please reload this pagehttps://github.com/nodejs/node/pull/23286
addaleaxhttps://github.com/addaleax
Oct 5, 2018https://github.com/nodejs/node/pull/23286#discussion_r223161922
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#23257https://github.com/nodejs/node/pull/23257
Please reload this pagehttps://github.com/nodejs/node/pull/23286
refackhttps://github.com/refack
Oct 6, 2018https://github.com/nodejs/node/pull/23286#discussion_r223163156
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#23257https://github.com/nodejs/node/pull/23257
5d8373ahttps://github.com/nodejs/node/commit/5d8373a498a50b1387464391402ef22636439303
node/Makefilehttps://github.com/nodejs/node/blob/2ba19ff2b8a6253c6fb7795f35d4fb1c30ec6c30/Makefile#L457-L467
2ba19ffhttps://github.com/nodejs/node/commit/2ba19ff2b8a6253c6fb7795f35d4fb1c30ec6c30
Please reload this pagehttps://github.com/nodejs/node/pull/23286
deps/v8/gypfiles/v8.gyphttps://github.com/nodejs/node/pull/23286/files/6e24dcca961b36d22351a62757717bd70783de30#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f
addaleaxhttps://github.com/addaleax
Oct 5, 2018https://github.com/nodejs/node/pull/23286#discussion_r223160881
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23286
refackhttps://github.com/refack
Oct 5, 2018https://github.com/nodejs/node/pull/23286#discussion_r223161872
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23286
https://github.com/refack
fixup! 1https://github.com/nodejs/node/pull/23286/commits/24ffb7256789ef0ed3c5e30087bdf0506a865e91
24ffb72https://github.com/nodejs/node/pull/23286/commits/24ffb7256789ef0ed3c5e30087bdf0506a865e91
https://github.com/refack
refackhttps://github.com/refack
Oct 5, 2018https://github.com/nodejs/node/pull/23286#issuecomment-427527072
https://ci.nodejs.org/job/node-test-pull-request/17652/https://ci.nodejs.org/job/node-test-pull-request/17652/
Please reload this pagehttps://github.com/nodejs/node/pull/23286
https://github.com/refack
refackhttps://github.com/refack
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Oct 5, 2018https://github.com/nodejs/node/pull/23286#event-1888304143
https://github.com/refack
refackhttps://github.com/refack
Oct 6, 2018https://github.com/nodejs/node/pull/23286#issuecomment-427530834
Please reload this pagehttps://github.com/nodejs/node/pull/23286
https://github.com/targos
targoshttps://github.com/targos
Oct 6, 2018https://github.com/nodejs/node/pull/23286#issuecomment-427555479
Please reload this pagehttps://github.com/nodejs/node/pull/23286
https://github.com/targos
targoshttps://github.com/targos
Oct 6, 2018 https://github.com/nodejs/node/pull/23286#pullrequestreview-162249283
View reviewed changes https://github.com/nodejs/node/pull/23286/files/24ffb7256789ef0ed3c5e30087bdf0506a865e91
https://github.com/targos
targoshttps://github.com/targos
force-pushedhttps://github.com/nodejs/node/compare/d17262581e4b66218584adb8b1c3ed23edb9307e..5982e7a6e88bec3f7996fc97bd211a73b2d93479
d172625https://github.com/nodejs/node/commit/d17262581e4b66218584adb8b1c3ed23edb9307e
5982e7ahttps://github.com/nodejs/node/commit/5982e7a6e88bec3f7996fc97bd211a73b2d93479
Compare https://github.com/nodejs/node/compare/d17262581e4b66218584adb8b1c3ed23edb9307e..5982e7a6e88bec3f7996fc97bd211a73b2d93479
October 6, 2018 08:26https://github.com/nodejs/node/pull/23286#event-1888479587
https://github.com/targos
targoshttps://github.com/targos
Oct 6, 2018https://github.com/nodejs/node/pull/23286#issuecomment-427556534
5982e7ahttps://github.com/nodejs/node/commit/5982e7a6e88bec3f7996fc97bd211a73b2d93479
47835e2https://github.com/nodejs/node/commit/47835e26efb386ed3c7f21cff6e681042b068cbc
Please reload this pagehttps://github.com/nodejs/node/pull/23286
https://github.com/targos
targoshttps://github.com/targos
Oct 6, 2018https://github.com/nodejs/node/pull/23286#event-1888480093
https://github.com/targos
targoshttps://github.com/targos
Oct 6, 2018https://github.com/nodejs/node/pull/23286#issuecomment-427557328
https://ci.nodejs.org/view/MyJobs/job/node-test-commit-node-v8/108/https://ci.nodejs.org/view/MyJobs/job/node-test-commit-node-v8/108/
Please reload this pagehttps://github.com/nodejs/node/pull/23286
https://github.com/refack
refackhttps://github.com/refack
October 6, 2018 13:43https://github.com/nodejs/node/pull/23286#event-1888577519
https://github.com/refack
refackhttps://github.com/refack
Oct 18, 2018 https://github.com/nodejs/node/pull/23286#ref-pullrequest-371578495
build: spawn make test-ci with -j1 #23733 https://github.com/nodejs/node/pull/23733
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23286
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23286/files/24ffb7256789ef0ed3c5e30087bdf0506a865e91
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/23286/files/24ffb7256789ef0ed3c5e30087bdf0506a865e91
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Please reload this pagehttps://github.com/nodejs/node/pull/23286
https://github.com/refack
https://github.com/nodejs-github-bot
https://github.com/targos
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.