René's URL Explorer Experiment


Title: test: add module require tests for certain package.json errors by TomCoded · Pull Request #23285 · nodejs/node · GitHub

Open Graph Title: test: add module require tests for certain package.json errors by TomCoded · Pull Request #23285 · nodejs/node

X Title: test: add module require tests for certain package.json errors by TomCoded · Pull Request #23285 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: test for unusual error cases: verify that module require falls back to index if package.json names a missing file and throws an error if package.json is unparseable. Checklist make -j4 test (UNIX...

X Description: test for unusual error cases: verify that module require falls back to index if package.json names a missing file and throws an error if package.json is unparseable. Checklist make -j4 test (UNIX...

Opengraph URL: https://github.com/nodejs/node/pull/23285

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2ec13244-0fb8-6633-c756-49d43157bb18
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB246:1D13CA:194B99C:20657F8:6991ADEA
html-safe-nonce0d540ce560251732f668ad4eb19ae7d51ed7d2d455beaf0e5bd5023d47fbee1f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjQ2OjFEMTNDQToxOTRCOTlDOjIwNjU3Rjg6Njk5MUFERUEiLCJ2aXNpdG9yX2lkIjoiMzcxNTgyODEyNTMxMzA1OTYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3778dd3a65ea531f52ca7830c69b3dcb85f316ead283ac85df7db678781ff216
hovercard-subject-tagpull_request:220841764
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23285/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9891ac4fe4a33738ca41cf20620374c704b6d9c5eb18bc97eba7b1748ba633a8/nodejs/node/pull/23285
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9891ac4fe4a33738ca41cf20620374c704b6d9c5eb18bc97eba7b1748ba633a8/nodejs/node/pull/23285
og:image:alttest for unusual error cases: verify that module require falls back to index if package.json names a missing file and throws an error if package.json is unparseable. Checklist make -j4 test (UNIX...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTomCoded
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23285#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23285
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23285
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23285
Reloadhttps://github.com/nodejs/node/pull/23285
Reloadhttps://github.com/nodejs/node/pull/23285
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23285
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
TomCodedhttps://github.com/TomCoded
nodejs:masterhttps://github.com/nodejs/node/tree/master
TomCoded:packagejsontestshttps://github.com/TomCoded/node/tree/packagejsontests
Conversationhttps://github.com/nodejs/node/pull/23285
Commits2 (2)https://github.com/nodejs/node/pull/23285/commits
Checkshttps://github.com/nodejs/node/pull/23285/checks
Files changedhttps://github.com/nodejs/node/pull/23285/files
test: add module require tests for certain package.json errorshttps://github.com/nodejs/node/pull/23285#top
TomCodedhttps://github.com/TomCoded
nodejs:masterhttps://github.com/nodejs/node/tree/master
TomCoded:packagejsontestshttps://github.com/TomCoded/node/tree/packagejsontests
https://github.com/TomCoded
TomCodedhttps://github.com/TomCoded
Oct 5, 2018https://github.com/nodejs/node/pull/23285#issue-367390937
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23285
https://github.com/TomCoded
test: add module require tests for certain package.json errorshttps://github.com/nodejs/node/pull/23285/commits/7d7218b252028f25be6af33929fff354de375ba5
7d7218bhttps://github.com/nodejs/node/pull/23285/commits/7d7218b252028f25be6af33929fff354de375ba5
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Oct 5, 2018https://github.com/nodejs/node/pull/23285#event-1888246325
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 5, 2018 https://github.com/nodejs/node/pull/23285#pullrequestreview-162225785
View reviewed changes https://github.com/nodejs/node/pull/23285/files/7d7218b252028f25be6af33929fff354de375ba5
test/sequential/test-module-loading.jshttps://github.com/nodejs/node/pull/23285/files/7d7218b252028f25be6af33929fff354de375ba5#diff-1d24c1f48ca260ae6baf0f98f0dffecabf1c90400d799b77376a62d2651bed5f
Trotthttps://github.com/Trott
Oct 5, 2018https://github.com/nodejs/node/pull/23285#discussion_r223156033
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23285
TomCodedhttps://github.com/TomCoded
Oct 6, 2018https://github.com/nodejs/node/pull/23285#discussion_r223165942
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23285
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 5, 2018https://github.com/nodejs/node/pull/23285#issuecomment-427519069
Please reload this pagehttps://github.com/nodejs/node/pull/23285
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 5, 2018https://github.com/nodejs/node/pull/23285#issuecomment-427519178
Please reload this pagehttps://github.com/nodejs/node/pull/23285
https://github.com/TomCoded
test: migrate new tests to use assert.throwshttps://github.com/nodejs/node/pull/23285/commits/c571dab2606e85c80a8d3c360e134297d1364843
c571dabhttps://github.com/nodejs/node/pull/23285/commits/c571dab2606e85c80a8d3c360e134297d1364843
https://github.com/TomCoded
TomCodedhttps://github.com/TomCoded
Oct 6, 2018https://github.com/nodejs/node/pull/23285#issuecomment-427533513
#22464https://github.com/nodejs/node/issues/22464
Please reload this pagehttps://github.com/nodejs/node/pull/23285
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 6, 2018https://github.com/nodejs/node/pull/23285#issuecomment-427534788
Please reload this pagehttps://github.com/nodejs/node/pull/23285
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 6, 2018 https://github.com/nodejs/node/pull/23285#pullrequestreview-162239580
View reviewed changes https://github.com/nodejs/node/pull/23285/files/c571dab2606e85c80a8d3c360e134297d1364843
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 6, 2018 https://github.com/nodejs/node/pull/23285#pullrequestreview-162242875
View reviewed changes https://github.com/nodejs/node/pull/23285/files/c571dab2606e85c80a8d3c360e134297d1364843
test/fixtures/packages/missing-main/index.jshttps://github.com/nodejs/node/pull/23285/files/c571dab2606e85c80a8d3c360e134297d1364843#diff-31c1c29e2d9fdad6c1c9cf11b736e46505a8c9d8a5dc6d7b19eed1735c3ecd6d
Trotthttps://github.com/Trott
Oct 6, 2018https://github.com/nodejs/node/pull/23285#discussion_r223170120
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23285
Trotthttps://github.com/Trott
Oct 6, 2018https://github.com/nodejs/node/pull/23285#discussion_r223170129
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23285
TomCodedhttps://github.com/TomCoded
Oct 6, 2018https://github.com/nodejs/node/pull/23285#discussion_r223170310
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23285
Trotthttps://github.com/Trott
Oct 6, 2018https://github.com/nodejs/node/pull/23285#discussion_r223170704
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23285
jasnellhttps://github.com/jasnell
Oct 6, 2018https://github.com/nodejs/node/pull/23285#discussion_r223170811
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23285
Trotthttps://github.com/Trott
Oct 6, 2018https://github.com/nodejs/node/pull/23285#discussion_r223171423
Please reload this pagehttps://github.com/nodejs/node/pull/23285
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23285
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 6, 2018https://github.com/nodejs/node/pull/23285#issuecomment-427543801
https://ci.nodejs.org/job/node-test-pull-request/17657/https://ci.nodejs.org/job/node-test-pull-request/17657/
Please reload this pagehttps://github.com/nodejs/node/pull/23285
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 7, 2018 https://github.com/nodejs/node/pull/23285#pullrequestreview-162308039
View reviewed changes https://github.com/nodejs/node/pull/23285/files/c571dab2606e85c80a8d3c360e134297d1364843
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 8, 2018https://github.com/nodejs/node/pull/23285#issuecomment-427699059
Please reload this pagehttps://github.com/nodejs/node/pull/23285
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 8, 2018https://github.com/nodejs/node/pull/23285#event-1889251326
Trotthttps://github.com/Trott
Oct 8, 2018 https://github.com/nodejs/node/pull/23285#ref-commit-13e6e01
https://github.com/TomCoded
https://github.com/Trott
test: add module require tests for certain package.json errorshttps://github.com/Trott/io.js/commit/13e6e01ce58cbd196846a9f90c0a79f2ccd758fc
13e6e01https://github.com/Trott/io.js/commit/13e6e01ce58cbd196846a9f90c0a79f2ccd758fc
nodejs#23285https://github.com/nodejs/node/pull/23285
targoshttps://github.com/targos
Oct 10, 2018 https://github.com/nodejs/node/pull/23285#ref-commit-b523f13
https://github.com/TomCoded
https://github.com/targos
test: add module require tests for certain package.json errorshttps://github.com/nodejs/node/commit/b523f13fa218f39d965e41be5bc3a14d59d264ea
b523f13https://github.com/nodejs/node/commit/b523f13fa218f39d965e41be5bc3a14d59d264ea
#23285https://github.com/nodejs/node/pull/23285
https://github.com/targos
targoshttps://github.com/targos
Oct 10, 2018 https://github.com/nodejs/node/pull/23285#ref-pullrequest-367548700
Release proposal: v10.12.0 #23313 https://github.com/nodejs/node/pull/23313
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#225 https://github.com/beevelop/docker-nodejs/issues/225
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#239 https://github.com/beevelop/docker-android-nodejs/issues/239
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#226 https://github.com/beevelop/docker-nodejs/issues/226
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#240 https://github.com/beevelop/docker-android-nodejs/issues/240
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#227 https://github.com/beevelop/docker-nodejs/issues/227
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#241 https://github.com/beevelop/docker-android-nodejs/issues/241
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#242 https://github.com/beevelop/docker-android-nodejs/issues/242
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#228 https://github.com/beevelop/docker-nodejs/issues/228
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#243 https://github.com/beevelop/docker-android-nodejs/issues/243
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#229 https://github.com/beevelop/docker-nodejs/issues/229
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23285#ref-commit-e67dc9d
https://github.com/TomCoded
https://github.com/jasnell
test: add module require tests for certain package.json errorshttps://github.com/nodejs/node/commit/e67dc9dd027256d35fa82572f675172a2f39401b
e67dc9dhttps://github.com/nodejs/node/commit/e67dc9dd027256d35fa82572f675172a2f39401b
#23285https://github.com/nodejs/node/pull/23285
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23285
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23285/files/c571dab2606e85c80a8d3c360e134297d1364843
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/23285/files/c571dab2606e85c80a8d3c360e134297d1364843
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23285/files/c571dab2606e85c80a8d3c360e134297d1364843
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/23285/files/c571dab2606e85c80a8d3c360e134297d1364843
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/23285
https://github.com/TomCoded
https://github.com/Trott
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/richardlau
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.