René's URL Explorer Experiment


Title: Fix two missing async hooks destroy calls by basti1302 · Pull Request #23272 · nodejs/node · GitHub

Open Graph Title: Fix two missing async hooks destroy calls by basti1302 · Pull Request #23272 · nodejs/node

X Title: Fix two missing async hooks destroy calls by basti1302 · Pull Request #23272 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Supersedes #23201 and #23263 due to feedback from @addaleax in #23201. Add a missing destroy for HTTP socket when the agent gets reused Avoid duplicate call to AsyncWrap::Reset for HTTP parsers (e...

X Description: Supersedes #23201 and #23263 due to feedback from @addaleax in #23201. Add a missing destroy for HTTP socket when the agent gets reused Avoid duplicate call to AsyncWrap::Reset for HTTP parsers (e...

Opengraph URL: https://github.com/nodejs/node/pull/23272

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cd4cc20d-5a8b-c3b3-5136-db7c9bb07dd7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE238:C4CDD:14B5E8:1A39FB:69904A6B
html-safe-nonce07987f3f37b1adca19437fc33324a5bcc70f4bd237d918683414244af6c48842
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjM4OkM0Q0REOjE0QjVFODoxQTM5RkI6Njk5MDRBNkIiLCJ2aXNpdG9yX2lkIjoiNTA4MTkwMjE5MjI3MDUyNzA4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3c48e510fad88fa6009d6093f9b80a9885f178e41aa859cf00741171cd507671
hovercard-subject-tagpull_request:220609837
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23272/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a08410add018ab114b1b7b6f955fa8b6a3f10ec57857e9967aa688558e159835/nodejs/node/pull/23272
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a08410add018ab114b1b7b6f955fa8b6a3f10ec57857e9967aa688558e159835/nodejs/node/pull/23272
og:image:altSupersedes #23201 and #23263 due to feedback from @addaleax in #23201. Add a missing destroy for HTTP socket when the agent gets reused Avoid duplicate call to AsyncWrap::Reset for HTTP parsers (e...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebasti1302
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23272#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23272
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23272
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23272
Reloadhttps://github.com/nodejs/node/pull/23272
Reloadhttps://github.com/nodejs/node/pull/23272
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23272
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 707 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
basti1302https://github.com/basti1302
nodejs:masterhttps://github.com/nodejs/node/tree/master
basti1302:fix-missing-async-hooks-destroy-callshttps://github.com/basti1302/node/tree/fix-missing-async-hooks-destroy-calls
Conversationhttps://github.com/nodejs/node/pull/23272
Commits1 (1)https://github.com/nodejs/node/pull/23272/commits
Checkshttps://github.com/nodejs/node/pull/23272/checks
Files changedhttps://github.com/nodejs/node/pull/23272/files
Fix two missing async hooks destroy callshttps://github.com/nodejs/node/pull/23272#top
basti1302https://github.com/basti1302
nodejs:masterhttps://github.com/nodejs/node/tree/master
basti1302:fix-missing-async-hooks-destroy-callshttps://github.com/basti1302/node/tree/fix-missing-async-hooks-destroy-calls
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 5, 2018https://github.com/nodejs/node/pull/23272#issue-367092245
#23201https://github.com/nodejs/node/pull/23201
#23263https://github.com/nodejs/node/pull/23263
@addaleaxhttps://github.com/addaleax
#23201https://github.com/nodejs/node/pull/23201
#19859https://github.com/nodejs/node/issues/19859
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Oct 5, 2018https://github.com/nodejs/node/pull/23272#event-1886430483
http: add missing async_hooks destroy before asyncReset #23201 https://github.com/nodejs/node/pull/23201
http: remove duplicate async_hooks init for http parser #23263 https://github.com/nodejs/node/pull/23263
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 5, 2018 https://github.com/nodejs/node/pull/23272#pullrequestreview-161921076
View reviewed changes https://github.com/nodejs/node/pull/23272/files
lib/internal/freelist.jshttps://github.com/nodejs/node/pull/23272/files#diff-935fdb4b50b8eb3cba98851cae0778b23b2f614ccdd381fa6e06c5f9ff639d47
Please reload this pagehttps://github.com/nodejs/node/pull/23272
lib/internal/freelist.jshttps://github.com/nodejs/node/pull/23272/files#diff-935fdb4b50b8eb3cba98851cae0778b23b2f614ccdd381fa6e06c5f9ff639d47
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/basti1302
basti1302https://github.com/basti1302
force-pushedhttps://github.com/nodejs/node/compare/bab65ecf6c27ef5fdbbe20559f2094046acbeb92..3d41d4f74f1d63fa8d9224b823c72194c18101cc
bab65echttps://github.com/nodejs/node/commit/bab65ecf6c27ef5fdbbe20559f2094046acbeb92
3d41d4fhttps://github.com/nodejs/node/commit/3d41d4f74f1d63fa8d9224b823c72194c18101cc
Compare https://github.com/nodejs/node/compare/bab65ecf6c27ef5fdbbe20559f2094046acbeb92..3d41d4f74f1d63fa8d9224b823c72194c18101cc
October 5, 2018 07:52https://github.com/nodejs/node/pull/23272#event-1886467307
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 5, 2018 https://github.com/nodejs/node/pull/23272#pullrequestreview-161928577
View reviewed changes https://github.com/nodejs/node/pull/23272/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/23272#pullrequestreview-161928577
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23272
lib/internal/freelist.jshttps://github.com/nodejs/node/pull/23272/files#diff-935fdb4b50b8eb3cba98851cae0778b23b2f614ccdd381fa6e06c5f9ff639d47
mcollinahttps://github.com/mcollina
Oct 5, 2018https://github.com/nodejs/node/pull/23272#discussion_r222922946
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23272
basti1302https://github.com/basti1302
Oct 5, 2018https://github.com/nodejs/node/pull/23272#discussion_r222933284
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/basti1302
basti1302https://github.com/basti1302
force-pushedhttps://github.com/nodejs/node/compare/0e1f49a32e26dec2d2139281deca4995ff49b370..d1b552d239bae52dd3e2613d93a26c4453ae4374
0e1f49ahttps://github.com/nodejs/node/commit/0e1f49a32e26dec2d2139281deca4995ff49b370
d1b552dhttps://github.com/nodejs/node/commit/d1b552d239bae52dd3e2613d93a26c4453ae4374
Compare https://github.com/nodejs/node/compare/0e1f49a32e26dec2d2139281deca4995ff49b370..d1b552d239bae52dd3e2613d93a26c4453ae4374
October 5, 2018 08:48https://github.com/nodejs/node/pull/23272#event-1886582810
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 5, 2018https://github.com/nodejs/node/pull/23272#issuecomment-427291905
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/basti1302
basti1302https://github.com/basti1302
force-pushedhttps://github.com/nodejs/node/compare/11b0d998397c21001b6216cfb1303af3d2262b40..5335c536ba02475d0cc79d2d1930a5446760fc8e
11b0d99https://github.com/nodejs/node/commit/11b0d998397c21001b6216cfb1303af3d2262b40
5335c53https://github.com/nodejs/node/commit/5335c536ba02475d0cc79d2d1930a5446760fc8e
Compare https://github.com/nodejs/node/compare/11b0d998397c21001b6216cfb1303af3d2262b40..5335c536ba02475d0cc79d2d1930a5446760fc8e
October 5, 2018 13:15https://github.com/nodejs/node/pull/23272#event-1887119833
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 5, 2018 https://github.com/nodejs/node/pull/23272#pullrequestreview-162075309
View reviewed changes https://github.com/nodejs/node/pull/23272/files
src/async_wrap.cchttps://github.com/nodejs/node/pull/23272/files#diff-a409448439ca3d2669ce04c6aee43977b52f25ef894a58c7a6d74e6d92e69808
addaleaxhttps://github.com/addaleax
Oct 5, 2018https://github.com/nodejs/node/pull/23272#discussion_r223037813
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23272
basti1302https://github.com/basti1302
Oct 6, 2018https://github.com/nodejs/node/pull/23272#discussion_r223176074
Please reload this pagehttps://github.com/nodejs/node/pull/23272
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/basti1302
basti1302https://github.com/basti1302
force-pushedhttps://github.com/nodejs/node/compare/9da6d7a9b20c9db6cf051eb2756f0bca936a38d9..7652bd7f51aa5803274f8e1fc0fa2103231c47fe
9da6d7ahttps://github.com/nodejs/node/commit/9da6d7a9b20c9db6cf051eb2756f0bca936a38d9
7652bd7https://github.com/nodejs/node/commit/7652bd7f51aa5803274f8e1fc0fa2103231c47fe
Compare https://github.com/nodejs/node/compare/9da6d7a9b20c9db6cf051eb2756f0bca936a38d9..7652bd7f51aa5803274f8e1fc0fa2103231c47fe
October 6, 2018 08:36https://github.com/nodejs/node/pull/23272#event-1888482694
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 6, 2018https://github.com/nodejs/node/pull/23272#issuecomment-427556982
Please reload this pagehttps://github.com/nodejs/node/pull/23272
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/basti1302
basti1302https://github.com/basti1302
force-pushedhttps://github.com/nodejs/node/compare/7652bd7f51aa5803274f8e1fc0fa2103231c47fe..9e3f644a4f0c9ef7e76e80621d0120d61ea5b273
7652bd7https://github.com/nodejs/node/commit/7652bd7f51aa5803274f8e1fc0fa2103231c47fe
9e3f644https://github.com/nodejs/node/commit/9e3f644a4f0c9ef7e76e80621d0120d61ea5b273
Compare https://github.com/nodejs/node/compare/7652bd7f51aa5803274f8e1fc0fa2103231c47fe..9e3f644a4f0c9ef7e76e80621d0120d61ea5b273
October 6, 2018 08:40https://github.com/nodejs/node/pull/23272#event-1888484005
https://github.com/basti1302
async_hooks: add missing async_hooks destroys in AsyncResethttps://github.com/nodejs/node/pull/23272/commits/284a0e09e047b1e30c572cfdf3572d57467543d7
284a0e0https://github.com/nodejs/node/pull/23272/commits/284a0e09e047b1e30c572cfdf3572d57467543d7
nodejs#19859https://github.com/nodejs/node/issues/19859
https://github.com/basti1302
basti1302https://github.com/basti1302
force-pushedhttps://github.com/nodejs/node/compare/9e3f644a4f0c9ef7e76e80621d0120d61ea5b273..284a0e09e047b1e30c572cfdf3572d57467543d7
9e3f644https://github.com/nodejs/node/commit/9e3f644a4f0c9ef7e76e80621d0120d61ea5b273
284a0e0https://github.com/nodejs/node/commit/284a0e09e047b1e30c572cfdf3572d57467543d7
Compare https://github.com/nodejs/node/compare/9e3f644a4f0c9ef7e76e80621d0120d61ea5b273..284a0e09e047b1e30c572cfdf3572d57467543d7
October 6, 2018 08:46https://github.com/nodejs/node/pull/23272#event-1888485755
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 6, 2018 https://github.com/nodejs/node/pull/23272#ref-issue-312153863
Reusing HTTP connection lead to no destroy triggered #19859 https://github.com/nodejs/node/issues/19859
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 8, 2018https://github.com/nodejs/node/pull/23272#issuecomment-427945265
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 9, 2018https://github.com/nodejs/node/pull/23272#issuecomment-428018872
https://ci.nodejs.org/job/node-test-pull-request/17692/https://ci.nodejs.org/job/node-test-pull-request/17692/
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/mcollina
mcollinahttps://github.com/mcollina
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 9, 2018https://github.com/nodejs/node/pull/23272#event-1891554482
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 9, 2018https://github.com/nodejs/node/pull/23272#issuecomment-428045609
node-test-commit-armhttps://ci.nodejs.org/job/node-test-commit-arm/19049/
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 9, 2018https://github.com/nodejs/node/pull/23272#issuecomment-428138643
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 9, 2018 https://github.com/nodejs/node/pull/23272#pullrequestreview-162972641
View reviewed changes https://github.com/nodejs/node/pull/23272/files/284a0e09e047b1e30c572cfdf3572d57467543d7
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2018https://github.com/nodejs/node/pull/23272#issuecomment-428458196
eb9748dhttps://github.com/nodejs/node/commit/eb9748d222061381236f19cbe162cf9eb2e034ad
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2018https://github.com/nodejs/node/pull/23272#event-1894646339
danbevhttps://github.com/danbev
Oct 10, 2018 https://github.com/nodejs/node/pull/23272#ref-commit-eb9748d
https://github.com/basti1302
https://github.com/danbev
async_hooks: add missing async_hooks destroys in AsyncResethttps://github.com/nodejs/node/commit/eb9748d222061381236f19cbe162cf9eb2e034ad
eb9748dhttps://github.com/nodejs/node/commit/eb9748d222061381236f19cbe162cf9eb2e034ad
#23272https://github.com/nodejs/node/pull/23272
#19859https://github.com/nodejs/node/issues/19859
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 10, 2018https://github.com/nodejs/node/pull/23272#issuecomment-428469285
@addaleaxhttps://github.com/addaleax
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/basti1302
basti1302https://github.com/basti1302
October 10, 2018 08:15https://github.com/nodejs/node/pull/23272#event-1894804226
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 10, 2018 https://github.com/nodejs/node/pull/23272#ref-pullrequest-368592695
[v10.x backport] async_hooks: add missing async_hooks destroys in AsyncReset #23404 https://github.com/nodejs/node/pull/23404
basti1302https://github.com/basti1302
Oct 10, 2018 https://github.com/nodejs/node/pull/23272#ref-commit-c650dfb
https://github.com/basti1302
async_hooks: add missing async_hooks destroys in AsyncResethttps://github.com/basti1302/node/commit/c650dfbde0a54a4c69b2397dd7af719f526f222c
c650dfbhttps://github.com/basti1302/node/commit/c650dfbde0a54a4c69b2397dd7af719f526f222c
nodejs#23272https://github.com/nodejs/node/pull/23272
nodejs#19859https://github.com/nodejs/node/issues/19859
[v8.x backport] async_hooks: add missing async_hooks destroys in AsyncReset #23410 https://github.com/nodejs/node/pull/23410
test: correct isReused parameter in test-http-parser #23412 https://github.com/nodejs/node/pull/23412
https://github.com/targos
targoshttps://github.com/targos
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Oct 10, 2018https://github.com/nodejs/node/pull/23272#event-1896746751
https://github.com/targos
targoshttps://github.com/targos
Oct 10, 2018https://github.com/nodejs/node/pull/23272#issuecomment-428747350
the guidehttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 11, 2018https://github.com/nodejs/node/pull/23272#issuecomment-428819578
@targoshttps://github.com/targos
saidhttps://github.com/nodejs/node/pull/23272#issuecomment-428469285
[v8.x backport] async_hooks: add missing async_hooks destroys in AsyncReset #23410https://github.com/nodejs/node/pull/23410
[v10.x backport] async_hooks: add missing async_hooks destroys in AsyncReset #23404https://github.com/nodejs/node/pull/23404
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backported-to-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Oct 11, 2018https://github.com/nodejs/node/pull/23272#event-1897203044
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23272#ref-commit-0339d3d
https://github.com/basti1302
https://github.com/jasnell
async_hooks: add missing async_hooks destroys in AsyncResethttps://github.com/nodejs/node/commit/0339d3dc360732381eed70af511e6d6c32924eba
0339d3dhttps://github.com/nodejs/node/commit/0339d3dc360732381eed70af511e6d6c32924eba
#23272https://github.com/nodejs/node/pull/23272
#19859https://github.com/nodejs/node/issues/19859
basti1302https://github.com/basti1302
Nov 2, 2018 https://github.com/nodejs/node/pull/23272#ref-commit-5f22659
https://github.com/basti1302
async_hooks: add missing async_hooks destroys in AsyncResethttps://github.com/basti1302/node/commit/5f22659a888059379f8eee2a157759d0fcce4b84
5f22659https://github.com/basti1302/node/commit/5f22659a888059379f8eee2a157759d0fcce4b84
nodejs#23272https://github.com/nodejs/node/pull/23272
nodejs#19859https://github.com/nodejs/node/issues/19859
MylesBorinshttps://github.com/MylesBorins
Nov 4, 2018 https://github.com/nodejs/node/pull/23272#ref-commit-8345a82
https://github.com/basti1302
https://github.com/MylesBorins
async_hooks: add missing async_hooks destroys in AsyncResethttps://github.com/nodejs/node/commit/8345a8227d3b73f6bc538602dbaf416771a0d71c
8345a82https://github.com/nodejs/node/commit/8345a8227d3b73f6bc538602dbaf416771a0d71c
#23404https://github.com/nodejs/node/pull/23404
#23272https://github.com/nodejs/node/pull/23272
#19859https://github.com/nodejs/node/issues/19859
MylesBorinshttps://github.com/MylesBorins
Nov 4, 2018 https://github.com/nodejs/node/pull/23272#ref-commit-26d145a
https://github.com/basti1302
https://github.com/MylesBorins
async_hooks: add missing async_hooks destroys in AsyncResethttps://github.com/nodejs/node/commit/26d145a77f63ecd3713f344f404ea9dd862edb39
26d145ahttps://github.com/nodejs/node/commit/26d145a77f63ecd3713f344f404ea9dd862edb39
#23410https://github.com/nodejs/node/pull/23410
#23272https://github.com/nodejs/node/pull/23272
#19859https://github.com/nodejs/node/issues/19859
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Nov 12, 2018 https://github.com/nodejs/node/pull/23272#ref-pullrequest-375564151
v8.13.0 proposal #23974 https://github.com/nodejs/node/pull/23974
https://github.com/beevelop
beevelophttps://github.com/beevelop
Nov 20, 2018 https://github.com/nodejs/node/pull/23272#ref-issue-382804528
2018-11-20 Version 8.13.0 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#250 https://github.com/beevelop/docker-android-nodejs/issues/250
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23272#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23272#ref-commit-5706282
https://github.com/basti1302
https://github.com/rvagg
async_hooks: add missing async_hooks destroys in AsyncResethttps://github.com/nodejs/node/commit/570628226fe2e3842a14b85cff178a0251ed8acf
5706282https://github.com/nodejs/node/commit/570628226fe2e3842a14b85cff178a0251ed8acf
#23404https://github.com/nodejs/node/pull/23404
#23272https://github.com/nodejs/node/pull/23272
#19859https://github.com/nodejs/node/issues/19859
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23272#ref-commit-6a21d3e
https://github.com/basti1302
https://github.com/MylesBorins
async_hooks: add missing async_hooks destroys in AsyncResethttps://github.com/nodejs/node/commit/6a21d3e72fc3f23a9ad06b3fae756472b5148235
6a21d3ehttps://github.com/nodejs/node/commit/6a21d3e72fc3f23a9ad06b3fae756472b5148235
#23404https://github.com/nodejs/node/pull/23404
#23272https://github.com/nodejs/node/pull/23272
#19859https://github.com/nodejs/node/issues/19859
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23272#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.com/watson
watsonhttps://github.com/watson
Jan 15, 2019 https://github.com/nodejs/node/pull/23272#ref-issue-397440131
High Memory issue at version 2.6.0 elastic/apm-agent-nodejs#772 https://github.com/elastic/apm-agent-nodejs/issues/772
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23272
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/23272/files/0e1f49a32e26dec2d2139281deca4995ff49b370
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23272/files/284a0e09e047b1e30c572cfdf3572d57467543d7
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23272/files/5335c536ba02475d0cc79d2d1930a5446760fc8e
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Reusing HTTP connection lead to no destroy triggered https://github.com/nodejs/node/issues/19859
Please reload this pagehttps://github.com/nodejs/node/pull/23272
https://github.com/basti1302
https://github.com/mcollina
https://github.com/danbev
https://github.com/targos
https://github.com/jasnell
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.