René's URL Explorer Experiment


Title: http: remove duplicate async_hooks init for http parser by basti1302 · Pull Request #23263 · nodejs/node · GitHub

Open Graph Title: http: remove duplicate async_hooks init for http parser by basti1302 · Pull Request #23263 · nodejs/node

X Title: http: remove duplicate async_hooks init for http parser by basti1302 · Pull Request #23263 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Each time a new parser was created, AsyncReset was being called via the C++ Parser class constructor (super constructor AsyncWrap) and also via Parser::Reinitialize. This also adds a missing async_...

X Description: Each time a new parser was created, AsyncReset was being called via the C++ Parser class constructor (super constructor AsyncWrap) and also via Parser::Reinitialize. This also adds a missing async_...

Opengraph URL: https://github.com/nodejs/node/pull/23263

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:68026cc8-4168-ba09-1f38-e5ab9c1a33dc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD7AE:1F3C65:8AE29C:B282A7:69907E26
html-safe-nonce60f4d55fbb36348391d1259598581ecfa123fcb07dbf3dad3d1ba26235c24616
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0FFOjFGM0M2NTo4QUUyOUM6QjI4MkE3OjY5OTA3RTI2IiwidmlzaXRvcl9pZCI6IjQ2MDA2MzI0MDY0NjYxMzM1NDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac89bd090ff7a8d4ecc69d6b42c93e4b16920fa0bda2bf643596a0c51acae5ea2e
hovercard-subject-tagpull_request:220365301
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23263/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7526a0bbc860e577490f5a00151670e8ed8bd2b553bacf60ff9e0efa4aae6d53/nodejs/node/pull/23263
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7526a0bbc860e577490f5a00151670e8ed8bd2b553bacf60ff9e0efa4aae6d53/nodejs/node/pull/23263
og:image:altEach time a new parser was created, AsyncReset was being called via the C++ Parser class constructor (super constructor AsyncWrap) and also via Parser::Reinitialize. This also adds a missing async_...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebasti1302
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23263#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23263
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23263
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23263
Reloadhttps://github.com/nodejs/node/pull/23263
Reloadhttps://github.com/nodejs/node/pull/23263
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23263
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
basti1302https://github.com/basti1302
nodejs:masterhttps://github.com/nodejs/node/tree/master
basti1302:fix-missing-async-hooks-destroy-http-parserhttps://github.com/basti1302/node/tree/fix-missing-async-hooks-destroy-http-parser
Conversationhttps://github.com/nodejs/node/pull/23263
Commits2 (2)https://github.com/nodejs/node/pull/23263/commits
Checkshttps://github.com/nodejs/node/pull/23263/checks
Files changedhttps://github.com/nodejs/node/pull/23263/files
http: remove duplicate async_hooks init for http parserhttps://github.com/nodejs/node/pull/23263#top
basti1302https://github.com/basti1302
nodejs:masterhttps://github.com/nodejs/node/tree/master
basti1302:fix-missing-async-hooks-destroy-http-parserhttps://github.com/basti1302/node/tree/fix-missing-async-hooks-destroy-http-parser
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 4, 2018https://github.com/nodejs/node/pull/23263#issue-366775292
Please reload this pagehttps://github.com/nodejs/node/pull/23263
#19859https://github.com/nodejs/node/issues/19859
#23201https://github.com/nodejs/node/pull/23201
https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23263
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
http_parser https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp_parser
Oct 4, 2018https://github.com/nodejs/node/pull/23263#event-1884526461
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 4, 2018 https://github.com/nodejs/node/pull/23263#ref-issue-312153863
Reusing HTTP connection lead to no destroy triggered #19859 https://github.com/nodejs/node/issues/19859
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 4, 2018 https://github.com/nodejs/node/pull/23263#pullrequestreview-161605051
View reviewed changes https://github.com/nodejs/node/pull/23263/files
test/async-hooks/test-graph.http.jshttps://github.com/nodejs/node/pull/23263/files#diff-88f143eb4560d54b944a2b99de47f79d334e61b628d83a6439d2dcd55f6aad36
basti1302https://github.com/basti1302
Oct 4, 2018https://github.com/nodejs/node/pull/23263#discussion_r222664440
Please reload this pagehttps://github.com/nodejs/node/pull/23263
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23263
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 4, 2018 https://github.com/nodejs/node/pull/23263#pullrequestreview-161606190
View reviewed changes https://github.com/nodejs/node/pull/23263/files
test/parallel/test-freelist.jshttps://github.com/nodejs/node/pull/23263/files#diff-5a206f2dccb35e43f9d5d3619d2b458f5bcc4c427b164b553c8cc17bbfaf7cb5
basti1302https://github.com/basti1302
Oct 4, 2018https://github.com/nodejs/node/pull/23263#discussion_r222665311
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23263
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 4, 2018 https://github.com/nodejs/node/pull/23263#ref-pullrequest-365534858
http: add missing async_hooks destroy before asyncReset #23201 https://github.com/nodejs/node/pull/23201
https://github.com/AyushG3112
AyushG3112https://github.com/AyushG3112
Oct 4, 2018https://github.com/nodejs/node/pull/23263#issuecomment-427054363
Please reload this pagehttps://github.com/nodejs/node/pull/23263
https://github.com/basti1302
basti1302https://github.com/basti1302
force-pushedhttps://github.com/nodejs/node/compare/db9426d50261fbb3ac500d26acac10a25465a223..0ba5ae7ebd9330decde9724db779bcb0e823a441
db9426dhttps://github.com/nodejs/node/commit/db9426d50261fbb3ac500d26acac10a25465a223
0ba5ae7https://github.com/nodejs/node/commit/0ba5ae7ebd9330decde9724db779bcb0e823a441
Compare https://github.com/nodejs/node/compare/db9426d50261fbb3ac500d26acac10a25465a223..0ba5ae7ebd9330decde9724db779bcb0e823a441
October 4, 2018 17:17https://github.com/nodejs/node/pull/23263#event-1885228768
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 4, 2018 https://github.com/nodejs/node/pull/23263#pullrequestreview-161738536
View reviewed changes https://github.com/nodejs/node/pull/23263/files
lib/internal/freelist.jshttps://github.com/nodejs/node/pull/23263/files#diff-935fdb4b50b8eb3cba98851cae0778b23b2f614ccdd381fa6e06c5f9ff639d47
ofrobotshttps://github.com/ofrobots
Oct 4, 2018https://github.com/nodejs/node/pull/23263#discussion_r222770710
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23263
basti1302https://github.com/basti1302
Oct 4, 2018https://github.com/nodejs/node/pull/23263#discussion_r222803532
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23263
basti1302https://github.com/basti1302
Oct 4, 2018https://github.com/nodejs/node/pull/23263#discussion_r222814495
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23263
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 4, 2018https://github.com/nodejs/node/pull/23263#issuecomment-427115212
@mcollinahttps://github.com/mcollina
@kjinhttps://github.com/kjin
Please reload this pagehttps://github.com/nodejs/node/pull/23263
https://github.com/basti1302
basti1302https://github.com/basti1302
force-pushedhttps://github.com/nodejs/node/compare/e27f470f358f70b85f32cd75c336908ffa8ddaba..d35be44e12176c4a09f08b5328e78856b194473b
e27f470https://github.com/nodejs/node/commit/e27f470f358f70b85f32cd75c336908ffa8ddaba
d35be44https://github.com/nodejs/node/commit/d35be44e12176c4a09f08b5328e78856b194473b
Compare https://github.com/nodejs/node/compare/e27f470f358f70b85f32cd75c336908ffa8ddaba..d35be44e12176c4a09f08b5328e78856b194473b
October 4, 2018 20:08https://github.com/nodejs/node/pull/23263#event-1885597463
basti1302https://github.com/basti1302
October 4, 2018 22:45https://github.com/nodejs/node/pull/23263#commits-pushed-d46dc79
https://github.com/basti1302
http: remove duplicate async_hooks init for http parserhttps://github.com/nodejs/node/pull/23263/commits/d46dc7958bd477c38190cb796a4ffda434bb0aa4
d46dc79https://github.com/nodejs/node/pull/23263/commits/d46dc7958bd477c38190cb796a4ffda434bb0aa4
nodejs#19859https://github.com/nodejs/node/issues/19859
https://github.com/basti1302
http: use symbol for FreeList's is_reusedhttps://github.com/nodejs/node/pull/23263/commits/26d147113f220dc3c65d9b19412dcc9dc1fe62d6
26d1471https://github.com/nodejs/node/pull/23263/commits/26d147113f220dc3c65d9b19412dcc9dc1fe62d6
https://github.com/basti1302
basti1302https://github.com/basti1302
force-pushedhttps://github.com/nodejs/node/compare/0c081fcca60c97d7881f7d7749604448fb705b58..26d147113f220dc3c65d9b19412dcc9dc1fe62d6
0c081fchttps://github.com/nodejs/node/commit/0c081fcca60c97d7881f7d7749604448fb705b58
26d1471https://github.com/nodejs/node/commit/26d147113f220dc3c65d9b19412dcc9dc1fe62d6
Compare https://github.com/nodejs/node/compare/0c081fcca60c97d7881f7d7749604448fb705b58..26d147113f220dc3c65d9b19412dcc9dc1fe62d6
October 4, 2018 20:46https://github.com/nodejs/node/pull/23263#event-1885678052
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 5, 2018 https://github.com/nodejs/node/pull/23263#ref-pullrequest-367092245
Fix two missing async hooks destroy calls #23272 https://github.com/nodejs/node/pull/23272
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 5, 2018https://github.com/nodejs/node/pull/23263#issuecomment-427273557
#23272https://github.com/nodejs/node/pull/23272
#23201https://github.com/nodejs/node/pull/23201
Please reload this pagehttps://github.com/nodejs/node/pull/23263
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 5, 2018https://github.com/nodejs/node/pull/23263#event-1886437979
https://github.com/basti1302
basti1302https://github.com/basti1302
October 10, 2018 08:15https://github.com/nodejs/node/pull/23263#event-1894804900
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23263
https://github.com/ofrobots
ofrobots https://github.com/ofrobots
https://github.com/nodejs/node/pull/23263/files/0ba5ae7ebd9330decde9724db779bcb0e823a441
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http_parser https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp_parser
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/23263
https://github.com/basti1302
https://github.com/AyushG3112
https://github.com/ofrobots
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.